April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: place asn1 context under hnb_ctx for better visibility

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32522 ) Change subject: place asn1 context under hnb_ctx for better visibility ...................................................................... place asn1 context under hnb_ctx for better visibility Include talloc_asn1_context in 'show talloc-context application'. It belongs there IMO. Related: SYS#6297 Change-Id: Iffc320c64713b225b57211da4fb95a868bf1f369 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index 50ada60..4885a2c 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -732,7 +732,7 @@ talloc_enable_null_tracking(); tall_hnb_ctx = talloc_named_const(NULL, 0, "hnb_context"); - talloc_asn1_ctx = talloc_named_const(NULL, 1, "asn1_context"); + talloc_asn1_ctx = talloc_named_const(tall_hnb_ctx, 1, "asn1_context"); msgb_talloc_ctx_init(tall_hnb_ctx, 0); g_hnb_gw = hnb_gw_create(tall_hnb_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iffc320c64713b225b57211da4fb95a868bf1f369 Gerrit-Change-Number: 32522 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix asn1 leak in handle_cn_ranap()

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32523 ) Change subject: fix asn1 leak in handle_cn_ranap() ...................................................................... fix asn1 leak in handle_cn_ranap() Related: SYS#6297 Change-Id: I307f65ae083aba16f75510bcd0a7d1f124e62be4 --- M src/osmo-hnbgw/hnbgw_cn.c 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_cn.c b/src/osmo-hnbgw/hnbgw_cn.c index e2dccf9..fdc5cde 100644 --- a/src/osmo-hnbgw/hnbgw_cn.c +++ b/src/osmo-hnbgw/hnbgw_cn.c @@ -276,6 +276,7 @@ } rc = _cn_ranap_rx(cnlink, unitdata, pdu, data, len); + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RANAP_PDU, pdu); return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I307f65ae083aba16f75510bcd0a7d1f124e62be4 Gerrit-Change-Number: 32523 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix vty: show talloc-context all

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32521 ) Change subject: fix vty: show talloc-context all ...................................................................... fix vty: show talloc-context all Without "null tracking" enabled, the VTY 'show talloc-ctx all' shows nothing at all. Since the talloc_asn1_ctx is "created in NULL ctx", it was not visible in any talloc reports before this patch. This patch uncovers a slur of leaks, which accumulate in talloc_asn1_ctx. Fixes follow. Related: SYS#6297 Change-Id: I5cb4e9a3b393100877f03d68a09acf5817c5a878 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index bd45dda..50ada60 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -729,6 +729,8 @@ struct osmo_stream_srv_link *srv; int rc; + talloc_enable_null_tracking(); + tall_hnb_ctx = talloc_named_const(NULL, 0, "hnb_context"); talloc_asn1_ctx = talloc_named_const(NULL, 1, "asn1_context"); msgb_talloc_ctx_init(tall_hnb_ctx, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32521 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5cb4e9a3b393100877f03d68a09acf5817c5a878 Gerrit-Change-Number: 32521 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix asn1 leak in error path of hnbgw_tx_ue_register_acc_tmsi()

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32525 ) Change subject: fix asn1 leak in error path of hnbgw_tx_ue_register_acc_tmsi() ...................................................................... fix asn1 leak in error path of hnbgw_tx_ue_register_acc_tmsi() Related: SYS#6297 Change-Id: Iad1519aea36d8b6fef51fedb22a861ad1bc462fc --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 27 insertions(+), 14 deletions(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index bc3dccd..980c6b0 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -338,19 +338,8 @@ memset(&accept_out, 0, sizeof(accept_out)); rc = hnbap_encode_ueregisteraccepties(&accept_out, &accept); - if (rc < 0) { - /* If we allocated the UE context but the UE REGISTER fails, get rid of it again: there will likely - * never be a UE DE-REGISTER for this UE from the HNB, and the ue_context would linger forever. */ - if (ue_allocated) - ue_context_free(ue_allocated); - return rc; - } - msg = hnbap_generate_successful_outcome(HNBAP_ProcedureCode_id_UERegister, - HNBAP_Criticality_reject, - &asn_DEF_HNBAP_UERegisterAccept, - &accept_out); - + /* free 'accept', now encoded in 'accept_out' */ switch (ue_id->present) { case HNBAP_UE_Identity_PR_tMSILAI: ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_BIT_STRING, @@ -377,9 +366,23 @@ break; } - ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_UERegisterAccept, &accept_out); + if (rc < 0) { + /* Encoding failed. Nothing in 'accept_out'. */ + /* If we allocated the UE context but the UE REGISTER fails, get rid of it again: there will likely + * never be a UE DE-REGISTER for this UE from the HNB, and the ue_context would linger forever. */ + if (ue_allocated) + ue_context_free(ue_allocated); + return rc; + } - return hnbgw_hnbap_tx(hnb, msg); + /* Encoding successful, transmit, then free 'accept_out'. */ + msg = hnbap_generate_successful_outcome(HNBAP_ProcedureCode_id_UERegister, + HNBAP_Criticality_reject, + &asn_DEF_HNBAP_UERegisterAccept, + &accept_out); + rc = hnbgw_hnbap_tx(hnb, msg); + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_UERegisterAccept, &accept_out); + return rc; } static int hnbgw_rx_hnb_deregister(struct hnb_context *ctx, ANY_t *in) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32525 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iad1519aea36d8b6fef51fedb22a861ad1bc462fc Gerrit-Change-Number: 32525 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix asn1 leaks in ps_rab_ass_resp_send_if_ready()

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32526 ) Change subject: fix asn1 leaks in ps_rab_ass_resp_send_if_ready() ...................................................................... fix asn1 leaks in ps_rab_ass_resp_send_if_ready() Related: SYS#6297 Change-Id: Icdb6eef0d1fde849c0b9121cc96d8221e72d45c8 --- M src/osmo-hnbgw/ps_rab_ass_fsm.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/ps_rab_ass_fsm.c b/src/osmo-hnbgw/ps_rab_ass_fsm.c index 65a6116..464c4d0 100644 --- a/src/osmo-hnbgw/ps_rab_ass_fsm.c +++ b/src/osmo-hnbgw/ps_rab_ass_fsm.c @@ -569,6 +569,8 @@ /* Reencode this list item in the RANAP message */ rc = ANY_fromType_aper(&list_ie->value, &asn_DEF_RANAP_RAB_SetupOrModifiedItem, rab_item); + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_BIT_STRING, &rab_item->transportLayerAddress); + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_OCTET_STRING, &rab_item->iuTransportAssociation->choice.gTP_TEI); if (rc < 0) { ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RANAP_RAB_SetupOrModifiedItem, &item_ies); LOG_PS_RAB_ASS(rab_ass, LOGL_ERROR, "Re-encoding RANAP PS RAB-AssignmentResponse failed\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32526 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Icdb6eef0d1fde849c0b9121cc96d8221e72d45c8 Gerrit-Change-Number: 32526 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix asn1 leak in error path of hnbgw_tx_ue_register_acc()

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32524 ) Change subject: fix asn1 leak in error path of hnbgw_tx_ue_register_acc() ...................................................................... fix asn1 leak in error path of hnbgw_tx_ue_register_acc() Related: SYS#6297 Change-Id: Iaaf7a393ef1fcad619687e2eb2dcc31f0aec0e96 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index a1cbec5..bc3dccd 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -146,6 +146,7 @@ memset(&accept_out, 0, sizeof(accept_out)); rc = hnbap_encode_ueregisteraccepties(&accept_out, &accept); + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_OCTET_STRING, &accept.uE_Identity.choice.iMSI); if (rc < 0) { return rc; } @@ -155,7 +156,6 @@ &asn_DEF_HNBAP_UERegisterAccept, &accept_out); - ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_OCTET_STRING, &accept.uE_Identity.choice.iMSI); ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_HNBAP_UERegisterAccept, &accept_out); return hnbgw_hnbap_tx(ue->hnb, msg); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaaf7a393ef1fcad619687e2eb2dcc31f0aec0e96 Gerrit-Change-Number: 32524 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: fix asn1 leak in hnbgw_rua_rx()

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32527 ) Change subject: fix asn1 leak in hnbgw_rua_rx() ...................................................................... fix asn1 leak in hnbgw_rua_rx() Related: SYS#6297 Change-Id: I7392e0bb07c2cb02c1a12f8e19acb142cd101f77 --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 83410b9..5e68e32 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -536,6 +536,8 @@ rc = _hnbgw_rua_rx(msg, pdu); + ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_RUA_RUA_PDU, pdu); + return rc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7392e0bb07c2cb02c1a12f8e19acb142cd101f77 Gerrit-Change-Number: 32527 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[M] Change in pysim[master]: pySim-shell: fix compatibility problem with cmd2 >= 2.3.0 (bg)

by fixeria

Attention is currently required from: laforge, msuraev, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30075 ) Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.3.0 (bg) ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File contrib/jenkins.sh: https://gerrit.osmocom.org/c/pysim/+/30075/comment/96d935a2_7242afc0 PS4, Line 41: E0611: No name 'Fg' in module 'cmd2' (no-name-in-module) better use inline `pylint: ...` comments, we don't want to ignore import errors globally, right? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/30075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9fd32c0fd8f6d40e00a318602af97c288605e8e5 Gerrit-Change-Number: 30075 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Apr 2023 16:36:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy)

by fixeria

Attention is currently required from: markb, laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32533 ) Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (include_ipy) ...................................................................... Patch Set 2: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/32533/comment/835554fd_798c2c77 PS2, Line 138: USE IPYTHON debugging leftovers? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc0e18b002a03ed17933be4d0b4f4e86ad99c26e Gerrit-Change-Number: 32533 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: markb <markboldyrev(a)gmail.com> Gerrit-Attention: markb <markboldyrev(a)gmail.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Apr 2023 16:33:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable)

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32532 ) Change subject: pySim-shell: fix compatibility problem with cmd2 >= 2.0.0 (Settable) ...................................................................... Patch Set 8: Code-Review-2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/32532/comment/0a24453e_6a305891 PS8, Line 11: Older versions will ignore the settable_object parameter Are you sure? Have you tested this at all? In `requirements.txt` we require `cmd2==1.5`, which does not like this argument. I quickly tested this patch in docker: ``` Card initialization failed with an exception: ---------------------8<--------------------- Traceback (most recent call last): File "/data/./pySim-shell.py", line 983, in <module> app = PysimApp(card, rs, sl, ch, opts.script) File "/data/./pySim-shell.py", line 148, in __init__ self.add_settable(cmd2.Settable('numeric_path', bool, 'Print File IDs instead of names', self, TypeError: __init__() takes 4 positional arguments but 5 positional arguments (and 1 keyword-only argument) were given ---------------------8<--------------------- ``` Either we maintain backwards compatibility with 1.5 and don't break it, or we finally bump the version (at least to 0.8.5, which is provided by debian:bullseye). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I38efe4702277ee092a5542d7d659df08cb0adeff Gerrit-Change-Number: 32532 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Apr 2023 16:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023