Attention is currently required from: neels.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32151
to look at the new patch set (#4).
Change subject: SCCP N-PCSTATE: trigger MSC status on PC availability
......................................................................
SCCP N-PCSTATE: trigger MSC status on PC availability
Related: SYS#6319
Related: Ia1aea4e33230d6a685b72ea5ba20dd9c7d265d44 osmo-ttcn3-hacks
Related: Ib4a5330df30a73e744c316898817b2fa3271d75e osmo-ttcn3-hacks
Change-Id: I3a0869598b8395601a16d78dbc46eec400c0ea84
---
M include/osmocom/bsc/bssmap_reset.h
M src/osmo-bsc/bssmap_reset.c
M src/osmo-bsc/osmo_bsc_sigtran.c
3 files changed, 123 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/32151/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32151
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3a0869598b8395601a16d78dbc46eec400c0ea84
Gerrit-Change-Number: 32151
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32244 )
Change subject: L3_Templates, bsc: set ts_PAG_RESP() arg to template (value)
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i am barely done hitting enter to push the patch for review, and you have already added a CR vote?? daaamn you're fast!
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32244
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib77fc2377c1cf86abca9cf3082b74926d3c2c431
Gerrit-Change-Number: 32244
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Apr 2023 22:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217 )
Change subject: bsc: add TC_mscpool_sccp_n_pcstate_attaches_msc
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS1:
> i'd rather merge the test and update via update_expected_results_from_jenkins. […]
Done
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217/comment/be950531_cd86…
PS1, Line 9190: pars1.mscpool.l3_info := valueof(ts_LU_REQ(LU_Type_IMSI_Attach, valueof(ts_MI_IMSI_LV('001010420000001'H)), '00F110'O));
> it is a rebase artifact and should not be here, thx. […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217/comment/ee7733ec_9407…
PS1, Line 9211: pars3.mscpool.l3_info := valueof(ts_PAG_RESP(valueof(ts_MI_IMSI_LV('001010420000003'H))));
> meh ok, all this overhead only for nice looks, but yea
done separately in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32244
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32217
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a5330df30a73e744c316898817b2fa3271d75e
Gerrit-Change-Number: 32217
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Apr 2023 22:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin, fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32216 )
Change subject: bsc: add TC_mscpool_sccp_n_pcstate_detaches_msc
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I personally never consciously used nor updated the expected-results, and it is news to me that we h […]
well i was here first =) expected_results.xml would not exist if i had not added it, and i agree with laforge; my intended workflow is using update_expected_results_from_jenkins.sh after merging.
At the same time i'm glad that you two are embracing the results summary i added back in the days, and that you are now reminding me of updating it <3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32216
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia1aea4e33230d6a685b72ea5ba20dd9c7d265d44
Gerrit-Change-Number: 32216
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Apr 2023 21:49:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment