April 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: e1d: fix log output

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32336 ) Change subject: e1d: fix log output ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3a0500f083cbe8cc162826e2ec974875bafcaba9 Gerrit-Change-Number: 32336 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Apr 2023 00:05:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in libosmo-abis[master]: e1d: reconnect to osmo-e1d after connection loss

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 ) Change subject: e1d: reconnect to osmo-e1d after connection loss ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I'm wondering why this is implemented in libosmo-abis, and not in libosmo-e1d? Isn't the same problem applicable to *all* applications using osmo-e1d, and not just to those applications that use libosmo-abis as they implement an interface related to Abis -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338 Gerrit-Change-Number: 32374 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Apr 2023 00:04:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: ms: Increase log level when scheduling release timer

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32384 ) Change subject: ms: Increase log level when scheduling release timer ...................................................................... ms: Increase log level when scheduling release timer Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d --- M src/gprs_ms.c M tests/ms/MsTest.err 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/84/32384/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 1b51d4d..877422f 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -240,7 +240,7 @@ return; } - LOGPMS(ms, DMS, LOGL_DEBUG, "Schedule MS release in %u secs\n", ms->delay); + LOGPMS(ms, DMS, LOGL_INFO, "Schedule MS release in %u secs\n", ms->delay); osmo_timer_schedule(&ms->timer, ms->delay, 0); } diff --git a/tests/ms/MsTest.err b/tests/ms/MsTest.err index 84a948e..b507ca9 100644 --- a/tests/ms/MsTest.err +++ b/tests/ms/MsTest.err @@ -61,6 +61,7 @@ MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:UL:DL) Detaching TBF: TBF(UL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0:DL) Detaching TBF: TBF(DL:STATE-NEW:GPRS:TLLI-0xffeeddbb) MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0): - tbf: now used by 0 (-) +MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Schedule MS release in 1 secs MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Release timer expired MS(TLLI-0xffeeddbb:TA-220:MSCLS-0-0) Destroying MS object Creating MS object -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie470b5b0c7b01d91f4ad693e52afd51860d6da2d Gerrit-Change-Number: 32384 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: ms: Rewrite MS release lifecycle

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 to look at the new patch set (#2). Change subject: ms: Rewrite MS release lifecycle ...................................................................... ms: Rewrite MS release lifecycle This commit changes lots of stuff in the MS release lifecycle, but there's no really good way to split this into patches which make sense, since all the chaos is intensively entangled. Get rid of the ms_callback complex mess, it is not needed at all. Previous MS release was strange due to the existance of previous ms_callback.idle concept and MS storage: the MS signalled when it went idle (no TBFs attached) and waited for somebody outside to free it, while then arming itself the release timer to release itself if it was not released by whoever. The new lifecycle follows an easier (expected) approach: Whenever all TBFs become detached from the MS and it becomes idle (use_count becomes 0), then it frees its reserved resources (TFI, etc.) and either: * frees itself immediatelly under certain conditions (release timeout configured = 0 or MS garbage with TLLI=GSM_RESERVED_TMSI) * Arms release_timer and frees itself when it triggers. If during release_timer the MS is required again (for instance because a new TBF with TLLI/IMSI of the MS is observed), then a TBF is attached to the MS and it is considered to become active again, hence the release_timer is stopped. OS#6002 Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M tests/alloc/AllocTest.err M tests/alloc/AllocTest.ok M tests/app_info/AppInfoTest.err M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/ms/MsTest.ok M tests/tbf/TbfTest.err M tests/ulc/PdchUlcTest.err 11 files changed, 388 insertions(+), 545 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/32360/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 Gerrit-Change-Number: 32360 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: Add new log category 'ms'

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/32383 ) Change subject: Add new log category 'ms' ...................................................................... Add new log category 'ms' This is useful to track the lifecycle of MS objects. The RLCMAC cateogry used so far in those log messages is too broad. Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd --- M src/gprs_debug.c M src/gprs_debug.h M src/gprs_ms.c M tests/app_info/AppInfoTest.cpp M tests/ms/MsTest.cpp M tests/tbf/TbfTest.cpp M tests/ulc/PdchUlcTest.cpp 7 files changed, 50 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/32383/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd Gerrit-Change-Number: 32383 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: Add new log category 'ms'

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32383 ) Change subject: Add new log category 'ms' ...................................................................... Add new log category 'ms' This is useful to track the lifecycle of MS objects. The RLCMAC cateogry used so far in those log messages is too broad. Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd --- M src/gprs_debug.c M src/gprs_debug.h M src/gprs_ms.c M tests/app_info/AppInfoTest.cpp M tests/ms/MsTest.cpp M tests/tbf/TbfTest.cpp M tests/ulc/PdchUlcTest.cpp 7 files changed, 50 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/83/32383/1 diff --git a/src/gprs_debug.c b/src/gprs_debug.c index 8aeca5b..e3f862d 100644 --- a/src/gprs_debug.c +++ b/src/gprs_debug.c @@ -79,6 +79,13 @@ .loglevel = LOGL_NOTICE, .enabled = 1, }, + [DMS] = { + .name = "DMS", + .color = "\033[1;32m", + .description = "Mobile Station (MS)", + .loglevel = LOGL_NOTICE, + .enabled = 1, + }, [DTBF] = { .name = "DTBF", .color = "\033[1;34m", diff --git a/src/gprs_debug.h b/src/gprs_debug.h index db9630c..b66de90 100644 --- a/src/gprs_debug.h +++ b/src/gprs_debug.h @@ -34,6 +34,7 @@ DRLCMACUL, DRLCMACSCHED, DRLCMACMEAS, + DMS, DTBF, DTBFDL, DTBFUL, diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 617c769..a209758 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -82,7 +82,7 @@ level = LOGL_DEBUG; - LOGPSRC(DRLCMAC, level, file, line, "%s: %s %s: now used by %s\n", + LOGPSRC(DMS, level, file, line, "%s: %s %s: now used by %s\n", ms_name(ms), (e->count - old_use_count) > 0 ? "+" : "-", e->use, (osmo_use_count_to_str_buf(buf, sizeof(buf), &ms->use_count), buf)); @@ -100,7 +100,7 @@ static void ms_release_timer_cb(void *data) { struct GprsMs *ms = (struct GprsMs *) data; - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Release timer expired\n"); + LOGPMS(ms, DMS, LOGL_INFO, "Release timer expired\n"); /* Finally free the MS after being idle for a while according to config */ talloc_free(ms); @@ -148,7 +148,7 @@ int codel_interval = LLC_CODEL_USE_DEFAULT; - LOGP(DRLCMAC, LOGL_INFO, "Creating MS object\n"); + LOGP(DMS, LOGL_INFO, "Creating MS object\n"); ms->imsi[0] = '\0'; osmo_timer_setup(&ms->timer, ms_release_timer_cb, ms); @@ -184,7 +184,7 @@ { struct llist_item *pos, *tmp; - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Destroying MS object\n"); + LOGPMS(ms, DMS, LOGL_INFO, "Destroying MS object\n"); bts_stat_item_dec(ms->bts, STAT_MS_PRESENT); llist_del(&ms->list); @@ -240,7 +240,7 @@ return; } - LOGPMS(ms, DRLCMAC, LOGL_DEBUG, "Schedule MS release in %u secs\n", ms->delay); + LOGPMS(ms, DMS, LOGL_DEBUG, "Schedule MS release in %u secs\n", ms->delay); osmo_timer_schedule(&ms->timer, ms->delay, 0); } @@ -249,7 +249,7 @@ if (!osmo_timer_pending(ms->timer.data)) return; - LOGPMS(ms, DRLCMAC, LOGL_DEBUG, "Cancel scheduled MS release\n"); + LOGPMS(ms, DMS, LOGL_DEBUG, "Cancel scheduled MS release\n"); osmo_timer_del(&ms->timer); } @@ -329,7 +329,7 @@ static void ms_attach_ul_tbf(struct GprsMs *ms, struct gprs_rlcmac_ul_tbf *tbf) { - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Attaching UL TBF: %s\n", tbf_name((struct gprs_rlcmac_tbf *)tbf)); + LOGPMS(ms, DMS, LOGL_INFO, "Attaching UL TBF: %s\n", tbf_name((struct gprs_rlcmac_tbf *)tbf)); if (ms->ul_tbf) llist_add_tail(tbf_ms_list(ul_tbf_as_tbf(ms->ul_tbf)), &ms->old_tbfs); @@ -341,7 +341,7 @@ static void ms_attach_dl_tbf(struct GprsMs *ms, struct gprs_rlcmac_dl_tbf *tbf) { - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Attaching DL TBF: %s\n", tbf_name((struct gprs_rlcmac_tbf *)tbf)); + LOGPMS(ms, DMS, LOGL_INFO, "Attaching DL TBF: %s\n", tbf_name((struct gprs_rlcmac_tbf *)tbf)); if (ms->dl_tbf) llist_add_tail(tbf_ms_list(dl_tbf_as_tbf(ms->dl_tbf)), &ms->old_tbfs); @@ -374,7 +374,7 @@ if (!ms_tbf_is_attached(ms, tbf)) return; - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Detaching TBF: %s\n", + LOGPMS(ms, DMS, LOGL_INFO, "Detaching TBF: %s\n", tbf_name(tbf)); if (tbf == ul_tbf_as_tbf(ms->ul_tbf)) { @@ -394,7 +394,7 @@ ms_ref() taken to avoid use-after-free. */ void ms_reset(struct GprsMs *ms) { - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Clearing MS object\n"); + LOGPMS(ms, DMS, LOGL_INFO, "Clearing MS object\n"); struct llist_item *pos; struct gprs_rlcmac_tbf *tbf; @@ -458,7 +458,7 @@ ms_name_buf(old_ms, old_ms_name, sizeof(old_ms_name)); - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Merge MS: %s\n", old_ms_name); + LOGPMS(ms, DMS, LOGL_INFO, "Merge MS: %s\n", old_ms_name); if (strlen(ms_imsi(ms)) == 0 && strlen(ms_imsi(old_ms)) != 0) osmo_strlcpy(ms->imsi, ms_imsi(old_ms), sizeof(ms->imsi)); @@ -498,7 +498,7 @@ return; if (tlli != ms->new_dl_tlli) { - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "Modifying MS object, UL TLLI: 0x%08x -> 0x%08x, " "not yet confirmed\n", ms_tlli(ms), tlli); @@ -506,7 +506,7 @@ return; } - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "Modifying MS object, TLLI: 0x%08x -> 0x%08x, " "already confirmed partly\n", ms->tlli, tlli); @@ -524,7 +524,7 @@ /* The MS has not sent a message with the new TLLI, which may * happen according to the spec [TODO: add reference]. */ - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "The MS object cannot fully confirm an unexpected TLLI: 0x%08x, " "partly confirmed\n", tlli); /* Use the network's idea of TLLI as candidate, this does not @@ -533,7 +533,7 @@ return false; } - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "Modifying MS object, TLLI: 0x%08x confirmed\n", tlli); ms_apply_tlli_change(ms, tlli); @@ -544,12 +544,12 @@ void ms_set_imsi(struct GprsMs *ms, const char *imsi) { if (!imsi) { - LOGP(DRLCMAC, LOGL_ERROR, "Expected IMSI!\n"); + LOGP(DMS, LOGL_ERROR, "Expected IMSI!\n"); return; } if (imsi[0] && strlen(imsi) < 3) { - LOGP(DRLCMAC, LOGL_ERROR, "No valid IMSI '%s'!\n", + LOGP(DMS, LOGL_ERROR, "No valid IMSI '%s'!\n", imsi); return; } @@ -557,7 +557,7 @@ if (strcmp(imsi, ms->imsi) == 0) return; - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "Modifying MS object, TLLI = 0x%08x, IMSI '%s' -> '%s'\n", ms_tlli(ms), ms->imsi, imsi); @@ -570,7 +570,7 @@ * different IMSI */ OSMO_ASSERT(old_ms != ms); - LOGPMS(ms, DRLCMAC, LOGL_NOTICE, + LOGPMS(ms, DMS, LOGL_NOTICE, "IMSI '%s' was already assigned to another " "MS object: TLLI = 0x%08x, that IMSI will be removed\n", imsi, ms_tlli(old_ms)); @@ -595,12 +595,12 @@ return; if (gsm48_ta_is_valid(ta_)) { - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "Modifying MS object, TLLI = 0x%08x, TA %d -> %d\n", ms_tlli(ms), ms->ta, ta_); ms->ta = ta_; } else - LOGP(DRLCMAC, LOGL_NOTICE, + LOGP(DMS, LOGL_NOTICE, "MS object, TLLI = 0x%08x, invalid TA %d rejected (old " "value %d kept)\n", ms_tlli(ms), ta_, ms->ta); } @@ -610,7 +610,7 @@ if (ms_class_ == ms->ms_class) return; - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "Modifying MS object, TLLI = 0x%08x, MS class %d -> %d\n", ms_tlli(ms), ms->ms_class, ms_class_); @@ -622,14 +622,14 @@ if (ms_class_ == ms->egprs_ms_class) return; - LOGP(DRLCMAC, LOGL_INFO, + LOGP(DMS, LOGL_INFO, "Modifying MS object, TLLI = 0x%08x, EGPRS MS class %d -> %d\n", ms_tlli(ms), ms->egprs_ms_class, ms_class_); ms->egprs_ms_class = ms_class_; if (!bts_max_mcs_ul(ms->bts) || !bts_max_mcs_dl(ms->bts)) { - LOGPMS(ms, DRLCMAC, LOGL_DEBUG, + LOGPMS(ms, DMS, LOGL_DEBUG, "Avoid enabling EGPRS because use of MCS is disabled: ul=%u dl=%u\n", bts_max_mcs_ul(ms->bts), bts_max_mcs_dl(ms->bts)); return; @@ -643,7 +643,7 @@ } else { ms_set_mode(ms, EGPRS); } - LOGPMS(ms, DRLCMAC, LOGL_INFO, "Enabled EGPRS, mode %s\n", mode_name(ms_mode(ms))); + LOGPMS(ms, DMS, LOGL_INFO, "Enabled EGPRS, mode %s\n", mode_name(ms_mode(ms))); } void ms_update_error_rate(struct GprsMs *ms, struct gprs_rlcmac_tbf *tbf, int error_rate) @@ -882,7 +882,7 @@ } if (orig_cs != cs) - LOGPMS(ms, DRLCMACDL, LOGL_INFO, "MS (mode=%s) suggests transmitting " + LOGPMS(ms, DMS, LOGL_INFO, "MS (mode=%s) suggests transmitting " "DL %s, downgrade to %s in order to match TBF & scheduler requirements\n", mode_name(ms_mode(ms)), mcs_name(orig_cs), mcs_name(cs)); diff --git a/tests/app_info/AppInfoTest.cpp b/tests/app_info/AppInfoTest.cpp index cb11d0f..d33e8ce 100644 --- a/tests/app_info/AppInfoTest.cpp +++ b/tests/app_info/AppInfoTest.cpp @@ -180,7 +180,7 @@ log_set_print_filename2(osmo_stderr_target, LOG_FILENAME_NONE); log_set_print_category(osmo_stderr_target, 0); log_set_print_category_hex(osmo_stderr_target, 0); - log_parse_category_mask(osmo_stderr_target, "DL1IF,1:DRLCMAC,3:DRLCMACSCHED,1"); + log_parse_category_mask(osmo_stderr_target, "DL1IF,1:DRLCMAC,3:DRLCMACSCHED,1:DMS,3"); the_pcu = gprs_pcu_alloc(tall_pcu_ctx); bts_alloc(the_pcu, 0); diff --git a/tests/ms/MsTest.cpp b/tests/ms/MsTest.cpp index 7b7d59a..2a15a7b 100644 --- a/tests/ms/MsTest.cpp +++ b/tests/ms/MsTest.cpp @@ -542,7 +542,7 @@ log_set_log_level(osmo_stderr_target, LOGL_INFO); log_set_print_category(osmo_stderr_target, 0); log_set_print_category_hex(osmo_stderr_target, 0); - log_parse_category_mask(osmo_stderr_target, "DPCU,3:DRLCMAC,3"); + log_parse_category_mask(osmo_stderr_target, "DPCU,3:DRLCMAC,3:DMS,3"); the_pcu = gprs_pcu_alloc(tall_pcu_ctx); diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index 4adbaf8..ad08318 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -3470,7 +3470,7 @@ log_set_print_category_hex(osmo_stderr_target, 0); log_parse_category_mask(osmo_stderr_target, "DRLCMAC,1:DRLCMACDATA,3:DRLCMACDL,3:DRLCMACUL,3:" "DRLCMACSCHED,1:DRLCMACMEAS,3:DNS,3:DLBSSGP,3:DPCU,5:" - "DL1IF,6:DTBF,1:DTBFUL,1:DTBFDL,1:DLGLOBAL,2:"); + "DL1IF,6:DMS,1:DTBF,1:DTBFUL,1:DTBFDL,1:DLGLOBAL,2:"); osmo_fsm_log_addr(false); vty_init(&pcu_vty_info); pcu_vty_init(); diff --git a/tests/ulc/PdchUlcTest.cpp b/tests/ulc/PdchUlcTest.cpp index 3756b9d..be370bd 100644 --- a/tests/ulc/PdchUlcTest.cpp +++ b/tests/ulc/PdchUlcTest.cpp @@ -317,7 +317,7 @@ log_set_log_level(osmo_stderr_target, LOGL_DEBUG); log_set_print_category_hex(osmo_stderr_target, 0); log_set_print_category(osmo_stderr_target, 0); - log_parse_category_mask(osmo_stderr_target, "DPCU,1:DRLCMAC,1:DRLCMACUL,1"); + log_parse_category_mask(osmo_stderr_target, "DPCU,1:DRLCMAC,1:DRLCMACUL,1:DMS,1"); the_pcu = gprs_pcu_alloc(tall_pcu_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib4ce88d0f7309ac77c064a94bb0d667e8dbc33dd Gerrit-Change-Number: 32383 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: dl_tbf: Set BandWidth timestamps to current time directly

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32382 ) Change subject: dl_tbf: Set BandWidth timestamps to current time directly ...................................................................... dl_tbf: Set BandWidth timestamps to current time directly Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 --- M src/tbf_dl.cpp 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/82/32382/1 diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 17b6a3a..cbf42a2 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -95,8 +95,8 @@ dl_loss_lost(0), dl_loss_received(0) { - timespecclear(&dl_bw_tv); - timespecclear(&dl_loss_tv); + osmo_clock_gettime(CLOCK_MONOTONIC, &dl_bw_tv); + osmo_clock_gettime(CLOCK_MONOTONIC, &dl_loss_tv); } static int dl_tbf_dtor(struct gprs_rlcmac_dl_tbf *tbf) @@ -154,9 +154,6 @@ llist_add(tbf_trx_list((struct gprs_rlcmac_tbf *)tbf), &tbf->trx->dl_tbfs); bts_do_rate_ctr_inc(tbf->bts, CTR_TBF_DL_ALLOCATED); - osmo_clock_gettime(CLOCK_MONOTONIC, &tbf->m_bw.dl_bw_tv); - osmo_clock_gettime(CLOCK_MONOTONIC, &tbf->m_bw.dl_loss_tv); - return tbf; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I01654534aef5255c6d1c3ba0c553190a0319e8e1 Gerrit-Change-Number: 32382 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32381 ) Change subject: tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS ...................................................................... tbf_dl: Avoid attempt scheduling DL ACK/NACK in TS != CTRL TS Change-Id: I80cddc80f23992fd86637980f9e2bfc00a50e04e --- M src/tbf_dl.cpp 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/81/32381/1 diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp index 390d0ae..17b6a3a 100644 --- a/src/tbf_dl.cpp +++ b/src/tbf_dl.cpp @@ -799,8 +799,9 @@ m_last_dl_poll_fn = fn; /* poll after POLL_ACK_AFTER_FRAMES frames, or when final block is tx or - * when last polled DL ACK/NACK was lost. */ - if (need_poll_for_dl_ack_nack()) { + * when last polled DL ACK/NACK was lost. Always do so in the control TS. */ + if (tbf_is_control_ts(dl_tbf_as_tbf(this), pdch) && + need_poll_for_dl_ack_nack()) { if (m_dl_ack_requested) { LOGPTBFDL(this, LOGL_DEBUG, "Scheduling Ack/Nack polling, because it was requested explicitly " -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I80cddc80f23992fd86637980f9e2bfc00a50e04e Gerrit-Change-Number: 32381 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: ms: Hold a reference during ms_alloc

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/32375 to look at the new patch set (#3). Change subject: ms: Hold a reference during ms_alloc ...................................................................... ms: Hold a reference during ms_alloc Make the caller hold a reference to the MS object just allocated, so that it hs to explicitly unref it and, in turn, if no new references were added during its use, trigger release of the MS object. This is useful to avoid leaking MS object if it was allocated and then no TBF is attached to it because allocation of TBF failed. Related: OS#6002 Change-Id: I2088a7ddd76fe9157b6626ef96ae4315e88779ea --- M src/bts.cpp M src/gprs_ms.c M src/gprs_ms.h M src/pdch.cpp M src/tbf_dl.cpp M tests/alloc/AllocTest.cpp M tests/app_info/AppInfoTest.cpp M tests/llc/LlcTest.cpp M tests/ms/MsTest.cpp M tests/ms/MsTest.err M tests/tbf/TbfTest.cpp M tests/tbf/TbfTest.err M tests/types/TypesTest.cpp M tests/ulc/PdchUlcTest.cpp 14 files changed, 274 insertions(+), 114 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/75/32375/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2088a7ddd76fe9157b6626ef96ae4315e88779ea Gerrit-Change-Number: 32375 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: cosmetic: Fix indentation in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32380 ) Change subject: cosmetic: Fix indentation in comment ...................................................................... cosmetic: Fix indentation in comment Change-Id: I15063346e4ff0367c0bf04f6b48ac62b9bdf2929 --- M src/gprs_ms.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/32380/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index bba0b94..140d5d3 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -1232,7 +1232,7 @@ } else { /* Check if we can create a DL TBF to start sending the enqueued * data. Otherwise it will be triggered later when it is reachable - * again. */ + * again. */ if (ms_is_reachable_for_dl_ass(ms)) { if (ms_ul_tbf(ms)) rc = ms_new_dl_tbf_assigned_on_pacch(ms, ul_tbf_as_tbf(ms_ul_tbf(ms))); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I15063346e4ff0367c0bf04f6b48ac62b9bdf2929 Gerrit-Change-Number: 32380 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023