April 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-pcu[master]: ms: Rewrite MS release lifecycle

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32360 ) Change subject: ms: Rewrite MS release lifecycle ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 Gerrit-Change-Number: 32360 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 09:24:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul: Move rate_ctr allocation to constructor

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32378 ) Change subject: tbf_ul: Move rate_ctr allocation to constructor ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32378 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I818eb05fe062e0610e86cb34273bde99b379aa3f Gerrit-Change-Number: 32378 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 09:21:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf: Move m_ctrs alloc to constructor

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32377 ) Change subject: tbf: Move m_ctrs alloc to constructor ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If64443c38624d159e68eec3a07d8e8caf369467b Gerrit-Change-Number: 32377 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 09:21:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf: Store initial timestamp during constructor

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32376 ) Change subject: tbf: Store initial timestamp during constructor ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia0c2d0f5456b211169fb6c71f5f3c2e2b8760a28 Gerrit-Change-Number: 32376 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 09:18:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[L] Change in osmo-pcu[master]: ms: Rewrite MS release lifecycle

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32360 ) Change subject: ms: Rewrite MS release lifecycle ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/gprs_ms.c: https://gerrit.osmocom.org/c/osmo-pcu/+/32360/comment/af372d21_4c104426 PS5, Line 218: ms_becomes_idle these ms_becomes_ function names sound a bit strange to me, as the other functions are in imperative form and it's not that descriptive imho. maybe ms_schedule_release and ms_cancel_release would be better? but feel free to ignore if you think the existing ones from this patch are better -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe5115bc15bb4d76026918adc1be79469c2f4839 Gerrit-Change-Number: 32360 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 09:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1d: close fd when osmo_fd_setup fails

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32370 ) Change subject: e1d: close fd when osmo_fd_setup fails ...................................................................... e1d: close fd when osmo_fd_setup fails When osmo_fd_register() fails we just exit but the file descriptor stays open. A file descriptor in this state does not work. Let's close the file descriptor Change-Id: I6b41e5ad8511f2d4e524979631a91ab23dc0b23f --- M src/input/e1d.c 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/input/e1d.c b/src/input/e1d.c index f95d493..44a710d 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -509,6 +509,8 @@ if (ret < 0) { LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "could not register FD: %s\n", strerror(ret)); talloc_free(ts_info); + close(bfd->fd); + bfd->fd = -1; return ret; } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I6b41e5ad8511f2d4e524979631a91ab23dc0b23f Gerrit-Change-Number: 32370 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in libosmo-abis[master]: e1d: cosmetic: remove double whitespace

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32373 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: e1d: cosmetic: remove double whitespace ...................................................................... e1d: cosmetic: remove double whitespace Change-Id: If29ace652b71b33c3240f4dcb5eceeffb513d970 --- M src/input/e1d.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/e1d.c b/src/input/e1d.c index 1296b52..f95d493 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -40,7 +40,7 @@ #include <osmocom/e1d/proto_clnt.h> -#define TS_SIGN_ALLOC_SIZE 300 +#define TS_SIGN_ALLOC_SIZE 300 struct osmo_e1dp_client *g_e1d; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If29ace652b71b33c3240f4dcb5eceeffb513d970 Gerrit-Change-Number: 32373 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[M] Change in osmo-pcu[master]: ms: Make ms_{attach,detach}_tbf expectancies more robust

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32358 ) Change subject: ms: Make ms_{attach,detach}_tbf expectancies more robust ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia18fe2de1fb3bf72f530157e5f30de64f2b11e12 Gerrit-Change-Number: 32358 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 08:37:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bsc[2023q1]: SCCP N-PCSTATE: trigger MSC status on PC availability

by dexter

Attention is currently required from: neels. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32385 ) Change subject: SCCP N-PCSTATE: trigger MSC status on PC availability ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2023q1 Gerrit-Change-Id: I3a0869598b8395601a16d78dbc46eec400c0ea84 Gerrit-Change-Number: 32385 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Apr 2023 08:06:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: AssignmentState: voice_call -> rtp_stream

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32342 ) Change subject: bsc: AssignmentState: voice_call -> rtp_stream ...................................................................... bsc: AssignmentState: voice_call -> rtp_stream Now that CSD is supported, rename the variable. It is true for both voice calls and for CSD. Related: OS#4393 Change-Id: Idfd9a102ad172d3aeaa4222a21357cdcd51680df --- M bsc/BSC_Tests.ttcn M bsc/MSC_ConnectionHandler.ttcn 2 files changed, 30 insertions(+), 17 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index aa627b7..ecd9953 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9390,7 +9390,7 @@ BSSAP.send(ass_cmd); var AssignmentState st := valueof(ts_AssignmentStateInit); - st.voice_call := true; + st.rtp_stream := true; st.is_assignment := false; alt { [] as_modify(st); @@ -11154,7 +11154,7 @@ ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); var AssignmentState st := valueof(ts_AssignmentStateInit); - st.voice_call := true; + st.rtp_stream := true; st.is_assignment := true; var ExpectCriteria mgcpcrit := { diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn index fa7cd84..944e153 100644 --- a/bsc/MSC_ConnectionHandler.ttcn +++ b/bsc/MSC_ConnectionHandler.ttcn @@ -1088,7 +1088,7 @@ type record AssignmentState { /* global */ - boolean voice_call, + boolean rtp_stream, boolean is_assignment, /* Assignment related bits */ boolean rr_ass_cmpl_seen, @@ -1104,7 +1104,7 @@ } template (value) AssignmentState ts_AssignmentStateInit := { - voice_call := false, + rtp_stream := false, is_assignment := false, rr_ass_cmpl_seen := false, old_lchan_deact_sacch_seen := false, @@ -1246,7 +1246,7 @@ /* no assignment, just mode modify */ var RSL_Message rsl; - [st.voice_call and not st.rr_modify_seen] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr)) -> value rsl { + [st.rtp_stream and not st.rr_modify_seen] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr)) -> value rsl { var PDU_ML3_NW_MS l3 := dec_PDU_ML3_NW_MS(rsl.ies[2].body.l3_info.payload); log("Rx L3 from net: ", l3); if (ischosen(l3.msgs.rrm.channelModeModify)) { @@ -1257,7 +1257,7 @@ } repeat; } - [st.voice_call and st.rr_modify_seen] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_MODE_MODIFY_REQ)) -> value rsl { + [st.rtp_stream and st.rr_modify_seen] RSL.receive(tr_RSL_MsgTypeD(RSL_MT_MODE_MODIFY_REQ)) -> value rsl { st.rsl_mode_modify_msg := rsl; RSL.send(ts_RSL_MODE_MODIFY_ACK(g_chan_nr)); st.modify_done := true; @@ -1451,9 +1451,9 @@ transid := omit }; var AssignmentState st := valueof(ts_AssignmentStateInit); - /* if the channel type is SIGNAL, we're not handling a voice call */ + /* if the channel type is SIGNAL, we're not handling an rtp stream */ if (ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechOrDataIndicator != '0011'B) { - st.voice_call := true; + st.rtp_stream := true; exp_modify := true; } @@ -1483,8 +1483,8 @@ g_media.mgcp_conn[0].mdcx_seen_exp := 0; g_media.mgcp_conn[1].crcx_seen_exp := 0; g_media.mgcp_conn[1].mdcx_seen_exp := 0; - } else if (st.voice_call) { - /* For voice calls we expect the following MGCP activity */ + } else if (st.rtp_stream) { + /* For RTP streams we expect the following MGCP activity */ g_media.mgcp_conn[0].crcx_seen_exp := 1; g_media.mgcp_conn[0].mdcx_seen_exp := 1; g_media.mgcp_conn[1].crcx_seen_exp := 1; @@ -1511,8 +1511,8 @@ /* modify related bits */ [not st.is_assignment and exp_modify] as_modify(st); - /* voice call related bits (IPA CRCX/MDCX + MGCP) */ - [st.voice_call] as_Media(); + /* RTP stream related bits (IPA CRCX/MDCX + MGCP) */ + [st.rtp_stream] as_Media(); /* if we receive exactly what we expected, always return + pass */ [st.is_assignment and st.assignment_done or (not st.is_assignment and (st.modify_done or not exp_modify))] BSSAP.receive(exp_ass_cpl) -> value bssap { @@ -1550,11 +1550,11 @@ /* TODO: more precisely expect the different types of speech? */ var OCT1 rr_channel_mode := st.rr_channel_mode_modify_msg.msgs.rrm.channelModeModify.channelMode.mode; - if (st.voice_call and rr_channel_mode == '00'O) { + if (st.rtp_stream and rr_channel_mode == '00'O) { setverdict(fail, "f_establish_fully(): Expected RR Channel Mode Modify", " to a speech mode, but got channelMode == ", rr_channel_mode); mtc.stop; - } else if (not st.voice_call and rr_channel_mode != '00'O) { + } else if (not st.rtp_stream and rr_channel_mode != '00'O) { setverdict(fail, "f_establish_fully(): Expected RR Channel Mode Modify", " to signalling mode, but got channelMode == ", rr_channel_mode); mtc.stop; @@ -1566,11 +1566,11 @@ mtc.stop; } var RSL_SpeechDataInd rsl_spd_ind := chan_mode_ie.chan_mode.spd_ind; - if (st.voice_call and rsl_spd_ind != RSL_SPDI_SPEECH) { + if (st.rtp_stream and rsl_spd_ind != RSL_SPDI_SPEECH) { setverdict(fail, "f_establish_fully(): Expected RSL MODE MODIFY", " to a speech mode, but got spd_ind == ", rsl_spd_ind); mtc.stop; - } else if (not st.voice_call and rsl_spd_ind != RSL_SPDI_SIGN) { + } else if (not st.rtp_stream and rsl_spd_ind != RSL_SPDI_SIGN) { setverdict(fail, "f_establish_fully(): Expected RSL MODE MODIFY", " to signalling mode, but got spd_ind == ", rsl_spd_ind); mtc.stop; @@ -1615,7 +1615,7 @@ } } - if (not exp_fail and st.voice_call and not g_pars.aoip) { + if (not exp_fail and st.rtp_stream and not g_pars.aoip) { /* With SCCPLite, connect to BSC-located MGW using a CRCX + SDP. It is sent in MGCP over IPA in the BSC<->MSC (BSC-NAT) connection. BSC will forward it to its MGW. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idfd9a102ad172d3aeaa4222a21357cdcd51680df Gerrit-Change-Number: 32342 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023