April 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: flags: add missing entries to bts_impl_flag_desc[]

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32332 ) Change subject: flags: add missing entries to bts_impl_flag_desc[] ...................................................................... flags: add missing entries to bts_impl_flag_desc[] The following output can be seen when doing 'show bts' in the VTY: BTS model specific (internal) flags: 001 Measurement and Payload data combined 003 unknown 0x8 Fix this by adding the missing values to the value-string array. Change-Id: I83e5065f9f80b4f81e9767f184c8dc027883025a Fixes: 0277cddab "sysmo,oc2g,lc15: Make RadioChannel MO depend on RadioCarrier MO" Fixes: ee5eb6169 "l1sap: check if BTS model supports interference reporting" --- M src/common/bts.c 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/common/bts.c b/src/common/bts.c index a35c6d5..e50eaf8 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -202,6 +202,8 @@ const struct value_string bts_impl_flag_desc[] = { { BTS_INTERNAL_FLAG_MS_PWR_CTRL_DSP, "DSP/HW based MS Power Control Loop" }, { BTS_INTERNAL_FLAG_MEAS_PAYLOAD_COMB, "Measurement and Payload data combined" }, + { BTS_INTERNAL_FLAG_NM_RCHANNEL_DEPENDS_RCARRIER, "OML RadioChannel MO depends on RadioCarrier MO" }, + { BTS_INTERNAL_FLAG_INTERF_MEAS, "Uplink interference measurements" }, { 0, NULL } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32332 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I83e5065f9f80b4f81e9767f184c8dc027883025a Gerrit-Change-Number: 32332 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in osmo-e1d[master]: proto_clnt: use osmo_fd_close to close the socket on connection loss

by tnt

Attention is currently required from: jolly, dexter. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/32393 ) Change subject: proto_clnt: use osmo_fd_close to close the socket on connection loss ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/32393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I702b944baf2ebbcc84b6a211e245a4a41627bde6 Gerrit-Change-Number: 32393 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Apr 2023 05:46:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: RSL_Types: Add (most) VGCS/VBS related IEs + Messages

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32404 ) Change subject: RSL_Types: Add (most) VGCS/VBS related IEs + Messages ...................................................................... RSL_Types: Add (most) VGCS/VBS related IEs + Messages This will help us to start tests for VGCS/VBS. Change-Id: I4c4a9ac1bbd5114cb2237ea282d7bace13a52abe --- M library/GSM_Types.ttcn M library/RSL_Types.ttcn 2 files changed, 143 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/32404/1 diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn index b234bf4..54c2e98 100644 --- a/library/GSM_Types.ttcn +++ b/library/GSM_Types.ttcn @@ -29,6 +29,8 @@ type hexstring GsmMnc length(2 .. 3); type uint16_t GsmLac; type uint16_t GsmCellId; +type octetstring GroupCallRef length(1 .. 5); + /* ARFCN with explicit band discrimination */ type record GsmBandArfcn { diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn index 0f03c87..fe46ddc 100644 --- a/library/RSL_Types.ttcn +++ b/library/RSL_Types.ttcn @@ -4,7 +4,7 @@ * * RSL is a 3GPP standard protocol used between BTS and BSC in a GSM network. * - * (C) 2017 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2017-2023 by Harald Welte <laforge(a)gnumonks.org> * All rights reserved. * * Released under the terms of GNU General Public License, Version 2 or @@ -206,7 +206,7 @@ RSL_IE_CBCH_LOAD_INFO ('00101101'B), RSL_IE_SMSCB_CHAN_INDICATOR ('00101110'B), RSL_IE_GROUP_CALL_REF ('00101111'B), - RSL_IE_CHAN_DESC ('00110000'B), + RSL_IE_GROUP_CHAN_DESC ('00110000'B), RSL_IE_NCH_DRX_INFO ('00110001'B), RSL_IE_CMD_INDICATOR ('00110010'B), RSL_IE_EMLPP_PRIO ('00110011'B), @@ -850,6 +850,78 @@ slot_count := slot_count } + /* 9.3.45 Group Call Reference */ + type record RSL_IE_GroupCallReference { + uint8_t len, + GroupCallRef group_or_bcast_call_ref + } with { + variant (len) "LENGTHTO(group_or_bcast_call_ref)" + }; + template (value) RSL_IE_GroupCallReference ts_GroupCallRef(template (value) GroupCallRef gcr) := { + len := 0, // overwritten + group_or_bcast_call_ref := gcr + } + template (present) RSL_IE_GroupCallReference tr_GroupCallRef(template (present) GroupCallRef gcr := ?) := { + len := ?, + group_or_bcast_call_ref := gcr + } + + /* 9.3.46 Channel description */ + type record RSL_IE_GroupChannelDescription { + uint8_t len, + octetstring chan_desc + } with { + variant (len) "LENGTHTO(chan_desc)" + }; + template (value) RSL_IE_GroupChannelDescription ts_GroupChanDesc(template (value) octetstring cd) := { + len := 0, // overwritten + chan_desc := cd + } + template (present) RSL_IE_GroupChannelDescription tr_GroupChanDesc(template (present) octetstring cd) := { + len := ?, + chan_desc := cd + } + + /* 9.3.47 NCH DRX Information */ + type record RSL_IE_NchDrxInformation { + uint8_t len, + BIT2 spare, + BIT1 nln_status, + BIT3 emlpp_priority, + BIT2 nln + } with { + variant (len) "LENGTHTO(spare,nln_status,emlpp_priority,nln)" + }; + + /* 9.3.48 Command Indicator */ + type enumerated RSL_CommandIndicator { + CMD_IND_START (0), + CMD_IND_STOP (1) + } with { variant "FIELDLENGTH(8)" }; + type record RSL_IE_CommandIndicator { + uint8_t len, + RSL_CommandIndicator command_value + } with { + variant (len) "LENGTHTO(command_value)" + }; + template (value) RSL_IE_CommandIndicator ts_CommandInd(template (value) RSL_CommandIndicator ci) := { + len := 0, // overwritten + command_value := ci + } + template (present) RSL_IE_CommandIndicator tr_CommandInd(template (present) RSL_CommandIndicator ci) := { + len := ?, + command_value := ci + } + + /* 9.3.50 UIC */ + type record RSL_IE_Uic { + uint8_t len, + BIT2 spare, + uint6_t uic + } with { + variant (len) "LENGTHTO(spare,uic)" + }; + /* 9.3.52, 3GPP TS 44.018 10.5.2.21aa */ type record RSL_IE_MultirateCfg { uint8_t len, @@ -1086,6 +1158,12 @@ RSL_LV full_imm_ass_info, MobileIdentityLV ms_identity, + RSL_IE_GroupCallReference group_call_ref, + RSL_IE_GroupChannelDescription group_chan_desc, + RSL_IE_NchDrxInformation nch_drx_info, + RSL_IE_CommandIndicator cmd_indicator, + RSL_IE_Uic uic, + uint16_t ipa_conn_id, uint16_t ipa_local_port, uint16_t ipa_remote_port, @@ -1153,6 +1231,12 @@ ms_identity, iei = RSL_IE_MS_IDENTITY; other, iei = RSL_IE_FULL_BCCH_INFO; + group_call_ref, iei = RSL_IE_GROUP_CALL_REF; + group_chan_desc, iei = RSL_IE_GROUP_CHAN_DESC; + nch_drx_info, iei = RSL_IE_NCH_DRX_INFO; + cmd_indicator, iei = RSL_IE_CMD_INDICATOR; + uic, iei = RSL_IE_UIC; + ipa_conn_id, iei = RSL_IE_IPAC_CONN_ID; ipa_remote_ip, iei = RSL_IE_IPAC_REMOTE_IP; ipa_remote_port, iei = RSL_IE_IPAC_REMOTE_PORT; @@ -2659,6 +2743,50 @@ } } + template (value) RSL_Message ts_RSL_NOTIF_CMD_START(template (value) GroupCallRef group_call_ref, + template (value) octetstring chan_desc) := { + msg_disc := ts_RSL_MsgDisc(RSL_MDISC_CCHAN, false), + msg_type := RSL_MT_NOT_CMD, + ies := { + t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := ts_RslChanNr_PCH_AGCH(0)}), + t_RSL_IE(RSL_IE_CMD_INDICATOR, RSL_IE_Body:{cmd_indicator := ts_CommandInd(CMD_IND_START)}), + t_RSL_IE(RSL_IE_GROUP_CALL_REF, RSL_IE_Body:{group_call_ref := ts_GroupCallRef(group_call_ref)}), + t_RSL_IE(RSL_IE_GROUP_CHAN_DESC, RSL_IE_Body:{group_chan_desc := ts_GroupChanDesc(chan_desc)}) + } + } + template RSL_Message tr_RSL_NOTIF_CMD_START(template (value) GroupCallRef group_call_ref, + template octetstring chan_desc := ?) := { + msg_disc := tr_RSL_MsgDisc(RSL_MDISC_CCHAN, false), + msg_type := RSL_MT_NOT_CMD, + ies := { + tr_RSL_IE(RSL_IE_Body:{chan_nr := ts_RslChanNr_PCH_AGCH(0)}), + tr_RSL_IE(RSL_IE_Body:{cmd_indicator := ts_CommandInd(CMD_IND_START)}), + tr_RSL_IE(RSL_IE_Body:{group_call_ref := tr_GroupCallRef(group_call_ref)}), + tr_RSL_IE(RSL_IE_Body:{group_chan_desc := tr_GroupChanDesc(chan_desc)}), + * + } + } + + template (value) RSL_Message ts_RSL_NOTIF_CMD_STOP(template (value) GroupCallRef group_call_ref) := { + msg_disc := ts_RSL_MsgDisc(RSL_MDISC_CCHAN, false), + msg_type := RSL_MT_NOT_CMD, + ies := { + t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := ts_RslChanNr_PCH_AGCH(0)}), + t_RSL_IE(RSL_IE_CMD_INDICATOR, RSL_IE_Body:{cmd_indicator := ts_CommandInd(CMD_IND_STOP)}), + t_RSL_IE(RSL_IE_GROUP_CALL_REF, RSL_IE_Body:{group_call_ref := ts_GroupCallRef(group_call_ref)}) + } + } + template RSL_Message tr_RSL_NOTIF_CMD_STOP(template (value) GroupCallRef group_call_ref) := { + msg_disc := tr_RSL_MsgDisc(RSL_MDISC_CCHAN, false), + msg_type := RSL_MT_NOT_CMD, + ies := { + tr_RSL_IE(RSL_IE_Body:{chan_nr := ts_RslChanNr_PCH_AGCH(0)}), + tr_RSL_IE(RSL_IE_Body:{cmd_indicator := ts_CommandInd(CMD_IND_STOP)}), + tr_RSL_IE(RSL_IE_Body:{group_call_ref := tr_GroupCallRef(group_call_ref)}), + * + } + } + function f_rsl_find_ie(RSL_Message msg, RSL_IE_Type iei, out RSL_IE_Body ret) return boolean { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32404 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4c4a9ac1bbd5114cb2237ea282d7bace13a52abe Gerrit-Change-Number: 32404 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: WIP: BSSMAP_Templates: Add VBS/VGCS related templates

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 ) Change subject: WIP: BSSMAP_Templates: Add VBS/VGCS related templates ...................................................................... WIP: BSSMAP_Templates: Add VBS/VGCS related templates As we want to test VBS/VGCS related aspects of BSC and/or MSC soon, we will need related templates to construct and match related messages and IEs. Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d --- M library/BSSMAP_Templates.ttcn 1 file changed, 491 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/32405/1 diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index 02aad9f..7dc5ce7 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -2,7 +2,7 @@ /* BSSMAP Templates, building on top of BSSAP_Types from Ericsson. * - * (C) 2017-2019 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2017-2023 by Harald Welte <laforge(a)gnumonks.org> * contributions by sysmocom - s.f.m.c. GmbH * All rights reserved. * @@ -396,13 +396,13 @@ } -template BSSMAP_IE_Layer3Information ts_BSSMAP_IE_L3Info(octetstring l3info) := { +template (value) BSSMAP_IE_Layer3Information ts_BSSMAP_IE_L3Info(template (value) octetstring l3info) := { elementIdentifier := '17'O, lengthIndicator := 0, layer3info := l3info } -template BSSMAP_IE_Layer3Information tr_BSSMAP_IE_L3Info(template octetstring l3info) := { +template (present) BSSMAP_IE_Layer3Information tr_BSSMAP_IE_L3Info(template (present) octetstring l3info) := { elementIdentifier := '17'O, lengthIndicator := ?, layer3info := l3info @@ -1962,6 +1962,481 @@ rTC := '00'B /* Response Time is not specified */ } + +/* 3.2.2.55 */ +template (value) BSSMAP_IE_GroupCallReference +ts_BSSMAP_IE_GroupCallRef(template (value) GroupCallRef group_call_ref) :={ + elementIdentifier := '37'O, + lengthIndicator := 0, // overwritten + descrGroupbroadcastCallRef := group_call_ref +} +template (present) BSSMAP_IE_GroupCallReference +tr_BSSMAP_IE_GroupCallRef(template (present) GroupCallRef group_call_ref) :={ + elementIdentifier := '37'O, + lengthIndicator := 0, // overwritten + descrGroupbroadcastCallRef := group_call_ref +} + +/* 3.2.2.88 */ +template (value) BSSMAP_IE_VGCS_FeatureFlags +ts_BSSMAP_IE_VGCS_FeatureFlags(BIT1 tp_ind, BIT2 as_ind, BIT1 bss_res, BIT1 tcp) := { + elementIdentifier := '69'O, + lengthIndicator := 0, // overwritten + TP_Ind := tp_ind, + AS_Ind := as_ind, + BSS_Res := bss_res, + tCP := tcp, + spare := '000'B +}; +template (present) BSSMAP_IE_VGCS_FeatureFlags +tr_BSSMAP_IE_VGCS_FeatureFlags(BIT1 tp_ind, BIT2 as_ind, BIT1 bss_res, BIT1 tcp) := { + elementIdentifier := '69'O, + lengthIndicator := ?, + TP_Ind := tp_ind, + AS_Ind := as_ind, + BSS_Res := bss_res, + tCP := tcp, + spare := ? +}; + +/* 3.2.2.98 */ +template (value) BSSMAP_IE_ApplicationData +ts_BSSMAP_IE_ApplicationData(template (value) OCT9 adi) := { + elementIdentifier := '78'O, + lengthIndicator := 0, // overwritten + applicationDataInfo := adi +}; +template (present) BSSMAP_IE_ApplicationData +tr_BSSMAP_IE_ApplicationData(template (present) OCT9 adi) := { + elementIdentifier := '78'O, + lengthIndicator := ?, + applicationDataInfo := adi +}; + +/* 3.2.2.99 */ +template (value) BSSMAP_IE_DataIdentity +ts_BSSMAP_IE_DataIdentity(template (value) DataIdentity data_id) := { + elementIdentifier := '79'O, + lengthIndicator := 0, // overwritten + dataIdentityInfo := data_id +}; +template (present) BSSMAP_IE_DataIdentity +tr_BSSMAP_IE_DataIdentity(template (present) DataIdentity data_id) := { + elementIdentifier := '79'O, + lengthIndicator := ?, + dataIdentityInfo := data_id +}; + +/* 3.2.2.52 */ +template (value) BSSMAP_IE_AssignmentRequirement +ts_BSSMAP_IE_AssRequirement(template (value) OCT1 ass_rqm) := { + elementIdentifier := '33'O, + assignmentRequirement := ass_rqm +} +template (present) BSSMAP_IE_AssignmentRequirement +tr_BSSMAP_IE_AssRequirement(template (present) OCT1 ass_rqm) := { + elementIdentifier := '33'O, + assignmentRequirement := ass_rqm +} + +/* 3.2.2.89 */ +template (value) BSSMAP_IE_TalkerPriority +ts_BSSMAP_IE_TalkerPriority(template (value) BIT2 prio) := { + elementIdentifier := '6A'O, + priority := prio, + spare := '000000'B +} +template (value) BSSMAP_IE_TalkerPriority +tr_BSSMAP_IE_TalkerPriority(template (value) BIT2 prio) := { + elementIdentifier := '6A'O, + priority := prio, + spare := '000000'B +} + +/* 3.2.2.90 */ +template (value) BSSMAP_IE_EmergencySetIndication +ts_BSSMAP_IE_EmergencySetIndication := { + elementIdentifier := '6B'O +} +template (present) BSSMAP_IE_EmergencySetIndication +tr_BSSMAP_IE_EmergencySetIndication := { + elementIdentifier := '6B'O +} + + + + +/* Section 3.2.1.50 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_Setup(template (value) GroupCallRef group_call_ref) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetup := { + messageType := '04'O, + groupCallReference := ts_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := omit, + vGCS_FeatureFlags := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_Setup(template (present) GroupCallRef group_call_ref) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetup := { + messageType := '04'O, + groupCallReference := tr_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := *, + vGCS_FeatureFlags := * + } + } + } +} + +/* Section 3.2.1.51 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_SetupAck(template (omit) BSSMAP_IE_VGCS_FeatureFlags feature_flags) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupAck := { + messageType := '05'O, + vGCS_FeatureFlags := feature_flags + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_SetupAck(template BSSMAP_IE_VGCS_FeatureFlags feature_flags) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupAck := { + messageType := '05'O, + vGCS_FeatureFlags := feature_flags + } + } + } +} + +/* Section 3.2.1.52 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_SetupRefuse(BssmapCause cause) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupRefuse := { + messageType := '06'O, + cause := ts_BSSMAP_IE_Cause(cause) + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_SetupRefuse(template (present) myBSSMAP_Cause cause) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSSetupRefuse := { + messageType := '06'O, + cause := tr_BSSMAP_IE_Cause(cause) + } + } + } +} + +/* Section 3.2.1.53 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_AssignmentReq(template (value) BSSMAP_IE_ChannelType ch_type, + template (value) OCT1 ass_requirement, + template (value) BSSMAP_IE_CellIdentifier cell_id, + template (value) GroupCallRef group_call_ref, + template (omit) BSSMAP_IE_CircuitIdentityCode cic := omit, + template (omit) BSSMAP_IE_AoIP_TransportLayerAddress aoip := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentRequest := { + messageType := '07'O, /* overwritten */ + channelType := ch_type, + assignmentRequirement := ts_BSSMAP_IE_AssRequirement(ass_requirement), + cellIdentifier := cell_id, + groupCallReference := ts_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := omit, + circuitIdentityCode := cic, + downLinkDTX_Flag := omit, + encryptionInformation := omit, + vSTK_RAND := omit, + vSTK := omit, + cellIdentifierListSegment := omit, + aoIPTransportLayer := aoip, + codecList := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_AssignmentReq(template (present) BSSMAP_IE_ChannelType ch_type, + template (present) OCT1 ass_requirement, + template (present) BSSMAP_IE_CellIdentifier cell_id, + template (present) GroupCallRef group_call_ref, + template BSSMAP_IE_CircuitIdentityCode cic := *, + template BSSMAP_IE_AoIP_TransportLayerAddress aoip := ?) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentRequest := { + messageType := '07'O, /* overwritten */ + channelType := ch_type, + assignmentRequirement := tr_BSSMAP_IE_AssRequirement(ass_requirement), + cellIdentifier := cell_id, + groupCallReference := tr_BSSMAP_IE_GroupCallRef(group_call_ref), + priority := omit, + circuitIdentityCode := cic, + downLinkDTX_Flag := omit, + encryptionInformation := omit, + vSTK_RAND := omit, + vSTK := omit, + cellIdentifierListSegment := omit, + aoIPTransportLayer := aoip, + codecList := omit + } + } + } +} + +/* Section 3.2.1.54 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_AssignmentRes(template (value) BSSMAP_IE_ChannelType ch_type, + template (value) BSSMAP_IE_CellIdentifier cell_id, + template (omit) BSSMAP_IE_ChosenChannel chosen_ch := omit, + template (omit) BSSMAP_IE_CircuitIdentityCode cic := omit, + template (omit) BSSMAP_IE_AoIP_TransportLayerAddress aoip := omit, + template (omit) BSSMAP_IE_SpeechCodec speech_codec := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentResult := { + messageType := '1C'O, /* overwritten */ + channelType := ch_type, + cellIdentifier := cell_id, + chosenChannel := chosen_ch, + circuitIdentityCode := cic, + circuitPool := omit, + aoIPTransportLayer := aoip, + speechCodec := speech_codec, + callIdentifier := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_AssignmentRes(template (present) BSSMAP_IE_ChannelType ch_type, + template (present) BSSMAP_IE_CellIdentifier cell_id, + template BSSMAP_IE_ChosenChannel chosen_ch := omit, + template BSSMAP_IE_CircuitIdentityCode cic := omit, + template BSSMAP_IE_AoIP_TransportLayerAddress aoip := omit, + template BSSMAP_IE_SpeechCodec speech_codec := omit) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentResult := { + messageType := '1C'O, /* overwritten */ + channelType := ch_type, + cellIdentifier := cell_id, + chosenChannel := chosen_ch, + circuitIdentityCode := cic, + circuitPool := *, + aoIPTransportLayer := aoip, + speechCodec := speech_codec, + callIdentifier := * + } + } + } +} + +/* Section 3.2.1.55 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_AssignmentFail(BssmapCause cause) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentFailure := { + messageType := '1D'O, /* overwritten */ + cause := ts_BSSMAP_IE_Cause(cause), + /* we only implement AoIP for now... */ + circuitPool := omit, + circuitPoolList := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_AssignmentFail(template (present) myBSSMAP_Cause cause) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSAssignmentFailure := { + messageType := '1D'O, /* overwritten */ + cause := tr_BSSMAP_IE_Cause(cause), + /* we only implement AoIP for now... */ + circuitPool := omit, + circuitPoolList := omit + } + } + } +} + +/* Section 3.2.1.56 */ +template (value) PDU_BSSAP +ts_BSSMAP_VGCS_VBS_QueuingInd +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSQueuingIndication := { + messageType := '1E'O + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_VGCS_VBS_QueuingInd +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + vGCS_VBSQueuingIndication := { + messageType := '1E'O + } + } + } +} + +/* Section 3.2.1.57 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkReq_L3(template (value) BIT2 priority, + template (omit) BSSMAP_IE_CellIdentifier cell_id, + template (value) octetstring l3_info) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := ts_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := ts_BSSMAP_IE_L3Info(l3_info), + mobileIdentity := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkReq_L3(template (present) BIT2 priority, + template BSSMAP_IE_CellIdentifier cell_id, + template (present) octetstring l3_info) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := tr_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := tr_BSSMAP_IE_L3Info(l3_info), + mobileIdentity := omit + } + } + } +} +template (value) PDU_BSSAP +ts_BSSMAP_UplinkReq_MI(template (value) BIT2 priority, + template (omit) BSSMAP_IE_CellIdentifier cell_id, + template (value) BSSMAP_IE_MobileIdentity mobile_id) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := ts_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := omit, + mobileIdentity := mobile_id + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_UplinkReq_MI(template (present) BIT2 priority, + template (omit) BSSMAP_IE_CellIdentifier cell_id, + template (present) BSSMAP_IE_MobileIdentity mobile_id) +modifies tr_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequest := { + messageType := '1F'O, + talkerPriority := tr_BSSMAP_IE_TalkerPriority(priority), + cellIdentifier := cell_id, + layer3Information := omit, + mobileIdentity := mobile_id + } + } + } +} + +/* 3.2.1.58 */ +template (value) PDU_BSSAP +ts_BSSMAP_UplinkReqAck(template (value) BIT2 priority, + template (omit) BSSMAP_IE_EmergencySetIndication ems := omit, + template (omit) BSSMAP_IE_TalkerIdentity talker_id := omit) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + uplinkRequestAck := { + messageType := '27'O, + talkerPriority := ts_BSSMAP_IE_TalkerPriority(priority), + emergencySetIndication := ems, + talkerIdentity := talker_id + } + } + } +} + + + + +/* Section 3.2.1.82 */ +template (value) PDU_BSSAP +ts_BSSMAP_NotificationData(template (value) OCT9 app_data, template (value) DataIdentity data_identity) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + notificationData := { + messageType := '62'O, + applicationData := ts_BSSMAP_IE_ApplicationData(app_data), + dataIdentity := ts_BSSMAP_IE_DataIdentity(data_identity), + mSISDN := omit + } + } + } +} +template (present) PDU_BSSAP +tr_BSSMAP_NotificationData(template (present) OCT9 app_data, template (present) DataIdentity data_identity) +modifies ts_BSSAP_BSSMAP := { + pdu := { + bssmap := { + notificationData := { + messageType := '62'O, + applicationData := tr_BSSMAP_IE_ApplicationData(app_data), + dataIdentity := tr_BSSMAP_IE_DataIdentity(data_identity), + mSISDN := ? + } + } + } +} + + + template (value) PDU_BSSAP ts_BSSMAP_Perform_Location_Request(template (omit) BSSMAP_IE_IMSI imsi, template (omit) BSSMAP_IE_CellIdentifier cellIdentifier := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32405 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I949f731de794b22292b01d0ddf9a75a9e7e7e71d Gerrit-Change-Number: 32405 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

[S] Change in docker-playground[master]: stp: Expand osmo-stp.cfg for "norctx" tests

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/32330 ) Change subject: stp: Expand osmo-stp.cfg for "norctx" tests ...................................................................... Patch Set 2: (2 comments) File ttcn3-stp-test/osmo-stp.cfg: https://gerrit.osmocom.org/c/docker-playground/+/32330/comment/7300004e_e29… PS1, Line 49: 0 > trailing zero here ... Done https://gerrit.osmocom.org/c/docker-playground/+/32330/comment/45fa074d_8a9… PS1, Line 75: asp asp-client60-norctx m3ua > Sorry to see that 6 days later this has still not been taken over by nhofmeyr. […] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/32330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie00d96d04dd36c71c79f3b73713c3fe1c26a5145 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Apr 2023 01:55:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in docker-playground[master]: stp: Expand osmo-stp.cfg for "norctx" tests

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/32330 ) Change subject: stp: Expand osmo-stp.cfg for "norctx" tests ...................................................................... stp: Expand osmo-stp.cfg for "norctx" tests In osmo-ttcn3-hacks.git I81052ece7d1cc8b43da6155356ed1c4d9620acdc we're adding support for so-called "norctrx"tests, covering operation without routing-context IEs. For this, we need additional AS/ASP definitions in the osmo-stp.cfg Change-Id: Ie00d96d04dd36c71c79f3b73713c3fe1c26a5145 Related: OS#6003 --- M ttcn3-stp-test/osmo-stp.cfg 1 file changed, 37 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ttcn3-stp-test/osmo-stp.cfg b/ttcn3-stp-test/osmo-stp.cfg index 9e4447c..e3083da 100644 --- a/ttcn3-stp-test/osmo-stp.cfg +++ b/ttcn3-stp-test/osmo-stp.cfg @@ -46,6 +46,20 @@ remote-ip fd02:db8:19::203 sctp-role client role asp + asp asp-client60-norctx0 11060 2907 m3ua + local-ip 172.18.19.200 + local-ip fd02:db8:19::200 + remote-ip 172.18.19.203 + remote-ip fd02:db8:19::203 + sctp-role client + role asp + asp asp-client61-norctx0 11061 2907 m3ua + local-ip 172.18.19.200 + local-ip fd02:db8:19::200 + remote-ip 172.18.19.203 + remote-ip fd02:db8:19::203 + sctp-role client + role asp as as-sender m3ua asp asp-sender routing-key 1023 23 @@ -56,6 +70,12 @@ as as-client m3ua routing-key 1055 55 asp asp-client0 + as as-client60-norctx m3ua + routing-key 0 60 + asp asp-client60-norctx0 + as as-client61-norctx m3ua + routing-key 0 61 + asp asp-client61-norctx0 ! ! IPA AS/ASP: ! @@ -110,6 +130,8 @@ update route 23 16777215 linkset as-sender update route 42 16777215 linkset as-receiver update route 55 16777215 linkset as-client + update route 60 16777215 linkset as-client60-norctx + update route 61 16777215 linkset as-client61-norctx update route 31 16777215 linkset ipa-as-loadshare-receiver update route 33 16777215 linkset ipa-as-override-receiver update route 5 16777215 linkset ipa-as-dynamic-asp -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/32330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie00d96d04dd36c71c79f3b73713c3fe1c26a5145 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

[S] Change in docker-playground[master]: stp: Expand osmo-stp.cfg for "norctx" tests

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/32330 ) Change subject: stp: Expand osmo-stp.cfg for "norctx" tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/32330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie00d96d04dd36c71c79f3b73713c3fe1c26a5145 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Apr 2023 01:54:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[S] Change in docker-playground[master]: stp: Expand osmo-stp.cfg for "norctx" tests

by laforge

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/32330 to look at the new patch set (#2). Change subject: stp: Expand osmo-stp.cfg for "norctx" tests ...................................................................... stp: Expand osmo-stp.cfg for "norctx" tests In osmo-ttcn3-hacks.git I81052ece7d1cc8b43da6155356ed1c4d9620acdc we're adding support for so-called "norctrx"tests, covering operation without routing-context IEs. For this, we need additional AS/ASP definitions in the osmo-stp.cfg Change-Id: Ie00d96d04dd36c71c79f3b73713c3fe1c26a5145 Related: OS#6003 --- M ttcn3-stp-test/osmo-stp.cfg 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/30/32330/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/32330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie00d96d04dd36c71c79f3b73713c3fe1c26a5145 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

[S] Change in docker-playground[master]: stp: Expand osmo-stp.cfg for "norctx" tests

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/32330 ) Change subject: stp: Expand osmo-stp.cfg for "norctx" tests ...................................................................... Patch Set 1: (1 comment) File ttcn3-stp-test/osmo-stp.cfg: https://gerrit.osmocom.org/c/docker-playground/+/32330/comment/9b4de6e8_812… PS1, Line 75: asp asp-client60-norctx m3ua > I don't have a way to realistically test the dockerized setup while travelling. […] Sorry to see that 6 days later this has still not been taken over by nhofmeyr. So now I really have to spend more time in my holidays to move this ahead :/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/32330 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie00d96d04dd36c71c79f3b73713c3fe1c26a5145 Gerrit-Change-Number: 32330 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Apr 2023 01:45:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

[M] Change in osmo-bts[master]: gsm_objclass2obj(): Change signature/set NACK cause

by laforge

Attention is currently required from: arehbein, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32354 ) Change subject: gsm_objclass2obj(): Change signature/set NACK cause ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If734ea2c8cae4c1f99b02520dffa4e3862a67745 Gerrit-Change-Number: 32354 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 22 Apr 2023 01:43:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2023