March 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: filesystem: decode select response for MF
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23209 ) Change subject: filesystem: decode select response for MF ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > any news on this change? ping? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b2476fc0e7d34cdacf7eb100ffadceb788c4d2 Gerrit-Change-Number: 23209 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:21:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[M] Change in pysim[master]: cards: move methods read_aids and select_adf_by_aid to class UsimCard
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24146 ) Change subject: cards: move methods read_aids and select_adf_by_aid to class UsimCard ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @dexter: is this patch still needed? if yes, please update. If not, please abandon. ping? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71667b7b38c930b4e0409fe2ba2786e1db9cf9a3 Gerrit-Change-Number: 24146 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:20:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Fix parsing of TLV_TYPE_SINGLE_TV
by pespin 22 Mar '23

22 Mar '23

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32014 to look at the new patch set (#2). Change subject: Fix parsing of TLV_TYPE_SINGLE_TV ...................................................................... Fix parsing of TLV_TYPE_SINGLE_TV The decoding path of TLV_TYPE_SINGLE_TV is wrong, since it is not shifting right the tag before using it. On the other hand, the encoding path (tlv_encode_one) is doing that, so it is clear there's a bug. It seems that in order to workaround the bug some IEs in gsm_04_08.h (TS 24.008 and TS 44.018) were defined incorrectly (eg 0x80) while the spec clearly assigns eg. "8" to it, and makes sure no full byte IEI collides. Some other IEIs like GSM48_IE_GMM_CIPH_CKSN which are also of the same type were already correctly defined as 0x08. Change-Id: I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 --- M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/gsm48.c M src/gsm/tlv_parser.c 3 files changed, 37 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/32014/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 Gerrit-Change-Number: 32014 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libsmpp34[master]: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29081 ) Change subject: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/ ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: ping? -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I9343f53c125be8e4c7590164a8541d9fe114deb5 Gerrit-Change-Number: 29081 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:17:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-ci[master]: jobs/osmocom-release-manuals: add new job
by osmith 22 Mar '23

22 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/32016 ) Change subject: jobs/osmocom-release-manuals: add new job ...................................................................... jobs/osmocom-release-manuals: add new job Add a jenkins job that automatically builds manuals for release tags, if they don't exist on the server already. Closes: OS#5902 Related: https://downloads.osmocom.org/docs/ Change-Id: I0ecb238660553c3c857e1b310873eca8a8d09dab --- M .gitignore A jobs/osmocom-release-manuals.yml A scripts/manuals/0001-build-custom-dblatex.sty-remove-DRAFT.patch A scripts/manuals/publish-manuals-for-tags.sh 4 files changed, 515 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/16/32016/1 diff --git a/.gitignore b/.gitignore index fa28062..3fcbe85 100644 --- a/.gitignore +++ b/.gitignore @@ -12,4 +12,5 @@ _release_tarballs/ _docker_playground _repo_install_test_data/ +_temp_manuals/ scripts/repo-install-test/run-inside-env.sh diff --git a/jobs/osmocom-release-manuals.yml b/jobs/osmocom-release-manuals.yml new file mode 100644 index 0000000..19a8765 --- /dev/null +++ b/jobs/osmocom-release-manuals.yml @@ -0,0 +1,40 @@ +--- +- project: + name: Osmocom-release-manuals + jobs: + - Osmocom-release-manuals + +- job: + name: 'Osmocom-release-manuals' + project-type: freestyle + defaults: global + description: | + Build manuals for all new Osmocom releases + (<a href="https://osmocom.org/issues/5902">OS#5902</a>). + parameters: + - string: + name: BRANCH_CI + description: | + osmo-ci.git branch + default: 'master' + builders: + - shell: | + scripts/manuals/publish-manuals-for-tags.sh + scm: + - git: + branches: + - '$BRANCH_CI' + url: https://gerrit.osmocom.org/osmo-ci + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins(a)osmocom.org' + wipe-workspace: true + triggers: + - timed: "@midnight" + publishers: + - email: + notify-every-unstable-build: true + recipients: 'jenkins-notifications(a)lists.osmocom.org' + wrappers: + - ssh-agent-credentials: + users: + - docs_ftp.osmocom.org diff --git a/scripts/manuals/0001-build-custom-dblatex.sty-remove-DRAFT.patch b/scripts/manuals/0001-build-custom-dblatex.sty-remove-DRAFT.patch new file mode 100644 index 0000000..65a4e89 --- /dev/null +++ b/scripts/manuals/0001-build-custom-dblatex.sty-remove-DRAFT.patch @@ -0,0 +1,48 @@ +From ed812f2bd79e7e01c833d90ee279ae4750f82f2f Mon Sep 17 00:00:00 2001 +From: Oliver Smith <osmith(a)sysmocom.de> +Date: Wed, 8 Mar 2023 17:48:17 +0100 +Subject: [PATCH] build/custom-dblatex.sty: remove DRAFT + +This patch will be used when generating manuals for the tagged +releases, so they don't have the draft watermark. + +Related: OS#5902 +Change-Id: Id9a27b01412b0e615638f20fa5e36f5b114a15d8 +--- + build/Makefile.asciidoc.inc | 4 ---- + build/custom-dblatex.sty | 4 ---- + 2 files changed, 8 deletions(-) + +diff --git a/build/Makefile.asciidoc.inc b/build/Makefile.asciidoc.inc +index 1b7375e..9a9e829 100644 +--- a/build/Makefile.asciidoc.inc ++++ b/build/Makefile.asciidoc.inc +@@ -69,10 +69,6 @@ $(ASCIIDOC_PDF): %.pdf: %.adoc %-docinfo.xml \ + + # TEXINPUTS: find LaTeX includes like \includegraphics{./common/images/sysmocom.pdf} + # in $(OSMO_GSM_MANUALS_DIR). +- @test -n "$(BUILD_RELEASE)" && echo -e "\n\n\ +- NOTE: TO REMOVE DRAFT MODE, YOU NEED TO EDIT build/custom-dblatex.sty\n\ +- and remove three lines starting with '% \"DRAFT\" on first page'\n" \ +- || true + TEXINPUTS="$(OSMO_GSM_MANUALS_DIR)" \ + a2x -vv $(A2X_OPTS) $(notdir $<) + +diff --git a/build/custom-dblatex.sty b/build/custom-dblatex.sty +index 16931ad..0d53bb1 100644 +--- a/build/custom-dblatex.sty ++++ b/build/custom-dblatex.sty +@@ -20,10 +20,6 @@ + \usepackage{alltt} + \usepackage{upquote} + +-% "DRAFT" on first page +-\definecolor{LtGrey}{rgb}{0.875,0.875,0.875} +-\AddToShipoutPicture*{ \AtTextCenter{ \makebox(0,0)[c]{\resizebox{\textwidth}{!}{ \rotatebox{45}{\textsf{\textbf{\color{LtGrey}DRAFT}}}}} } } +- + \def\Company{sysmocom - s.f.m.c. GmbH} + + \def\DBKcover{ +-- +2.34.1 + diff --git a/scripts/manuals/publish-manuals-for-tags.sh b/scripts/manuals/publish-manuals-for-tags.sh new file mode 100755 index 0000000..0426868 --- /dev/null +++ b/scripts/manuals/publish-manuals-for-tags.sh @@ -0,0 +1,412 @@ +#!/bin/sh -e +. "$(dirname "$0")/../common.sh" +OSMO_CI_DIR="$(realpath $(dirname "$0")/../..)" +TEMP="$OSMO_CI_DIR/_temp_manuals" +WEB_PATH="/downloads/home/docs/web-files" +SSH_COMMAND="ssh -o UserKnownHostsFile=$TEMP/src/osmo-gsm-manuals/build/known_hosts -p 48" +DOCKER_IMAGE="$USER/debian-bullseye-jenkins" +LOG_PREFIX="::" + +# Releases that were made before shared osmo-gsm-manuals, or where build fails +# for other reasons. +TAGS_IGNORE=" + openbsc:0.9.0, + openbsc:0.9.1, + openbsc:0.9.2, + openbsc:0.9.3, + openbsc:0.9.4, + openbsc:0.9.5, + openbsc:0.9.6, + openbsc:0.9.8, + openbsc:0.9.9, + openbsc:0.9.10, + openbsc:0.9.11, + openbsc:0.9.12, + openbsc:0.9.13, + openbsc:0.9.14, + openbsc:0.9.15, + openbsc:0.9.16, + openbsc:0.10.0, + openbsc:0.10.1, + openbsc:0.11.0, + openbsc:0.12.0, + openbsc:0.13.0, + openbsc:0.14.0, + openbsc:0.15.0, + openbsc:1.0.0, + openbsc:1.1.0, + + osmo-bsc:1.0.1, + osmo-bsc:1.1.0, + osmo-bsc:1.1.1, + osmo-bsc:1.1.2, + osmo-bsc:1.2.0, + osmo-bsc:1.2.1, + osmo-bsc:1.2.2, + osmo-bsc:1.3.0, + osmo-bsc:1.4.0, + osmo-bsc:1.4.1, + osmo-bsc:1.5.0, + osmo-bsc:1.6.0, + + osmo-bts:0.0.1, + osmo-bts:0.1.0, + osmo-bts:0.2.0, + osmo-bts:0.3.0, + osmo-bts:0.4.0, + osmo-bts:0.6.0, + osmo-bts:0.7.0, + osmo-bts:0.8.0, + osmo-bts:0.8.1, + osmo-bts:1.0.0, + osmo-bts:1.0.1, + osmo-bts:1.1.0, + osmo-bts:1.2.0, + + osmo-e1d:0.0.1, + osmo-e1d:0.1.0, + osmo-e1d:0.1.1, + osmo-e1d:0.2.0, + osmo-e1d:0.2.1, + osmo-e1d:0.2.2, + osmo-e1d:0.3.0, + osmo-e1d:0.4.0, + + osmo-ggsn:1.0.0, + osmo-ggsn:1.1.0, + osmo-ggsn:1.2.0, + osmo-ggsn:1.2.1, + osmo-ggsn:1.2.2, + + osmo-gsm-tester:0.1, + + osmo-hlr:0.0.1, + osmo-hlr:0.1.0, + osmo-hlr:0.2.0, + osmo-hlr:0.2.1, + + osmo-mgw:1.0.1, + osmo-mgw:1.0.2, + osmo-mgw:1.1.0, + osmo-mgw:1.2.0, + osmo-mgw:1.2.1, + osmo-mgw:1.3.0, + osmo-mgw:1.4.0, + + osmo-msc:1.0.1, + osmo-msc:1.1.0, + osmo-msc:1.1.1, + osmo-msc:1.1.2, + osmo-msc:1.2.0, + osmo-msc:1.3.0, + osmo-msc:1.3.1, + osmo-msc:1.4.0, + osmo-msc:1.5.0, + osmo-msc:1.6.0, + osmo-msc:1.6.1, + osmo-msc:1.6.2, + osmo-msc:1.6.3, + + osmo-pcap:0.0.1, + osmo-pcap:0.0.2, + osmo-pcap:0.0.3, + osmo-pcap:0.0.4, + osmo-pcap:0.0.5, + osmo-pcap:0.0.6, + osmo-pcap:0.0.7, + osmo-pcap:0.0.8, + osmo-pcap:0.0.9, + osmo-pcap:0.0.10, + osmo-pcap:0.0.11, + osmo-pcap:0.1.0, + osmo-pcap:0.1.1, + osmo-pcap:0.1.2, + osmo-pcap:0.1.3, + + osmo-pcu:0.1, + osmo-pcu:0.1.0, + osmo-pcu:0.2, + osmo-pcu:0.2.0, + osmo-pcu:0.4.0, + osmo-pcu:0.5.0, + osmo-pcu:0.5.1, + + osmo-remsim:0.0, + osmo-remsim:0.1.0, + osmo-remsim:0.2.0, + osmo-remsim:0.2.1, + + osmo-sgsn:0.10.0, + osmo-sgsn:0.10.1, + osmo-sgsn:0.11.0, + osmo-sgsn:0.12.0, + osmo-sgsn:0.13.0, + osmo-sgsn:0.14.0, + osmo-sgsn:0.15.0, + osmo-sgsn:0.9.0, + osmo-sgsn:0.9.1, + osmo-sgsn:0.9.10, + osmo-sgsn:0.9.11, + osmo-sgsn:0.9.12, + osmo-sgsn:0.9.13, + osmo-sgsn:0.9.13+deb1, + osmo-sgsn:0.9.14, + osmo-sgsn:0.9.14-onwaves1, + osmo-sgsn:0.9.15, + osmo-sgsn:0.9.16, + osmo-sgsn:0.9.2, + osmo-sgsn:0.9.3, + osmo-sgsn:0.9.4, + osmo-sgsn:0.9.5, + osmo-sgsn:0.9.6, + osmo-sgsn:0.9.8, + osmo-sgsn:0.9.9, + osmo-sgsn:1.0.1, + osmo-sgsn:1.1.0, + osmo-sgsn:1.10.0, + osmo-sgsn:1.2.0, + osmo-sgsn:1.3.0, + osmo-sgsn:1.4.0, + osmo-sgsn:1.4.1, + osmo-sgsn:1.5.0, + osmo-sgsn:1.6.0, + osmo-sgsn:1.6.1, + + osmo-sip-connector:0.0.1, + osmo-sip-connector:1.1.0, + osmo-sip-connector:1.1.1, + + libosmo-sccp:0.0.1, + libosmo-sccp:0.0.2, + libosmo-sccp:0.0.3, + libosmo-sccp:0.0.4, + libosmo-sccp:0.0.5, + libosmo-sccp:0.0.5.1, + libosmo-sccp:0.0.6, + libosmo-sccp:0.0.6.1, + libosmo-sccp:0.0.6.2, + libosmo-sccp:0.0.6.3, + libosmo-sccp:0.10.0, + libosmo-sccp:0.7.0, + libosmo-sccp:0.8.0, + libosmo-sccp:0.8.1, + libosmo-sccp:0.9.0, + libosmo-sccp:1.0.0, + libosmo-sccp:1.1.0, + libosmo-sccp:1.2.0, + + osmo-trx:0.2.0, + osmo-trx:0.3.0, + osmo-trx:0.4.0, + + pysim:1.0, +" + +mkdir -p \ + "$TEMP" \ + "$TEMP/src" + +check_ssh_auth_sock() { + if [ -z "$SSH_AUTH_SOCK" ]; then + echo "ERROR: SSH_AUTH_SOCK is not set" + exit 1 + fi +} + +# $1: docs dir +get_repo_name_from_docs_dir() { + case "$1" in + osmo-stp) + echo "libosmo-sccp" + ;; + *) + echo "$1" + ;; + esac +} + +# $1: repo name +get_docs_dir_from_repo_name() { + case "$1" in + libosmo-sccp) + echo "osmo-stp" + ;; + *) + echo "$1" + ;; + esac +} + + +# $1: path on server, e.g. "/docs/osmo-bsc" +get_server_ls() { + local dir="$1" + local out="$TEMP/ls$(echo "$dir" | tr / _)" + + echo "$LOG_PREFIX Listing files on server: $dir" + + if [ -e "$out" ]; then + echo "Skipped, file exists: $out" + return + fi + + dir="$(echo "$dir" | sed "s.^/docs.$WEB_PATH.")" + $SSH_COMMAND docs(a)ftp.osmocom.org "ls -1 $dir" >"$out" +} + +# $1: repository +get_git_tags() { + local repo="$1" + local out="$TEMP/git_tags_$repo" + + echo "$LOG_PREFIX Getting git tags" + + if [ -e "$out" ]; then + echo "Skipped, file exists: $out" + return + fi + + osmo_git_last_tags "$repo" "all" >"$out" +} + +# $1: docs dir +# $2: tag +manuals_exist() { + local docs_dir="$1" + local tag="$2" + + grep -q "^$tag$" "$TEMP"/ls_docs_"$docs_dir" +} + +# $1: repository +# $2: tag +is_tag_ignored() { + local repo="$1" + local tag="$2" + + case "$TAGS_IGNORE" in + *"$repo:$tag,"*) + return 0 + ;; + esac + + return 1 +} + +# $1: repository +# $2: tag +clone_repo() { + local repo="$1" + local tag="$2" + local gitdir="$TEMP/src/$repo" + + if ! [ -d "$gitdir" ]; then + local url="$(osmo_git_clone_url "$repo")" + echo "$LOG_PREFIX Cloning $url" + git -C "$TEMP/src" clone "$url" "$repo" + fi + + echo "$LOG_PREFIX Checkout $tag" + cd "$gitdir" + git reset --hard HEAD + git checkout "$tag" + git submodule update --init + git clean -dxf + + # Fix depends on packages that don't exist anymore + sed -i 's/dh-systemd $.*$,//g' debian/control + sed -i 's/python-minimal,//g' debian/control +} + +# $1: repository +# $2: tag +build_publish_manuals() { + local repo="$1" + local tag="$2" + echo "$LOG_PREFIX Building manuals" + + if ! docker run \ + --rm \ + -e "BUILD_RELEASE=1" \ + -e "DEBIAN_FRONTEND=noninteractive" \ + -e "OSMO_GSM_MANUALS_DIR=/opt/osmo-gsm-manuals" \ + -e "OSMO_REPOSITORY=$(get_docs_dir_from_repo_name "$repo")" \ + -e "PUBLISH_REF=$tag" \ + -e "SSH_AUTH_SOCK=/ssh-agent" \ + -v "$OSMO_CI_DIR/scripts/manuals:/manuals" \ + -v "$TEMP/src/$repo/:/build" \ + -v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \ + "$DOCKER_IMAGE" \ + sh -ex -c " + apt-get update + + # Install dependencies + case $repo in + *) + apt-get -y build-dep /build + cd /opt/osmo-gsm-manuals/ + patch -p1 < /manuals/0001-build-custom-dblatex.sty-remove-DRAFT.patch + ;; + esac + + # Build manuals + cd /build + case $repo in + openbsc) + for dir in manuals/*/; do + su build -c \"make -C \$dir\" + done + ;; + *) + su build -c \"autoreconf -fi\" + su build -c \"./configure --enable-manuals\" + su build -c \"make -j$(nproc)\" + ;; + esac + + + # Publish manuals + case $repo in + openbsc) + for dir in manuals/*/; do + su build -c \"make -C \$dir publish\" + done + ;; + *) + su build -c \"make -C doc/manuals publish\" + ;; + esac + "; then + echo "$LOG_PREFIX Building manuals failed!" + exit 1 + fi + + # Mark as built for local testing + echo "$tag" >> "$TEMP/ls_docs_$repo" +} + +check_ssh_auth_sock +clone_repo "osmo-gsm-manuals" "master" +get_server_ls "/docs" + +for docs_dir in $(cat "$TEMP"/ls_docs); do + repo="$(get_repo_name_from_docs_dir "$docs_dir")" + LOG_PREFIX=":: ($repo)" + get_server_ls "/docs/$docs_dir" + get_git_tags "$repo" + + echo "$LOG_PREFIX Building missing manuals" + for tag in $(cat "$TEMP"/git_tags_"$repo"); do + LOG_PREFIX=":: ($repo, $tag)" + if manuals_exist "$docs_dir" "$tag"; then + echo "$LOG_PREFIX: skipping, manuals exist" + continue + elif is_tag_ignored "$repo" "$tag"; then + echo "$LOG_PREFIX: skipping, tag is ignored" + continue + fi + + clone_repo "$repo" "$tag" + build_publish_manuals "$repo" "$tag" + done +done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0ecb238660553c3c857e1b310873eca8a8d09dab Gerrit-Change-Number: 32016 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in libosmocore[master]: Fix parsing of TLV_TYPE_SINGLE_TV
by fixeria 22 Mar '23

22 Mar '23

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32014 ) Change subject: Fix parsing of TLV_TYPE_SINGLE_TV ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/32014/comment/8d0c93de_c9d67ffb PS1, Line 1779: GSM48_IE_CIP_MODE_SET > 1- Stuff is already broken. It's not possible to encode and decode those IEs properly in a sane way. Let's clarify: the libosmocore's TLV codec is handling `TLV_TYPE_SINGLE_TV` incorrectly, yes. But not all projects are using it, osmo-bsc.git does the encoding of some PDUs manually (by using the msgb API), and it's doing it correctly. So not everything is broken. > 2- That what libversion is for. We make them depend on newer libversion in master and next releases. Not sure if I am following you. AFAIU, you're talking about fixing osmo-bsc.git and making it depend on more recent fixed libosmocore. But I am talking about compiling old osmo-bsc (e.g. while bisecting) against recent (to be fixed) libosmocore. If you change define values, old code doing manual encoding of these IEIs will start producing wrong encoding results. To me it's even worse than breaking the API and breaking compilation for old code, because it will cause problems at run-time. IMO, we should rather keep the old GSM48_IE_ for backwards compatibility with projects using them like osmo-bsc does, define new ones with the correct values and use these new ones in `gsm48_rr_att_tlvdef[]`. > I know it's a pain changing those and breaking the ABI, but otherwise we are just mtairning a broken system and keep adding workaround everywhere. Well, yes, it's a pain. But I don't remember we ever changed our policy about keeping backwards compatibility and started breaking the API here and there? It's similar to deprecating functions: just add a comment marking old defines as deprecated, add new ones with the correct values, and use these new ones everywhere. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 Gerrit-Change-Number: 32014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:00:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: logging: add log level cache
by Jenkins Builder 22 Mar '23

22 Mar '23

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30633 ) Change subject: logging: add log level cache ...................................................................... Patch Set 10: (1 comment) File src/core/logging.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5332): https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/f7787d70_d4083f28 PS10, Line 120: for (int i = 0; i < osmo_log_info->num_cat; i++) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 Mar 2023 12:55:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: logging: add log level cache
by Hoernchen 22 Mar '23

22 Mar '23

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30633 to look at the new patch set (#10). Change subject: logging: add log level cache ...................................................................... logging: add log level cache This ensures multithreaded logging attempts, in particular ones that do nothing, do not hold the lock just for checking the level, which interferes with other logging attempts. Closes: OS#5818 Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d --- M include/osmocom/core/logging.h M src/core/logging.c M src/vty/logging_vty.c M tests/ctrl/ctrl_test.c 4 files changed, 139 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/30633/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 10 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: common: Make socket queue max. length configurable
by arehbein 22 Mar '23

22 Mar '23

Attention is currently required from: fixeria, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31534 ) Change subject: common: Make socket queue max. length configurable ...................................................................... Patch Set 6: (1 comment) File tests/osmo-bts.vty: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/cbf19bc5_a7801b06 PS6, Line 228: help > The libosmovty's own command are intentionally masked with '...', please keep it this way. […] I tried the ellipsis before, but for whatever reason, it didn't and doesn't work after my changes. I have diffed the outputs quoted from the testlog and the only difference between 'expected' and 'got' was the three dots. What is happening/what do I have to do to fix this? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 12:47:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: Fix parsing of TLV_TYPE_SINGLE_TV
by pespin 22 Mar '23

22 Mar '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32014 ) Change subject: Fix parsing of TLV_TYPE_SINGLE_TV ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/32014/comment/8bbfa772_a6d92003 PS1, Line 1779: GSM48_IE_CIP_MODE_SET > 1- Stuff is already broken. It's not possible to encode and decode those IEs properly in a sane way. […] I know it's a pain changing those and breaking the ABI, but otherwise we are just mtairning a broken system and keep adding workaround everywhere. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 Gerrit-Change-Number: 32014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 12:44:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0