March 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: common: Make socket queue max. length configurable
by fixeria 22 Mar '23

22 Mar '23

Attention is currently required from: arehbein, pespin. fixeria has uploaded a new patch set (#7) to the change originally created by arehbein. ( https://gerrit.osmocom.org/c/osmo-bts/+/31534 ) Change subject: common: Make socket queue max. length configurable ...................................................................... common: Make socket queue max. length configurable Title refers to the maximum length of the osmo_wqueue used for the PCU socket connection. Related: OS#5774 Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa --- M include/osmo-bts/bts.h M include/osmo-bts/pcu_if.h M src/common/bts.c M src/common/main.c M src/common/pcu_sock.c M src/common/vty.c M tests/osmo-bts.vty 7 files changed, 64 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/34/31534/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 7 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: common: Make socket queue max. length configurable
by fixeria 22 Mar '23

22 Mar '23

Attention is currently required from: arehbein, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31534 ) Change subject: common: Make socket queue max. length configurable ...................................................................... Patch Set 6: (1 comment) File tests/osmo-bts.vty: https://gerrit.osmocom.org/c/osmo-bts/+/31534/comment/bd47552d_7b7d1960 PS6, Line 228: help > I tried the ellipsis before, but for whatever reason, it didn't and doesn't work after my changes. […] I guess by ellipsis you mean https://www.compart.com/en/unicode/U+2026, a unicode character. But the VTY checking scripts actually expect three ASCII dots, not the unicode stuff. I will push an updated version, marking as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6ba6e4eadce9ce82ef2407f4e28346e7fe4abfa Gerrit-Change-Number: 31534 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 14:25:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: logging: add log level cache
by Hoernchen 22 Mar '23

22 Mar '23

Attention is currently required from: Hoernchen, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30633 to look at the new patch set (#11). Change subject: logging: add log level cache ...................................................................... logging: add log level cache This ensures multithreaded logging attempts, in particular ones that do nothing, do not hold the lock just for checking the level, which interferes with other logging attempts. Closes: OS#5818 Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d --- M include/osmocom/core/logging.h M src/core/libosmocore.map M src/core/logging.c M src/vty/logging_vty.c M tests/ctrl/ctrl_test.c 5 files changed, 139 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/30633/11 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d Gerrit-Change-Number: 30633 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in pysim[master]: cards: move methods read_aids and select_adf_by_aid to class UsimCard
by dexter 22 Mar '23

22 Mar '23

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/24146 ) Change subject: cards: move methods read_aids and select_adf_by_aid to class UsimCard ...................................................................... Abandoned It is probably better not to move those two functions. The problem I see is that the class model in cards.py is not entirely correct. Lets keep it like it is. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71667b7b38c930b4e0409fe2ba2786e1db9cf9a3 Gerrit-Change-Number: 24146 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 0

[S] Change in osmo-sip-connector[master]: sip: log release caused by status >= 300 as error
by osmith 22 Mar '23

22 Mar '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 ) Change subject: sip: log release caused by status >= 300 as error ...................................................................... sip: log release caused by status >= 300 as error Make it easier to spot when the sip server answers an invite with anything that would cause osmo-sip-connector to release the call. Related: SYS#6386 Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164 --- M src/sip.c 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/18/32018/1 diff --git a/src/sip.c b/src/sip.c index 9124752..60c2682 100644 --- a/src/sip.c +++ b/src/sip.c @@ -380,13 +380,13 @@ else if (status >= 300) { struct call_leg *other = call_leg_other(&leg->base); - LOGP(DSIP, LOGL_INFO, "INVITE got status(%d), releasing leg(%p).\n", status, leg); + LOGP(DSIP, LOGL_ERROR, "INVITE got status(%d), releasing leg(%p).\n", status, leg); nua_cancel(leg->nua_handle, TAG_END()); nua_handle_destroy(leg->nua_handle); call_leg_release(&leg->base); if (other) { - LOGP(DSIP, LOGL_INFO, "Releasing MNCC leg (%p) with status(%d)\n", other, status); + LOGP(DSIP, LOGL_ERROR, "Releasing MNCC leg (%p) with status(%d)\n", other, status); other->cause = status2cause(status); other->release_call(other); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164 Gerrit-Change-Number: 32018 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: filesystem: decode select response for MF
by dexter 22 Mar '23

22 Mar '23

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23209 ) Change subject: filesystem: decode select response for MF ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: I have checked this back. This problem has been solved differently a while ago, so the patch can be abandoned. Unfortunately I cannot abandon this patch myself since I am not the owner. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/23209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b2476fc0e7d34cdacf7eb100ffadceb788c4d2 Gerrit-Change-Number: 23209 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in docker-playground[master]: new bsc-nat: msc tests
by Hoernchen 22 Mar '23

22 Mar '23

Attention is currently required from: laforge. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27625 ) Change subject: new bsc-nat: msc tests ...................................................................... Patch Set 2: (1 comment) File osmo-bsc-nat-latest/osmo-bsc-nat.cfg: https://gerrit.osmocom.org/c/docker-playground/+/27625/comment/f55958a7_4c7… PS1, Line 2: # > ping? Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifdb9956a8bdde8aa3f9f62bfcfc035baab01c934 Gerrit-Change-Number: 27625 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: pdch_ul_controller: log reserved frame numbers
by dexter 22 Mar '23

22 Mar '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/31022 to look at the new patch set (#2). Change subject: pdch_ul_controller: log reserved frame numbers ...................................................................... pdch_ul_controller: log reserved frame numbers When debugging frame number offset problems betwen l1 and below and the upper layers of the PCU, it may be helpful do know which blocks/frame numbers got reserverd for uplink transmissions. Change-Id: I4277c572a4cc6cbbf3ac4e67442c9036be687627 Related: OS#5198 --- M src/pdch_ul_controller.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/22/31022/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4277c572a4cc6cbbf3ac4e67442c9036be687627 Gerrit-Change-Number: 31022 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: pdch_ul_controller: log reserved frame numbers
by dexter 22 Mar '23

22 Mar '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31022 ) Change subject: pdch_ul_controller: log reserved frame numbers ...................................................................... Patch Set 2: (1 comment) File src/pdch_ul_controller.c: https://gerrit.osmocom.org/c/osmo-pcu/+/31022/comment/3209be2e_5db738e8 PS1, Line 196: LOGPDCH(ulc->pdch, DRLCMAC, LOGL_DEBUG, "reserving FN %u\n", item->fn); > It would be useful to print "get_value_string(pdch_ul_node_names, it->type)" here too. […] We do not know it at this point. It is populated in the while loop. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4277c572a4cc6cbbf3ac4e67442c9036be687627 Gerrit-Change-Number: 31022 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:33:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: Use new GSM0408 defines for half-octet tags
by pespin 22 Mar '23

22 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32017 ) Change subject: Use new GSM0408 defines for half-octet tags ...................................................................... Use new GSM0408 defines for half-octet tags The old ones have been deprecated and shall not be used anymore· Depends: libosmocore.git Change-Id I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 Change-Id: Id3be8e38ec87ae39c4e1b4fab163563b24fb2cee --- M TODO-RELEASE M src/osmo-bsc/gsm_04_08_rr.c 2 files changed, 16 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/32017/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index 98023fc..2658cdd 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -12,4 +12,5 @@ osmo-bsc CTRL,VTY osmo_fsm instance IDs now use new dynamic timeslot names 'DYNAMIC_OSMOCOM' and 'DYNAMIC_IPACCESS' libosmogsm >1.8.0 circuit switched data stuff (gsm0808_enc/dec_channel_type etc.) libosmo-abis >1.4.0 osmo_ortp.h: add RTP_PT_CSDATA -libosmo-sccp >1.7.0 osmo_sccp_{get,set}_priv() \ No newline at end of file +libosmo-sccp >1.7.0 osmo_sccp_{get,set}_priv() +libosmocore >1.8.0 GSM48_IE_CIP_MODE_SET_HO and GSM48_IE_SYNC_IND_HO \ No newline at end of file diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index ee772df..8395dcf 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -565,7 +565,7 @@ * TODO: NCI (Normal cell indication), currently 0. */ const uint8_t sync_ind = async ? 0x00 : 0x01; /* T (4 bit) + V (4 bit), see 3GPP TS 44.018, 10.5.2.39 */ - msgb_v_put(msg, GSM48_IE_SYNC_IND | (sync_ind & 0x0f)); + msgb_v_put(msg, (GSM48_IE_SYNC_IND_HO << 4) | (sync_ind & 0x0f)); } if (new_lchan->ts->hopping.enabled) { @@ -595,7 +595,7 @@ if (new_lchan->encr.alg_a5_n > 0) cms = (new_lchan->encr.alg_a5_n - 1) << 1 | 1; /* T (4 bit) + V (4 bit), see 3GPP TS 44.018, 10.5.2.9 */ - msgb_v_put(msg, GSM48_IE_CIP_MODE_SET | (cms & 0x0f)); + msgb_v_put(msg, (GSM48_IE_CIP_MODE_SET_HO << 4) | (cms & 0x0f)); } /* in case of multi rate we need to attach a config */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id3be8e38ec87ae39c4e1b4fab163563b24fb2cee Gerrit-Change-Number: 32017 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0