March 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: Fix parsing of TLV_TYPE_SINGLE_TV

by pespin

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/32014 to look at the new patch set (#3). Change subject: Fix parsing of TLV_TYPE_SINGLE_TV ...................................................................... Fix parsing of TLV_TYPE_SINGLE_TV The decoding path of TLV_TYPE_SINGLE_TV is wrong, since it is not shifting right the tag before using it. On the other hand, the encoding path (tlv_encode_one) is doing that, so it is clear there's a bug. It seems that in order to workaround the bug some IEs in gsm_04_08.h (TS 24.008 and TS 44.018) were defined incorrectly (eg 0x80) while the spec clearly assigns eg. "8" to it, and makes sure no full byte IEI collides. Some other IEIs like GSM48_IE_GMM_CIPH_CKSN which are also of the same type were already correctly defined as 0x08. Change-Id: I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 --- M TODO-RELEASE M include/osmocom/gsm/protocol/gsm_04_08.h M src/gsm/gsm48.c M src/gsm/tlv_parser.c 4 files changed, 39 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/32014/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I799e35dc8d4d153fa63bf50563a5482cdf4de2d7 Gerrit-Change-Number: 32014 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in libsmpp34[master]: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29081 ) Change subject: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/ ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I9343f53c125be8e4c7590164a8541d9fe114deb5 Gerrit-Change-Number: 29081 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

2 years, 3 months

1
0
0 0

[S] Change in libsmpp34[master]: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29081 ) Change subject: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/ ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > ping? After several attempts and several more commits which I decided to not push, I am giving up on this patch. I am fixing one thing and breaking three other things. It does not make sense to fix the build system in libsmpp34.git, it's a mess and needs to be rewritten from scratch, IMHO. Let me know if you think I should spend several hours reworking everything. I think it makes no sense, so abandoning this patch. -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I9343f53c125be8e4c7590164a8541d9fe114deb5 Gerrit-Change-Number: 29081 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:25:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in pysim[master]: pySim-shell: add cardinfo command

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/25805 ) Change subject: pySim-shell: add cardinfo command ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: ping? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/25805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If31ed17102dc0108e27a5eb0344aabaaf19b19f9 Gerrit-Change-Number: 25805 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569 ) Change subject: hlr: add imsi unknown cause test case ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ping? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:23:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: docs: add a simple example to use configuration file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 ) Change subject: docs: add a simple example to use configuration file ...................................................................... docs: add a simple example to use configuration file Change-Id: I013f03779508bc3ee5bb378c357a5c94b40b74a0 --- M README.md A examples/sys.config 2 files changed, 32 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/README.md b/README.md index 52c076a..4b52070 100644 --- a/README.md +++ b/README.md @@ -19,9 +19,19 @@ == Running == -Once osmo_dia2gsup is built, you can start it this way: +Once osmo\_dia2gsup is built, you can start it this way: $ rebar3 shell In the erlang shell: +``` 1> osmo_dia2gsup:start(). +``` + +== Configuration == + +$ rebar3 shell --config ./examples/sys.config +``` +1> osmo_dia2gsup:start(). +``` + diff --git a/examples/sys.config b/examples/sys.config new file mode 100644 index 0000000..8814893 --- /dev/null +++ b/examples/sys.config @@ -0,0 +1,12 @@ +[{osmo_dia2gsup, [ + {hlr_ip, "127.0.0.1"}, + {hlr_port, 4222}, + + {diameter_ip, "127.0.0.4"}, + {diameter_port, 3868}, + {diameter_proto, sctp}, + + {origin_host, "hss.localdomain"}, + {origin_realm, "localdomain"}, + {vendor_id, 0} +]}]. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I013f03779508bc3ee5bb378c357a5c94b40b74a0 Gerrit-Change-Number: 27647 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: docs: add a simple example to use configuration file

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 ) Change subject: docs: add a simple example to use configuration file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/27647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I013f03779508bc3ee5bb378c357a5c94b40b74a0 Gerrit-Change-Number: 27647 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:23:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[L] Change in docker-playground[master]: new bsc-nat: msc tests

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27625 ) Change subject: new bsc-nat: msc tests ...................................................................... Patch Set 1: (1 comment) File osmo-bsc-nat-latest/osmo-bsc-nat.cfg: https://gerrit.osmocom.org/c/docker-playground/+/27625/comment/8eda2a62_2d5… PS1, Line 2: # > can you include a pointer as to where the template + parametes are which generate the files? I could […] ping? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifdb9956a8bdde8aa3f9f62bfcfc035baab01c934 Gerrit-Change-Number: 27625 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 13:22:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

[L] Change in osmo-ci[master]: jobs/osmocom-release-manuals: add new job

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/32016 to look at the new patch set (#2). Change subject: jobs/osmocom-release-manuals: add new job ...................................................................... jobs/osmocom-release-manuals: add new job Add a jenkins job that automatically builds manuals for release tags, if they don't exist on the server already. Closes: OS#5902 Related: https://downloads.osmocom.org/docs/ Change-Id: I0ecb238660553c3c857e1b310873eca8a8d09dab --- M .gitignore A jobs/osmocom-release-manuals.yml A scripts/manuals/0001-build-custom-dblatex.sty-remove-DRAFT.patch A scripts/manuals/publish-manuals-for-tags.sh 4 files changed, 513 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/16/32016/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/32016 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0ecb238660553c3c857e1b310873eca8a8d09dab Gerrit-Change-Number: 32016 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

[S] Change in osmo-e1d[master]: usb: Pass not just the actual transfer length but also the buffer size

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27578 ) Change subject: usb: Pass not just the actual transfer length but also the buffer size ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5088a5213d2945fdfaf3b242a63e35d0ed511914 Gerrit-Change-Number: 27578 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: abandon

2 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2023