Attention is currently required from: neels.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/31702
to look at the new patch set (#6).
Change subject: [codecs filter] msc_vlr_test_call: test codecs resolution
......................................................................
[codecs filter] msc_vlr_test_call: test codecs resolution
Show that the codecs filter now works as expected in call messaging.
Related: SYS#5066
Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9
---
M tests/msc_vlr/msc_vlr_test_call.c
M tests/msc_vlr/msc_vlr_test_call.err
M tests/msc_vlr/msc_vlr_tests.c
M tests/msc_vlr/msc_vlr_tests.h
4 files changed, 3,681 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/31702/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31702
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I879ec61f523ad4ffc69a0b02810591f7c0261ff9
Gerrit-Change-Number: 31702
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31742 )
Change subject: make: doc/sequence_charts: use wildcards for EXTRA_DIST and CLEANFILES
......................................................................
make: doc/sequence_charts: use wildcards for EXTRA_DIST and CLEANFILES
Both EXTRA_DIST and CLEANFILES had missing entries. It is easy to
forget to keep them up to date. Rather use wildcards to always pick up
all relevant files.
(Not adding *.dot because there are no .dot charts here, yet.)
Change-Id: I3a18e4608a310169d7c9cd9c1b8ac9015a990920
---
M doc/sequence_charts/Makefile.am
1 file changed, 17 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/42/31742/1
diff --git a/doc/sequence_charts/Makefile.am b/doc/sequence_charts/Makefile.am
index 5efe855..b4a55e0 100644
--- a/doc/sequence_charts/Makefile.am
+++ b/doc/sequence_charts/Makefile.am
@@ -4,17 +4,11 @@
charts: msc dot
EXTRA_DIST = \
- inter_bsc_ho.msc \
- inter_msc_ho.msc \
- mncc_call_fsm.msc \
- call_reestablishment.msc \
+ *.msc \
$(NULL)
CLEANFILES = \
- inter_bsc_ho.png \
- inter_msc_ho.png \
- mncc_call_fsm.png \
- voice_call_full.png \
+ *.png \
$(NULL)
msc: \
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31742
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3a18e4608a310169d7c9cd9c1b8ac9015a990920
Gerrit-Change-Number: 31742
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 )
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
......................................................................
build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
When a locally built lib is not the first in LDFLAGS, libtool prefers
a system installed lib over the locally built one. By using LDADD for
gen__pfcp_ies_auto, the local lib gets appended, not listed first.
Change LDADD to LDFLAGS to make sure libtool is using the locally built
libosmo-gtlv for gen__pfcp_ies_auto.
Related: OS#5942
Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66
---
M src/libosmo-pfcp/Makefile.am
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/41/31741/1
diff --git a/src/libosmo-pfcp/Makefile.am b/src/libosmo-pfcp/Makefile.am
index 578ac0b..5d53923 100644
--- a/src/libosmo-pfcp/Makefile.am
+++ b/src/libosmo-pfcp/Makefile.am
@@ -65,7 +65,7 @@
gen__pfcp_ies_auto.c \
$(NULL)
-gen__pfcp_ies_auto_LDADD = \
+gen__pfcp_ies_auto_LDFLAGS = \
$(top_builddir)/src/libosmo-gtlv/libosmo-gtlv.la \
$(LIBOSMOCORE_LIBS) \
$(COVERAGE_LDFLAGS) \
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66
Gerrit-Change-Number: 31741
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newchange
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31740 )
Change subject: do CN CRCX first
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/31740/comment/ff9b5b10_eb74cb20
PS1, Line 13: Update the voice call sequence chart to show the effects.
for convenience, renderings of the voice call charts before and after this patch:
https://people.osmocom.org/neels/ohGhe5ah/voice_call_full.before.pnghttps://people.osmocom.org/neels/ohGhe5ah/voice_call_full.after.png
note how the CN CRCX happens first, before sending the first RTP related MNCC, so that this first MNCC can already contain the correct RTP port of the MGW towards CN.
On the MO side we see the CN CRCX OK establishing the RTP port before MNCC_SETUP_IND towards MNCC is sent.
On the MT side we see the CN CRCX OK happens before MNCC_RTP_CREATE goes back to the MNCC. It also shows that the MNCC_CALL_CONF_IND happens before that CRCX OK, because the CALL_CONF_IND does not yet contain RTP or codecs information.
These charts were made (a long time ago) with some script of mine that automatically scrapes the osmo-msc log to create an .msc ladder diagram.
(maybe i should run this again now, since the patches have changed a bit. I don't expect any difference, but I guess I should confirm that.)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/31740/comment/82047761_1ffb3d9f
PS1, Line 901: /* Directly ack with MNCC_CALL_CONF_IND, not yet containing SDP or RTP IP:port information. */
(here is that MT MNCC_CALL_CONF_IND that has no RTP nor SDP yet)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31740
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c
Gerrit-Change-Number: 31740
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 07 Mar 2023 23:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31700 )
Change subject: [codecs filter] use codecs filter on crcx ok
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
> something went wrong here, i must have accidentally squashed "do CN CRCX first" into its preceding p […]
phew, I'm relieved that it was easy to fix. no idea how i messed that up, the reflog didn't show any fixup or squash, only suddenly the super pivotal and important "do CN CRCX first" disappears from the logs. Now it's separate again.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31700
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I03753df567d1dc24852e6fbb681fbba81d2a545d
Gerrit-Change-Number: 31700
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 07 Mar 2023 22:54:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/30126
to look at the new patch set (#5).
Change subject: [codecs filter] use filter result in Assignment
......................................................................
[codecs filter] use filter result in Assignment
So far, patches have set up rtp_stream to allow setting multiple codecs,
and collected the codecs information into the codecs filter struct.
Now actually use the codecs filter result to choose a codec.
Setting up the call leg FSMs and codecs still looks rather confusing in
this patch, because this is an incremental step in a larger series. The
upcoming patch 'do CN CRCX first' clarifies this substantially.
The resulting codecs behavior is tested in upcoming patch
I879ec61f523ad4ffc69a0b02810591f7c0261ff9. (The test ideally should have
come before this patch, but my time to rework this branch is up.)
With the codecs filter in place, we are ready for sending and receiving
full SDP via MNCC, see upcoming Ie0668c0e079ec69da1532b52d00621efe114fc2c
and Ie433db1ba0c46d4b97538a969233c155cefac21c
Related: SYS#5066
Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9
---
M src/libmsc/gsm_04_08_cc.c
M tests/msc_vlr/msc_vlr_test_call.err
2 files changed, 46 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/26/30126/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9
Gerrit-Change-Number: 30126
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: neels.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/30125
to look at the new patch set (#5).
Change subject: rtp_stream: allow multiple codecs / use codec filter from Assignment
......................................................................
rtp_stream: allow multiple codecs / use codec filter from Assignment
Allow configuring MGW conns with multiple codecs. The new codecs filter
can have multiple results, and MGCP can configure multiple codecs. Get
rid of this bottleneck, that so far limits to a single codec to MGW.
On Assignment Complete, set codec_filter.assignment to the assigned
codec, and use that to set the resulting codec (possibly multiple codecs
in the future) to create the CN side MGW endpoint.
Related: SYS#5066
Change-Id: If9c67b298b30f893ec661f84c9fc622ad01b5ee5
---
M include/osmocom/msc/call_leg.h
M include/osmocom/msc/msc_ho.h
M include/osmocom/msc/rtp_stream.h
M src/libmsc/call_leg.c
M src/libmsc/gsm_04_08_cc.c
M src/libmsc/mncc_call.c
M src/libmsc/msc_a.c
M src/libmsc/msc_ho.c
M src/libmsc/msc_t.c
M src/libmsc/rtp_stream.c
M tests/msc_vlr/msc_vlr_test_call.err
M tests/msc_vlr/msc_vlr_tests.c
12 files changed, 205 insertions(+), 106 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/25/30125/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30125
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If9c67b298b30f893ec661f84c9fc622ad01b5ee5
Gerrit-Change-Number: 30125
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: newpatchset