March 2023 - gerrit-log - lists.osmocom.org

[L] Change in osmo-msc[master]: do CN CRCX first

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31740 ) Change subject: do CN CRCX first ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/31740/comment/c2613385_bbff4b19 PS1, Line 13: Update the voice call sequence chart to show the effects. > for convenience, renderings of the voice call charts before and after this patch: […] updated charts: https://people.osmocom.org/neels/ihi6TohR/voice_call_external.before.png https://people.osmocom.org/neels/ihi6TohR/voice_call_external.after.png https://people.osmocom.org/neels/ihi6TohR/voice_call_internal.before.png https://people.osmocom.org/neels/ihi6TohR/voice_call_internal.after.png -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c Gerrit-Change-Number: 31740 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 08 Mar 2023 05:52:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

[S] Change in osmo-msc[master]: charts: Rename voice_call_full.msc to voice_call_external_mncc.msc

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31745 ) Change subject: charts: Rename voice_call_full.msc to voice_call_external_mncc.msc ...................................................................... charts: Rename voice_call_full.msc to voice_call_external_mncc.msc Because I will soon add an _internal_mncc one as well. Change-Id: Ic90a93d749ea936a632a45e615007a58104eeedd --- M doc/sequence_charts/Makefile.am R doc/sequence_charts/voice_call_external_mncc.msc 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/31745/1 diff --git a/doc/sequence_charts/Makefile.am b/doc/sequence_charts/Makefile.am index b4a55e0..10960de 100644 --- a/doc/sequence_charts/Makefile.am +++ b/doc/sequence_charts/Makefile.am @@ -15,7 +15,7 @@ $(builddir)/mncc_call_fsm.png \ $(builddir)/inter_bsc_ho.png \ $(builddir)/inter_msc_ho.png \ - $(builddir)/voice_call_full.png \ + $(builddir)/voice_call_external_mncc.png \ $(builddir)/call_reestablishment.png \ $(NULL) diff --git a/doc/sequence_charts/voice_call_full.msc b/doc/sequence_charts/voice_call_external_mncc.msc similarity index 100% rename from doc/sequence_charts/voice_call_full.msc rename to doc/sequence_charts/voice_call_external_mncc.msc -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic90a93d749ea936a632a45e615007a58104eeedd Gerrit-Change-Number: 31745 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[M] Change in osmo-msc[master]: add voice_call_internal_mncc.msc

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31747 ) Change subject: add voice_call_internal_mncc.msc ...................................................................... add voice_call_internal_mncc.msc Same as voice_call_external_mncc.msc, but run with internal MNCC. Shows some curious differences like the MNCC_LCHAN_MODIFY that internal MNCC sends, but external doesn't. Change-Id: Ic003322dc4e3fce24a8413688cfe18198a4dc08a --- M doc/sequence_charts/Makefile.am A doc/sequence_charts/voice_call_internal_mncc.msc 2 files changed, 143 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/47/31747/1 diff --git a/doc/sequence_charts/Makefile.am b/doc/sequence_charts/Makefile.am index 10960de..f43bb3d 100644 --- a/doc/sequence_charts/Makefile.am +++ b/doc/sequence_charts/Makefile.am @@ -16,6 +16,7 @@ $(builddir)/inter_bsc_ho.png \ $(builddir)/inter_msc_ho.png \ $(builddir)/voice_call_external_mncc.png \ + $(builddir)/voice_call_internal_mncc.png \ $(builddir)/call_reestablishment.png \ $(NULL) diff --git a/doc/sequence_charts/voice_call_internal_mncc.msc b/doc/sequence_charts/voice_call_internal_mncc.msc new file mode 100644 index 0000000..69af60e --- /dev/null +++ b/doc/sequence_charts/voice_call_internal_mncc.msc @@ -0,0 +1,129 @@ +# Generated by osmo-msc.git/doc/sequence_charts/msc_log_to_ladder.py +msc { +hscale="3"; +moms[label="MS,BSS (MO)\nUE,hNodeB (MO)"],momgw[label="MGW for MSC (MO)"],momsc[label="MSC (MO)"],mncc[label="MNCC"],mtmsc[label="MSC (MT)"],mtmgw[label="MGW for MSC (MT)"],mtms[label="BSS,MS (MT)\nhNodeB,UE (MT)"]; +moms =>> momsc [label="(BSSMAP) Complete Layer 3 Information"]; +moms =>> momsc [label="MM CM_SERV_REQ"]; +moms <<= momsc [label="MM AUTH_REQ"]; +moms =>> momsc [label="MM AUTH_RESP"]; +moms <<= momsc [label="(BSSMAP) CIPHER_MODE_COMMAND"]; +moms =>> momsc [label="(BSSMAP) Ciphering Mode Complete"]; +moms <<= momsc [label="(BSSMAP) COMMON_ID"]; +moms =>> momsc [label="RR CIPH_M_COMPL"]; +moms =>> momsc [label="CC SETUP"]; +momsc note momsc [label="CC starts guard timer (180s)"]; +momsc abox momsc [label="CC state:\nINITIATED"]; +momsc =>> mncc [label="MNCC_SETUP_IND"]; +momsc <<= mncc [label="MNCC_CALL_PROC_REQ"]; +momsc note momsc [label="CC stops guard timer"]; +momsc note momsc [label="CC starts guard timer (180s)"]; +momsc abox momsc [label="CC state:\nMO_CALL_PROC"]; +moms <<= momsc [label="CC CALL_PROC"]; +momgw <<= momsc [label="for RAN: CRCX\nrtpbridge/*@msc"]; +momsc <<= mncc [label="MNCC_LCHAN_MODIFY"]; +momsc note momsc [label="CC stops guard timer"]; +momsc note momsc [label="CC starts guard timer (180s)"]; +mtmsc <<= mncc [label="MNCC_SETUP_REQ"]; +mtms <<= mtmsc [label="Paging"]; +momgw =>> momsc [label="for RAN: CRCX OK\nEP-1 CI-1 IP:port-1"]; +moms <<= momsc [label="(BSSMAP) ASSIGNMENT_COMMAND"]; +moms =>> momsc [label="(BSSMAP) Assignment Complete"]; +momgw <<= momsc [label="for RAN: MDCX\nEP-1 CI-1"]; +momgw =>> momsc [label="for RAN: MDCX OK\nEP-1 CI-1 IP:port-1"]; +momgw <<= momsc [label="for CN: CRCX\nEP-1"]; +momgw =>> momsc [label="for CN: CRCX OK\nEP-1 CI-2 IP:port-2"]; +momsc =>> mncc [label="MNCC_RTP_CREATE\nIP:port-2"]; +mtms =>> mtmsc [label="(BSSMAP) Complete Layer 3 Information"]; +mtms =>> mtmsc [label="RR PAG_RESP"]; +mtms <<= mtmsc [label="MM AUTH_REQ"]; +mtms =>> mtmsc [label="MM AUTH_RESP"]; +mtms <<= mtmsc [label="(BSSMAP) CIPHER_MODE_COMMAND"]; +mtms =>> mtmsc [label="(BSSMAP) Ciphering Mode Complete"]; +mtms <<= mtmsc [label="(BSSMAP) COMMON_ID"]; +mtmsc note mtmsc [label="CC starts timer T303 (30s)"]; +mtmsc abox mtmsc [label="CC state:\nCALL_PRESENT"]; +mtms <<= mtmsc [label="CC SETUP"]; +mtms =>> mtmsc [label="RR CIPH_M_COMPL"]; +mtms =>> mtmsc [label="CC CALL_CONF"]; +mtmsc note mtmsc [label="CC stops timer T303"]; +mtmsc note mtmsc [label="CC starts timer T310 (30s)"]; +mtmsc abox mtmsc [label="CC state:\nMO_TERM_CALL_CONF"]; +mtmgw <<= mtmsc [label="for RAN: CRCX\nrtpbridge/*@msc"]; +mtmsc =>> mncc [label="MNCC_CALL_CONF_IND"]; +mtmsc <<= mncc [label="MNCC_LCHAN_MODIFY"]; +mtmsc note mtmsc [label="CC starts guard timer (180s)"]; +mtmgw =>> mtmsc [label="for RAN: CRCX OK\nEP-2 CI-3 IP:port-3"]; +mtms <<= mtmsc [label="(BSSMAP) ASSIGNMENT_COMMAND"]; +mtms =>> mtmsc [label="(BSSMAP) Assignment Complete"]; +mtmgw <<= mtmsc [label="for RAN: MDCX\nEP-2 CI-3"]; +mtmgw =>> mtmsc [label="for RAN: MDCX OK\nEP-2 CI-3 IP:port-3"]; +mtmgw <<= mtmsc [label="for CN: CRCX\nEP-2"]; +mtmgw =>> mtmsc [label="for CN: CRCX OK\nEP-2 CI-4 IP:port-4"]; +mtmsc =>> mncc [label="MNCC_RTP_CREATE\nIP:port-4"]; +mtms =>> mtmsc [label="CC ALERTING"]; +mtmsc note mtmsc [label="CC stops timer T310"]; +mtmsc note mtmsc [label="CC starts timer T301 (180s)"]; +mtmsc abox mtmsc [label="CC state:\nCALL_RECEIVED"]; +mtmsc =>> mncc [label="MNCC_ALERT_IND"]; +momsc <<= mncc [label="MNCC_ALERT_REQ"]; +momsc note momsc [label="CC stops guard timer"]; +momsc note momsc [label="CC starts guard timer (180s)"]; +momsc abox momsc [label="CC state:\nCALL_DELIVERED"]; +moms <<= momsc [label="CC ALERTING"]; +mtms =>> mtmsc [label="CC CONNECT"]; +mtmsc note mtmsc [label="CC stops timer T301"]; +mtmsc abox mtmsc [label="CC state:\nCONNECT_REQUEST"]; +mtmsc =>> mncc [label="MNCC_SETUP_CNF"]; +mtmsc <<= mncc [label="MNCC_SETUP_COMPL_REQ"]; +mtmsc note mtmsc [label="CC stops guard timer"]; +mtmsc note mtmsc [label="CC starts guard timer (180s)"]; +mtmsc abox mtmsc [label="CC state:\nACTIVE"]; +mtmsc note mtmsc [label="CC stops guard timer"]; +mtms <<= mtmsc [label="CC CONNECT_ACK"]; +momsc <<= mncc [label="MNCC_SETUP_RSP"]; +momsc note momsc [label="CC stops guard timer"]; +momsc note momsc [label="CC starts guard timer (180s)"]; +momsc note momsc [label="CC starts timer T313 (30s)"]; +momsc abox momsc [label="CC state:\nCONNECT_IND"]; +moms <<= momsc [label="CC CONNECT"]; +mtmgw <<= mtmsc [label="for CN: MDCX\nEP-2 CI-4"]; +momgw <<= momsc [label="for CN: MDCX\nEP-1 CI-2"]; +mtmgw =>> mtmsc [label="for CN: MDCX OK\nEP-2 CI-4 IP:port-4"]; +momgw =>> momsc [label="for CN: MDCX OK\nEP-1 CI-2 IP:port-2"]; +moms =>> momsc [label="CC CONNECT_ACK"]; +momsc note momsc [label="CC stops timer T313"]; +momsc abox momsc [label="CC state:\nACTIVE"]; +momsc note momsc [label="CC stops guard timer"]; +momsc =>> mncc [label="MNCC_SETUP_COMPL_IND"]; +moms =>> momsc [label="CC DISCONNECT"]; +momsc abox momsc [label="CC state:\nDISCONNECT_IND"]; +momsc =>> mncc [label="MNCC_DISC_IND"]; +momsc <<= mncc [label="MNCC_REL_REQ"]; +momsc note momsc [label="CC starts guard timer (180s)"]; +momsc note momsc [label="CC starts timer T308 (10s)"]; +momsc abox momsc [label="CC state:\nRELEASE_REQ"]; +moms <<= momsc [label="CC RELEASE"]; +mtmsc <<= mncc [label="MNCC_DISC_REQ"]; +mtmsc note mtmsc [label="CC starts guard timer (180s)"]; +mtmsc note mtmsc [label="CC starts timer T306 (30s)"]; +mtmsc abox mtmsc [label="CC state:\nDISCONNECT_IND"]; +mtms <<= mtmsc [label="CC DISCONNECT"]; +mtms =>> mtmsc [label="CC RELEASE"]; +mtmsc note mtmsc [label="CC stops timer T306"]; +mtms <<= mtmsc [label="CC RELEASE_COMPL"]; +mtmsc =>> mncc [label="MNCC_REL_IND"]; +momsc <<= mncc [label="MNCC_REL_REQ"]; +momsc note momsc [label="CC stops guard timer"]; +momsc note momsc [label="CC starts guard timer (180s)"]; +mtmsc abox mtmsc [label="CC state:\nNULL"]; +mtmsc note mtmsc [label="CC stops guard timer"]; +mtms <<= mtmsc [label="(BSSMAP) CLEAR_COMMAND"]; +mtms =>> mtmsc [label="(BSSMAP) Clear Complete"]; +moms =>> momsc [label="CC RELEASE_COMPL"]; +momsc note momsc [label="CC stops timer T308"]; +momsc =>> mncc [label="MNCC_REL_CNF"]; +momsc abox momsc [label="CC state:\nNULL"]; +momsc note momsc [label="CC stops guard timer"]; +moms <<= momsc [label="(BSSMAP) CLEAR_COMMAND"]; +moms =>> momsc [label="(BSSMAP) Clear Complete"]; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic003322dc4e3fce24a8413688cfe18198a4dc08a Gerrit-Change-Number: 31747 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[M] Change in osmo-msc[master]: update doc/sequence_charts/voice_call_external_mncc.msc

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31746 ) Change subject: update doc/sequence_charts/voice_call_external_mncc.msc ...................................................................... update doc/sequence_charts/voice_call_external_mncc.msc Re-run the msc_log_to_ladder.py on an actual 2G-2G voice call log, to see if anything changed in the meantime, to prepare for upcoming changes to the sequencing of establishing voice calls. Also shows recent improvements on picking up RTP ports from MGCP and MNCC. Change-Id: I9dcf980ad24d5921c291c9aada211b37f6f3db7f --- M doc/sequence_charts/voice_call_external_mncc.msc 1 file changed, 64 insertions(+), 47 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/46/31746/1 diff --git a/doc/sequence_charts/voice_call_external_mncc.msc b/doc/sequence_charts/voice_call_external_mncc.msc index 75fcef2..980755d 100644 --- a/doc/sequence_charts/voice_call_external_mncc.msc +++ b/doc/sequence_charts/voice_call_external_mncc.msc @@ -1,65 +1,68 @@ -# Generated by msc_log_to_ladder.py +# Generated by osmo-msc.git/doc/sequence_charts/msc_log_to_ladder.py msc { hscale="3"; -moms[label="MS,BSS (MO)\nUE,hNodeB (MO)"],momgw[label="MGW for MSC (MO)"],momsc[label="MSC (MO)"],sip[label="MNCC to PBX via\nosmo-sip-connector"],mtmsc[label="MSC (MT)"],mtmgw[label="MGW for MSC (MT)"],mtms[label="BSS,MS (MT)\nhNodeB,UE (MT)"]; +moms[label="MS,BSS (MO)\nUE,hNodeB (MO)"],momgw[label="MGW for MSC (MO)"],momsc[label="MSC (MO)"],mncc[label="MNCC"],mtmsc[label="MSC (MT)"],mtmgw[label="MGW for MSC (MT)"],mtms[label="BSS,MS (MT)\nhNodeB,UE (MT)"]; +moms =>> momsc [label="(BSSMAP) Complete Layer 3 Information"]; moms =>> momsc [label="MM CM_SERV_REQ"]; moms <<= momsc [label="MM AUTH_REQ"]; moms =>> momsc [label="MM AUTH_RESP"]; moms <<= momsc [label="(BSSMAP) CIPHER_MODE_COMMAND"]; moms =>> momsc [label="(BSSMAP) Ciphering Mode Complete"]; +moms <<= momsc [label="(BSSMAP) COMMON_ID"]; moms =>> momsc [label="RR CIPH_M_COMPL"]; moms =>> momsc [label="CC SETUP"]; momsc note momsc [label="CC starts guard timer (180s)"]; momsc abox momsc [label="CC state:\nINITIATED"]; -momsc =>> sip [label="MNCC_SETUP_IND"]; -momsc <<= sip [label="MNCC_RTP_CREATE"]; +momsc =>> mncc [label="MNCC_SETUP_IND"]; +momsc <<= mncc [label="MNCC_RTP_CREATE"]; momgw <<= momsc [label="for RAN: CRCX\nrtpbridge/*@msc"]; -momgw =>> momsc [label="for RAN: CRCX OK\nEP-1 CI-1"]; +momgw =>> momsc [label="for RAN: CRCX OK\nEP-1 CI-1 IP:port-1"]; moms <<= momsc [label="(BSSMAP) ASSIGNMENT_COMMAND"]; moms =>> momsc [label="(BSSMAP) Assignment Complete"]; momgw <<= momsc [label="for RAN: MDCX\nEP-1 CI-1"]; -momgw =>> momsc [label="for RAN: MDCX OK\nEP-1 CI-1"]; +momgw =>> momsc [label="for RAN: MDCX OK\nEP-1 CI-1 IP:port-1"]; momgw <<= momsc [label="for CN: CRCX\nEP-1"]; -momgw =>> momsc [label="for CN: CRCX OK\nEP-1 CI-2"]; -momsc =>> sip [label="MNCC_RTP_CREATE\nIP:port-1"]; -momsc <<= sip [label="MNCC_CALL_PROC_REQ"]; +momgw =>> momsc [label="for CN: CRCX OK\nEP-1 CI-2 IP:port-2"]; +momsc =>> mncc [label="MNCC_RTP_CREATE\nIP:port-2"]; +momsc <<= mncc [label="MNCC_CALL_PROC_REQ"]; momsc note momsc [label="CC stops guard timer"]; momsc note momsc [label="CC starts guard timer (180s)"]; momsc abox momsc [label="CC state:\nMO_CALL_PROC"]; moms <<= momsc [label="CC CALL_PROC"]; -mtmsc <<= sip [label="MNCC_SETUP_REQ"]; +mtmsc <<= mncc [label="MNCC_SETUP_REQ"]; mtms <<= mtmsc [label="Paging"]; +mtms =>> mtmsc [label="(BSSMAP) Complete Layer 3 Information"]; mtms =>> mtmsc [label="RR PAG_RESP"]; mtms <<= mtmsc [label="MM AUTH_REQ"]; -mtms =>> mtmsc [label="MM NULL"]; mtms =>> mtmsc [label="MM AUTH_RESP"]; -mtms <<= mtmsc [label="(RANAP) SecurityModeCommand"]; -mtms =>> mtmsc [label="(RANAP) SecurityModeControl successfulOutcome"]; -mtms <<= mtmsc [label="(RANAP) CommonId"]; +mtms <<= mtmsc [label="(BSSMAP) CIPHER_MODE_COMMAND"]; +mtms =>> mtmsc [label="(BSSMAP) Ciphering Mode Complete"]; +mtms <<= mtmsc [label="(BSSMAP) COMMON_ID"]; mtmsc note mtmsc [label="CC starts timer T303 (30s)"]; mtmsc abox mtmsc [label="CC state:\nCALL_PRESENT"]; mtms <<= mtmsc [label="CC SETUP"]; +mtms =>> mtmsc [label="RR CIPH_M_COMPL"]; mtms =>> mtmsc [label="CC CALL_CONF"]; mtmsc note mtmsc [label="CC stops timer T303"]; mtmsc note mtmsc [label="CC starts timer T310 (30s)"]; mtmsc abox mtmsc [label="CC state:\nMO_TERM_CALL_CONF"]; mtmgw <<= mtmsc [label="for RAN: CRCX\nrtpbridge/*@msc"]; -mtmsc =>> sip [label="MNCC_CALL_CONF_IND"]; -mtmsc <<= sip [label="MNCC_RTP_CREATE"]; -mtmgw =>> mtmsc [label="for RAN: CRCX OK\nEP-2 CI-3"]; -mtms <<= mtmsc [label="(RANAP) RAB AssignmentRequest"]; -mtms =>> mtmsc [label="(RANAP) RAB Assignment Response"]; +mtmsc =>> mncc [label="MNCC_CALL_CONF_IND"]; +mtmsc <<= mncc [label="MNCC_RTP_CREATE"]; +mtmgw =>> mtmsc [label="for RAN: CRCX OK\nEP-2 CI-3 IP:port-3"]; +mtms <<= mtmsc [label="(BSSMAP) ASSIGNMENT_COMMAND"]; +mtms =>> mtmsc [label="(BSSMAP) Assignment Complete"]; mtmgw <<= mtmsc [label="for RAN: MDCX\nEP-2 CI-3"]; -mtmgw =>> mtmsc [label="for RAN: MDCX OK\nEP-2 CI-3"]; +mtmgw =>> mtmsc [label="for RAN: MDCX OK\nEP-2 CI-3 IP:port-3"]; mtmgw <<= mtmsc [label="for CN: CRCX\nEP-2"]; -mtmgw =>> mtmsc [label="for CN: CRCX OK\nEP-2 CI-4"]; -mtmsc =>> sip [label="MNCC_RTP_CREATE\nIP:port-2"]; +mtmgw =>> mtmsc [label="for CN: CRCX OK\nEP-2 CI-4 IP:port-4"]; +mtmsc =>> mncc [label="MNCC_RTP_CREATE\nIP:port-4"]; mtms =>> mtmsc [label="CC ALERTING"]; mtmsc note mtmsc [label="CC stops timer T310"]; mtmsc note mtmsc [label="CC starts timer T301 (180s)"]; mtmsc abox mtmsc [label="CC state:\nCALL_RECEIVED"]; -mtmsc =>> sip [label="MNCC_ALERT_IND"]; -momsc <<= sip [label="MNCC_ALERT_REQ"]; +mtmsc =>> mncc [label="MNCC_ALERT_IND"]; +momsc <<= mncc [label="MNCC_ALERT_REQ"]; momsc note momsc [label="CC stops guard timer"]; momsc note momsc [label="CC starts guard timer (180s)"]; momsc abox momsc [label="CC state:\nCALL_DELIVERED"]; @@ -67,57 +70,55 @@ mtms =>> mtmsc [label="CC CONNECT"]; mtmsc note mtmsc [label="CC stops timer T301"]; mtmsc abox mtmsc [label="CC state:\nCONNECT_REQUEST"]; -mtmsc =>> sip [label="MNCC_SETUP_CNF"]; -mtmsc <<= sip [label="MNCC_RTP_CONNECT\nIP:port-1"]; +mtmsc =>> mncc [label="MNCC_SETUP_CNF"]; +mtmsc <<= mncc [label="MNCC_RTP_CONNECT\nIP:port-2"]; mtmgw <<= mtmsc [label="for CN: MDCX\nEP-2 CI-4"]; -mtmsc <<= sip [label="MNCC_SETUP_COMPL_REQ"]; +mtmsc <<= mncc [label="MNCC_SETUP_COMPL_REQ"]; mtmsc note mtmsc [label="CC starts guard timer (180s)"]; mtmsc abox mtmsc [label="CC state:\nACTIVE"]; mtmsc note mtmsc [label="CC stops guard timer"]; mtms <<= mtmsc [label="CC CONNECT_ACK"]; -mtmgw =>> mtmsc [label="for CN: MDCX OK\nEP-2 CI-4"]; -momsc <<= sip [label="MNCC_RTP_CONNECT\nIP:port-2"]; +momsc <<= mncc [label="MNCC_RTP_CONNECT\nIP:port-4"]; momgw <<= momsc [label="for CN: MDCX\nEP-1 CI-2"]; -momsc <<= sip [label="MNCC_SETUP_RSP"]; +momsc <<= mncc [label="MNCC_SETUP_RSP"]; momsc note momsc [label="CC stops guard timer"]; momsc note momsc [label="CC starts guard timer (180s)"]; momsc note momsc [label="CC starts timer T313 (30s)"]; momsc abox momsc [label="CC state:\nCONNECT_IND"]; moms <<= momsc [label="CC CONNECT"]; -momgw =>> momsc [label="for CN: MDCX OK\nEP-1 CI-2"]; +mtmgw =>> mtmsc [label="for CN: MDCX OK\nEP-2 CI-4 IP:port-4"]; +momgw =>> momsc [label="for CN: MDCX OK\nEP-1 CI-2 IP:port-2"]; moms =>> momsc [label="CC CONNECT_ACK"]; momsc note momsc [label="CC stops timer T313"]; momsc abox momsc [label="CC state:\nACTIVE"]; momsc note momsc [label="CC stops guard timer"]; -momsc =>> sip [label="MNCC_SETUP_COMPL_IND"]; +momsc =>> mncc [label="MNCC_SETUP_COMPL_IND"]; moms =>> momsc [label="CC DISCONNECT"]; momsc abox momsc [label="CC state:\nDISCONNECT_IND"]; -momsc =>> sip [label="MNCC_DISC_IND"]; -momsc <<= sip [label="MNCC_REL_REQ"]; +momsc =>> mncc [label="MNCC_DISC_IND"]; +momsc <<= mncc [label="MNCC_REL_REQ"]; momsc note momsc [label="CC starts guard timer (180s)"]; momsc note momsc [label="CC starts timer T308 (10s)"]; momsc abox momsc [label="CC state:\nRELEASE_REQ"]; moms <<= momsc [label="CC RELEASE"]; -mtmsc <<= sip [label="MNCC_DISC_REQ"]; +mtmsc <<= mncc [label="MNCC_DISC_REQ"]; mtmsc note mtmsc [label="CC starts guard timer (180s)"]; mtmsc note mtmsc [label="CC starts timer T306 (30s)"]; mtmsc abox mtmsc [label="CC state:\nDISCONNECT_IND"]; mtms <<= mtmsc [label="CC DISCONNECT"]; -moms =>> momsc [label="CC RELEASE_COMPL"]; -momsc note momsc [label="CC stops timer T308"]; -momsc abox momsc [label="CC state:\nNULL"]; -momsc note momsc [label="CC stops guard timer"]; -moms <<= momsc [label="(BSSMAP) CLEAR_COMMAND"]; -momsc =>> sip [label="MNCC_REL_CNF"]; -moms =>> momsc [label="(BSSMAP) Clear Complete"]; mtms =>> mtmsc [label="CC RELEASE"]; mtmsc note mtmsc [label="CC stops timer T306"]; mtms <<= mtmsc [label="CC RELEASE_COMPL"]; +mtmsc =>> mncc [label="MNCC_REL_IND"]; mtmsc abox mtmsc [label="CC state:\nNULL"]; mtmsc note mtmsc [label="CC stops guard timer"]; -mtms <<= mtmsc [label="(RANAP) Iu Release"]; -mtmsc =>> sip [label="MNCC_REL_IND"]; -mtms =>> mtmsc [label="(RANAP) Iu Release successfulOutcome"]; -moms =>> momsc [label="IMSI Detach"]; -mtms =>> mtmsc [label="IMSI Detach"]; +mtms <<= mtmsc [label="(BSSMAP) CLEAR_COMMAND"]; +mtms =>> mtmsc [label="(BSSMAP) Clear Complete"]; +moms =>> momsc [label="CC RELEASE_COMPL"]; +momsc note momsc [label="CC stops timer T308"]; +momsc =>> mncc [label="MNCC_REL_CNF"]; +momsc abox momsc [label="CC state:\nNULL"]; +momsc note momsc [label="CC stops guard timer"]; +moms <<= momsc [label="(BSSMAP) CLEAR_COMMAND"]; +moms =>> momsc [label="(BSSMAP) Clear Complete"]; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9dcf980ad24d5921c291c9aada211b37f6f3db7f Gerrit-Change-Number: 31746 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

[M] Change in osmo-msc[master]: MNCC: use codec_mapping, drop mgcp_codec_to_mncc_payload_msg_type()

by neels

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/30115 to look at the new patch set (#6). Change subject: MNCC: use codec_mapping, drop mgcp_codec_to_mncc_payload_msg_type() ...................................................................... MNCC: use codec_mapping, drop mgcp_codec_to_mncc_payload_msg_type() Change-Id: I8995ef43b9f79bc1db5672362c6433e4d96dd9e0 --- M src/libmsc/gsm_04_08_cc.c M src/libmsc/mncc_call.c 2 files changed, 29 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/15/30115/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8995ef43b9f79bc1db5672362c6433e4d96dd9e0 Gerrit-Change-Number: 30115 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[M] Change in osmo-msc[master]: [codecs filter] use filter result in Assignment

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 to look at the new patch set (#6). Change subject: [codecs filter] use filter result in Assignment ...................................................................... [codecs filter] use filter result in Assignment So far, patches have set up rtp_stream to allow setting multiple codecs, and collected the codecs information into the codecs filter struct. Now actually use the codecs filter result to choose a codec. Setting up the call leg FSMs and codecs still looks rather confusing in this patch, because this is an incremental step in a larger series. The upcoming patch 'do CN CRCX first' clarifies this substantially. The resulting codecs behavior is tested in upcoming patch I879ec61f523ad4ffc69a0b02810591f7c0261ff9. (The test ideally should have come before this patch, but my time to rework this branch is up.) With the codecs filter in place, we are ready for sending and receiving full SDP via MNCC, see upcoming Ie0668c0e079ec69da1532b52d00621efe114fc2c and Ie433db1ba0c46d4b97538a969233c155cefac21c Related: SYS#5066 Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 --- M src/libmsc/gsm_04_08_cc.c M tests/msc_vlr/msc_vlr_test_call.err 2 files changed, 46 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/26/30126/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66e7c8c5e401f4f3a7d3d42b9525b2c6e99691d9 Gerrit-Change-Number: 30126 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[S] Change in osmo-msc[master]: [codecs filter] add trans.cc.codecs

by neels

Attention is currently required from: neels, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/30117 to look at the new patch set (#6). Change subject: [codecs filter] add trans.cc.codecs ...................................................................... [codecs filter] add trans.cc.codecs Add the central codecs_filter for Call Control. The new member is not used in this patch yet, subsequent patches will start to populate the various stages of this codec filter, one by one. Related: SYS#5066 Change-Id: Ib3fdeff8d1e1ea0760168d63ee6e1b1fb993aa5f --- M include/osmocom/msc/transaction.h 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/17/30117/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib3fdeff8d1e1ea0760168d63ee6e1b1fb993aa5f Gerrit-Change-Number: 30117 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[L] Change in osmo-msc[master]: [codecs filter] send + receive SDP via MNCC

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31698 to look at the new patch set (#5). Change subject: [codecs filter] send + receive SDP via MNCC ...................................................................... [codecs filter] send + receive SDP via MNCC Transmit and receive full SDP information via MNCC, to accurately pass codecs choices between the call legs. In msc_vlr_test_call.c test_call_mt(), show that when receiving MNCC, the codec information in SDP overrules the Bearer Cap codec information -- we expect to still receive inaccurate Bearer Cap from e.g. osmo-sip-connector, because we have chosen to add SDP to MNCC instead of trying to fix the codecs represented in Bearer Cap. For internal MNCC, the MT call leg now knows which codec the MO has chosen and assigned. For external MNCC, osmo-sip-connector receives SDP about our codecs choices and sends it in SIP messages, and we also receive the full SDP information from the remote SIP leg. Update the SDP in codec_filter every time it is received, to always have the latest SDP information from the remote leg. CC MNCC | ---ALERTING--> | add local side SDP to MNCC msg | <--ALERTING--- | store remote side SDP | <--SETUP-RESP- | store remote side SDP | --SETUP-CNF--> | add local side SDP to MNCC msg | -RTP-CREATE--> | use codec_filter, add local side SDP to MNCC msg | <-RTP-CONNECT- | store remote side SDP There still is one problem: when initiating MNCC, we do not yet know the RTP address and port to be used for the CN side, because the CN CRCX happens later. So far we send 0.0.0.0:0 as RTP endpoint in the SDP, until the CN CRCX is done. A subsequent patch moves CN CRCX to an earlier time, adding proper RTP information right from the start. Related: SYS#5066 Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c --- M include/osmocom/msc/rtp_stream.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_a.c M src/libmsc/rtp_stream.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 6 files changed, 241 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/98/31698/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie0668c0e079ec69da1532b52d00621efe114fc2c Gerrit-Change-Number: 31698 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[L] Change in osmo-msc[master]: do CN CRCX first

by neels

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31740 to look at the new patch set (#2). Change subject: do CN CRCX first ...................................................................... do CN CRCX first In order to send the MSC's RTP endpoint IP address+port in the inital SDP, move the MGCP CRCX up to an earlier point in the sequence of establishing a voice call. Update the voice call sequence chart to show the effects. Though the semantic change is rather simple, the patch is rather huge -- things have to happen in a different order, and async waits have to happen at different times. The new codec filter helps to carry codec resolution information across the newly arranged code paths. Related: SYS#5066 Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c --- M doc/sequence_charts/voice_call_external_mncc.msc M doc/sequence_charts/voice_call_internal_mncc.msc M include/osmocom/msc/gsm_04_08.h M include/osmocom/msc/msc_a.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/msc_a.c M tests/msc_vlr/msc_vlr_test_call.c M tests/msc_vlr/msc_vlr_test_call.err 8 files changed, 487 insertions(+), 261 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/31740/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie433db1ba0c46d4b97538a969233c155cefac21c Gerrit-Change-Number: 31740 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

[M] Change in osmo-msc[master]: mncc_recvmsg(): log caller file,line

by neels

Attention is currently required from: neels. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/31701 to look at the new patch set (#5). Change subject: mncc_recvmsg(): log caller file,line ...................................................................... mncc_recvmsg(): log caller file,line Change-Id: I3755eb35b504f2f2580e0ba43dfa41f16087decc --- M include/osmocom/msc/transaction.h M src/libmsc/gsm_04_08_cc.c 2 files changed, 35 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/01/31701/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3755eb35b504f2f2580e0ba43dfa41f16087decc Gerrit-Change-Number: 31701 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2023