March 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-gprs[master]: rlcmac: Move create_pkt_ctrl_ack() to tbf base class
by pespin 08 Mar '23

08 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31755 ) Change subject: rlcmac: Move create_pkt_ctrl_ack() to tbf base class ...................................................................... rlcmac: Move create_pkt_ctrl_ack() to tbf base class The code to generate a PKT CTRL ACK is the same for a DL TBF and an UL TBF. Move it to the generic base class in order to be able to generate it for a DL TBF in a follow up patch. Change-Id: I767696b445842ebc32b35c320273b13f63076ca4 --- M include/osmocom/gprs/rlcmac/tbf.h M include/osmocom/gprs/rlcmac/tbf_ul.h M src/rlcmac/sched.c M src/rlcmac/tbf.c M src/rlcmac/tbf_ul.c 5 files changed, 68 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/55/31755/1 diff --git a/include/osmocom/gprs/rlcmac/tbf.h b/include/osmocom/gprs/rlcmac/tbf.h index 2886c83..83a887d 100644 --- a/include/osmocom/gprs/rlcmac/tbf.h +++ b/include/osmocom/gprs/rlcmac/tbf.h @@ -27,3 +27,14 @@ void gprs_rlcmac_tbf_destructor(struct gprs_rlcmac_tbf *tbf); void gprs_rlcmac_tbf_free(struct gprs_rlcmac_tbf *tbf); + +struct msgb *gprs_rlcmac_tbf_create_pkt_ctrl_ack(const struct gprs_rlcmac_tbf *tbf); + +#define LOGPTBF(tbf, lvl, fmt, args...) \ + LOGP(g_rlcmac_log_cat[tbf->direction == GPRS_RLCMAC_TBF_DIR_DL ? \ + OSMO_GPRS_RLCMAC_LOGC_TBFDL : \ + OSMO_GPRS_RLCMAC_LOGC_TBFUL], \ + lvl, "TBF(%s:NR-%" PRIu8 ":TLLI-%08x) " fmt, \ + tbf->direction == GPRS_RLCMAC_TBF_DIR_DL ? "DL" : "UL", \ + tbf->nr, tbf->gre->tlli, \ + ## args) diff --git a/include/osmocom/gprs/rlcmac/tbf_ul.h b/include/osmocom/gprs/rlcmac/tbf_ul.h index ab85f50..e5cfa91 100644 --- a/include/osmocom/gprs/rlcmac/tbf_ul.h +++ b/include/osmocom/gprs/rlcmac/tbf_ul.h @@ -54,7 +54,6 @@ struct msgb *gprs_rlcmac_ul_tbf_data_create(struct gprs_rlcmac_ul_tbf *ul_tbf, const struct gprs_rlcmac_rts_block_ind *bi); struct msgb *gprs_rlcmac_ul_tbf_dummy_create(const struct gprs_rlcmac_ul_tbf *ul_tbf); -struct msgb *gprs_rlcmac_ul_tbf_create_pkt_ctrl_ack(const struct gprs_rlcmac_ul_tbf *ul_tbf); int gprs_rlcmac_ul_tbf_handle_pkt_ul_ack_nack(struct gprs_rlcmac_ul_tbf *ul_tbf, const RlcMacDownlink_t *dl_block); diff --git a/src/rlcmac/sched.c b/src/rlcmac/sched.c index 0431631..2630940 100644 --- a/src/rlcmac/sched.c +++ b/src/rlcmac/sched.c @@ -198,13 +198,13 @@ if (tbfs->poll_ul_ack) { LOGRLCMAC(LOGL_DEBUG, "(ts=%u,fn=%u,usf=%u) Tx Pkt Control Ack (UL ACK/NACK poll)\n", bi->ts, bi->fn, bi->usf); - msg = gprs_rlcmac_ul_tbf_create_pkt_ctrl_ack(tbfs->poll_ul_ack); + msg = gprs_rlcmac_tbf_create_pkt_ctrl_ack(ul_tbf_as_tbf(tbfs->poll_ul_ack)); /* Last UL message, freeing */ gprs_rlcmac_ul_tbf_free(tbfs->poll_ul_ack); return msg; } if (tbfs->poll_ul_ass) { - msg = gprs_rlcmac_ul_tbf_create_pkt_ctrl_ack(tbfs->poll_ul_ass); + msg = gprs_rlcmac_tbf_create_pkt_ctrl_ack(ul_tbf_as_tbf(tbfs->poll_ul_ass)); if (msg) return msg; } diff --git a/src/rlcmac/tbf.c b/src/rlcmac/tbf.c index ea15d69..c18ad83 100644 --- a/src/rlcmac/tbf.c +++ b/src/rlcmac/tbf.c @@ -19,8 +19,14 @@ * */ +#include <osmocom/core/bitvec.h> +#include <osmocom/core/msgb.h> +#include <osmocom/gsm/protocol/gsm_04_08.h> + #include <osmocom/gprs/rlcmac/tbf.h> #include <osmocom/gprs/rlcmac/tbf_ul.h> +#include <osmocom/gprs/rlcmac/gre.h> +#include <osmocom/gprs/rlcmac/rlcmac_enc.h> void gprs_rlcmac_tbf_constructor(struct gprs_rlcmac_tbf *tbf, enum gprs_rlcmac_tbf_direction direction, @@ -41,3 +47,38 @@ gprs_rlcmac_ul_tbf_free(tbf_as_ul_tbf(tbf)); /* else: TODO dl_tbf not yet implemented */ } + +struct msgb *gprs_rlcmac_tbf_create_pkt_ctrl_ack(const struct gprs_rlcmac_tbf *tbf) +{ + struct msgb *msg; + struct bitvec bv; + RlcMacUplink_t ul_block; + int rc; + + OSMO_ASSERT(tbf); + + msg = msgb_alloc(GSM_MACBLOCK_LEN, "pkt_ctrl_ack"); + if (!msg) + return NULL; + + /* Initialize a bit vector that uses allocated msgb as the data buffer. */ + bv = (struct bitvec){ + .data = msgb_put(msg, GSM_MACBLOCK_LEN), + .data_len = GSM_MACBLOCK_LEN, + }; + bitvec_unhex(&bv, GPRS_RLCMAC_DUMMY_VEC); + + gprs_rlcmac_enc_prepare_pkt_ctrl_ack(&ul_block, tbf->gre->tlli); + rc = osmo_gprs_rlcmac_encode_uplink(&bv, &ul_block); + if (rc < 0) { + LOGPTBF(tbf, LOGL_ERROR, "Encoding of Packet Control ACK failed (%d)\n", rc); + goto free_ret; + } + LOGPTBF(tbf, LOGL_DEBUG, "Tx Packet Control Ack\n"); + + return msg; + +free_ret: + msgb_free(msg); + return NULL; +} diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index fcd7f56..143c880 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -310,41 +310,6 @@ return NULL; } -struct msgb *gprs_rlcmac_ul_tbf_create_pkt_ctrl_ack(const struct gprs_rlcmac_ul_tbf *ul_tbf) -{ - struct msgb *msg; - struct bitvec bv; - RlcMacUplink_t ul_block; - int rc; - - OSMO_ASSERT(ul_tbf); - - msg = msgb_alloc(GSM_MACBLOCK_LEN, "pkt_ctrl_ack"); - if (!msg) - return NULL; - - /* Initialize a bit vector that uses allocated msgb as the data buffer. */ - bv = (struct bitvec){ - .data = msgb_put(msg, GSM_MACBLOCK_LEN), - .data_len = GSM_MACBLOCK_LEN, - }; - bitvec_unhex(&bv, GPRS_RLCMAC_DUMMY_VEC); - - gprs_rlcmac_enc_prepare_pkt_ctrl_ack(&ul_block, ul_tbf->tbf.gre->tlli); - rc = osmo_gprs_rlcmac_encode_uplink(&bv, &ul_block); - if (rc < 0) { - LOGPTBFUL(ul_tbf, LOGL_ERROR, "Encoding of Packet Control ACK failed (%d)\n", rc); - goto free_ret; - } - LOGPTBFUL(ul_tbf, LOGL_DEBUG, "Tx Packet Control Ack\n"); - - return msg; - -free_ret: - msgb_free(msg); - return NULL; -} - bool gprs_rlcmac_ul_tbf_have_data(const struct gprs_rlcmac_ul_tbf *ul_tbf) { return (ul_tbf->llc_tx_msg && msgb_length(ul_tbf->llc_tx_msg) > 0) || -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I767696b445842ebc32b35c320273b13f63076ca4 Gerrit-Change-Number: 31755 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[L] Change in libosmo-gprs[master]: WIP
by pespin 08 Mar '23

08 Mar '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31757 ) Change subject: WIP ...................................................................... WIP Change-Id: Idafb4e37971e93c7e8667b8669a29755485e95bb --- M include/osmocom/gprs/rlcmac/Makefile.am M include/osmocom/gprs/rlcmac/gre.h A include/osmocom/gprs/rlcmac/tbf_start_fsm.h M src/rlcmac/Makefile.am M src/rlcmac/gre.c M src/rlcmac/misc.c M src/rlcmac/rlcmac.c M src/rlcmac/sched.c A src/rlcmac/tbf_start_fsm.c M tests/rlcmac/rlcmac_prim_test.err 10 files changed, 561 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/57/31757/1 diff --git a/include/osmocom/gprs/rlcmac/Makefile.am b/include/osmocom/gprs/rlcmac/Makefile.am index 81cfecd..1c780fe 100644 --- a/include/osmocom/gprs/rlcmac/Makefile.am +++ b/include/osmocom/gprs/rlcmac/Makefile.am @@ -18,6 +18,7 @@ tbf_ul.h \ tbf_ul_fsm.h \ tbf_ul_ass_fsm.h \ + tbf_start_fsm.h \ types_private.h \ $(NULL) diff --git a/include/osmocom/gprs/rlcmac/gre.h b/include/osmocom/gprs/rlcmac/gre.h index f6397a6..29987c9 100644 --- a/include/osmocom/gprs/rlcmac/gre.h +++ b/include/osmocom/gprs/rlcmac/gre.h @@ -3,6 +3,7 @@ #include <osmocom/gprs/rlcmac/rlcmac.h> #include <osmocom/gprs/rlcmac/llc_queue.h> +#include <osmocom/gprs/rlcmac/tbf_start_fsm.h> struct gprs_rlcmac_dl_tbf; struct gprs_rlcmac_ul_tbf; @@ -13,6 +14,9 @@ struct gprs_rlcmac_llc_queue *llc_queue; + /* Manage TBF Starting Time delay during TBF assignment: */ + struct gprs_rlcmac_tbf_start_fsm_ctx dl_tbf_start_fsm; + struct gprs_rlcmac_dl_tbf *dl_tbf; struct gprs_rlcmac_ul_tbf *ul_tbf; }; diff --git a/include/osmocom/gprs/rlcmac/tbf_start_fsm.h b/include/osmocom/gprs/rlcmac/tbf_start_fsm.h new file mode 100644 index 0000000..bf966ce --- /dev/null +++ b/include/osmocom/gprs/rlcmac/tbf_start_fsm.h @@ -0,0 +1,61 @@ +/* DL TBF Assignment FSM, 3GPP TS 44.060 */ +#pragma once + +#include <stdint.h> + +#include <osmocom/core/fsm.h> +#include <osmocom/core/msgb.h> + +#include <osmocom/gprs/rlcmac/csn1_defs.h> +#include <osmocom/gprs/rlcmac/rlcmac_private.h> +#include <osmocom/gprs/rlcmac/rlcmac_dec.h> + +enum gprs_rlcmac_tbf_start_fsm_states { + GPRS_RLCMAC_TBF_START_ST_IDLE = 0, /* new created TBF */ + GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME, /* wait for Immediate Assignment */ + GPRS_RLCMAC_TBF_START_ST_COMPL, /* Completed, will update TBF and return to IDLE state */ +}; + +struct gprs_rlcmac_tbf_start_fsm_ctx { + struct osmo_fsm_inst *fi; + struct gprs_rlcmac_entity *gre; /* backpointer */ + struct gprs_rlcmac_dl_tbf_allocation alloc; + union { + IA_RestOctets_t iaro; /* CCCH Imm Ass rest octets */ + RlcMacDownlink_t dl_block; /* PACCH pkt dl ass */ + }; + bool tbf_starting_time_exists; + uint32_t tbf_starting_time; + uint8_t ts_nr; +}; + +enum tbf_start_fsm_event { + GPRS_RLCMAC_TBF_START_EV_RX_CCCH_IMM_ASS, /* Start Downlink/Uplink assignment from CCCH Imm Ass (data: strcut tbf_start_ev_rx_ccch_imm_ass_ctx) */ + GPRS_RLCMAC_TBF_START_EV_RX_PACCH_PKT_ASS, /* Start Downlink/Uplink assignment from Pkt Dl/Ul Ass (data: strcut tbf_start_ev_rx_pacch_pkt_ass_ctx) */ + GPRS_RLCMAC_TBF_START_EV_TBF_STARTING_TIME, /* TBF Starting Time reached */ +}; + +struct tbf_start_ev_rx_ccch_imm_ass_ctx { + uint8_t ts_nr; + uint32_t fn; + const struct gsm48_imm_ass *ia; + const IA_RestOctets_t *iaro; +}; + +struct tbf_start_ev_rx_pacch_pkt_ass_ctx { + uint8_t ts_nr; + uint32_t fn; + const RlcMacDownlink_t *dl_block; /* decoded Pkt{Ul,Dl}Ass */ +}; +int gprs_rlcmac_tbf_start_fsm_init(void); +void gprs_rlcmac_tbf_start_fsm_set_log_cat(int logcat); + +int gprs_rlcmac_tbf_start_fsm_constructor(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, struct gprs_rlcmac_entity *gre); +void gprs_rlcmac_tbf_start_fsm_destructor(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx); + +int gprs_rlcmac_tbf_start_from_ccch(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, const struct tbf_start_ev_rx_ccch_imm_ass_ctx *d); +int gprs_rlcmac_tbf_start_from_pacch(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, const struct tbf_start_ev_rx_pacch_pkt_ass_ctx *d); + +bool gprs_rlcmac_tbf_start_pending(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx); +void gprs_rlcmac_tbf_start_fn_tick(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, uint32_t fn, uint8_t ts_nr); +enum gprs_rlcmac_tbf_start_fsm_states gprs_rlcmac_tbf_start_state(const struct gprs_rlcmac_tbf_start_fsm_ctx *ctx); diff --git a/src/rlcmac/Makefile.am b/src/rlcmac/Makefile.am index 9133df0..599e468 100644 --- a/src/rlcmac/Makefile.am +++ b/src/rlcmac/Makefile.am @@ -47,6 +47,7 @@ tbf_ul.c \ tbf_ul_fsm.c \ tbf_ul_ass_fsm.c \ + tbf_start_fsm.c \ ts_44_060.c \ ts_44_064.c \ misc.c \ diff --git a/src/rlcmac/gre.c b/src/rlcmac/gre.c index 53d53c7..633d733 100644 --- a/src/rlcmac/gre.c +++ b/src/rlcmac/gre.c @@ -25,6 +25,7 @@ #include <osmocom/gprs/rlcmac/rlcmac_prim.h> #include <osmocom/gprs/rlcmac/rlcmac_private.h> #include <osmocom/gprs/rlcmac/tbf_dl.h> +#include <osmocom/gprs/rlcmac/tbf_start_fsm.h> #include <osmocom/gprs/rlcmac/tbf_ul_fsm.h> #include <osmocom/gprs/rlcmac/tbf_ul.h> #include <osmocom/gprs/rlcmac/gre.h> @@ -32,6 +33,7 @@ struct gprs_rlcmac_entity *gprs_rlcmac_entity_alloc(uint32_t tlli) { struct gprs_rlcmac_entity *gre; + int rc; gre = talloc_zero(g_ctx, struct gprs_rlcmac_entity); if (!gre) @@ -44,6 +46,10 @@ g_ctx->cfg.codel.use, g_ctx->cfg.codel.interval_msec); + rc = gprs_rlcmac_tbf_start_fsm_constructor(&gre->dl_tbf_start_fsm, gre); + if (rc < 0) + goto err_free_gre; + gre->tlli = tlli; llist_add_tail(&gre->entry, &g_ctx->gre_list); @@ -59,6 +65,7 @@ if (!gre) return; + gprs_rlcmac_tbf_start_fsm_destructor(&gre->dl_tbf_start_fsm); gprs_rlcmac_dl_tbf_free(gre->dl_tbf); gprs_rlcmac_ul_tbf_free(gre->ul_tbf); gprs_rlcmac_llc_queue_free(gre->llc_queue); diff --git a/src/rlcmac/misc.c b/src/rlcmac/misc.c index 7317bd1..8612afc 100644 --- a/src/rlcmac/misc.c +++ b/src/rlcmac/misc.c @@ -21,6 +21,7 @@ #include <osmocom/gprs/rlcmac/tbf_dl_fsm.h> #include <osmocom/gprs/rlcmac/tbf_ul_fsm.h> #include <osmocom/gprs/rlcmac/tbf_ul_ass_fsm.h> +#include <osmocom/gprs/rlcmac/tbf_start_fsm.h> int g_rlcmac_log_cat[_OSMO_GPRS_RLCMAC_LOGC_MAX] = { [0 ... _OSMO_GPRS_RLCMAC_LOGC_MAX - 1] = DLGLOBAL @@ -32,6 +33,9 @@ g_rlcmac_log_cat[logc] = logc_num; switch (logc) { + case OSMO_GPRS_RLCMAC_LOGC_RLCMAC: + gprs_rlcmac_tbf_start_fsm_set_log_cat(logc_num); + break; case OSMO_GPRS_RLCMAC_LOGC_TBFUL: gprs_rlcmac_tbf_ul_fsm_set_log_cat(logc_num); gprs_rlcmac_tbf_ul_ass_fsm_set_log_cat(logc_num); diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index 4647fff..516ed46 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -86,6 +86,11 @@ osmo_tdefs_reset(g_ctx->T_defs); if (first_init) { + rc = gprs_rlcmac_tbf_start_fsm_init(); + if (rc != 0) { + TALLOC_FREE(g_ctx); + return rc; + } rc = gprs_rlcmac_tbf_dl_fsm_init(); if (rc != 0) { TALLOC_FREE(g_ctx); @@ -195,8 +200,8 @@ { int rc; struct gprs_rlcmac_entity *gre; - struct gprs_rlcmac_dl_tbf *dl_tbf; const Packet_Downlink_ImmAssignment_t *pkdlass; + struct tbf_start_ev_rx_ccch_imm_ass_ctx ev_data; if (iaro->UnionType == 1) { /* TODO */ @@ -211,17 +216,13 @@ return -ENOENT; } - LOGGRE(gre, LOGL_INFO, "Got PCH IMM_ASS (DL_TBF): DL_TFI=%u TS=%u\n", - pkdlass->TFI_ASSIGNMENT, ts_nr); - dl_tbf = gprs_rlcmac_dl_tbf_alloc(gre); - dl_tbf->cur_alloc.dl_tfi = pkdlass->TFI_ASSIGNMENT; - dl_tbf->cur_alloc.ts[ts_nr].allocated = true; - - /* replace old DL TBF with new one: */ - gprs_rlcmac_dl_tbf_free(gre->dl_tbf); - gre->dl_tbf = dl_tbf; - - rc = osmo_fsm_inst_dispatch(dl_tbf->state_fsm.fi, GPRS_RLCMAC_TBF_UL_EV_DL_ASS_COMPL, NULL); + ev_data = (struct tbf_start_ev_rx_ccch_imm_ass_ctx) { + .ts_nr = ts_nr, + .fn = fn, + .ia = ia, + .iaro = iaro, + }; + rc = gprs_rlcmac_tbf_start_from_ccch(&gre->dl_tbf_start_fsm, &ev_data); return rc; } @@ -333,6 +334,82 @@ return rc; } +static struct gprs_rlcmac_tbf *find_tbf_by_global_tfi(const Global_TFI_t *gtfi) +{ + struct gprs_rlcmac_ul_tbf *ul_tbf; + struct gprs_rlcmac_dl_tbf *dl_tbf; + switch (gtfi->UnionType) { + case 0: /* UL TFI */ + ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(gtfi->u.UPLINK_TFI); + if (ul_tbf) + return ul_tbf_as_tbf(ul_tbf); + break; + case 1: /* DL TFI */ + dl_tbf = gprs_rlcmac_find_dl_tbf_by_tfi(gtfi->u.DOWNLINK_TFI); + if (dl_tbf) + return dl_tbf_as_tbf(dl_tbf); + break; + default: + OSMO_ASSERT(0); + } + return NULL; +} + +static struct gprs_rlcmac_entity *find_gre_by_global_tfi(const Global_TFI_t *gtfi) +{ + struct gprs_rlcmac_tbf *tbf = find_tbf_by_global_tfi(gtfi); + if (tbf) + return tbf->gre; + return NULL; +} + + +static int gprs_rlcmac_handle_pkt_dl_ass(const struct osmo_gprs_rlcmac_prim *rlcmac_prim, const RlcMacDownlink_t *dl_block) +{ + struct gprs_rlcmac_tbf *tbf = NULL; + struct gprs_rlcmac_entity *gre = NULL; + const Packet_Downlink_Assignment_t *dlass = &dl_block->u.Packet_Downlink_Assignment; + struct tbf_start_ev_rx_pacch_pkt_ass_ctx ev_data; + int rc; + + /* Attempt to find relevant MS in assignment state from ID (set "gre" ptr): */ + switch (dlass->ID.UnionType) { + case 0: /* GLOBAL_TFI: */ + tbf = find_tbf_by_global_tfi(&dlass->ID.u.Global_TFI); + if (tbf) + gre = tbf->gre; + break; + case 1: /* TLLI */ + gre = gprs_rlcmac_find_entity_by_tlli(dlass->ID.u.TLLI); + break; + default: + OSMO_ASSERT(0); + } + + if (!gre) { + LOGRLCMAC(LOGL_INFO, "TS=%u FN=%u Rx Pkt DL ASS: MS not found\n", + rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, + rlcmac_prim->l1ctl.pdch_data_ind.fn); + return -ENOENT; + } + + ev_data = (struct tbf_start_ev_rx_pacch_pkt_ass_ctx) { + .ts_nr = rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, + .fn = rlcmac_prim->l1ctl.pdch_data_ind.fn, + .dl_block = dl_block, + }; + rc = gprs_rlcmac_tbf_start_from_pacch(&gre->dl_tbf_start_fsm, &ev_data); + + if (tbf && dl_block->SP) { + uint32_t poll_fn = rrbp2fn(rlcmac_prim->l1ctl.pdch_data_ind.fn, dl_block->RRBP); + gprs_rlcmac_pdch_ulc_reserve(g_ctx->sched.ulc[rlcmac_prim->l1ctl.pdch_data_ind.ts_nr], + poll_fn, + GPRS_RLCMAC_PDCH_ULC_POLL_DL_ASS, + tbf); + } + return rc; +} + static int gprs_rlcmac_handle_pkt_ul_ack_nack(const struct osmo_gprs_rlcmac_prim *rlcmac_prim, const RlcMacDownlink_t *dl_block) { struct gprs_rlcmac_ul_tbf *ul_tbf; @@ -362,28 +439,13 @@ static int gprs_rlcmac_handle_pkt_ul_ass(const struct osmo_gprs_rlcmac_prim *rlcmac_prim, const RlcMacDownlink_t *dl_block) { struct gprs_rlcmac_entity *gre = NULL; - struct gprs_rlcmac_ul_tbf *ul_tbf = NULL; - struct gprs_rlcmac_dl_tbf *dl_tbf; const Packet_Uplink_Assignment_t *ulass = &dl_block->u.Packet_Uplink_Assignment; int rc; /* Attempt to find relevant MS owning UL TBF in assignment state from ID (set "gre" ptr): */ switch (ulass->ID.UnionType) { case 0: /* GLOBAL_TFI: */ - switch (ulass->ID.u.Global_TFI.UnionType) { - case 0: /* UL TFI */ - ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(ulass->ID.u.Global_TFI.u.UPLINK_TFI); - if (ul_tbf) - gre = ul_tbf->tbf.gre; - break; - case 1: /* DL TFI */ - dl_tbf = gprs_rlcmac_find_dl_tbf_by_tfi(ulass->ID.u.Global_TFI.u.DOWNLINK_TFI); - if (dl_tbf) - gre = dl_tbf->tbf.gre; - break; - default: - OSMO_ASSERT(0); - } + gre = find_gre_by_global_tfi(&ulass->ID.u.Global_TFI); break; case 1: /* TLLI */ gre = gprs_rlcmac_find_entity_by_tlli(ulass->ID.u.TLLI); @@ -443,6 +505,9 @@ get_value_string(osmo_gprs_rlcmac_dl_msg_type_names, dl_ctrl_block->u.MESSAGE_TYPE)); switch (dl_ctrl_block->u.MESSAGE_TYPE) { + case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_DOWNLINK_ASSIGNMENT: + rc = gprs_rlcmac_handle_pkt_dl_ass(rlcmac_prim, dl_ctrl_block); + break; case OSMO_GPRS_RLCMAC_DL_MSGT_PACKET_UPLINK_ACK_NACK: rc = gprs_rlcmac_handle_pkt_ul_ack_nack(rlcmac_prim, dl_ctrl_block); break; diff --git a/src/rlcmac/sched.c b/src/rlcmac/sched.c index f77deab..e6885f9 100644 --- a/src/rlcmac/sched.c +++ b/src/rlcmac/sched.c @@ -38,6 +38,7 @@ struct gprs_rlcmac_ul_tbf *poll_ul_ack_new_ul_tbf; /* 9.3.2.4.2 (answer with PKT RES REQ) */ struct gprs_rlcmac_ul_tbf *poll_ul_ack; /* 11.2.2 (answer with PKT CTRL ACK) */ struct gprs_rlcmac_ul_tbf *poll_ul_ass; /* (answer Pkt UL ASS with PKT CTRL ACK) */ + struct gprs_rlcmac_tbf *poll_dl_ass; /* (answer Pkt DL ASS with PKT CTRL ACK) */ struct gprs_rlcmac_ul_tbf *ul_ass; /* PCU grants USF/SBA: transmit Pkt Res Req (2phase access)*/ }; @@ -79,7 +80,7 @@ tbfs->poll_ul_ass = tbf_as_ul_tbf(node->tbf); break; case GPRS_RLCMAC_PDCH_ULC_POLL_DL_ASS: - /* TODO */ + tbfs->poll_dl_ass = node->tbf; break; case GPRS_RLCMAC_PDCH_ULC_POLL_UL_ACK: /* TS 44.060: 9.3.2.4.2 If the PACKET UPLINK ACK/NACK message @@ -203,6 +204,13 @@ gprs_rlcmac_ul_tbf_free(tbfs->poll_ul_ack); return msg; } + if (tbfs->poll_dl_ass) { + LOGRLCMAC(LOGL_DEBUG, "(ts=%u,fn=%u,usf=%u) Tx Pkt Control Ack (DL ASS poll)\n", + bi->ts, bi->fn, bi->usf); + msg = gprs_rlcmac_tbf_create_pkt_ctrl_ack(tbfs->poll_dl_ass); + if (msg) + return msg; + } if (tbfs->poll_ul_ass) { LOGRLCMAC(LOGL_DEBUG, "(ts=%u,fn=%u,usf=%u) Tx Pkt Control Ack (UL ASS poll)\n", bi->ts, bi->fn, bi->usf); @@ -259,9 +267,12 @@ static void rts_tick(const struct gprs_rlcmac_rts_block_ind *bi) { struct gprs_rlcmac_entity *gre; + llist_for_each_entry(gre, &g_ctx->gre_list, entry) { if (gre->ul_tbf && gprs_rlcmac_tbf_ul_ass_waiting_tbf_starting_time(gre->ul_tbf)) gprs_rlcmac_tbf_ul_ass_fn_tick(gre->ul_tbf, bi->fn, bi->ts); + if (gprs_rlcmac_tbf_start_pending(&gre->dl_tbf_start_fsm)) + gprs_rlcmac_tbf_start_fn_tick(&gre->dl_tbf_start_fsm, bi->fn, bi->ts); } } diff --git a/src/rlcmac/tbf_start_fsm.c b/src/rlcmac/tbf_start_fsm.c new file mode 100644 index 0000000..77492a8 --- /dev/null +++ b/src/rlcmac/tbf_start_fsm.c @@ -0,0 +1,343 @@ +/* TBF as per 3GPP TS 44.064 */ +/* + * (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <errno.h> +#include <talloc.h> +#include <osmocom/core/tdef.h> +#include <osmocom/core/fsm.h> +#include <osmocom/core/bitvec.h> + +#include <osmocom/gprs/rlcmac/types.h> +#include <osmocom/gprs/rlcmac/tbf_start_fsm.h> +#include <osmocom/gprs/rlcmac/tbf_dl.h> +#include <osmocom/gprs/rlcmac/gre.h> +#include <osmocom/gprs/rlcmac/sched.h> +#include <osmocom/gprs/rlcmac/csn1_defs.h> +#include <osmocom/gprs/rlcmac/rlcmac_enc.h> +#include <osmocom/gprs/rlcmac/pdch_ul_controller.h> + +#define X(s) (1 << (s)) + +static const struct value_string tbf_start_fsm_event_names[] = { + { GPRS_RLCMAC_TBF_START_EV_RX_CCCH_IMM_ASS, "RX_CCCH_IMM_ASS" }, + { GPRS_RLCMAC_TBF_START_EV_RX_PACCH_PKT_ASS, "RX_PACCH_PKT_ASS" }, + { GPRS_RLCMAC_TBF_START_EV_TBF_STARTING_TIME, "TBF_STARTING_TIME" }, + { 0, NULL } +}; + +static const struct osmo_tdef_state_timeout tbf_start_fsm_timeouts[32] = { + [GPRS_RLCMAC_TBF_START_ST_IDLE] = { }, + [GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME] = { }, + [GPRS_RLCMAC_TBF_START_ST_COMPL] = { }, +}; + +/* Transition to a state, using the T timer defined in tbf_fsm_timeouts. + * The actual timeout value is in turn obtained from conn->T_defs. + * Assumes local variable fi exists. */ + #define tbf_start_fsm_state_chg(fi, NEXT_STATE) \ + osmo_tdef_fsm_inst_state_chg(fi, NEXT_STATE, \ + tbf_start_fsm_timeouts, \ + g_ctx->T_defs, \ + -1) + +static int handle_imm_ass(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, const struct tbf_start_ev_rx_ccch_imm_ass_ctx *d) +{ + const Packet_Downlink_ImmAssignment_t *pkdlass; + + switch (d->iaro->UnionType) { + case 1: /* d->iaro->u.lh.* (IA_RestOctetsLH_t) */ + switch (d->iaro->u.lh.lh0x.UnionType) { + case 1: /* d->iaro->u.ll.lh0x.MultiBlock_PktDlAss.* (IA_MultiBlock_PktDlAss_t) */ + return -ENOTSUP; /* TODO */ + } + case 3: /* d->iaro->u.hh.* (IA_RestOctetsHH_t) */ + switch (d->iaro->u.hh.UnionType) { + case 0: /* d->iaro->u.hh.u.UplinkDownlinkAssignment.* (IA_PacketAssignment_UL_DL_t) */ + switch (d->iaro->u.hh.u.UplinkDownlinkAssignment.UnionType) { + case 1: /* d->iaro->u.hh.u.UplinkDownlinkAssignment.ul_dl.Packet_Downlink_ImmAssignment.* (Packet_Downlink_ImmAssignment_t) */ + pkdlass = &d->iaro->u.hh.u.UplinkDownlinkAssignment.ul_dl.Packet_Downlink_ImmAssignment; + ctx->alloc.dl_tfi = pkdlass->TFI_ASSIGNMENT; + + ctx->tbf_starting_time_exists = pkdlass->Exist_TBF_STARTING_TIME; + if (ctx->tbf_starting_time_exists) + ctx->tbf_starting_time = TBF_StartingTime_to_fn(&pkdlass->TBF_STARTING_TIME, d->fn); + + ctx->alloc.num_ts = 1; + ctx->alloc.ts[d->ts_nr].allocated = true; + LOGPFSML(ctx->fi, LOGL_INFO, "Got PCH IMM_ASS (DL_TBF): DL_TFI=%u TS=%u\n", + pkdlass->TFI_ASSIGNMENT, d->ts_nr); + return 0; + } + } + break; + } + + OSMO_ASSERT(0); + return -EFAULT; +} + +static int handle_pkt_dl_ass(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, const struct tbf_start_ev_rx_pacch_pkt_ass_ctx *d) +{ + + const Packet_Downlink_Assignment_t *dlass = &d->dl_block->u.Packet_Downlink_Assignment; + unsigned int i; + + if (dlass->Exist_DOWNLINK_TFI_ASSIGNMENT) + ctx->alloc.dl_tfi = dlass->DOWNLINK_TFI_ASSIGNMENT; + else + ctx->alloc.dl_tfi = 0xff; + + ctx->tbf_starting_time_exists = dlass->Exist_TBF_Starting_Time; + if (ctx->tbf_starting_time_exists) + ctx->tbf_starting_time = TBF_Starting_Frame_Number_to_fn(&dlass->TBF_Starting_Time, d->fn); + + ctx->alloc.num_ts = 0; + for (i = 0; i < 8; i++) { + ctx->alloc.ts[i].allocated = (dlass->TIMESLOT_ALLOCATION >> i) & 0x01; + if (ctx->alloc.ts[i].allocated) + ctx->alloc.num_ts++; + } + return 0; +} + +static void st_idle_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct gprs_rlcmac_tbf_start_fsm_ctx *ctx = (struct gprs_rlcmac_tbf_start_fsm_ctx *)fi->priv; + + /* Reset state: */ + ctx->tbf_starting_time_exists = false; + ctx->tbf_starting_time = 0; + ctx->ts_nr = 0; + memset(&ctx->alloc, 0, sizeof(ctx->alloc)); +} + +static void st_idle(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct gprs_rlcmac_tbf_start_fsm_ctx *ctx = (struct gprs_rlcmac_tbf_start_fsm_ctx *)fi->priv; + struct tbf_start_ev_rx_ccch_imm_ass_ctx *ev_ccch_imm_ass; + struct tbf_start_ev_rx_pacch_pkt_ass_ctx *ev_pacch_pkt_ass; + + switch (event) { + case GPRS_RLCMAC_TBF_START_EV_RX_CCCH_IMM_ASS: + ev_ccch_imm_ass = (struct tbf_start_ev_rx_ccch_imm_ass_ctx *)data; + if (handle_imm_ass(ctx, ev_ccch_imm_ass) < 0) + return; + memcpy(&ctx->iaro, ev_ccch_imm_ass->iaro, sizeof(ctx->iaro)); + if (ctx->tbf_starting_time_exists && + fn_cmp(ctx->tbf_starting_time, ev_ccch_imm_ass->fn) > 0) + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME); + else + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_COMPL); + break; + case GPRS_RLCMAC_TBF_START_EV_RX_PACCH_PKT_ASS: + ev_pacch_pkt_ass = (struct tbf_start_ev_rx_pacch_pkt_ass_ctx *)data; + if (handle_pkt_dl_ass(ctx, ev_pacch_pkt_ass) < 0) + return; + memcpy(&ctx->dl_block, ev_pacch_pkt_ass->dl_block, sizeof(ctx->dl_block)); + if (ctx->tbf_starting_time_exists && + fn_cmp(ctx->tbf_starting_time, ev_pacch_pkt_ass->fn) > 0) + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME); + else + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_COMPL); + break; + default: + OSMO_ASSERT(0); + } +} + +static void st_wait_tbf_starting_time(struct osmo_fsm_inst *fi, uint32_t event, void *data) +{ + struct gprs_rlcmac_tbf_start_fsm_ctx *ctx = (struct gprs_rlcmac_tbf_start_fsm_ctx *)fi->priv; + const struct tbf_start_ev_rx_ccch_imm_ass_ctx *ev_ccch_imm_ass; + struct tbf_start_ev_rx_pacch_pkt_ass_ctx *ev_pacch_pkt_ass; + + switch (event) { + case GPRS_RLCMAC_TBF_START_EV_RX_CCCH_IMM_ASS: + ev_ccch_imm_ass = (struct tbf_start_ev_rx_ccch_imm_ass_ctx *)data; + if (handle_imm_ass(ctx, ev_ccch_imm_ass) < 0) + return; + memcpy(&ctx->iaro, ev_ccch_imm_ass->iaro, sizeof(ctx->iaro)); + if (ctx->tbf_starting_time_exists && + fn_cmp(ctx->tbf_starting_time, ev_ccch_imm_ass->fn) > 0) + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME); + else + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_COMPL); + break; + case GPRS_RLCMAC_TBF_START_EV_RX_PACCH_PKT_ASS: + ev_pacch_pkt_ass = (struct tbf_start_ev_rx_pacch_pkt_ass_ctx *)data; + if (handle_pkt_dl_ass(ctx, ev_pacch_pkt_ass) < 0) + return; + memcpy(&ctx->dl_block, ev_pacch_pkt_ass->dl_block, sizeof(ctx->dl_block)); + if (ctx->tbf_starting_time_exists && + fn_cmp(ctx->tbf_starting_time, ev_pacch_pkt_ass->fn) > 0) + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME); + else + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_COMPL); + break; + case GPRS_RLCMAC_TBF_START_EV_TBF_STARTING_TIME: + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_COMPL); + break; + default: + OSMO_ASSERT(0); + } +} + +static void st_compl_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) +{ + struct gprs_rlcmac_tbf_start_fsm_ctx *ctx = (struct gprs_rlcmac_tbf_start_fsm_ctx *)fi->priv; + struct gprs_rlcmac_dl_tbf *dl_tbf; + + dl_tbf = gprs_rlcmac_dl_tbf_alloc(ctx->gre); + + /* Update TBF with allocated content: */ + memcpy(&dl_tbf->cur_alloc, &ctx->alloc, sizeof(ctx->alloc)); + + /* Replace old DL TBF with new one. 8.1.1.1.3: "the mobile station shall + * release all ongoing downlink TBFs not addressed by this message and + * shall act on the message. All ongoing uplink TBFs shall be maintained;" + */ + gprs_rlcmac_dl_tbf_free(ctx->gre->dl_tbf); + ctx->gre->dl_tbf = dl_tbf; + + /* Inform the main TBF state about the assignment completed: */ + osmo_fsm_inst_dispatch(dl_tbf->state_fsm.fi, GPRS_RLCMAC_TBF_UL_EV_DL_ASS_COMPL, NULL); + /* Go back to IDLE state. */ + tbf_start_fsm_state_chg(fi, GPRS_RLCMAC_TBF_START_ST_IDLE); +} + +static struct osmo_fsm_state tbf_start_fsm_states[] = { + [GPRS_RLCMAC_TBF_START_ST_IDLE] = { + .in_event_mask = + X(GPRS_RLCMAC_TBF_START_EV_RX_CCCH_IMM_ASS) | + X(GPRS_RLCMAC_TBF_START_EV_RX_PACCH_PKT_ASS), + .out_state_mask = + X(GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME) | + X(GPRS_RLCMAC_TBF_START_ST_COMPL), + .name = "IDLE", + .onenter = st_idle_on_enter, + .action = st_idle, + }, + [GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME] = { + .in_event_mask = + X(GPRS_RLCMAC_TBF_START_EV_RX_CCCH_IMM_ASS) | + X(GPRS_RLCMAC_TBF_START_EV_RX_PACCH_PKT_ASS) | + X(GPRS_RLCMAC_TBF_START_EV_TBF_STARTING_TIME), + .out_state_mask = + X(GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME) | + X(GPRS_RLCMAC_TBF_START_ST_COMPL), + .name = "WAIT_TBF_STARTING_TIME", + .action = st_wait_tbf_starting_time, + }, + [GPRS_RLCMAC_TBF_START_ST_COMPL] = { + .in_event_mask = 0, + .out_state_mask = + X(GPRS_RLCMAC_TBF_START_ST_IDLE), + .name = "COMPLETED", + .onenter = st_compl_on_enter, + }, +}; + + +static int tbf_start_fsm_timer_cb(struct osmo_fsm_inst *fi) +{ + //struct gprs_rlcmac_tbf_start_fsm_ctx *ctx = (struct gprs_rlcmac_tbf_start_fsm_ctx *)fi->priv; + switch (fi->T) { + default: + OSMO_ASSERT(0); + } + return 0; +} + +static struct osmo_fsm tbf_start_fsm = { + .name = "TBF_START", + .states = tbf_start_fsm_states, + .num_states = ARRAY_SIZE(tbf_start_fsm_states), + .timer_cb = tbf_start_fsm_timer_cb, + .log_subsys = DLGLOBAL, /* updated dynamically through gprs_rlcmac_tbf_start_fsm_set_log_cat() */ + .event_names = tbf_start_fsm_event_names, +}; + +int gprs_rlcmac_tbf_start_fsm_init(void) +{ + return osmo_fsm_register(&tbf_start_fsm); +} + +void gprs_rlcmac_tbf_start_fsm_set_log_cat(int logcat) +{ + tbf_start_fsm.log_subsys = logcat; +} + +int gprs_rlcmac_tbf_start_fsm_constructor(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, struct gprs_rlcmac_entity *gre) +{ + ctx->gre = gre; + ctx->fi = osmo_fsm_inst_alloc(&tbf_start_fsm, gre, ctx, LOGL_INFO, NULL); + if (!ctx->fi) + return -ENODATA; + + return 0; +} + +void gprs_rlcmac_tbf_start_fsm_destructor(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx) +{ + osmo_fsm_inst_free(ctx->fi); + ctx->fi = NULL; +} + +/* A DL TBF assaigned was received over CCCH. */ +int gprs_rlcmac_tbf_start_from_ccch(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, const struct tbf_start_ev_rx_ccch_imm_ass_ctx *d) +{ + int rc; + rc = osmo_fsm_inst_dispatch(ctx->fi, + GPRS_RLCMAC_TBF_START_EV_RX_CCCH_IMM_ASS, + (void *)d); + return rc; +} + +/* A DL TBF assaigned was received over PACCH (of an UL TBF or previous DL TBF). */ +int gprs_rlcmac_tbf_start_from_pacch(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, const struct tbf_start_ev_rx_pacch_pkt_ass_ctx *d) +{ + int rc; + rc = osmo_fsm_inst_dispatch(ctx->fi, + GPRS_RLCMAC_TBF_START_EV_RX_PACCH_PKT_ASS, + (void *)d); + return rc; +} + +bool gprs_rlcmac_tbf_start_pending(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx) +{ + return ctx->fi->state == GPRS_RLCMAC_TBF_START_ST_WAIT_TBF_STARTING_TIME; +} + +/* The scheduled ticks the new FN, which may trigger changes internally if TBF Starting Time is reached */ +void gprs_rlcmac_tbf_start_fn_tick(struct gprs_rlcmac_tbf_start_fsm_ctx *ctx, uint32_t fn, uint8_t ts_nr) +{ + OSMO_ASSERT(gprs_rlcmac_tbf_start_pending(ctx)); + if (fn != ctx->tbf_starting_time || + ts_nr != ctx->ts_nr) + return; + + osmo_fsm_inst_dispatch(ctx->fi, GPRS_RLCMAC_TBF_START_EV_TBF_STARTING_TIME, NULL); +} + +enum gprs_rlcmac_tbf_start_fsm_states gprs_rlcmac_tbf_start_state(const struct gprs_rlcmac_tbf_start_fsm_ctx *ctx) +{ + return ctx->fi->state; +} diff --git a/tests/rlcmac/rlcmac_prim_test.err b/tests/rlcmac/rlcmac_prim_test.err index 1aedd64..8f596ac 100644 --- a/tests/rlcmac/rlcmac_prim_test.err +++ b/tests/rlcmac/rlcmac_prim_test.err @@ -1,5 +1,6 @@ DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL INFO UL_TBF{NEW}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Received Event START @@ -64,8 +65,10 @@ DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{RELEASING}: Deallocated DLGLOBAL DEBUG Tx to lower layers: L1CTL-PDCH_DATA.request +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL INFO UL_TBF{NEW}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Received Event START @@ -152,8 +155,10 @@ DLGLOBAL NOTICE UL_TBF{FLOW}: TBF establishment failure (T3164 timeout attempts=4) DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{FLOW}: Deallocated +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL INFO UL_TBF{NEW}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Received Event START @@ -287,10 +292,12 @@ DLGLOBAL NOTICE UL_TBF{FLOW}: TBF establishment failure (T3166 timeout attempts=4) DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{FLOW}: Deallocated +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL DEBUG Rx from lower layers: L1CTL-CCCH_DATA.indication DLGLOBAL DEBUG Rx SI13 from lower layers DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL INFO UL_TBF{NEW}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Received Event START @@ -423,10 +430,12 @@ DLGLOBAL DEBUG Tx to lower layers: L1CTL-CFG_UL_TBF.request DLGLOBAL INFO UL_TBF{ASSIGN}: state_chg to FLOW DLGLOBAL INFO UL_TBF_ASS{COMPLETED}: state_chg to IDLE +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{FLOW}: Deallocated DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL INFO UL_TBF{NEW}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Received Event START @@ -484,8 +493,10 @@ DLGLOBAL INFO UL_TBF{FINISHED}: Timeout of T3182 DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{FINISHED}: Deallocated +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL INFO UL_TBF{NEW}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Received Event START @@ -587,8 +598,10 @@ DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{FINISHED}: Deallocated DLGLOBAL DEBUG Tx to lower layers: L1CTL-PDCH_DATA.request +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO Rx from upper layers: GRR-UNITDATA.request DLGLOBAL INFO TLLI=0x00002342 not found, creating entity on the fly +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL INFO UL_TBF{NEW}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Allocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Received Event START @@ -650,17 +663,22 @@ DLGLOBAL INFO UL_TBF_ASS{SCHED_PKT_RES_REQ}: Received Event CREATE_RLCMAC_MSG DLGLOBAL INFO UL_TBF_ASS{SCHED_PKT_RES_REQ}: state_chg to WAIT_PKT_UL_ASS DLGLOBAL DEBUG Tx to lower layers: L1CTL-PDCH_DATA.request +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO UL_TBF_ASS{WAIT_PKT_UL_ASS}: Deallocated DLGLOBAL INFO UL_TBF{ASSIGN}: Deallocated DLGLOBAL INFO Rx from upper layers: GMMRR-ASSIGN.request DLGLOBAL INFO GMMRR-ASSIGN.req: creating new entity TLLI=0x00000001 +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL DEBUG Rx from lower layers: L1CTL-CCCH_DATA.indication -DLGLOBAL INFO GRE(00000001) Got PCH IMM_ASS (DL_TBF): DL_TFI=0 TS=7 +DLGLOBAL INFO TBF_START{IDLE}: Received Event RX_CCCH_IMM_ASS +DLGLOBAL INFO TBF_START{IDLE}: Got PCH IMM_ASS (DL_TBF): DL_TFI=0 TS=7 +DLGLOBAL INFO TBF_START{IDLE}: state_chg to COMPLETED DLGLOBAL INFO DL_TBF{NEW}: Allocated DLGLOBAL INFO DL_TBF{NEW}: Received Event DL_ASS_COMPL DLGLOBAL INFO TBF(DL:NR-0:TLLI-00000001) Send L1CTL-CF_DL_TBF.req dl_slotmask=0x80 dl_tfi=0 DLGLOBAL DEBUG Tx to lower layers: L1CTL-CFG_DL_TBF.request DLGLOBAL INFO DL_TBF{NEW}: state_chg to FLOW +DLGLOBAL INFO TBF_START{COMPLETED}: state_chg to IDLE DLGLOBAL DEBUG Rx from lower layers: L1CTL-PDCH_DATA.indication DLGLOBAL DEBUG TBF(DL:NR-0:TLLI-00000001) Rx new DL data DLGLOBAL DEBUG TBF(DL:NR-0:TLLI-00000001) DL DATA TFI=0 received (V(Q)=0 .. V(R)=0) @@ -682,16 +700,21 @@ DLGLOBAL DEBUG (ts=7,fn=21,usf=0) Tx DL ACK/NACK FinalAck=1 DLGLOBAL DEBUG TBF(DL:NR-0:TLLI-00000001) - V(N): "IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIR" R=Received I=Invalid DLGLOBAL DEBUG Tx to lower layers: L1CTL-PDCH_DATA.request +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO DL_TBF{FINISHED}: Deallocated DLGLOBAL INFO Rx from upper layers: GMMRR-ASSIGN.request DLGLOBAL INFO GMMRR-ASSIGN.req: creating new entity TLLI=0x00000001 +DLGLOBAL INFO TBF_START{IDLE}: Allocated DLGLOBAL DEBUG Rx from lower layers: L1CTL-CCCH_DATA.indication -DLGLOBAL INFO GRE(00000001) Got PCH IMM_ASS (DL_TBF): DL_TFI=0 TS=7 +DLGLOBAL INFO TBF_START{IDLE}: Received Event RX_CCCH_IMM_ASS +DLGLOBAL INFO TBF_START{IDLE}: Got PCH IMM_ASS (DL_TBF): DL_TFI=0 TS=7 +DLGLOBAL INFO TBF_START{IDLE}: state_chg to COMPLETED DLGLOBAL INFO DL_TBF{NEW}: Allocated DLGLOBAL INFO DL_TBF{NEW}: Received Event DL_ASS_COMPL DLGLOBAL INFO TBF(DL:NR-0:TLLI-00000001) Send L1CTL-CF_DL_TBF.req dl_slotmask=0x80 dl_tfi=0 DLGLOBAL DEBUG Tx to lower layers: L1CTL-CFG_DL_TBF.request DLGLOBAL INFO DL_TBF{NEW}: state_chg to FLOW +DLGLOBAL INFO TBF_START{COMPLETED}: state_chg to IDLE DLGLOBAL DEBUG Rx from lower layers: L1CTL-PDCH_DATA.indication DLGLOBAL DEBUG TBF(DL:NR-0:TLLI-00000001) Rx new DL data DLGLOBAL DEBUG TBF(DL:NR-0:TLLI-00000001) DL DATA TFI=0 received (V(Q)=0 .. V(R)=0) @@ -751,6 +774,7 @@ DLGLOBAL INFO UL_TBF{FLOW}: Last UL block sent (CV=0), start T3182 DLGLOBAL INFO UL_TBF{FLOW}: state_chg to FINISHED DLGLOBAL DEBUG Tx to lower layers: L1CTL-PDCH_DATA.request +DLGLOBAL INFO TBF_START{IDLE}: Deallocated DLGLOBAL INFO DL_TBF{FINISHED}: Deallocated DLGLOBAL INFO UL_TBF_ASS{IDLE}: Deallocated DLGLOBAL INFO UL_TBF{FINISHED}: Deallocated -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Idafb4e37971e93c7e8667b8669a29755485e95bb Gerrit-Change-Number: 31757 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmocom-bb[master]: mobile: allow configuring local GSMTAP address
by osmith 08 Mar '23

08 Mar '23

Attention is currently required from: laforge, fixeria, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31661 ) Change subject: mobile: allow configuring local GSMTAP address ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia1555db653cf0bb20af74617f33aad31c971bfdb Gerrit-Change-Number: 31661 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 15:19:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-gsm-tester[master]: doc/manuals: set OSMO_REPOSITORY
by osmith 08 Mar '23

08 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 ) Change subject: doc/manuals: set OSMO_REPOSITORY ...................................................................... doc/manuals: set OSMO_REPOSITORY Fix uploading manuals to the wrong directory. Related: OS#5902 Change-Id: Ia9935e176ee7633270ccd2926d60d7f8cea822f8 --- M doc/manuals/Makefile 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified msuraev: Looks good to me, but someone else must approve diff --git a/doc/manuals/Makefile b/doc/manuals/Makefile index 0730411..8b548b6 100644 --- a/doc/manuals/Makefile +++ b/doc/manuals/Makefile @@ -5,4 +5,5 @@ ASCIIDOC_DEPS = $(srcdir)/chapters/*.adoc include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc +OSMO_REPOSITORY = osmo-gsm-tester include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ia9935e176ee7633270ccd2926d60d7f8cea822f8 Gerrit-Change-Number: 31728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-gsm-tester[master]: doc/manuals: set OSMO_REPOSITORY
by osmith 08 Mar '23

08 Mar '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 ) Change subject: doc/manuals: set OSMO_REPOSITORY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/31728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ia9935e176ee7633270ccd2926d60d7f8cea822f8 Gerrit-Change-Number: 31728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 15:16:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: TC_stats_conn_fail: fix for sccplite
by osmith 08 Mar '23

08 Mar '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31750 ) Change subject: bsc: TC_stats_conn_fail: fix for sccplite ...................................................................... bsc: TC_stats_conn_fail: fix for sccplite Change the test so OsmoBSC always sends an BSSAP Assignment Failure by setting the Data Indicator to an invalid value. Previously the test had assumed that OsmoBSC would always send an Assignment Failure when requesting CSD as it was not yet implemented. The test only passed by chance on AoIP: OsmoBSC rejects the CSD Assignment Request unless it has the Speech Codec List IE for AoIP. Related: OS#4393 Change-Id: Ia4e8ab01dbadae5c9d7a964c0760dd3b016ab606 --- M bsc/BSC_Tests.ttcn 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 5a22c00..bfab0fa 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2095,8 +2095,9 @@ f_statsd_reset(); - /* Establish SDCCH */ + /* Establish SDCCH (invalid DataIndicator for exp_fail) */ ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeCSD); + ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := 'ff'O; f_establish_fully(ass_cmd, exp_fail); /* Expect stats to be 0 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4e8ab01dbadae5c9d7a964c0760dd3b016ab606 Gerrit-Change-Number: 31750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: TC_stats_conn_fail: fix for sccplite
by osmith 08 Mar '23

08 Mar '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31750 ) Change subject: bsc: TC_stats_conn_fail: fix for sccplite ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4e8ab01dbadae5c9d7a964c0760dd3b016ab606 Gerrit-Change-Number: 31750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 15:15:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by pespin 08 Mar '23

08 Mar '23

Attention is currently required from: osmith, neels, laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 8: (1 comment) File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/9b399ded_6b9f79c7 PS8, Line 354: char *src; src_addr -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 15:03:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by pespin 08 Mar '23

08 Mar '23

Attention is currently required from: osmith, neels, laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 8: Code-Review-1 (2 comments) File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/45668a36_36336d93 PS8, Line 815: tgt = log_target_find(LOG_TGT_TYPE_GSMTAP, hostname); Now if you do: """ log gsmtap foobar 127.0.0.1 log gsmtap foobar 127.0.0.2 """ The second one is a noop, which is probably not expected. File utils/osmo-stat-dummy/osmo-stat-dummy.cfg: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/490da65a_8361f92d PS4, Line 1: log gsmtap 127.0.0.69 127.6.9.1 > Which one? I would really not add this here. The default of selecting source address based on routing makes a lot more sense than adding an ip addr which may not exist. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 15:03:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmocom-bb[master]: mobile: allow configuring local GSMTAP address
by pespin 08 Mar '23

08 Mar '23

Attention is currently required from: laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31661 ) Change subject: mobile: allow configuring local GSMTAP address ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia1555db653cf0bb20af74617f33aad31c971bfdb Gerrit-Change-Number: 31661 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 14:58:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0