osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31750 ) Change subject: bsc: TC_stats_conn_fail: fix for sccplite ...................................................................... bsc: TC_stats_conn_fail: fix for sccplite Change the test so OsmoBSC always sends an BSSAP Assignment Failure by setting the Data Indicator to an invalid value. Previously the test had assumed that OsmoBSC would always send an Assignment Failure when requesting CSD as it was not yet implemented. The test only passed by chance on AoIP: OsmoBSC rejects the CSD Assignment Request unless it has the Speech Codec List IE for AoIP. Related: OS#4393 Change-Id: Ia4e8ab01dbadae5c9d7a964c0760dd3b016ab606 --- M bsc/BSC_Tests.ttcn 1 file changed, 20 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 5a22c00..bfab0fa 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2095,8 +2095,9 @@ f_statsd_reset(); - /* Establish SDCCH */ + /* Establish SDCCH (invalid DataIndicator for exp_fail) */ ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelTypeCSD); + ass_cmd.pdu.bssmap.assignmentRequest.channelType.speechId_DataIndicator := 'ff'O; f_establish_fully(ass_cmd, exp_fail); /* Expect stats to be 0 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4e8ab01dbadae5c9d7a964c0760dd3b016ab606 Gerrit-Change-Number: 31750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged