March 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames
by laforge 22 Mar '23

22 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31805 ) Change subject: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: nice catch, thanks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibb7f0731c31e5a5cd2911f733da5510ce0f3a1d6 Gerrit-Change-Number: 31805 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:51:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31805 to look at the new patch set (#2). Change subject: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames ...................................................................... gsmtap.h: Define a packet type for encapsulation of GSM RLP frames This allows us to feed RLP frames (occurring in GSM CSD) into wireshark for dissection. Change-Id: Ibb7f0731c31e5a5cd2911f733da5510ce0f3a1d6 --- M include/osmocom/core/gsmtap.h M src/core/gsmtap_util.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/05/31805/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibb7f0731c31e5a5cd2911f733da5510ce0f3a1d6 Gerrit-Change-Number: 31805 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmocore[master]: logging: print talloc report on exit from vty test
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31868 ) Change subject: logging: print talloc report on exit from vty test ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31868 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5739bceb90d36164fd4cbf21242bbe26bd1e7075 Gerrit-Change-Number: 31868 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:42:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-trx: alloc/free burst buffers in trx_sched_set_lchan()
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31672 ) Change subject: osmo-bts-trx: alloc/free burst buffers in trx_sched_set_lchan() ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/31672/comment/0b23a505_f9d1cc05 PS4, Line 14: o that we can dynamically choose : buffer size depending on the channel mode (speech/data). I don't know if this is really an advantage. Sounds to me like we just put more load on the memory allocator and cause more memory fragmentation. There's nothing wrong with a TRX allocating the maximum buffer size for all the burst buffers it needs in the "worst case" scenario once at start-up, and then using them as needed. It's not like the total size of all those burst buffers is ever going to be of concern on any of our target platforms, right? It's not super critical, after all we're not activating/deactivating hundreds or thousands of timeslots per second. But still something to think about. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6a5f76023fc492786076a63016f81285b3576c33 Gerrit-Change-Number: 31672 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:41:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: osmo-bts-trx: properly activate [CBCH/]BCCH/CCCH
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31716 ) Change subject: osmo-bts-trx: properly activate [CBCH/]BCCH/CCCH ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id0c70d6a2b777a5117c85149bfa1b3a997299d1d Gerrit-Change-Number: 31716 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:38:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: fix pcu_l1if_tx_pch_dt(): use OSMO_STRLCPY_ARRAY
by fixeria 22 Mar '23

22 Mar '23

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31955 ) Change subject: fix pcu_l1if_tx_pch_dt(): use OSMO_STRLCPY_ARRAY ...................................................................... Abandoned Another patch was merged doing the same I9192d50dd78be0a72ffdb9bfb9ed66aef085bcf1. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I04a86c1e00fc0a4066564693f6b563c88bf4e46f Gerrit-Change-Number: 31955 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[M] Change in libosmocore[master]: GSMTAP: allow configuring src IP for log messages
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: osmith, neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 13: (1 comment) File src/vty/logging_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/0841e44a_3510402a PS13, Line 806: "log gsmta whether or not the feature is worth having has been debated/raised before. But what I really dislike is the syntax proposed here. Just a positional argument for the source IP address, without any kind of "qualifier". The order "dest src" is already unintuitive. and what if we ever want to make the destination port configurable? Would it then be "dst-ip src-ip dst-port", even more awkward ordering? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 13 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:35:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: fix pcu_l1if_tx_pch_dt(): use OSMO_STRLCPY_ARRAY
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31955 ) Change subject: fix pcu_l1if_tx_pch_dt(): use OSMO_STRLCPY_ARRAY ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I04a86c1e00fc0a4066564693f6b563c88bf4e46f Gerrit-Change-Number: 31955 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:31:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: obs: build_binpkg: add ubuntu 22.04
by laforge 22 Mar '23

22 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31910 ) Change subject: obs: build_binpkg: add ubuntu 22.04 ...................................................................... obs: build_binpkg: add ubuntu 22.04 Add it for debugging a build failure that we only saw on Ubuntu. Related: OS#5946 Change-Id: I4a927447d8f8b89411b93c563fbc6aa8d4998ffa --- M scripts/obs/build_binpkg.py M scripts/obs/data/build_binpkg.Dockerfile M scripts/obs/data/build_binpkg_manuals.Dockerfile M scripts/obs/lib/config.py 4 files changed, 22 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/obs/build_binpkg.py b/scripts/obs/build_binpkg.py index dcd6cdc..1ee9636 100755 --- a/scripts/obs/build_binpkg.py +++ b/scripts/obs/build_binpkg.py @@ -64,7 +64,7 @@ script_path = "data/build.sh" - if not distro.startswith("debian:"): + if not distro.startswith("debian:") and not distro.startswith("ubuntu:"): env["PACKAGEFORMAT"] = "rpm" if args.docker: diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index 925680d..bd12562 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -16,7 +16,7 @@ # to regenerate the manuals database when installing build dependencies. # SYS#5818: using almalinux:8 instead of centos:8 RUN case "$DISTRO" in \ - debian*) \ + debian*|ubuntu*) \ echo "path-exclude=/usr/share/man/*" \ > /etc/dpkg/dpkg.cfg.d/exclude-man-pages && \ rm -rf /usr/share/man/ && \ @@ -59,6 +59,12 @@ echo "deb https://downloads.osmocom.org/packages/osmocom:/master/Debian_11/ ./" \ > /etc/apt/sources.list.d/osmocom-master.list \ ;; \ + ubuntu:22.04) \ + apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb https://downloads.osmocom.org/packages/osmocom:/master/xUbuntu_22.04/ ./" \ + > /etc/apt/sources.list.d/osmocom-master.list \ + ;; \ almalinux:8) \ { echo "[network_osmocom_master]"; \ echo "name=osmocom:master"; \ diff --git a/scripts/obs/data/build_binpkg_manuals.Dockerfile b/scripts/obs/data/build_binpkg_manuals.Dockerfile index fd4c709..c2b1211 100644 --- a/scripts/obs/data/build_binpkg_manuals.Dockerfile +++ b/scripts/obs/data/build_binpkg_manuals.Dockerfile @@ -10,7 +10,7 @@ ARG DISTRO RUN case "$DISTRO" in \ - debian*) \ + debian*|ubuntu*) \ apt-get update && \ apt-get install -y --no-install-recommends \ osmo-gsm-manuals-dev \ diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 473916b..15e4d44 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -114,4 +114,5 @@ docker_distro_default = "debian:11" docker_distro_other = [ "almalinux:8", # instead of centos:8 (SYS#5818) + "ubuntu:22.04", ] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a927447d8f8b89411b93c563fbc6aa8d4998ffa Gerrit-Change-Number: 31910 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: obs: build_binpkg: add ubuntu 22.04
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/31910 ) Change subject: obs: build_binpkg: add ubuntu 22.04 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/31910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4a927447d8f8b89411b93c563fbc6aa8d4998ffa Gerrit-Change-Number: 31910 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:30:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0