March 2023 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: fix SimCardCommands.run_gsm(): always use CLA=0xa0
by laforge 22 Mar '23

22 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31813 ) Change subject: fix SimCardCommands.run_gsm(): always use CLA=0xa0 ...................................................................... fix SimCardCommands.run_gsm(): always use CLA=0xa0 Depending on the card type (SIM or USIM/ISUM), self.cla_byte may be either 0xa0 or 0x00. Sending RUN GSM ALGORITHM with CLA=0x00 fails with SW=6985 (Command not allowed), so let's make sure that we always use CLA=0xa0 regardless of the card type. Change-Id: Ia0abba136dbd4cdea8dbbc3c4d6abe12c2863680 --- M pySim/commands.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index d123e67..ba37876 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -407,7 +407,7 @@ if len(rand) != 32: raise ValueError('Invalid rand') self.select_path(['3f00', '7f20']) - return self._tp.send_apdu(self.cla_byte + '88000010' + rand) + return self._tp.send_apdu('a0' + '88000010' + rand) def authenticate(self, rand: str, autn: str, context='3g'): """Execute AUTHENTICATE (USIM/ISIM). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia0abba136dbd4cdea8dbbc3c4d6abe12c2863680 Gerrit-Change-Number: 31813 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: SimCardCommands.run_gsm(): use send_apdu_checksw()
by laforge 22 Mar '23

22 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31814 ) Change subject: SimCardCommands.run_gsm(): use send_apdu_checksw() ...................................................................... SimCardCommands.run_gsm(): use send_apdu_checksw() Change-Id: Ib713cf8154a3aba72bc5776a8d99ec47631ade28 --- M pySim/commands.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index ba37876..b0f8b39 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -407,7 +407,7 @@ if len(rand) != 32: raise ValueError('Invalid rand') self.select_path(['3f00', '7f20']) - return self._tp.send_apdu('a0' + '88000010' + rand) + return self._tp.send_apdu_checksw('a0' + '88000010' + rand, sw='9000') def authenticate(self, rand: str, autn: str, context='3g'): """Execute AUTHENTICATE (USIM/ISIM). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib713cf8154a3aba72bc5776a8d99ec47631ade28 Gerrit-Change-Number: 31814 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in pysim[master]: fix SimCardCommands.run_gsm(): always use CLA=0xa0
by laforge 22 Mar '23

22 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31813 ) Change subject: fix SimCardCommands.run_gsm(): always use CLA=0xa0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia0abba136dbd4cdea8dbbc3c4d6abe12c2863680 Gerrit-Change-Number: 31813 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: SimCardCommands.run_gsm(): use send_apdu_checksw()
by laforge 22 Mar '23

22 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31814 ) Change subject: SimCardCommands.run_gsm(): use send_apdu_checksw() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib713cf8154a3aba72bc5776a8d99ec47631ade28 Gerrit-Change-Number: 31814 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:57:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: pySim-shell.py: add a command for RUN GSM ALGORITHM
by laforge 22 Mar '23

22 Mar '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31815 ) Change subject: pySim-shell.py: add a command for RUN GSM ALGORITHM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7876d83d018aca79253784411d3a9d54a249a0a Gerrit-Change-Number: 31815 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:57:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: pespin, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ...................................................................... Patch Set 5: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/89786253_25e66897 PS5, Line 1267: && bts_internal_flag_get(lchan->ts->trx->bts, BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_TS101318))) { > same agreeing with pespin. The fact that the constant BTS_INTERNAL_FLAG_SPEECH_H_V1_RTP_TS101318 is ridiculously long makes it virtually impossible to write code that fits into a line. One could pooissibly use a local 'bts' variable to avoid the lchan->ts->trx->bts chain. Or one could have boolean variables for the results of bts_internal_flag_get and just use those boolean variables here, fitting in the same line as the OSMO_UNLIKELY(). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e Gerrit-Change-Number: 31417 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:56:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-pcu[master]: Makefile.am: remove phy specific EXTRA_DIST variables
by laforge 22 Mar '23

22 Mar '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31816 ) Change subject: Makefile.am: remove phy specific EXTRA_DIST variables ...................................................................... Makefile.am: remove phy specific EXTRA_DIST variables EXTRA_DIST should only list files that are not source, but should be distributed anyway. Listing the source files in _HEADERS and _SOURCES should be sufficient Change-Id: If8b9b8cfaad22a093a74c418651bc76f48f2d071 --- M src/Makefile.am 1 file changed, 13 insertions(+), 21 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/Makefile.am b/src/Makefile.am index 58d3bfa..21c37a6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -137,13 +137,6 @@ if ENABLE_SYSMODSP AM_CPPFLAGS += -I$(srcdir)/osmo-bts-sysmo -I$(SYSMOBTS_INCDIR) -EXTRA_DIST = \ - osmo-bts-sysmo/sysmo_l1_if.c \ - osmo-bts-sysmo/sysmo_l1_if.h \ - osmo-bts-sysmo/sysmo_l1_hw.c \ - osmo-bts-sysmo/femtobts.c \ - osmo-bts-sysmo/femtobts.h - noinst_HEADERS += \ osmo-bts-sysmo/sysmo_l1_if.h \ osmo-bts-sysmo/femtobts.h @@ -175,13 +168,6 @@ if ENABLE_LC15BTS_PHY AM_CPPFLAGS += $(LITECELL15_CFLAGS) -I$(srcdir)/osmo-bts-litecell15 -EXTRA_DIST = \ - osmo-bts-litecell15/lc15_l1_if.c \ - osmo-bts-litecell15/lc15_l1_if.h \ - osmo-bts-litecell15/lc15_l1_hw.c \ - osmo-bts-litecell15/lc15bts.c \ - osmo-bts-litecell15/lc15bts.h - noinst_HEADERS += \ osmo-bts-litecell15/lc15_l1_if.h \ osmo-bts-litecell15/lc15bts.h @@ -195,13 +181,6 @@ if ENABLE_OC2GBTS_PHY AM_CPPFLAGS += -I$(OC2G_INCDIR) -I$(srcdir)/osmo-bts-oc2g -EXTRA_DIST = \ - osmo-bts-oc2g/oc2g_l1_if.c \ - osmo-bts-oc2g/oc2g_l1_if.h \ - osmo-bts-oc2g/oc2g_l1_hw.c \ - osmo-bts-oc2g/oc2gbts.c \ - osmo-bts-oc2g/oc2gbts.h - noinst_HEADERS += \ osmo-bts-oc2g/oc2g_l1_if.h \ osmo-bts-oc2g/oc2gbts.h -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If8b9b8cfaad22a093a74c418651bc76f48f2d071 Gerrit-Change-Number: 31816 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-pcu[master]: Makefile.am: remove phy specific EXTRA_DIST variables
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31816 ) Change subject: Makefile.am: remove phy specific EXTRA_DIST variables ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: hasn't been merged since march 10. @dexter, was there any reason not to merge it? I'm merging it now. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If8b9b8cfaad22a093a74c418651bc76f48f2d071 Gerrit-Change-Number: 31816 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:54:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames
by fixeria 22 Mar '23

22 Mar '23

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31805 ) Change subject: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibb7f0731c31e5a5cd2911f733da5510ce0f3a1d6 Gerrit-Change-Number: 31805 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:52:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames
by laforge 22 Mar '23

22 Mar '23

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31805 ) Change subject: gsmtap.h: Define a packet type for encapsulation of GSM RLP frames ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > See also: https://gerrit.osmocom.org/c/libosmocore/+/31829. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibb7f0731c31e5a5cd2911f733da5510ce0f3a1d6 Gerrit-Change-Number: 31805 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 09:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0