November 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: soft_uart: make osmo_soft_uart_alloc() accept *cfg

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email ) Change subject: soft_uart: make osmo_soft_uart_alloc() accept *cfg ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: * mixes two different topics in one patch * please don't remove the name. In some of our intended use cases we have *many* instances of soft-uarts (e.g. a modem bank / RAS server, or a CSD<->modem IWF). * The fact that the code doesn't log anything using the logging framework is a bug (See my other comment regarding fprintf) * even just for state introspection like "show ..." vty commands a name is very useful adding the cfg argument can then be squashed in the original patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e78d60c747a8805064d5e4bacfd47a30bc65cba Gerrit-Change-Number: 35021 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: split osmo_soft_uart_enable()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35020?usp=email ) Change subject: soft_uart: split osmo_soft_uart_enable() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: can also be squashed -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ieacc7e639304eeb14fdb298c7e14d772c136ca6e Gerrit-Change-Number: 35020 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: add doxygen documentation

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35019?usp=email ) Change subject: soft_uart: add doxygen documentation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: likewise, please squash -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib0dcea0c35619bda5626cf75044000951b26485b Gerrit-Change-Number: 35019 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:08:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: add osmo_soft_uart_free()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35018?usp=email ) Change subject: soft_uart: add osmo_soft_uart_free() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: probably makes sesne to squash into the original patch -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2fdcf6116144d8f16cf4167c37cfa7215d16337f Gerrit-Change-Number: 35018 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[L] Change in libosmocore[master]: core: Add software UART implementation

by laforge

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email ) Change subject: core: Add software UART implementation ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: I think something like a soft-uart is an ideal candidate for some unit tests for decoding valid characters, handling parity error, overrun error, ... File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/177dad01_8b5e747a PS3, Line 132: TODO: verify parity not critical to get it merged: But do you still have on your agenda to implement this? https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/187a66db_ad266314 PS3, Line 138: fprintf(stderr, "framing e this was ok for a hack in my private branch, but we shouldn't merge code to master that prints directly to stderr... https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/79e5b6c8_467cd481 PS3, Line 181: if (!suart->tx.running) the transmit is not implemented at all? Please squash your additions/fixes into this patch so we don't merge incomplete code in a commit. https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/ed646dc4_30c0ca5f PS3, Line 203: /* FIXME: Tx */ likewise here. the function is a NOP. Please squash your implementation into the patch, thanks. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2ca95963fd5852ddb89bdd35b86b31489127fe84 Gerrit-Change-Number: 30763 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:07:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: tests/testsuite.at: remove copy-pasted 'touch experr'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email ) Change subject: tests/testsuite.at: remove copy-pasted 'touch experr' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3bdaf6db25e4a2995abdff5c859d4be023d45a9 Gerrit-Change-Number: 35017 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:04:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case

by lynxis lazus

Attention is currently required from: daniel, fixeria, laforge, neels. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email ) Change subject: hlr: add imsi unknown cause test case ...................................................................... Patch Set 2: (2 comments) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/77d6478f_1731… PS2, Line 991: > (i'm having a hard time to understand what the test does, maybe a brief comment?) Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/e36a6ef8_e57d… PS2, Line 1007: test > the new test seems to separate two TC_gsup_ul_unknown_imsi* that wanted to be very close together. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 13:31:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add imsi unknown cause test case

by lynxis lazus

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, neels. Hello Jenkins Builder, daniel, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by neels, Verified+1 by Jenkins Builder Change subject: hlr: add imsi unknown cause test case ...................................................................... hlr: add imsi unknown cause test case Check if the reject-cause is correct implement when the subscriber couldn't found. Depends-on: Icea39020c23fbbea9e92847df76af8986fdbf48a (osmo-hlr) Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a --- M hlr/HLR_Tests.ttcn 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/27569/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 year, 7 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add config option diameter_connect_timer

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email ) Change subject: osmo_dia2gsup: add config option diameter_connect_timer ...................................................................... osmo_dia2gsup: add config option diameter_connect_timer The diameter_connect_timer can be set to reduce the ttcn3 timing. Otherwise every test case would need to wait for at least one connect timer period to succeed. Related: OS#5657 Change-Id: I669a76022d866824e7b4e9f30dd7e51aa714ae7d --- M src/osmo_dia2gsup.erl 1 file changed, 20 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 90f5ddc..5a817fd 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -70,10 +70,12 @@ % DIAMETER side SvcName = ?MODULE, diameter:start_service(SvcName, ?SERVICE(SvcName)), + Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), Proto = application:get_env(osmo_dia2gsup, diameter_proto, sctp), - listen({address, Proto, element(2,inet:parse_address(Ip)), Port}), + ConnectTimer = application:get_env(osmo_dia2gsup, diameter_connect_timer, 30000), + listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), {ok, State}. @@ -114,14 +116,12 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -listen(Name, {address, Protocol, IPAddr, Port}) -> +listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer}) -> TransOpts = [{transport_module, tmod(Protocol)}, {transport_config, [{reuseaddr, true}, - {ip, IPAddr}, {port, Port}]}], + {ip, IPAddr}, {port, Port}]}, + {connect_timer, ConnectTimer}], {ok, _} = diameter:add_transport(Name, {listen, TransOpts}). -listen(Address) -> - listen(?SVC_NAME, Address). - tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I669a76022d866824e7b4e9f30dd7e51aa714ae7d Gerrit-Change-Number: 35002 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add config option diameter_connect_timer

by lynxis lazus

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email ) Change subject: osmo_dia2gsup: add config option diameter_connect_timer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I669a76022d866824e7b4e9f30dd7e51aa714ae7d Gerrit-Change-Number: 35002 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 16 Nov 2023 13:20:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023