November 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email ) Change subject: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES ...................................................................... [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES This is a hack allowing us to examine the receiver's internal buffer without having to wait for a timeout to expire. I am not sure if such mode would be useful for anything else. Maybe adding API to access the Rx msgb would be a more flexible solution? Change-Id: Ib3249a06c84f3ddb2723d0787db51873c4707d81 Related: OS#4396 --- M include/osmocom/core/soft_uart.h M src/core/soft_uart.c 2 files changed, 67 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/45/35045/1 diff --git a/include/osmocom/core/soft_uart.h b/include/osmocom/core/soft_uart.h index 6088922..19af0cf 100644 --- a/include/osmocom/core/soft_uart.h +++ b/include/osmocom/core/soft_uart.h @@ -45,6 +45,14 @@ }; #endif +/*! Rx data pulling mode */ +enum osmo_soft_uart_rx_mode { + /*! the .rx_cb() is called on timeout */ + OSMO_SUART_RX_MODE_TIMEOUT, + /*! the .rx_cb() is called on a specified number of UART frames */ + OSMO_SUART_RX_MODE_N_FRAMES, +}; + /* configuration for a soft-uart */ struct osmo_soft_uart_cfg { /*! number of data bits (typically 5, 6, 7 or 8) */ @@ -53,14 +61,25 @@ uint8_t num_stop_bits; /*! parity mode (none, even, odd) */ enum osmo_soft_uart_parity_mode parity_mode; + /*! size of transmit buffer */ unsigned int tx_buf_size; - /*! size of receive buffer; UART will buffer up to that number of characters - * before calling the receive call-back */ + /*! size of receive buffer */ unsigned int rx_buf_size; - /*! receive timeout; UART will flush receive buffer via the receive call-back - * after indicated number of milli-seconds even if it is not full yet */ - unsigned int rx_timeout_ms; + + /*! Rx data pulling mode */ + enum osmo_soft_uart_rx_mode rx_pull_mode; + /*! Rx data pulling parameters */ + union { + /*! receive timeout for OSMO_SUART_RX_MODE_TIMEOUT; UART will flush receive + * buffer via the receive call-back after indicated number of milli-seconds + * even if it is not full yet. */ + unsigned int rx_timeout_ms; + /*! number of received UART frames for OSMO_SUART_RX_MODE_N_FRAMES; UART + * will flush receive buffer via the receive call-back after indicated number + * of UART frames had been received. */ + unsigned int rx_n_uart_frames; + } rx_pull_param; /*! opaque application-private data; passed to call-backs */ void *priv; diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index 9b6ca05..c7179a6 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -47,6 +47,7 @@ unsigned int flags; unsigned int status; struct osmo_timer_list timer; + unsigned int n_uart_frames; enum suart_flow_state flow_state; } rx; struct { @@ -71,7 +72,8 @@ .parity_mode = OSMO_SUART_PARITY_NONE, .tx_buf_size = 1024, .rx_buf_size = 1024, - .rx_timeout_ms = 100, + .rx_pull_mode = OSMO_SUART_RX_MODE_TIMEOUT, + .rx_pull_param = { .rx_timeout_ms = 100 }, .priv = NULL, .rx_cb = NULL, .status_change_cb = NULL, @@ -105,12 +107,29 @@ msgb_put_u8(suart->rx.msg, ch); msg_len = msgb_length(suart->rx.msg); - /* first character in new message: start timer */ - if (msg_len == 1) { - osmo_timer_schedule(&suart->rx.timer, suart->cfg.rx_timeout_ms / 1000, - (suart->cfg.rx_timeout_ms % 1000) * 1000); - } else if (msg_len >= suart->cfg.rx_buf_size || suart->rx.flags) { + /* flush immediately: + * a) when the Rx buffer gets full; + * b) when a parity/framing error is occured. */ + if (msg_len >= suart->cfg.rx_buf_size || suart->rx.flags) { suart_flush_rx(suart); + return; + } + + switch (suart->cfg.rx_pull_mode) { + case OSMO_SUART_RX_MODE_TIMEOUT: + /* first character in new message: start timer */ + if (msg_len == 1) { + unsigned int rx_timeout_ms = suart->cfg.rx_pull_param.rx_timeout_ms; + osmo_timer_schedule(&suart->rx.timer, rx_timeout_ms / 1000, + (rx_timeout_ms % 1000) * 1000); + } + break; + case OSMO_SUART_RX_MODE_N_FRAMES: + if (suart->rx.n_uart_frames >= suart->cfg.rx_pull_param.rx_n_uart_frames) { + suart->rx.n_uart_frames = 0; + suart_flush_rx(suart); + } + break; } } @@ -171,6 +190,7 @@ if (suart->rx.bit_count >= (suart->cfg.num_data_bits + suart->cfg.num_stop_bits)) { /* we have accumulated enough stop bits */ + suart->rx.n_uart_frames++; suart_rx_ch(suart, suart->rx.shift_reg); suart->rx.flow_state = SUART_FLOW_ST_IDLE; } @@ -358,10 +378,12 @@ if (cfg->rx_buf_size == 0) return -EINVAL; +#if 0 if (suart->cfg.rx_buf_size > cfg->rx_buf_size || suart->cfg.rx_timeout_ms > cfg->rx_timeout_ms) { suart_flush_rx(suart); } +#endif suart->cfg = *cfg; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3249a06c84f3ddb2723d0787db51873c4707d81 Gerrit-Change-Number: 35045 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[L] Change in libosmocore[master]: soft_uart: add unit tests for the receiver and transmitter

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email ) Change subject: soft_uart: add unit tests for the receiver and transmitter ...................................................................... soft_uart: add unit tests for the receiver and transmitter Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Related: OS#4396 --- M tests/Makefile.am A tests/soft_uart/soft_uart_test.c A tests/soft_uart/soft_uart_test.ok M tests/testsuite.at 4 files changed, 283 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/35046/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 5f4914e..af17e50 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -55,6 +55,7 @@ v110/ra1_test \ gsm44021/frame_csd_test \ osmo_io/osmo_io_test \ + soft_uart/soft_uart_test \ $(NULL) if ENABLE_MSGFILE @@ -375,6 +376,8 @@ osmo_io_osmo_io_test_SOURCES = osmo_io/osmo_io_test.c +soft_uart_soft_uart_test_SOURCES = soft_uart/soft_uart_test.c + # The `:;' works around a Bash 3.2 bug when the output is not writeable. $(srcdir)/package.m4: $(top_srcdir)/configure.ac @@ -693,6 +696,8 @@ osmo_io/osmo_io_test \ >$(srcdir)/osmo_io/osmo_io_test.ok \ 2>$(srcdir)/osmo_io/osmo_io_test.err + soft_uart/soft_uart_test \ + >$(srcdir)/soft_uart/soft_uart.ok check-local: atconfig $(TESTSUITE) diff --git a/tests/soft_uart/soft_uart_test.c b/tests/soft_uart/soft_uart_test.c new file mode 100644 index 0000000..54d02b1 --- /dev/null +++ b/tests/soft_uart/soft_uart_test.c @@ -0,0 +1,211 @@ +/* + * (C) 2023 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * Author: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + */ + +#include <stdio.h> +#include <stdint.h> + +#include <osmocom/core/msgb.h> +#include <osmocom/core/utils.h> +#include <osmocom/core/soft_uart.h> + +static void suart_rx_cb(void *priv, struct msgb *msg, unsigned int flags) +{ + fprintf(stdout, "%s(flags=%02x): %s\n", + __func__, flags, msgb_hexdump(msg)); + msgb_free(msg); +} + +static const struct osmo_soft_uart_cfg suart_default_cfg = { + .num_data_bits = 8, + .num_stop_bits = 1, + .parity_mode = OSMO_SUART_PARITY_NONE, + .tx_buf_size = 1024, + .rx_buf_size = 1024, + .rx_pull_mode = OSMO_SUART_RX_MODE_N_FRAMES, + .rx_pull_param = { .rx_n_uart_frames = 1 }, + .rx_cb = &suart_rx_cb, +}; + +static void test_rx_exec(struct osmo_soft_uart *suart, + const char *input) +{ + for (unsigned int i = 0; input[i] != '\0'; i++) { + ubit_t ubit; + + switch (input[i]) { + case '0': + case '1': + ubit = input[i] - '0'; + osmo_soft_uart_rx_ubits(suart, &ubit, 1); + break; + case ' ': /* padding */ + continue; + default: + printf("%s() @ %u: unknown opcode '%c'\n", + __func__, i, input[i]); + break; + } + } +} + +static void test_rx(void) +{ + struct osmo_soft_uart_cfg cfg; + struct osmo_soft_uart *suart; + + suart = osmo_soft_uart_alloc(NULL, &suart_default_cfg); + OSMO_ASSERT(suart != NULL); + + osmo_soft_uart_set_rx(suart, true); + + printf("======== %s(): testing 8-N-1\n", __func__); + test_rx_exec(suart, + "111111111111" /* no data */ + "0 00010010 1" /* 'H' */ + "0 10100010 1" /* 'E' */ + "111111111111" /* no data */ + "0 00110010 1" /* 'L' */ + "0 00110010 1" /* 'L' */ + "111111111111" /* no data */ + "0 11110010 1" /* 'O' */ + ); + + printf("======== %s(): testing 8-N-2\n", __func__); + cfg = suart_default_cfg; + cfg.num_stop_bits = 2; + osmo_soft_uart_configure(suart, &cfg); + test_rx_exec(suart, + "1111111111111" /* no data */ + "0 00010010 11" /* 'H' */ + "0 10100010 11" /* 'E' */ + "0 00110010 11" /* 'L' */ + "0 00110010 11" /* 'L' */ + "0 11110010 11" /* 'O' */ + "1111111111111" /* no data */ + "1111111111111" /* no data */ + ); + + + printf("======== %s(): testing 8-E-1\n", __func__); + cfg = suart_default_cfg; + cfg.parity_mode = OSMO_SUART_PARITY_EVEN; + osmo_soft_uart_configure(suart, &cfg); + test_rx_exec(suart, + "0 00000000 1 1" /* invalid parity (odd) */ + "0 10000000 0 1" /* invalid parity (odd) */ + "0 11111111 1 1" /* invalid parity (odd) */ + "0 00000000 0 1" + "0 11111111 0 1" + "0 01010101 0 1" + "0 10101010 0 1" + "0 00000001 1 1" + "0 00000111 1 1" + "0 00011111 1 1" + "0 01111111 1 1" + ); + + printf("======== %s(): testing 8-O-1\n", __func__); + cfg = suart_default_cfg; + cfg.parity_mode = OSMO_SUART_PARITY_ODD; + osmo_soft_uart_configure(suart, &cfg); + test_rx_exec(suart, + "0 00000000 0 1" /* invalid parity (even) */ + "0 10000000 1 1" /* invalid parity (even) */ + "0 11111111 0 1" /* invalid parity (even) */ + "0 00000000 1 1" + "0 11111111 1 1" + "0 01010101 1 1" + "0 10101010 1 1" + "0 00000001 0 1" + "0 00000111 0 1" + "0 00011111 0 1" + "0 01111111 0 1" + ); + + osmo_soft_uart_free(suart); +} + +static void test_tx_exec(struct osmo_soft_uart *suart, + const char *tx_data, size_t tx_data_len, + unsigned int n_bits) +{ + ubit_t tx_buf[64]; + + OSMO_ASSERT((tx_data_len * n_bits) <= sizeof(tx_buf)); + + osmo_soft_uart_tx(suart, (const uint8_t *)tx_data, tx_data_len); + osmo_soft_uart_tx_ubits(suart, &tx_buf[0], n_bits * tx_data_len); + + printf("%s():", __func__); + for (size_t i = 0; i < (tx_data_len * n_bits); i += n_bits) + printf(" %s", osmo_ubit_dump(&tx_buf[i], n_bits)); + printf("\n"); +} + +static void test_tx_rx(void) +{ + struct osmo_soft_uart_cfg cfg; + struct osmo_soft_uart *suart; + + suart = osmo_soft_uart_alloc(NULL, &suart_default_cfg); + OSMO_ASSERT(suart != NULL); + + osmo_soft_uart_set_tx(suart, true); + + printf("======== %s(): testing 8-N-1\n", __func__); + test_tx_exec(suart, "\xde\xad\xbe\xef", 4, (1 + 8 + 1)); + test_tx_exec(suart, "\x00\xaa\x55\xff", 4, (1 + 8 + 1)); + + printf("======== %s(): testing 8-E-1\n", __func__); + cfg = suart_default_cfg; + cfg.parity_mode = OSMO_SUART_PARITY_EVEN; + osmo_soft_uart_configure(suart, &cfg); + test_tx_exec(suart, "\xde\xad\xbe\xef", 4, (1 + 8 + 1 + 1)); + test_tx_exec(suart, "\x00\xaa\x55\xff", 4, (1 + 8 + 1 + 1)); + + printf("======== %s(): testing 8-O-1\n", __func__); + cfg = suart_default_cfg; + cfg.parity_mode = OSMO_SUART_PARITY_ODD; + osmo_soft_uart_configure(suart, &cfg); + test_tx_exec(suart, "\xde\xad\xbe\xef", 4, (1 + 8 + 1 + 1)); + test_tx_exec(suart, "\x00\xaa\x55\xff", 4, (1 + 8 + 1 + 1)); + + printf("======== %s(): testing 8-N-2\n", __func__); + cfg = suart_default_cfg; + cfg.num_stop_bits = 2; + osmo_soft_uart_configure(suart, &cfg); + test_tx_exec(suart, "\xde\xad\xbe\xef", 4, (1 + 8 + 2)); + test_tx_exec(suart, "\x00\xaa\x55\xff", 4, (1 + 8 + 2)); + + printf("======== %s(): testing 6-N-1\n", __func__); + cfg = suart_default_cfg; + cfg.num_data_bits = 6; + osmo_soft_uart_configure(suart, &cfg); + test_tx_exec(suart, "\xde\xad\xbe\xef", 4, (1 + 6 + 1)); + test_tx_exec(suart, "\x00\xaa\x55\xff", 4, (1 + 6 + 1)); + + osmo_soft_uart_free(suart); +} + +int main(int argc, char **argv) +{ + test_rx(); + test_tx_rx(); + + return 0; +} diff --git a/tests/soft_uart/soft_uart_test.ok b/tests/soft_uart/soft_uart_test.ok new file mode 100644 index 0000000..b9eb0fd --- /dev/null +++ b/tests/soft_uart/soft_uart_test.ok @@ -0,0 +1,51 @@ +======== test_rx(): testing 8-N-1 +suart_rx_cb(flags=00): 48 +suart_rx_cb(flags=00): 45 +suart_rx_cb(flags=00): 4c +suart_rx_cb(flags=00): 4c +suart_rx_cb(flags=00): 4f +======== test_rx(): testing 8-N-2 +suart_rx_cb(flags=00): 48 +suart_rx_cb(flags=00): 45 +suart_rx_cb(flags=00): 4c +suart_rx_cb(flags=00): 4c +suart_rx_cb(flags=00): 4f +======== test_rx(): testing 8-E-1 +suart_rx_cb(flags=02): 00 +suart_rx_cb(flags=02): 01 +suart_rx_cb(flags=02): ff +suart_rx_cb(flags=00): 00 +suart_rx_cb(flags=00): ff +suart_rx_cb(flags=00): aa +suart_rx_cb(flags=00): 55 +suart_rx_cb(flags=00): 80 +suart_rx_cb(flags=00): e0 +suart_rx_cb(flags=00): f8 +suart_rx_cb(flags=00): fe +======== test_rx(): testing 8-O-1 +suart_rx_cb(flags=02): 00 +suart_rx_cb(flags=02): 01 +suart_rx_cb(flags=02): ff +suart_rx_cb(flags=00): 00 +suart_rx_cb(flags=00): ff +suart_rx_cb(flags=00): aa +suart_rx_cb(flags=00): 55 +suart_rx_cb(flags=00): 80 +suart_rx_cb(flags=00): e0 +suart_rx_cb(flags=00): f8 +suart_rx_cb(flags=00): fe +======== test_tx_rx(): testing 8-N-1 +test_tx_exec(): 0011110111 0101101011 0011111011 0111101111 +test_tx_exec(): 0000000001 0010101011 0101010101 0111111111 +======== test_tx_rx(): testing 8-E-1 +test_tx_exec(): 00111101101 01011010111 00111110101 01111011111 +test_tx_exec(): 00000000001 00101010101 01010101001 01111111101 +======== test_tx_rx(): testing 8-O-1 +test_tx_exec(): 00111101111 01011010101 00111110111 01111011101 +test_tx_exec(): 00000000011 00101010111 01010101011 01111111111 +======== test_tx_rx(): testing 8-N-2 +test_tx_exec(): 00111101111 01011010111 00111110111 01111011111 +test_tx_exec(): 00000000011 00101010111 01010101011 01111111111 +======== test_tx_rx(): testing 6-N-1 +test_tx_exec(): 00111101 01011011 00111111 01111011 +test_tx_exec(): 00000001 00101011 01010101 01111111 diff --git a/tests/testsuite.at b/tests/testsuite.at index 73c3cdc..aacdad7 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -513,3 +513,9 @@ cat $abs_srcdir/osmo_io/osmo_io_test.err > experr AT_CHECK([$abs_top_builddir/tests/osmo_io/osmo_io_test], [0], [expout], [experr]) AT_CLEANUP + +AT_SETUP([soft_uart]) +AT_KEYWORDS([soft_uart]) +cat $abs_srcdir/soft_uart/soft_uart_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/soft_uart/soft_uart_test], [0], [expout], [ignore]) +AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35046?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icdfa0c644548964d37940c32dc9dcfcfc53c3a19 Gerrit-Change-Number: 35046 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: add osmo_soft_uart_free()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35018?usp=email ) Change subject: soft_uart: add osmo_soft_uart_free() ...................................................................... soft_uart: add osmo_soft_uart_free() Change-Id: I2fdcf6116144d8f16cf4167c37cfa7215d16337f Related: OS#4396 --- M include/osmocom/core/soft_uart.h M src/core/libosmocore.map M src/core/soft_uart.c 3 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/18/35018/1 diff --git a/include/osmocom/core/soft_uart.h b/include/osmocom/core/soft_uart.h index 36a43fe..4f9c1fc 100644 --- a/include/osmocom/core/soft_uart.h +++ b/include/osmocom/core/soft_uart.h @@ -75,6 +75,7 @@ struct osmo_soft_uart; struct osmo_soft_uart *osmo_soft_uart_alloc(void *ctx, const char *name); +void osmo_soft_uart_free(struct osmo_soft_uart *suart); int osmo_soft_uart_configure(struct osmo_soft_uart *suart, const struct osmo_soft_uart_cfg *cfg); int osmo_soft_uart_enable(struct osmo_soft_uart *suart, bool rx, bool tx); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index c08d3ff..142e4c4 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -440,6 +440,7 @@ osmo_sock_unix_init; osmo_sock_unix_init_ofd; osmo_soft_uart_alloc; +osmo_soft_uart_free; osmo_soft_uart_configure; osmo_soft_uart_enable; osmo_soft_uart_rx_ubits; diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index 1a65243..e97ad2f 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -222,6 +222,20 @@ return suart; } +/*! Release memory taken by the given soft-UART. + * \param[in] suart soft-UART instance to be free()d. */ +void osmo_soft_uart_free(struct osmo_soft_uart *suart) +{ + if (suart == NULL) + return; + + osmo_timer_del(&suart->rx.timer); + msgb_free(suart->rx.msg); + + talloc_free((void *)suart->name); + talloc_free(suart); +} + /*! change soft-UART configuration to user-provided config */ int osmo_soft_uart_configure(struct osmo_soft_uart *suart, const struct osmo_soft_uart_cfg *cfg) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2fdcf6116144d8f16cf4167c37cfa7215d16337f Gerrit-Change-Number: 35018 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: tests/testsuite.at: remove copy-pasted 'touch experr'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email ) Change subject: tests/testsuite.at: remove copy-pasted 'touch experr' ...................................................................... tests/testsuite.at: remove copy-pasted 'touch experr' Doing this after creating a file yields nothing. Change-Id: Ib3bdaf6db25e4a2995abdff5c859d4be023d45a9 --- M tests/testsuite.at 1 file changed, 11 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/35017/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index 3366995..73c3cdc 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -355,7 +355,6 @@ AT_KEYWORDS([socket]) cat $abs_srcdir/socket/socket_test.ok > expout cat $abs_srcdir/socket/socket_test.err > experr -touch experr AT_CHECK([$abs_top_builddir/tests/socket/socket_test], [0], [expout], [experr]) AT_CLEANUP @@ -364,7 +363,6 @@ AT_SKIP_IF([! test -e $abs_top_builddir/tests/socket/socket_sctp_test]) cat $abs_srcdir/socket/socket_sctp_test.ok > expout cat $abs_srcdir/socket/socket_sctp_test.err > experr -touch experr AT_CHECK([$abs_top_builddir/tests/socket/socket_sctp_test], [0], [expout], [experr]) AT_CLEANUP @@ -513,6 +511,5 @@ AT_KEYWORDS([osmo_io]) cat $abs_srcdir/osmo_io/osmo_io_test.ok > expout cat $abs_srcdir/osmo_io/osmo_io_test.err > experr -touch experr AT_CHECK([$abs_top_builddir/tests/osmo_io/osmo_io_test], [0], [expout], [experr]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3bdaf6db25e4a2995abdff5c859d4be023d45a9 Gerrit-Change-Number: 35017 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: add doxygen documentation

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35019?usp=email ) Change subject: soft_uart: add doxygen documentation ...................................................................... soft_uart: add doxygen documentation Change-Id: Ib0dcea0c35619bda5626cf75044000951b26485b Related: OS#4396 --- M src/core/soft_uart.c 1 file changed, 42 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/19/35019/1 diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index e97ad2f..a668b21 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -26,7 +26,7 @@ #include <osmocom/core/timer.h> #include <osmocom/core/soft_uart.h> -/*! one instance of a soft-uart */ +/*! Internal state of a soft-UART */ struct osmo_soft_uart { struct osmo_soft_uart_cfg cfg; const char *name; @@ -49,6 +49,7 @@ } tx; }; +/*! Default soft-UART configuration (8-N-1) */ static struct osmo_soft_uart_cfg suart_default_cfg = { .num_data_bits = 8, .num_stop_bits = 1, @@ -154,7 +155,11 @@ suart_flush_rx(suart); } -/*! feed a number of unpacked bits into the soft-uart receiver */ +/*! Feed a number of unpacked bits into the soft-UART receiver. + * \param[in] suart soft-UART instance to feed bits into. + * \param[in] ubits pointer to the unpacked bits. + * \param[in] n_ubits number of unpacked bits to be fed. + * \returns 0 on success; negative on error. */ int osmo_soft_uart_rx_ubits(struct osmo_soft_uart *suart, const ubit_t *ubits, size_t n_ubits) { for (size_t i = 0; i < n_ubits; i++) { @@ -167,7 +172,9 @@ * Transmitter *************************************************************************/ -/*! enqueue the given message buffer into the transmit queue of the UART. */ +/*! Enqueue the given message buffer into the transmit queue of the soft-UART. + * \param[in] suart soft-UART instance for transmitting data. + * \param[in] tx_data message buffer containing to be transmitted data. */ void osmo_soft_uart_tx(struct osmo_soft_uart *suart, struct msgb *tx_data) { if (!suart->tx.msg) @@ -190,7 +197,11 @@ return 1; } -/*! pull then number of specified unpacked bits out of the UART Transmitter */ +/*! Pull a number of unpacked bits out of the soft-UART transmitter. + * \param[in] suart soft-UART instance to pull the bits from. + * \param[out] ubits pointer to a buffer where to store pulled bits. + * \param[in] n_ubits number of unpacked bits to be pulled. + * \returns number of unpacked bits pulled; negative on error. */ int osmo_soft_uart_tx_ubits(struct osmo_soft_uart *suart, ubit_t *ubits, size_t n_ubits) { for (size_t i = 0; i < n_ubits; i++) { @@ -199,7 +210,10 @@ return n_ubits; } -/*! Set the modem status lines of the UART */ +/*! Set the modem status lines of the given soft-UART. + * \param[in] suart soft-UART instance to update the modem status. + * \param[in] status mask of osmo_soft_uart_status. + * \returns 0 on success; negative on error. */ int osmo_soft_uart_set_status(struct osmo_soft_uart *suart, unsigned int status) { /* FIXME: Tx */ @@ -211,6 +225,10 @@ * Management / Initialization *************************************************************************/ +/*! Allocate a soft-UART instance. + * \param[in] ctx parent talloc context. + * \param[in] name name of the soft-UART instance. + * \returns pointer to allocated soft-UART instance; NULL on error. */ struct osmo_soft_uart *osmo_soft_uart_alloc(void *ctx, const char *name) { struct osmo_soft_uart *suart = talloc_zero(ctx, struct osmo_soft_uart); @@ -236,7 +254,10 @@ talloc_free(suart); } -/*! change soft-UART configuration to user-provided config */ +/*! Change soft-UART configuration to the user-provided config. + * \param[in] suart soft-UART instance to be re-configured. + * \param[in] cfg the user-provided config to be applied. + * \returns 0 on success; negative on error. */ int osmo_soft_uart_configure(struct osmo_soft_uart *suart, const struct osmo_soft_uart_cfg *cfg) { /* consistency checks on the configuration */ @@ -262,6 +283,11 @@ return 0; } +/*! Enable/disable receiver and/or transmitter of the given soft-UART. + * \param[in] suart soft-UART instance to be re-configured. + * \param[in] rx enable/disable state of the receiver. + * \param[in] tx enable/disable state of the transmitter. + * \returns 0 on success; negative on error. */ int osmo_soft_uart_enable(struct osmo_soft_uart *suart, bool rx, bool tx) { if (!rx && suart->rx.running) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib0dcea0c35619bda5626cf75044000951b26485b Gerrit-Change-Number: 35019 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: make osmo_soft_uart_alloc() accept *cfg

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email ) Change subject: soft_uart: make osmo_soft_uart_alloc() accept *cfg ...................................................................... soft_uart: make osmo_soft_uart_alloc() accept *cfg I cannot see how naming soft-UART instances would be useful, given that currently we're not logging anything. What I find useful is having access to the default configuration and being able to configure soft-UART at the allocation time. Change-Id: I7e78d60c747a8805064d5e4bacfd47a30bc65cba Related: OS#4396 --- M include/osmocom/core/soft_uart.h M src/core/libosmocore.map M src/core/soft_uart.c 3 files changed, 23 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/21/35021/1 diff --git a/include/osmocom/core/soft_uart.h b/include/osmocom/core/soft_uart.h index 71846ed..df14648 100644 --- a/include/osmocom/core/soft_uart.h +++ b/include/osmocom/core/soft_uart.h @@ -74,7 +74,9 @@ struct osmo_soft_uart; -struct osmo_soft_uart *osmo_soft_uart_alloc(void *ctx, const char *name); +extern const struct osmo_soft_uart_cfg osmo_soft_uart_default_cfg; + +struct osmo_soft_uart *osmo_soft_uart_alloc(void *ctx, const struct osmo_soft_uart_cfg *cfg); void osmo_soft_uart_free(struct osmo_soft_uart *suart); int osmo_soft_uart_configure(struct osmo_soft_uart *suart, const struct osmo_soft_uart_cfg *cfg); int osmo_soft_uart_set_rx(struct osmo_soft_uart *suart, bool enable); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index e2aef39..a9d25fb 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -439,6 +439,7 @@ osmo_sock_set_priority; osmo_sock_unix_init; osmo_sock_unix_init_ofd; +osmo_soft_uart_default_cfg; osmo_soft_uart_alloc; osmo_soft_uart_free; osmo_soft_uart_configure; diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index fcc90b2..4633691 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -29,7 +29,6 @@ /*! Internal state of a soft-UART */ struct osmo_soft_uart { struct osmo_soft_uart_cfg cfg; - const char *name; struct { bool running; uint8_t bit_count; @@ -50,7 +49,7 @@ }; /*! Default soft-UART configuration (8-N-1) */ -static struct osmo_soft_uart_cfg suart_default_cfg = { +const struct osmo_soft_uart_cfg osmo_soft_uart_default_cfg = { .num_data_bits = 8, .num_stop_bits = 1, .parity_mode = OSMO_SUART_PARITY_NONE, @@ -227,15 +226,14 @@ /*! Allocate a soft-UART instance. * \param[in] ctx parent talloc context. - * \param[in] name name of the soft-UART instance. + * \param[in] cfg initial configuration of the soft-UART instance. * \returns pointer to allocated soft-UART instance; NULL on error. */ -struct osmo_soft_uart *osmo_soft_uart_alloc(void *ctx, const char *name) +struct osmo_soft_uart *osmo_soft_uart_alloc(void *ctx, const struct osmo_soft_uart_cfg *cfg) { struct osmo_soft_uart *suart = talloc_zero(ctx, struct osmo_soft_uart); if (!suart) return NULL; - suart->name = talloc_strdup(suart, name); - suart->cfg = suart_default_cfg; + suart->cfg = *cfg; return suart; } @@ -249,8 +247,6 @@ osmo_timer_del(&suart->rx.timer); msgb_free(suart->rx.msg); - - talloc_free((void *)suart->name); talloc_free(suart); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e78d60c747a8805064d5e4bacfd47a30bc65cba Gerrit-Change-Number: 35021 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: split osmo_soft_uart_enable()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35020?usp=email ) Change subject: soft_uart: split osmo_soft_uart_enable() ...................................................................... soft_uart: split osmo_soft_uart_enable() The problem with a single function controlling both Rx and Tx is that enabling/disabling one of the directions requires knowing state of the other one. In other words, disabling Tx requires knowing the state of Rx, which may be inconvenient. Change-Id: Ieacc7e639304eeb14fdb298c7e14d772c136ca6e Related: OS#4396 --- M include/osmocom/core/soft_uart.h M src/core/libosmocore.map M src/core/soft_uart.c 3 files changed, 35 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/20/35020/1 diff --git a/include/osmocom/core/soft_uart.h b/include/osmocom/core/soft_uart.h index 4f9c1fc..71846ed 100644 --- a/include/osmocom/core/soft_uart.h +++ b/include/osmocom/core/soft_uart.h @@ -77,7 +77,8 @@ struct osmo_soft_uart *osmo_soft_uart_alloc(void *ctx, const char *name); void osmo_soft_uart_free(struct osmo_soft_uart *suart); int osmo_soft_uart_configure(struct osmo_soft_uart *suart, const struct osmo_soft_uart_cfg *cfg); -int osmo_soft_uart_enable(struct osmo_soft_uart *suart, bool rx, bool tx); +int osmo_soft_uart_set_rx(struct osmo_soft_uart *suart, bool enable); +int osmo_soft_uart_set_tx(struct osmo_soft_uart *suart, bool enable); int osmo_soft_uart_rx_ubits(struct osmo_soft_uart *suart, const ubit_t *ubits, size_t n_ubits); int osmo_soft_uart_tx_ubits(struct osmo_soft_uart *suart, ubit_t *ubits, size_t n_ubits); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 142e4c4..e2aef39 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -442,7 +442,8 @@ osmo_soft_uart_alloc; osmo_soft_uart_free; osmo_soft_uart_configure; -osmo_soft_uart_enable; +osmo_soft_uart_set_rx; +osmo_soft_uart_set_tx; osmo_soft_uart_rx_ubits; osmo_soft_uart_tx_ubits; osmo_soft_uart_tx; diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index a668b21..fcc90b2 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -283,26 +283,34 @@ return 0; } -/*! Enable/disable receiver and/or transmitter of the given soft-UART. +/*! Enable/disable receiver of the given soft-UART. * \param[in] suart soft-UART instance to be re-configured. - * \param[in] rx enable/disable state of the receiver. - * \param[in] tx enable/disable state of the transmitter. + * \param[in] enable enable/disable state of the receiver. * \returns 0 on success; negative on error. */ -int osmo_soft_uart_enable(struct osmo_soft_uart *suart, bool rx, bool tx) +int osmo_soft_uart_set_rx(struct osmo_soft_uart *suart, bool enable) { - if (!rx && suart->rx.running) { + if (!enable && suart->rx.running) { suart_flush_rx(suart); suart->rx.running = false; - } else if (rx && !suart->rx.running) { + } else if (enable && !suart->rx.running) { if (!suart->rx.msg) suart->rx.msg = msgb_alloc_c(suart, suart->cfg.rx_buf_size, "soft_uart rx"); suart->rx.running = true; } - if (!tx && suart->tx.running) { + return 0; +} + +/*! Enable/disable transmitter of the given soft-UART. + * \param[in] suart soft-UART instance to be re-configured. + * \param[in] enable enable/disable state of the transmitter. + * \returns 0 on success; negative on error. */ +int osmo_soft_uart_set_tx(struct osmo_soft_uart *suart, bool enable) +{ + if (!enable && suart->tx.running) { /* FIXME: Tx */ suart->tx.running = false; - } else if (tx && !suart->tx.running) { + } else if (enable && !suart->tx.running) { suart->tx.running = true; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ieacc7e639304eeb14fdb298c7e14d772c136ca6e Gerrit-Change-Number: 35020 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[S] Change in libosmocore[master]: soft_uart: implement parity checking for the receiver

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35023?usp=email ) Change subject: soft_uart: implement parity checking for the receiver ...................................................................... soft_uart: implement parity checking for the receiver Change-Id: I28be2ca19d423447a718fb518566d52ae1967ec7 Related: OS#4396 --- M src/core/soft_uart.c 1 file changed, 31 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/35023/1 diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index 2f5084d..d92b8bc 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -42,7 +42,7 @@ uint8_t bit_count; uint8_t shift_reg; struct msgb *msg; - ubit_t parity_bit; + ubit_t parity_bit; /* 0 (even) / 1 (odd) */ unsigned int flags; unsigned int status; struct osmo_timer_list timer; @@ -119,13 +119,16 @@ suart->rx.flags = 0x00; suart->rx.shift_reg = 0; suart->rx.bit_count = 0; + suart->rx.parity_bit = 0; } break; case SUART_FLOW_ST_DATA: suart->rx.bit_count++; suart->rx.shift_reg >>= 1; - if (bit != 0) + if (bit != 0) { + suart->rx.parity_bit = !suart->rx.parity_bit; /* flip */ suart->rx.shift_reg |= 0x80; + } if (suart->rx.bit_count >= suart->cfg.num_data_bits) { /* we have accumulated enough data bits */ if (suart->cfg.parity_mode != OSMO_SUART_PARITY_NONE) @@ -135,7 +138,22 @@ } break; case SUART_FLOW_ST_PARITY: - /* TODO: actually verify parity */ + switch (suart->cfg.parity_mode) { + case OSMO_SUART_PARITY_EVEN: + /* number of 1-bits (in both data and parity) shall be even */ + if (suart->rx.parity_bit != bit) + suart->rx.flags |= OSMO_SUART_F_PARITY_ERROR; + break; + case OSMO_SUART_PARITY_ODD: + /* number of 1-bits (in both data and parity) shall be odd */ + if (suart->rx.parity_bit == bit) + suart->rx.flags |= OSMO_SUART_F_PARITY_ERROR; + break; + case OSMO_SUART_PARITY_NONE: /* shall not happen */ + default: + OSMO_ASSERT(0); + } + suart->rx.flow_state = SUART_FLOW_ST_STOP; break; case SUART_FLOW_ST_STOP: -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I28be2ca19d423447a718fb518566d52ae1967ec7 Gerrit-Change-Number: 35023 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[M] Change in libosmocore[master]: soft_uart: rework osmo_uart_rx_bit() to use flow state

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email ) Change subject: soft_uart: rework osmo_uart_rx_bit() to use flow state ...................................................................... soft_uart: rework osmo_uart_rx_bit() to use flow state Change-Id: I40ab5d12b6f7087daa51405468f5c4ea639561ea Related: OS#4396 --- M src/core/soft_uart.c 1 file changed, 55 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/35022/1 diff --git a/src/core/soft_uart.c b/src/core/soft_uart.c index 4633691..2f5084d 100644 --- a/src/core/soft_uart.c +++ b/src/core/soft_uart.c @@ -26,6 +26,14 @@ #include <osmocom/core/timer.h> #include <osmocom/core/soft_uart.h> +/*! Rx/Tx flow state of a soft-UART */ +enum suart_flow_state { + SUART_FLOW_ST_IDLE, /*!< waiting for a start bit or Tx data */ + SUART_FLOW_ST_DATA, /*!< receiving/transmitting data bits */ + SUART_FLOW_ST_PARITY, /*!< receiving/transmitting parity bits */ + SUART_FLOW_ST_STOP, /*!< receiving/transmitting stop bits */ +}; + /*! Internal state of a soft-UART */ struct osmo_soft_uart { struct osmo_soft_uart_cfg cfg; @@ -38,6 +46,7 @@ unsigned int flags; unsigned int status; struct osmo_timer_list timer; + enum suart_flow_state flow_state; } rx; struct { bool running; @@ -100,50 +109,46 @@ /* receive a single bit */ static inline void osmo_uart_rx_bit(struct osmo_soft_uart *suart, const ubit_t bit) { - unsigned int num_parity_bits = 0; - if (!suart->rx.running) return; - if (suart->rx.bit_count == 0) { - /* start bit is 0. Wait if there is none */ - if (bit == 0) { - /* START bit */ - suart->rx.flags = 0; + switch (suart->rx.flow_state) { + case SUART_FLOW_ST_IDLE: + if (bit == 0) { /* start bit condition */ + suart->rx.flow_state = SUART_FLOW_ST_DATA; + suart->rx.flags = 0x00; suart->rx.shift_reg = 0; - suart->rx.bit_count++; - } - return; - } - - if (suart->cfg.parity_mode != OSMO_SUART_PARITY_NONE) - num_parity_bits = 1; - - suart->rx.bit_count++; - if (suart->rx.bit_count <= 1 + suart->cfg.num_data_bits) { - /* DATA bit */ - suart->rx.shift_reg = suart->rx.shift_reg >> 1; - if (bit) - suart->rx.shift_reg |= 0x80; - } else if (suart->cfg.parity_mode != OSMO_SUART_PARITY_NONE && - suart->rx.bit_count == 1 + suart->cfg.num_data_bits + 1) { - /* PARITY bit */ - suart->rx.parity_bit = bit; - /* TODO: verify parity */ - //suart->rx.flags |= OSMO_SUART_F_PARITY_ERROR; - } else if (suart->rx.bit_count <= - 1 + suart->cfg.num_data_bits + num_parity_bits + suart->cfg.num_stop_bits) { - /* STOP bit */ - if (bit != 1) { - fprintf(stderr, "framing error: stop bit %u != 1\n", suart->rx.bit_count); - suart->rx.flags |= OSMO_SUART_F_FRAMING_ERROR; - } - - if (suart->rx.bit_count == 1 + suart->cfg.num_data_bits + num_parity_bits + suart->cfg.num_stop_bits) { - //printf("Rx: 0x%02x %c\n", suart->rx.shift_reg, suart->rx.shift_reg); - suart_rx_ch(suart, suart->rx.shift_reg); suart->rx.bit_count = 0; } + break; + case SUART_FLOW_ST_DATA: + suart->rx.bit_count++; + suart->rx.shift_reg >>= 1; + if (bit != 0) + suart->rx.shift_reg |= 0x80; + if (suart->rx.bit_count >= suart->cfg.num_data_bits) { + /* we have accumulated enough data bits */ + if (suart->cfg.parity_mode != OSMO_SUART_PARITY_NONE) + suart->rx.flow_state = SUART_FLOW_ST_PARITY; + else + suart->rx.flow_state = SUART_FLOW_ST_STOP; + } + break; + case SUART_FLOW_ST_PARITY: + /* TODO: actually verify parity */ + suart->rx.flow_state = SUART_FLOW_ST_STOP; + break; + case SUART_FLOW_ST_STOP: + suart->rx.bit_count++; + if (bit != 1) + suart->rx.flags |= OSMO_SUART_F_FRAMING_ERROR; + + if (suart->rx.bit_count >= (suart->cfg.num_data_bits + suart->cfg.num_stop_bits)) { + /* we have accumulated enough stop bits */ + suart_rx_ch(suart, suart->rx.shift_reg); + suart->rx.flow_state = SUART_FLOW_ST_IDLE; + } + break; } } @@ -288,10 +293,12 @@ if (!enable && suart->rx.running) { suart_flush_rx(suart); suart->rx.running = false; + suart->rx.flow_state = SUART_FLOW_ST_IDLE; } else if (enable && !suart->rx.running) { if (!suart->rx.msg) suart->rx.msg = msgb_alloc_c(suart, suart->cfg.rx_buf_size, "soft_uart rx"); suart->rx.running = true; + suart->rx.flow_state = SUART_FLOW_ST_IDLE; } return 0; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I40ab5d12b6f7087daa51405468f5c4ea639561ea Gerrit-Change-Number: 35022 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[L] Change in libosmocore[master]: tests: Test gsmtap logging if write queue fills up

by fixeria

Attention is currently required from: daniel. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email ) Change subject: tests: Test gsmtap logging if write queue fills up ...................................................................... Patch Set 2: (1 comment) File tests/logging/logging_test_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/0eccdc17_56efdb64 PS2, Line 3: 2008, 2009 by Holger Hans Peter Freyther <zecke(a)selfish.org> I doubt it was Holger who wrote this test -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 Gerrit-Change-Number: 34967 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 06:57:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023