October 2023 - gerrit-log - lists.osmocom.org

[S] Change in gapk[master]: libgsmhr: fix unneeded dependency for libgsmhr.c
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34890?usp=email ) Change subject: libgsmhr: fix unneeded dependency for libgsmhr.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I95900e3d26a7668246ec97d3182bea84156b4725 Gerrit-Change-Number: 34890 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 11:57:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Include BearerContext in CreateSessionResponse
by pespin 25 Oct '23

25 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34883?usp=email ) Change subject: epdg: Include BearerContext in CreateSessionResponse ...................................................................... epdg: Include BearerContext in CreateSessionResponse Change-Id: I89e364a5be68105ae8811e8bc917f32511f9e6ef --- M epdg/EPDG_Tests.ttcn M library/GTPv2_Templates.ttcn 2 files changed, 49 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 580d4d4..e7c8633 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -393,9 +393,12 @@ var PDU_GTPCv2 rx_msg; var template (value) FullyQualifiedTEID fteid_c_ie, fteid_u_ie; var template (value) PDN_AddressAllocation paa; + var uint4_t bid; + var template (value) BearerContextIEs bctx_ies; [] GTP2.receive(tr_GTP2C_CreateSessionReq(g_pars.imsi)) -> value rx_msg { /* TODO: parse TEIC and TEID and store it in g_pars.remote_tei{c,d} */ + bid := rx_msg.gtpcv2_pdu.createSessionRequest.bearerContextGrouped[0].bearerContextIEs.ePS_Bearer_ID.ePS_Bearer_ID_Value; /* allocate + register TEID-C on local side */ g_pars.teic := f_gtp2_allocate_teid(); @@ -409,8 +412,11 @@ fteid_u_ie := ts_GTP2C_FTEID(FTEID_IF_S2bU_ePDG_GTPU, g_pars.teid, 2, f_inet_addr(mp_s2b_local_ip), omit); paa := ts_GTP2C_PdnAddrAlloc_v4(f_inet_addr(g_pars.ue_ip)); - - GTP2.send(ts_GTP2C_CreateSessionResp({ fteid_c_ie }, paa)); + bctx_ies := ts_GTP2C_BcContextIE(bid := bid, + teid_list := { fteid_u_ie }, + qos := ts_GTP2C_BearerQos('09'O, 0,0,0,0), + charging_id := ts_GTP2C_ChargingID(g_pars.teic)); + GTP2.send(ts_GTP2C_CreateSessionResp({ fteid_c_ie }, paa, { ts_GTP2C_BcGrouped(bctx_ies) } )); setverdict(pass); } [] GTP2.receive(PDU_GTPCv2:?) -> value rx_msg { diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index 6bd3ba6..e1e71f0 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -505,6 +505,25 @@ } /* 8.28 */ +template (value) BearerContextIEs +ts_GTP2C_BcContextIE(template (value) uint4_t bid, + template (omit) FullyQualifiedTEID_List teid_list := omit, + template (omit) Bearer_QoS qos := ts_GTP2C_BearerQos('09'O, 0,0,0,0), + template (omit) ChargingID charging_id := omit) := { + ePS_Bearer_ID := ts_GTP2C_EpsBearerId(bid), + cause := ts_GTP2C_Cause(Request_accepted, '0'B), + ePS_Bearer_TFT := omit, + fullyQualifiedTEID := teid_list, + bearerLevel_QoS := qos, + chargingID := charging_id, + bearerFlags := omit, + transactionIdentifier := omit, + protocolConfigOptions := omit, + rAN_NASCause := omit, + additionalProtocolConfigOptions := omit, + extendedProtocolConfigOptions := omit +} + template (value) BearerContextGrouped ts_GTP2C_BcGrouped(template (value) BearerContextIEs ies) := { elementIdentifier := '5D'O, @@ -522,7 +541,16 @@ bearerContextIEs := ies } - +/* 8.29 */ +template (value) ChargingID +ts_GTP2C_ChargingID(template (value) OCT4 chargingID_Value) := { + elementIdentifier := '5D'O, + lengthIndicator := 0, /* overwritten */ + instance := '0000'B, + spare := '0000'B, + chargingID_Value := chargingID_Value, + additionalOctets := omit +} /* 8.30 */ template (value) ChargingCharacteristics @@ -811,7 +839,8 @@ template (value) PDU_GTPCv2 ts_GTP2C_CreateSessionResp(template (value) FullyQualifiedTEID_List fteids, - template (value) PDN_AddressAllocation addr) := + template (value) PDN_AddressAllocation addr, + template (omit) BearerContextGrouped_List bearerContextGrouped := omit) := ts_PDU_GTP2C('00000000'O, '000000'O, '21'O, { createSessionResponse := { cause := ts_GTP2C_Cause(Request_accepted, '0'B), @@ -824,7 +853,7 @@ ambr := omit, linkedEPS_Bearer_ID := omit, protocolConfigOptions := omit, - bearerContextGrouped := omit, + bearerContextGrouped := bearerContextGrouped, recovery := omit, chargingGatewayName := omit, chargingGatewayAddress := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I89e364a5be68105ae8811e8bc917f32511f9e6ef Gerrit-Change-Number: 34883 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Include BearerContext in CreateSessionResponse
by pespin 25 Oct '23

25 Oct '23

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34883?usp=email ) Change subject: epdg: Include BearerContext in CreateSessionResponse ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I89e364a5be68105ae8811e8bc917f32511f9e6ef Gerrit-Change-Number: 34883 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 11:56:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: bsc: Make socket queue max. length configurable
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: arehbein, dexter, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email ) Change subject: bsc: Make socket queue max. length configurable ...................................................................... Patch Set 8: Code-Review+1 (2 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/59475bc3_d0846a7b PS8, Line 2499: size_t to = (net->pcu_sock_wqueue_len_max = atoi(argv[0])); this new variable is really not needed and just makes everything more complex, specially with the parenthesis in there. https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/d00434b0_899ce34d PS8, Line 2503: LOGP(DPCU, LOGL_INFO, "Have dropped %zu messages due to shortened max. message queue size (from: %zu to %zu)\n", it may be good to do vty_out with the same message here, to show the user of the VTY what happened as a consequenc eof the cmd typed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b Gerrit-Change-Number: 33892 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 11:56:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: ASCI: Add primitive to L1-SAP to switch uplink access detection on or...
by fixeria 25 Oct '23

25 Oct '23

Attention is currently required from: jolly, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34885?usp=email ) Change subject: ASCI: Add primitive to L1-SAP to switch uplink access detection on or off ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd6a1d468a70126a8f67e944fcb916969cc3c36b Gerrit-Change-Number: 34885 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 11:22:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: dist: exclude libgsmhr files downloaded by fetch_sources.py
by osmith 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34892?usp=email ) Change subject: dist: exclude libgsmhr files downloaded by fetch_sources.py ...................................................................... Patch Set 1: (1 comment) File libgsmhr/Makefile.am: https://gerrit.osmocom.org/c/gapk/+/34892/comment/e743eb8e_54f4866d PS1, Line 39: -rm -rf $(distdir)/$(REFSRC_PATH) I think removing the sources in a dist-hook is a good idea, so they don't end up in the archive by accident if they were already downloaded. However downloading the sources first even if we don't intend to package them, and then remove them, seems like an unclean solution. Can't we additionally change it so they don't get downloaded in the first place unless --enable-gsmhr is set? -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I66e31dec37e53bf1a8c7df948fd9316e1467752c Gerrit-Change-Number: 34892 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 10:56:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: dist: include .[tarball-]version and git-version-gen files
by osmith 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34891?usp=email ) Change subject: dist: include .[tarball-]version and git-version-gen files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I5c15cefb68ab787819edaa1a097fe397837e0bcd Gerrit-Change-Number: 34891 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 10:35:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: libgsmhr: fix unneeded dependency for libgsmhr.c
by osmith 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34890?usp=email ) Change subject: libgsmhr: fix unneeded dependency for libgsmhr.c ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I95900e3d26a7668246ec97d3182bea84156b4725 Gerrit-Change-Number: 34890 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 10:35:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: libgsmhr: fix unneeded dependency for libgsmhr.c
by fixeria 25 Oct '23

25 Oct '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/34890?usp=email ) Change subject: libgsmhr: fix unneeded dependency for libgsmhr.c ...................................................................... libgsmhr: fix unneeded dependency for libgsmhr.c Change-Id: I95900e3d26a7668246ec97d3182bea84156b4725 Related: OS#6227 --- M libgsmhr/Makefile.am 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/90/34890/1 diff --git a/libgsmhr/Makefile.am b/libgsmhr/Makefile.am index 9904098..f3c01b7 100644 --- a/libgsmhr/Makefile.am +++ b/libgsmhr/Makefile.am @@ -21,7 +21,7 @@ done touch $@ -$(REFSRC_SRC) libgsmhr.c: ${REFSRC_PATH}/.downloaded +$(REFSRC_SRC): ${REFSRC_PATH}/.downloaded lib_LTLIBRARIES = libgsmhr.la libgsmhr_la_SOURCES = $(REFSRC_SRC) libgsmhr.c -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I95900e3d26a7668246ec97d3182bea84156b4725 Gerrit-Change-Number: 34890 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in gapk[master]: dist: include .[tarball-]version and git-version-gen files
by fixeria 25 Oct '23

25 Oct '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/34891?usp=email ) Change subject: dist: include .[tarball-]version and git-version-gen files ...................................................................... dist: include .[tarball-]version and git-version-gen files Most of other [lib]osmo-projects do include these files in the release tarballs. Do the same for the sake of consistency. Change-Id: I5c15cefb68ab787819edaa1a097fe397837e0bcd Related: OS#6227 --- M Makefile.am 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/91/34891/1 diff --git a/Makefile.am b/Makefile.am index a1642d4..f2a2c31 100644 --- a/Makefile.am +++ b/Makefile.am @@ -11,3 +11,17 @@ endif SUBDIRS += src tests + +BUILT_SOURCES = \ + $(top_srcdir)/.version \ + $(NULL) +EXTRA_DIST = \ + git-version-gen \ + .version \ + $(NULL) + +# versioning magic +$(top_srcdir)/.version: + echo $(VERSION) > $@-t && mv $@-t $@ +dist-hook: + echo $(VERSION) > $(distdir)/.tarball-version -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I5c15cefb68ab787819edaa1a097fe397837e0bcd Gerrit-Change-Number: 34891 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0