October 2023 - gerrit-log - lists.osmocom.org

[S] Change in gapk[master]: dist: ensure the license text is included
by fixeria 25 Oct '23

25 Oct '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/34893?usp=email ) Change subject: dist: ensure the license text is included ...................................................................... dist: ensure the license text is included The autotools pick up COPYING file automatically. Change-Id: Ib5c7b479fa66291be987230f102ff391f4902988 Related: OS#6227 --- R COPYING M contrib/gapk.spec.in 2 files changed, 13 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/gpl-3.0.txt b/COPYING similarity index 100% rename from gpl-3.0.txt rename to COPYING diff --git a/contrib/gapk.spec.in b/contrib/gapk.spec.in index e5d06ba..e0466f4 100644 --- a/contrib/gapk.spec.in +++ b/contrib/gapk.spec.in @@ -128,7 +128,7 @@ %postun -n libosmogapk%{sover} -p /sbin/ldconfig %files -%doc gpl-3.0.txt +%doc COPYING %{_bindir}/osmo-gapk %if 0%{with_gsmhr} -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ib5c7b479fa66291be987230f102ff391f4902988 Gerrit-Change-Number: 34893 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in gapk[master]: dist: exclude libgsmhr files downloaded by fetch_sources.py
by fixeria 25 Oct '23

25 Oct '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/34892?usp=email ) Change subject: dist: exclude libgsmhr files downloaded by fetch_sources.py ...................................................................... dist: exclude libgsmhr files downloaded by fetch_sources.py We deliberately do not include these files in the git repository, nor do we intend to include them in the release tarballs. This is done intentionally to avoid potential licensing issues. Change-Id: I66e31dec37e53bf1a8c7df948fd9316e1467752c Related: OS#6227 --- M libgsmhr/Makefile.am 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/libgsmhr/Makefile.am b/libgsmhr/Makefile.am index f3c01b7..ffbde21 100644 --- a/libgsmhr/Makefile.am +++ b/libgsmhr/Makefile.am @@ -33,3 +33,7 @@ distclean-local: -rm -rf ${REFSRC_PATH}/ + +# exclude files downloaded by fetch_sources.py +dist-hook: + -rm -rf $(distdir)/$(REFSRC_PATH) -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I66e31dec37e53bf1a8c7df948fd9316e1467752c Gerrit-Change-Number: 34892 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in gapk[master]: libgsmhr: fix unneeded dependency for libgsmhr.c
by fixeria 25 Oct '23

25 Oct '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/34890?usp=email ) Change subject: libgsmhr: fix unneeded dependency for libgsmhr.c ...................................................................... libgsmhr: fix unneeded dependency for libgsmhr.c Change-Id: I95900e3d26a7668246ec97d3182bea84156b4725 Related: OS#6227 --- M libgsmhr/Makefile.am 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/libgsmhr/Makefile.am b/libgsmhr/Makefile.am index 9904098..f3c01b7 100644 --- a/libgsmhr/Makefile.am +++ b/libgsmhr/Makefile.am @@ -21,7 +21,7 @@ done touch $@ -$(REFSRC_SRC) libgsmhr.c: ${REFSRC_PATH}/.downloaded +$(REFSRC_SRC): ${REFSRC_PATH}/.downloaded lib_LTLIBRARIES = libgsmhr.la libgsmhr_la_SOURCES = $(REFSRC_SRC) libgsmhr.c -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I95900e3d26a7668246ec97d3182bea84156b4725 Gerrit-Change-Number: 34890 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in gapk[master]: dist: include .[tarball-]version and git-version-gen files
by fixeria 25 Oct '23

25 Oct '23

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/gapk/+/34891?usp=email ) Change subject: dist: include .[tarball-]version and git-version-gen files ...................................................................... dist: include .[tarball-]version and git-version-gen files Most of other [lib]osmo-projects do include these files in the release tarballs. Do the same for the sake of consistency. Change-Id: I5c15cefb68ab787819edaa1a097fe397837e0bcd Related: OS#6227 --- M Makefile.am 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile.am b/Makefile.am index a1642d4..f2a2c31 100644 --- a/Makefile.am +++ b/Makefile.am @@ -11,3 +11,17 @@ endif SUBDIRS += src tests + +BUILT_SOURCES = \ + $(top_srcdir)/.version \ + $(NULL) +EXTRA_DIST = \ + git-version-gen \ + .version \ + $(NULL) + +# versioning magic +$(top_srcdir)/.version: + echo $(VERSION) > $@-t && mv $@-t $@ +dist-hook: + echo $(VERSION) > $(distdir)/.tarball-version -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I5c15cefb68ab787819edaa1a097fe397837e0bcd Gerrit-Change-Number: 34891 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in gapk[master]: dist: ensure the license text is included
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34893?usp=email ) Change subject: dist: ensure the license text is included ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ib5c7b479fa66291be987230f102ff391f4902988 Gerrit-Change-Number: 34893 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 14:12:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2)
by fixeria 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email ) Change subject: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/ec7b4506_d65f4b94 PS3, Line 731: goto rsp_error; > Yes, I actually forgot that one, thanks!. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df Gerrit-Change-Number: 32552 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Wed, 25 Oct 2023 14:04:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2)
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria, fixeria, laforge. pespin has uploaded a new patch set (#5) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email ) Change subject: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) ...................................................................... trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) - If the llist is flushed during rx rsp callback, when the flow is returned to trx_ctrl_read_cb() it would access tcm which was in the llist and end up in use-after-free. - We need to store state on whether code path is inside the read_cb in order to: -- Delay transmission of new message if callback calls trx_if_flush() followed by trx_ctrl_send(), since the trx_ctrl_send() at the end of trx_ctrl_read_cb would retransmit it again immediatelly. -- Avoid accessing tcm pointer if the callback called trx_if_flush(), since it has been freed. Related: OS#6020 Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df --- M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/trx_if.c 2 files changed, 52 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/52/32552/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df Gerrit-Change-Number: 32552 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2)
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria, fixeria, laforge. pespin has uploaded a new patch set (#4) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) ...................................................................... trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) - If the llist is flushed during rx rsp callback, when the flow is returned to trx_ctrl_read_cb() it would access tcm which was in the llist and end up in use-after-free. - We need to store state on whether code path is inside the read_cb in order to: -- Delay transmission of new message if callback calls trx_if_flush() followed by trx_ctrl_send(), since the trx_ctrl_send() at the end of trx_ctrl_read_cb would retransmit it again immediatelly. -- Avoid accessing tcm pointer if the callback called trx_if_flush(), since it has been freed. Related: OS#6020 Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df --- M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/trx_if.c 2 files changed, 51 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/52/32552/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df Gerrit-Change-Number: 32552 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in osmo-bts[master]: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2)
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email ) Change subject: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) ...................................................................... Patch Set 3: (2 comments) File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/7774bd75_2e5857fc PS3, Line 731: goto rsp_error; > just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here? Yes, I actually forgot that one, thanks!. https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/55832446_86eab842 PS3, Line 738: return 0; > just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df Gerrit-Change-Number: 32552 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Wed, 25 Oct 2023 13:56:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2)
by fixeria 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email ) Change subject: trx_if: Allow calling trx_if_flush/close from within TRXC callback (v2) ...................................................................... Patch Set 3: Code-Review+1 (4 comments) File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/5dab35f0_dbd09cfa PS1, Line 737: > I was thinking about this too. But this would make the logging/flow a bit confusing: […] Done https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/11319e4a_34c93535 PS1, Line 743: re-schedule last cmd in rc seconds time > Looks like I introduced related issues back in 4444262a6ab1e1e231ea81c4ec990f1a1f571a1f (https://ger […] Done File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/fe89a4de_7d8e07b8 PS3, Line 731: goto rsp_error; just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here? https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/9b9642af_af8e78bd PS3, Line 738: return 0; just to confirm, don't we need to reset `flushed_wile_in_trx_ctrl_read_cb` to `false` here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df Gerrit-Change-Number: 32552 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator(a)gmail.com> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <axilirator(a)gmail.com> Gerrit-Comment-Date: Wed, 25 Oct 2023 13:55:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0