October 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: ASCI: Add control of uplink access to osmo-bts-trx
by fixeria 25 Oct '23

25 Oct '23

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34886?usp=email ) Change subject: ASCI: Add control of uplink access to osmo-bts-trx ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/34886/comment/d3c9b12a_02a06359 PS1, Line 13: Change-Id: I9045437d52984b7abe00fbc815d7f83c62c0fb5a `Depends: libosmocore.git Ibd6a1d468a70126a8f67e944fcb916969cc3c36b` Also, I think you need to update `TODO-RELEASE` file? File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/34886/comment/9f6f76fe_d30e02db PS1, Line 1153: /* look for > in which situation would we want to enable/disable rach detection for multiple l1sched_chan at the s […] AFAIR, in this context it means both main (DCCH/TCH) and associated (SACCH) channels. The scheduler maintains separate states for these. They both have the same `chan_nr`, but different `link_id` in `trx_chan_desc[]`. I am not sure if it's valid to expect Access Bursts on SACCH too. I would expect the MS to transmit them on the main (DCCH/TCH) only. But the transceiver would most likely make no distinction and perform AB detection on both. https://gerrit.osmocom.org/c/osmo-bts/+/34886/comment/1edda4e3_1304c651 PS1, Line 1156: struct l1sched_ts *l1ts = lchan->ts->priv; This pointer can be obtained only once outside of the loop. The code above in `trx_sched_set_lchan()` does additionally check `l1ts` against `NULL` - we may want to do the same here too. Though I don't remember in which cases an `lchan` would have no associated `l1ts`, perhaps when it's not active? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9045437d52984b7abe00fbc815d7f83c62c0fb5a Gerrit-Change-Number: 34886 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 25 Oct 2023 13:24:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in gapk[master]: dist: ensure the license text is included
by fixeria 25 Oct '23

25 Oct '23

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/34893?usp=email ) Change subject: dist: ensure the license text is included ...................................................................... dist: ensure the license text is included The autotools pick up COPYING file automatically. Change-Id: Ib5c7b479fa66291be987230f102ff391f4902988 Related: OS#6227 --- R COPYING M contrib/gapk.spec.in 2 files changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/93/34893/1 diff --git a/gpl-3.0.txt b/COPYING similarity index 100% rename from gpl-3.0.txt rename to COPYING diff --git a/contrib/gapk.spec.in b/contrib/gapk.spec.in index e5d06ba..e0466f4 100644 --- a/contrib/gapk.spec.in +++ b/contrib/gapk.spec.in @@ -128,7 +128,7 @@ %postun -n libosmogapk%{sover} -p /sbin/ldconfig %files -%doc gpl-3.0.txt +%doc COPYING %{_bindir}/osmo-gapk %if 0%{with_gsmhr} -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ib5c7b479fa66291be987230f102ff391f4902988 Gerrit-Change-Number: 34893 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in gapk[master]: dist: exclude libgsmhr files downloaded by fetch_sources.py
by fixeria 25 Oct '23

25 Oct '23

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34892?usp=email ) Change subject: dist: exclude libgsmhr files downloaded by fetch_sources.py ...................................................................... Patch Set 1: (1 comment) File libgsmhr/Makefile.am: https://gerrit.osmocom.org/c/gapk/+/34892/comment/e376410c_57907fd1 PS1, Line 39: -rm -rf $(distdir)/$(REFSRC_PATH) > However downloading the sources first even if we don't intend to package them, and then remove them, seems like an unclean solution. Can't we additionally change it so they don't get downloaded in the first place unless --enable-gsmhr is set? I was thinking of this and first tried to make the autotools not download these files, but could not find any hooks nor examples for that. Maybe this can be achieved by overwriting the `distdir-am` target somehow, but then we would need to manually add these files which need to be in the tarball. I gave up on this. -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I66e31dec37e53bf1a8c7df948fd9316e1467752c Gerrit-Change-Number: 34892 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 13:05:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: ASCI: Control uplink access bursts detection of physical interface
by laforge 25 Oct '23

25 Oct '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34889?usp=email ) Change subject: ASCI: Control uplink access bursts detection of physical interface ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34889?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I92d6773a3a463eb747143c85aa149e54c1fda122 Gerrit-Change-Number: 34889 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 25 Oct 2023 12:20:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: ASCI: Enable voice group/broadcast call feature at osmo-bts-trx
by laforge 25 Oct '23

25 Oct '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34888?usp=email ) Change subject: ASCI: Enable voice group/broadcast call feature at osmo-bts-trx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34888?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3a2e3f94812cec0bbf7e3674172437fa359d014c Gerrit-Change-Number: 34888 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 25 Oct 2023 12:20:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-bts[master]: ASCI: Add control of uplink access to osmo-bts-sysmo
by laforge 25 Oct '23

25 Oct '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34887?usp=email ) Change subject: ASCI: Add control of uplink access to osmo-bts-sysmo ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I61f232aa91191dae08404c1f08cad91964d74568 Gerrit-Change-Number: 34887 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 25 Oct 2023 12:20:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-bts[master]: ASCI: Add control of uplink access to osmo-bts-trx
by laforge 25 Oct '23

25 Oct '23

Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34886?usp=email ) Change subject: ASCI: Add control of uplink access to osmo-bts-trx ...................................................................... Patch Set 1: (1 comment) File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/34886/comment/43266327_9700ac8b PS1, Line 1153: /* look for in which situation would we want to enable/disable rach detection for multiple l1sched_chan at the same time? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9045437d52984b7abe00fbc815d7f83c62c0fb5a Gerrit-Change-Number: 34886 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 25 Oct 2023 12:19:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: ASCI: Add primitive to L1-SAP to switch uplink access detection on or...
by laforge 25 Oct '23

25 Oct '23

Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34885?usp=email ) Change subject: ASCI: Add primitive to L1-SAP to switch uplink access detection on or off ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd6a1d468a70126a8f67e944fcb916969cc3c36b Gerrit-Change-Number: 34885 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 12:18:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmocore[master]: gsup: add message type for osmo-epdg CEAI interface
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: laforge, lynxis lazus. pespin has uploaded a new patch set (#2) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: gsup: add message type for osmo-epdg CEAI interface ...................................................................... gsup: add message type for osmo-epdg CEAI interface The CEIA interface is an interface between osmo-epdg and strongswan. It is used by the osmo-epdg to synchronize state. Related: OS#6091 Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3 --- M include/osmocom/gsm/gsup.h M src/gsm/gsup.c 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/32033/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3 Gerrit-Change-Number: 32033 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in gapk[master]: dist: include .[tarball-]version and git-version-gen files
by pespin 25 Oct '23

25 Oct '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/34891?usp=email ) Change subject: dist: include .[tarball-]version and git-version-gen files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/34891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I5c15cefb68ab787819edaa1a097fe397837e0bcd Gerrit-Change-Number: 34891 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Oct 2023 11:58:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0