January 2023 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31011 ) Change subject: ttcn3-bts-test: replace subnets during 'make cfg' ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 12:03:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/31011 to look at the new patch set (#2). Change subject: ttcn3-bts-test: replace subnets during 'make cfg' ...................................................................... ttcn3-bts-test: replace subnets during 'make cfg' Make ttcn3-bts-test work as expected again by replacing the subnets hardcoded in the confmerge files and Makefile. Related: OS#5802 Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f --- M jenkins-common.sh M ttcn3-bts-test/jenkins.sh 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/11/31011/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bts-test: replace subnets during 'make cfg'

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31011 ) Change subject: ttcn3-bts-test: replace subnets during 'make cfg' ...................................................................... ttcn3-bts-test: replace subnets during 'make cfg' Make ttcn3-bts-test work as expected again by replacing the subnets hardcoded in the confmerge files and Makefile. Related: OS#5802 Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f --- M jenkins-common.sh M ttcn3-bts-test/jenkins.sh 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/11/31011/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 08d4e4e..d566b23 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -270,10 +270,12 @@ "$VOL_BASE_DIR" \ -name '*.cfg' -o \ -name '*.conf' -o \ + -name '*.confmerge' -o \ -name '*.scm' -o \ -name '*.sh' -o \ -name '*.txt' -o \ - -name '*.yaml' \ + -name '*.yaml' -o \ + -name 'Makefile' \ )" if [ -z "$files" ]; then diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 691c753..7d4d3dc 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -140,7 +140,9 @@ $VOL_BASE_DIR/bts-tester-hopping/BTS_Tests.cfg.inc # (re)generate the configuration files -make cfg +cp Makefile $VOL_BASE_DIR/Makefile +network_replace_subnet_in_configs +make -f $VOL_BASE_DIR/Makefile cfg mkdir $VOL_BASE_DIR/bsc cp generic/osmo-bsc.gen.cfg $VOL_BASE_DIR/bsc/ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I733619f80b4e2456da070649634d3c942bb6d95f Gerrit-Change-Number: 31011 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: Add vty `reject-cause` to set the reject cause

by fixeria

Attention is currently required from: keith, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 ) Change subject: Add vty `reject-cause` to set the reject cause ...................................................................... Patch Set 11: Code-Review+2 (5 comments) Patchset: PS6: > CR-1 for incomplete command description. […] Done File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/f3deb0b1_35c2f6af PS4, Line 85: get_value_string_or_null > We should not get NULL if everything is correct I think. Done https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/70fe5a9a_2f73a111 PS4, Line 356: imsi unknown cause > Given that you're adding a value-string array now, it would be better to generate the command and he […] Done https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/982d00c0_09315dd9 PS4, Line 357: GSUP cause > Saying GSUP/GMM is an option ;) But I don't want to block you here, so you can keep this as is. Done File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/262e98ac_6b0de870 PS6, Line 381: imsi unknown cause > Here I would recommend concatenating all three words using '-', i.e. 'imsi-unknown-cause'. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icea39020c23fbbea9e92847df76af8986fdbf48a Gerrit-Change-Number: 16808 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 18 Jan 2023 11:00:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hnbgw[master]: fix msgb leak for RANAP RAB Ass. Req.

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 ) Change subject: fix msgb leak for RANAP RAB Ass. Req. ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie30e880301346ffca72f98f8c467e56d622fb03f Gerrit-Change-Number: 31009 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 10:47:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hnbgw[master]: fix segfault on MGCP timeout

by fixeria

Attention is currently required from: neels, pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/31008 ) Change subject: fix segfault on MGCP timeout ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31008 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I460d7249f4fc7edcfd94f6084fc8f933b491520c Gerrit-Change-Number: 31008 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 10:47:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: main: Log line about using config file before parsing it

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31006 ) Change subject: layer23: main: Log line about using config file before parsing it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I66b5b18887b8deb37c3784fec90644470498d7b5 Gerrit-Change-Number: 31006 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 10:44:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: install ccache

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31010 ) Change subject: debian-buster-jenkins: install ccache ...................................................................... debian-buster-jenkins: install ccache Make ccache available inside debian-buster-jenkins. An upcoming osmo-ci patch will make use of it in gerrit-verification and master jobs. With this docker-playground patch alone it's not used yet since /usr/lib/ccache is not in the default PATH. Related: OS#5848 Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, approved diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 44c2ee3..ddd14f4 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -30,6 +30,7 @@ bison \ bzip2 \ ca-certificates \ + ccache \ cmake \ coccinelle \ cppcheck \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 Gerrit-Change-Number: 31010 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: install ccache

by Hoernchen

Attention is currently required from: osmith. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31010 ) Change subject: debian-buster-jenkins: install ccache ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 Gerrit-Change-Number: 31010 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Jan 2023 09:17:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: install ccache

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/31010 ) Change subject: debian-buster-jenkins: install ccache ...................................................................... debian-buster-jenkins: install ccache Make ccache available inside debian-buster-jenkins. An upcoming osmo-ci patch will make use of it in gerrit-verification and master jobs. With this docker-playground patch alone it's not used yet since /usr/lib/ccache is not in the default PATH. Related: OS#5848 Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 --- M debian-buster-jenkins/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/10/31010/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 44c2ee3..ddd14f4 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -30,6 +30,7 @@ bison \ bzip2 \ ca-certificates \ + ccache \ cmake \ coccinelle \ cppcheck \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I164c7835f99436e8d768a864f36118eaf799d109 Gerrit-Change-Number: 31010 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023