January 2023 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: SI: add missing header

by osmith

Attention is currently required from: fixeria, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31080 ) Change subject: SI: add missing header ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/0e0e5772_3e8d7fc4 PS3, Line 7: SI: add missing header As Pau mentioned, the title of this patch is misleading: > btw, this patch is not adding a missing header. It's adding a missing function declaration in an existing header. Besides that: LGTM! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31080 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3 Gerrit-Change-Number: 31080 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jan 2023 15:50:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: DIAMETER_Templates: Fix 3GPP Spec number

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31097 ) Change subject: DIAMETER_Templates: Fix 3GPP Spec number ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31097 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I33d437593a13a92151e33e86534e2189b541b5ea Gerrit-Change-Number: 31097 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 30 Jan 2023 15:48:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: Add SI10 support

by osmith

Attention is currently required from: laforge, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31039 ) Change subject: Add SI10 support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I268ba716ded330a024a8f3c0d1bd2f28622cecab Gerrit-Change-Number: 31039 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jan 2023 15:47:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: vty: Fix typo in symbol name

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31104 ) Change subject: vty: Fix typo in symbol name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib33ffba348d6e9414eb904bfb7a2bd7ba2f55344 Gerrit-Change-Number: 31104 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jan 2023 15:47:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: SI: add missing Message Type

by osmith

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31105 ) Change subject: SI: add missing Message Type ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3b59638a3cf75c7105b1992094a4cc20855161d Gerrit-Change-Number: 31105 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jan 2023 15:45:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: SI: add missing Message Type

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31105 ) Change subject: SI: add missing Message Type ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31105 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id3b59638a3cf75c7105b1992094a4cc20855161d Gerrit-Change-Number: 31105 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 30 Jan 2023 13:46:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: FR testsuites: clean up all networks before start

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31103 ) Change subject: FR testsuites: clean up all networks before start ...................................................................... FR testsuites: clean up all networks before start Add a new network_clean_remove_all_ttcn3 function and use it in the fr related testsuites to ensure no network is running before the test starts. We just had the situation where the network link between gtp0-deb10fr (where these testsuites run exclusively, and only one at a time) and the jenkins host went down. And so the clean up trap apparently did not run and starting a new test fails as the old network still exists and has the network devices attached. Related: OS#5802 Change-Id: I6a9464a11edcba978be08764bec9de19760a5c77 --- M jenkins-common.sh M ttcn3-fr-test/jenkins.sh M ttcn3-gbproxy-test-fr/jenkins.sh M ttcn3-ns-test/jenkins-fr.sh 4 files changed, 32 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/jenkins-common.sh b/jenkins-common.sh index ef0a3fc..a607f9a 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -262,6 +262,35 @@ docker network remove $NET_NAME } +# Clean and remove all docker networks related to ttcn3 testing. This prevents +# running testsuites in parallel, so usually we don't want this and rely on the +# clean_up_trap to clean the network. But on e.g. gtp0-deb10fr this gets used +# as we only run one testsuite at once and it has dahdi netdevices attached. +# Due connection loss, it may not be cleaned up there and so another testsuite +# cannot start. +network_clean_remove_all_ttcn3() { + local networks + local i + + networks="$(docker network ls --format '{{.Name}}' | grep ^ttcn3- || true)" + + if [ -z "$networks" ]; then + return + fi + + set +x + echo "Removing stale network and containers..." + set -x + + for i in $networks; do + NET_NAME="$i" + network_clean + network_remove + done + + unset NET_NAME +} + network_replace_subnet_in_configs() { set +x diff --git a/ttcn3-fr-test/jenkins.sh b/ttcn3-fr-test/jenkins.sh index 9122063..12e14a5 100755 --- a/ttcn3-fr-test/jenkins.sh +++ b/ttcn3-fr-test/jenkins.sh @@ -30,6 +30,7 @@ mkdir $VOL_BASE_DIR/unix +network_clean_remove_all_ttcn3 network_create network_replace_subnet_in_configs diff --git a/ttcn3-gbproxy-test-fr/jenkins.sh b/ttcn3-gbproxy-test-fr/jenkins.sh index ab62bc1..1c53173 100755 --- a/ttcn3-gbproxy-test-fr/jenkins.sh +++ b/ttcn3-gbproxy-test-fr/jenkins.sh @@ -33,6 +33,7 @@ mkdir $VOL_BASE_DIR/unix +network_clean_remove_all_ttcn3 network_create network_replace_subnet_in_configs diff --git a/ttcn3-ns-test/jenkins-fr.sh b/ttcn3-ns-test/jenkins-fr.sh index 3b609ab..b6af67f 100755 --- a/ttcn3-ns-test/jenkins-fr.sh +++ b/ttcn3-ns-test/jenkins-fr.sh @@ -29,6 +29,7 @@ mkdir $VOL_BASE_DIR/ns cp fr/osmo-ns-dummy.cfg $VOL_BASE_DIR/ns/ +network_clean_remove_all_ttcn3 network_create network_replace_subnet_in_configs -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6a9464a11edcba978be08764bec9de19760a5c77 Gerrit-Change-Number: 31103 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 4 months

1
0
0 0

Change in docker-playground[master]: FR testsuites: clean up all networks before start

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31103 ) Change subject: FR testsuites: clean up all networks before start ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6a9464a11edcba978be08764bec9de19760a5c77 Gerrit-Change-Number: 31103 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jan 2023 13:26:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: vty: Fix typo in symbol name

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31104 ) Change subject: vty: Fix typo in symbol name ...................................................................... vty: Fix typo in symbol name Change-Id: Ib33ffba348d6e9414eb904bfb7a2bd7ba2f55344 --- M src/common/vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/31104/1 diff --git a/src/common/vty.c b/src/common/vty.c index 7e36504..5877a41 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -2270,7 +2270,7 @@ return CMD_SUCCESS; } -DEFUN(cfg_trx_no_gsmtap_sapi, cfg_bts_no_gsmtap_sapi_cmd, +DEFUN(cfg_bts_no_gsmtap_sapi, cfg_bts_no_gsmtap_sapi_cmd, "HIDDEN", "HIDDEN") { struct gsm_bts *bts = vty->index; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31104 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib33ffba348d6e9414eb904bfb7a2bd7ba2f55344 Gerrit-Change-Number: 31104 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in osmo-bts[master]: Add SI10 support

by msuraev

Attention is currently required from: laforge. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31039 ) Change subject: Add SI10 support ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > do we have a related TTCN3 test that sends the SI10 to osmo-bts and verifies it actually appears on […] No, not yet. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I268ba716ded330a024a8f3c0d1bd2f28622cecab Gerrit-Change-Number: 31039 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 30 Jan 2023 13:14:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023