January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: pcu_sock: rework check logic for ts

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30876 ) Change subject: pcu_sock: rework check logic for ts ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30876/comment/cd44d0ba_6d074cd5 PS2, Line 96: static bool ts_is_pdch(const struct gsm_bts_trx_ts *ts) ts_should_be_pdch() in osmo-bts.git (the coutnerpart of this function) looks more complex, probably checking properly dynamic TS. I bet dynamic TS are not going to work with current code in osmo-bsc? (maybe we don't care at all because RBS doesn't support dynamic TS). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a Gerrit-Change-Number: 30876 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 17:02:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-pcu[master]: bts: refuse to set invalid frame numbers

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30863 ) Change subject: bts: refuse to set invalid frame numbers ...................................................................... bts: refuse to set invalid frame numbers A valid GSM frame ranges from 0 to 2715647. When using set_current_frame_number() to set the current frame number (source usually is the layer 1 and below) we should not allow invalid frame numbers. Note: this also fixes FnTest which uses invalid frame numbers for testsing. Change-Id: Iaae31b370fababba975d419b0d20ac15618c296e Related: OS#5198 --- M src/bts.cpp M tests/fn/FnTest.cpp M tests/fn/FnTest.ok 3 files changed, 17 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/bts.cpp b/src/bts.cpp index cf39aa4..650d4a3 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -338,6 +338,9 @@ void bts_set_current_frame_number(struct gprs_rlcmac_bts *bts, uint32_t fn) { + /* See also 3GPP TS 45.002, section 4.3.3 */ + OSMO_ASSERT(fn < GSM_TDMA_HYPERFRAME); + /* The UL frame numbers lag 3 behind the DL frames and the data * indication is only sent after all 4 frames of the block have been * received. Sometimes there is an idle frame between the end of one diff --git a/tests/fn/FnTest.cpp b/tests/fn/FnTest.cpp index e5ac46d..ae15164 100644 --- a/tests/fn/FnTest.cpp +++ b/tests/fn/FnTest.cpp @@ -92,13 +92,13 @@ fn = calc_fn(bts, RFN_MODULUS - 1); OSMO_ASSERT(fn == 42431); - set_fn(bts, RFN_MODULUS * 123 + 16); + set_fn(bts, RFN_MODULUS * 12 + 16); fn = calc_fn(bts, RFN_MODULUS - 4); - OSMO_ASSERT(fn == 5219132); + OSMO_ASSERT(fn == 509180); - set_fn(bts, RFN_MODULUS * 123 + 451); + set_fn(bts, RFN_MODULUS * 12 + 451); fn = calc_fn(bts, RFN_MODULUS - 175); - OSMO_ASSERT(fn == 5218961); + OSMO_ASSERT(fn == 509009); /* Lets check a special cornercase. We assume that @@ -125,7 +125,7 @@ /* Also check with some corner case * values where Fn and RFn reach its * maximum/minimum valid range */ - set_fn(bts, GSM_MAX_FN); + set_fn(bts, GSM_MAX_FN-1); fn = calc_fn(bts, RFN_MODULUS-1); OSMO_ASSERT(fn == GSM_MAX_FN-1); @@ -133,9 +133,9 @@ fn = calc_fn(bts, RFN_MODULUS-1); OSMO_ASSERT(fn == GSM_MAX_FN-1); - set_fn(bts, GSM_MAX_FN); + set_fn(bts, GSM_MAX_FN-1); fn = calc_fn(bts, 0); - OSMO_ASSERT(fn == GSM_MAX_FN); + OSMO_ASSERT(fn == GSM_MAX_FN-RFN_MODULUS*2); set_fn(bts, 0); fn = calc_fn(bts, 0); diff --git a/tests/fn/FnTest.ok b/tests/fn/FnTest.ok index be6400f..4884ca5 100644 --- a/tests/fn/FnTest.ok +++ b/tests/fn/FnTest.ok @@ -19,11 +19,11 @@ bts: fn=42433 rfn=42431 ==> fn=42431 -bts: fn=5219152 -rfn=42428 ==> fn=5219132 +bts: fn=509200 +rfn=42428 ==> fn=509180 -bts: fn=5219587 -rfn=42257 ==> fn=5218961 +bts: fn=509635 +rfn=42257 ==> fn=509009 bts: fn=0 rfn=42419 ==> fn=2715635 @@ -37,14 +37,14 @@ bts: fn=23 rfn=42390 ==> fn=2715606 -bts: fn=2715648 +bts: fn=2715647 rfn=42431 ==> fn=2715647 bts: fn=0 rfn=42431 ==> fn=2715647 -bts: fn=2715648 -rfn=0 ==> fn=2715648 +bts: fn=2715647 +rfn=0 ==> fn=2630784 bts: fn=0 rfn=0 ==> fn=0 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iaae31b370fababba975d419b0d20ac15618c296e Gerrit-Change-Number: 30863 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: check trx mo state

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30875 ) Change subject: pcu_sock: check trx mo state ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30875/comment/7eba179e_b3298559 PS2, Line 117: if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || trx->mo.nm_state.administrative != NM_STATE_UNLOCKED) { Better put this into 2 lines like in osmo-bts.git, it's much more easier to read: if (trx->mo.nm_state.operational != NM_OPSTATE_ENABLED || trx->mo.nm_state.administrative != NM_STATE_UNLOCKED) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7a93826e6b0df187425310cb82854e7d7fb47e72 Gerrit-Change-Number: 30875 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 17:00:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: move code that fills in trx info to helper function

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30874 ) Change subject: pcu_sock: move code that fills in trx info to helper function ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic30185c9364adcc61d0a9d3483b0550ac1cdf894 Gerrit-Change-Number: 30874 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 16:57:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bts[master]: pcu_sock: don not continue when running out of TRX space

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30878 ) Change subject: pcu_sock: don not continue when running out of TRX space ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think that's a continue on purpose in order to log all the trx which are not confgiured due to being more than 8. So not sure we really win much with this change. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If4d7eecaded22f86750283f7aa13072064724537 Gerrit-Change-Number: 30878 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 16:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-pcu[master]: bts: use GSM_TDMA_FN_ macros and uint32_t in bts_rfn_to_fn

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30864 ) Change subject: bts: use GSM_TDMA_FN_ macros and uint32_t in bts_rfn_to_fn ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I assume you verified this variable never can hold a negative value (being named "relative"). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iedd493bb30dd1c342dec031883060c545432e740 Gerrit-Change-Number: 30864 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 16:54:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: guard against too many TRX

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30873 ) Change subject: pcu_sock: guard against too many TRX ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30873/comment/bb812eb6_4eaeb987 PS1, Line 233: continue > break? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I351080a112f3d3fdf833ee7fa0d77c4cd1d13e42 Gerrit-Change-Number: 30873 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 16:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: check trx mo state

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30875 to look at the new patch set (#2). Change subject: pcu_sock: check trx mo state ...................................................................... pcu_sock: check trx mo state Make sure that the TRX MO state is enabled and unlocked before filling in any TRX information into the info indication Change-Id: I7a93826e6b0df187425310cb82854e7d7fb47e72 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/30875/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7a93826e6b0df187425310cb82854e7d7fb47e72 Gerrit-Change-Number: 30875 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: guard against too many TRX

by dexter

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30873 to look at the new patch set (#2). Change subject: pcu_sock: guard against too many TRX ...................................................................... pcu_sock: guard against too many TRX The pcuif only supports a limited but sufficient number of TRXs. When filling in the TRX array in info_ind, we must guard against overflowing the maximum number of TRXs Change-Id: I351080a112f3d3fdf833ee7fa0d77c4cd1d13e42 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/30873/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I351080a112f3d3fdf833ee7fa0d77c4cd1d13e42 Gerrit-Change-Number: 30873 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: rework check logic for ts

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30876 ) Change subject: pcu_sock: rework check logic for ts ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/30876/comment/748cc55c_696c3724 PS1, Line 9: Befor > before Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a Gerrit-Change-Number: 30876 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 16:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023