January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: fix integer overflow in l1ctl_tx_data_req()

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30962 ) Change subject: layer23: fix integer overflow in l1ctl_tx_data_req() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/common/l1ctl.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30962/comment/5f52a462_1bb708bd PS1, Line 397: chan_ts, gsmtap_chan_type, chan_ss, 0, 127, 0, > i'm wondering why the fix is not 127, the largest int8_t. […] Because it's Tx data (Uplink), so there cannot be Signal-Noise-Ratio. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I23e9ea5ad59099c24db60057c8e7da1e6a0d2293 Gerrit-Change-Number: 30962 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 07:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: fix memleak of proxy_subscr_listentry

by keith

Attention is currently required from: neels. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30981 ) Change subject: fix memleak of proxy_subscr_listentry ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ic1ec4911fa5ae91cc75aa865c8201edd83af41ed Gerrit-Change-Number: 30981 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 05:06:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Let each app allocate its ms obj and start layer2 when needed

by neels

Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30979 ) Change subject: layer23: Let each app allocate its ms obj and start layer2 when needed ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: (now that the callbacks don't communicate any external state, and three of them are called so close together, it seems to make more sense to have it the other way round: each app could have its own main(), calling some common functions. looks like only the exit cb really needs to be a cb?) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I32f99df76a5513eff9df5489d28d60aedf96dec3 Gerrit-Change-Number: 30979 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 01:21:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move layer2-socket VTY command to common/

by neels

Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30978 ) Change subject: layer23: Move layer2-socket VTY command to common/ ...................................................................... Patch Set 1: (6 comments) File src/host/layer23/include/osmocom/bb/common/vty.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/13164637_2d1dc039 PS1, Line 25: extern bool l23_vty_reading; adding l23_vty_reading seems unrelated to the move. separate patch? File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/1aa2530f_a3f4d3bc PS1, Line 166: layer2_socket_path = optarg; are you sure about changing the allocation here? seems unrelated to the code moved, separate patch? https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/e74e04ca_2928ed3c PS1, Line 292: rc = layer2_open(ms, ms->settings.layer2_socket_path); this seems like a bugfix unrelated to the move. ms->settings.layer2_socket_path existed before this patch, but this code here failed to use it? File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/0a0c85de_46772434 PS1, Line 53: static void l23_vty_restart(struct vty *vty, struct osmocom_ms *ms) > I'm just keeping the old name here, adding the new prefix. (a different name would be good indeed, but rather no additional changes during a patch that moves things) https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/f9984493_198e4759 PS1, Line 168: /tmp/osmocom_l2 "Unix socket, default '" L2_DEFAULT_SOCKET_PATH "'" https://gerrit.osmocom.org/c/osmocom-bb/+/30978/comment/880160ab_31ea8449 PS1, Line 243: /* placeholder for shared VTY commands */ the empty function was a placeholder, now it is used and no longer a placeholder -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If7419f8fc54a54eed68a076968d93dba5ac977b7 Gerrit-Change-Number: 30978 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 01:08:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move '(no) shutdown' VTY code to common/vty.c

by neels

Attention is currently required from: pespin, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30972 ) Change subject: layer23: Move '(no) shutdown' VTY code to common/vty.c ...................................................................... Patch Set 2: (3 comments) File src/host/layer23/src/common/vty.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/ccd24add_15800ab2 PS2, Line 223: placeholder placeholder? i don't understand... https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/ac804b2c_a71e4431 PS2, Line 229: vty_out (i would drop this line) File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30972/comment/9e3f1841_37750da8 PS2, Line 2951: static int l23_vty_signal_cb(unsigned int subsys, unsigned int signal, this patch log says "Move" some vty command, but this function seems brand new / not moved from anywhere. separate patch? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib5c9b6f3efa255d67980945db9f98dd8a112af0e Gerrit-Change-Number: 30972 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 00:47:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move settings.{c,h} under common/

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30975 ) Change subject: layer23: Move settings.{c,h} under common/ ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0a741b2384195d512fdc49eda6762241f385b1f1 Gerrit-Change-Number: 30975 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 00:33:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers)

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30982 ) Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ...................................................................... bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) Related: SYS#6287 Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 --- M src/osmo-bsc/bts_ctrl.c A tests/ctrl/osmo-bsc-neighbor-list.cfg M tests/ctrl_test_runner.py 3 files changed, 180 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/30982/1 diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 728d89f..3a16b94 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -21,6 +21,7 @@ #include <errno.h> #include <time.h> +#include <inttypes.h> #include <osmocom/ctrl/control_cmd.h> @@ -578,6 +579,56 @@ CTRL_CMD_DEFINE_WO(bts_neighbor_list_del, "neighbor-list del"); +static void write_neighbors(struct llist_head *neighbors, struct osmo_strbuf *csv) +{ + struct neighbor *n; + llist_for_each_entry(n, neighbors, entry) { + if (n->type == NEIGHBOR_TYPE_BTS_NR) { + OSMO_STRBUF_PRINTF(*csv, "%" PRIu8 ",", n->bts_nr); + } + } +} + +static int get_bts_neighbor_list(struct ctrl_cmd *cmd, void *data) +{ + size_t buf_on_heap = 0; + char log_buf[4096]; + struct osmo_strbuf csv = { .buf = log_buf, + .len = sizeof(log_buf), + .pos = log_buf, + .chars_needed = 0 + }; + struct gsm_bts *bts = (struct gsm_bts *)cmd->node; + if (!bts) { + cmd->reply = "bts not found."; + return CTRL_CMD_ERROR; + } + write_neighbors(&bts->neighbors, &csv); + if (csv.chars_needed >= csv.len) { /* Just to be save, although this is very unlikely */ + buf_on_heap = csv.chars_needed + 1; + if (!(csv.buf = talloc_zero_size(cmd, buf_on_heap))) + goto oom; + csv.len = buf_on_heap; + csv.pos = csv.buf; + csv.chars_needed = 0; + write_neighbors(&bts->neighbors, &csv); + } + if (csv.buf == csv.pos) { + cmd->reply = "No BTS neighbors configured through BTS number"; + } else {/* Get rid of trailing comma */ + csv.pos[-1] = '\0'; + if (!(cmd->reply = talloc_strdup(cmd, csv.buf))) + goto oom; + } + return CTRL_CMD_REPLY; + +oom: + cmd->reply = "OOM"; + return CTRL_CMD_ERROR; +} + +CTRL_CMD_DEFINE_RO(bts_neighbor_list, "neighbor-list"); + static int verify_bts_neighbor_list_mode(struct ctrl_cmd *cmd, const char *value, void *_data) { if (!strcmp(value, "automatic")) @@ -643,6 +694,7 @@ rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_add); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_del); rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list_mode); + rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_neighbor_list); rc |= neighbor_ident_ctrl_init(); diff --git a/tests/ctrl/osmo-bsc-neighbor-list.cfg b/tests/ctrl/osmo-bsc-neighbor-list.cfg new file mode 100644 index 0000000..6d58b43 --- /dev/null +++ b/tests/ctrl/osmo-bsc-neighbor-list.cfg @@ -0,0 +1,109 @@ +network + bts 1 + type osmo-bts + band DCS1800 + cell_identity 123 + location_area_code 0x0001 + base_station_id_code 55 + ms max power 15 + cell reselection hysteresis 4 + rxlev access min 0 + radio-link-timeout 32 + channel allocator mode set-all ascending + rach tx integer 9 + rach max transmission 7 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 + early-classmark-sending forbidden + ipa unit-id 55 0 + oml ipa stream-id 255 line 0 + codec-support fr + gprs mode gprs + gprs routing area 6 + neighbor bts 0 + neighbor bts 2 + trx 0 + rf_locked 0 + arfcn 880 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 0 + timeslot 0 + phys_chan_config CCCH+SDCCH4 + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F + hopping enabled 0 + bts 2 + type osmo-bts + band DCS1800 + cell_identity 125 + location_area_code 0x0001 + base_station_id_code 55 + ms max power 15 + cell reselection hysteresis 4 + rxlev access min 0 + radio-link-timeout 32 + channel allocator mode set-all ascending + rach tx integer 9 + rach max transmission 7 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 + early-classmark-sending forbidden + ipa unit-id 55 0 + oml ipa stream-id 255 line 0 + codec-support fr + gprs mode gprs + gprs routing area 6 + trx 0 + rf_locked 0 + arfcn 880 + nominal power 23 + ! to use full TRX power, set max_power_red 0 + max_power_red 20 + rsl e1 tei 0 + timeslot 0 + phys_chan_config CCCH+SDCCH4 + hopping enabled 0 + timeslot 1 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 2 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 3 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 4 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 5 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 6 + phys_chan_config TCH/F + hopping enabled 0 + timeslot 7 + phys_chan_config TCH/F + hopping enabled 0 diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index 4c07d5e..8e92159 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -526,6 +526,7 @@ self.assertEqual(r['value'], 'OK') def testNeighborList(self): + # Enter manual neighbor-list mode r = self.do_set('bts.0.neighbor-list.mode', 'manual') print('respose: ' + str(r)) @@ -566,6 +567,24 @@ self.assertEqual(r['mtype'], 'ERROR') self.assertEqual(r['error'], 'Invalid mode') + def testCtrlNeighborList(self): + + # Use alternative config file with neighbors (tested above...) + vty_cfg = os.path.join(confpath, 'tests/ctrl/osmo-bsc-neighbor-list.cfg') + r = self.do_set('apply-config-file', vty_cfg) + + # Get BTS locally configured neighbors (when none configured) + r = self.do_get('bts.0.neighbor-list') + self.assertEqual(r['mtype'], 'GET_REPLY') + self.assertEqual(r['var'], 'bts.0.neighbor-list') + self.assertEqual(r['value'], 'No BTS neighbors configured through BTS number') + + # Get BTS locally configured neighbors + r = self.do_get('bts.1.neighbor-list') + self.assertEqual(r['mtype'], 'GET_REPLY') + self.assertEqual(r['var'], 'bts.1.neighbor-list') + self.assertEqual(r['value'], '0,2') + class TestCtrlBSCNeighbor(TestCtrlBase): def tearDown(self): -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 Gerrit-Change-Number: 30982 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move script_lua call outside of settings.c

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30977 ) Change subject: layer23: Move script_lua call outside of settings.c ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/30977/comment/947e54db_bfdead6b PS1, Line 7: script_lua sctipt_lua_close() -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I634a4514ead9d064e7509c3fbbb3a2c89c7f3a56 Gerrit-Change-Number: 30977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 00:32:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move subscriber.{c,h} under common/

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30974 ) Change subject: layer23: Move subscriber.{c,h} under common/ ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3727e40bcc9a4ee93aaf2c4ced070cc789653e80 Gerrit-Change-Number: 30974 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 00:30:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Move support.{c,h} under common/

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30973 ) Change subject: layer23: Move support.{c,h} under common/ ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/host/layer23/include/osmocom/bb/common/support.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30973/comment/1e726e83_8dc82181 PS2, Line 113: uint16_t temp; (unrelated ws) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c5af4db8e603aa004d0b6410b09b5143173b874 Gerrit-Change-Number: 30973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 00:29:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023