January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: Add initial VTY support for l23_apps

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 ) Change subject: layer23: Add initial VTY support for l23_apps ...................................................................... Patch Set 5: (1 comment) File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/50e71214_61ff4e0b PS5, Line 177: config_file = optarg; > this is also removing two cmdline options, is that intended? it is not mentioned in the commit log, […] Yes it's intended because anyway they were not used and didn't make any sense at all. In here I'm just doing similar to what we do in all osmocom apps: Simply pass a cfg file and it should contain info on which IP address and port to use. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a Gerrit-Change-Number: 30950 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:16:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce l23_app_start() API step

by pespin

Attention is currently required from: neels, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30943 ) Change subject: layer23: Introduce l23_app_start() API step ...................................................................... Patch Set 5: (1 comment) File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30943/comment/71e42226_95ba782e PS5, Line 281: } > They are not strictly separate, they are related since a new step is added and hence the init() step […] Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1d232809764962f82fee86159bc61cdbc3eb3c48 Gerrit-Change-Number: 30943 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:14:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce l23_app_start() API step

by pespin

Attention is currently required from: neels, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30943 ) Change subject: layer23: Introduce l23_app_start() API step ...................................................................... Patch Set 5: (1 comment) File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30943/comment/3e4802b8_2e2ca921 PS5, Line 281: } > all changes in this file above this line seem to be separate from introducing l23_app_start. […] They are not strictly separate, they are related since a new step is added and hence the init() steps slightly changes (or rather becomes more specific). As this happens, order of some stuff is also adapted to conform to the new set of steps. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1d232809764962f82fee86159bc61cdbc3eb3c48 Gerrit-Change-Number: 30943 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:14:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: llc: Allow app provided callbacks to retain ownership of passed primi...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30921 ) Change subject: llc: Allow app provided callbacks to retain ownership of passed primitive ...................................................................... llc: Allow app provided callbacks to retain ownership of passed primitive This way the app can, for instance, simply forward the primtiive pointer from LLC callback to SNDCP layer, which will in the end take the ownership of the primitive and free it. Change-Id: I6ea91b8f190a399c4bcf6c7cba9a65809aaf3ddb --- M src/llc/llc_prim.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/llc/llc_prim.c b/src/llc/llc_prim.c index e789819..b5fab8f 100644 --- a/src/llc/llc_prim.c +++ b/src/llc/llc_prim.c @@ -142,7 +142,9 @@ rc = g_ctx->llc_up_cb(llc_prim, g_ctx->llc_up_cb_user_data); else rc = llc_up_cb_dummy(llc_prim, g_ctx->llc_up_cb_user_data); - msgb_free(llc_prim->oph.msg); + /* Special return value '1' means: do not free */ + if (rc != 1) + msgb_free(llc_prim->oph.msg); return rc; } @@ -178,7 +180,9 @@ rc = g_ctx->llc_down_cb(llc_prim, g_ctx->llc_down_cb_user_data); else rc = llc_down_cb_dummy(llc_prim, g_ctx->llc_down_cb_user_data); - msgb_free(llc_prim->oph.msg); + /* Special return value '1' means: do not free */ + if (rc != 1) + msgb_free(llc_prim->oph.msg); return rc; } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6ea91b8f190a399c4bcf6c7cba9a65809aaf3ddb Gerrit-Change-Number: 30921 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: llc: Log error loading gprs chiper plugins

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30910 ) Change subject: llc: Log error loading gprs chiper plugins ...................................................................... llc: Log error loading gprs chiper plugins Change-Id: Ie0438b444c2aff8991736806256fb67b59ee8bcc --- M src/llc/llc.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/llc/llc.c b/src/llc/llc.c index 3ddba6a..1f52851 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -126,8 +126,10 @@ int rc; OSMO_ASSERT(location == OSMO_GPRS_LLC_LOCATION_MS || location == OSMO_GPRS_LLC_LOCATION_SGSN) - if ((rc = gprs_cipher_load(cipher_plugin_path)) != 0) + if ((rc = gprs_cipher_load(cipher_plugin_path)) != 0) { + LOGLLC(LOGL_NOTICE, "Failed loading GPRS cipher plugins from %s\n", cipher_plugin_path); return rc; + } if (g_ctx) talloc_free(g_ctx); 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie0438b444c2aff8991736806256fb67b59ee8bcc Gerrit-Change-Number: 30910 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 ) Change subject: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp ...................................................................... sndcp: Initial support for async SN-XID.ind and SN-XID.rsp Before this patch, the response was being crafted synchronously through a direct function call. This patch provides initial support to trigger the primitives so that the application using the SNDCP layer can handle the indication and submit a response. The different XID L3 params are still not being passed to the app, that will be done in a subsequent patch. Change-Id: I0a5069fd3dc0d6c3dd28aeae09b51c49dd8be92d --- M include/osmocom/gprs/sndcp/sndcp_prim.h M include/osmocom/gprs/sndcp/sndcp_private.h M src/sndcp/sndcp.c M src/sndcp/sndcp_prim.c M tests/sndcp/sndcp_prim_test.c M tests/sndcp/sndcp_prim_test.err M tests/sndcp/sndcp_prim_test.ok 7 files changed, 95 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/gprs/sndcp/sndcp_prim.h b/include/osmocom/gprs/sndcp/sndcp_prim.h index 591e75f..b19498f 100644 --- a/include/osmocom/gprs/sndcp/sndcp_prim.h +++ b/include/osmocom/gprs/sndcp/sndcp_prim.h @@ -99,7 +99,8 @@ } xid_req; /* OSMO_GPRS_SNDCP_SN_XID | Ind */ struct { - uint8_t *req_xid; + uint8_t nsapi; + uint8_t *req_xid; /* TODO: theses need to be passed already decoded as in xid_req above */ uint32_t req_xid_len; } xid_ind; /* OSMO_GPRS_SNDCP_SN_XID | Rsp */ diff --git a/include/osmocom/gprs/sndcp/sndcp_private.h b/include/osmocom/gprs/sndcp/sndcp_private.h index ac6c660..206b660 100644 --- a/include/osmocom/gprs/sndcp/sndcp_private.h +++ b/include/osmocom/gprs/sndcp/sndcp_private.h @@ -161,6 +161,10 @@ uint8_t *l3xid_req; unsigned int l3xid_req_len; + /* Copy of the requested XID fields array we have received with the last + * originated XID-Request from peer. NULL if not existing (and l3xid_req_len = 0) */ + struct llist_head *l3_xid_comp_fields_req_from_peer; + /* TODO: taken from lle.params and not yet set ever in code! */ uint16_t n201_u; uint16_t n201_i; @@ -190,6 +194,7 @@ /* sndcp_prim.c: */ struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_unitdata_ind(uint32_t tlli, uint8_t sapi, uint8_t nsapi, uint8_t *npdu, size_t npdu_len); +struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_xid_ind(uint32_t tlli, uint8_t sapi, uint8_t nsapi); struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_snsm_activate_rsp(uint32_t tlli, uint8_t nsapi); int gprs_sndcp_prim_call_up_cb(struct osmo_gprs_sndcp_prim *sndcp_prim); int gprs_sndcp_prim_call_down_cb(struct osmo_gprs_llc_prim *llc_prim); @@ -206,6 +211,7 @@ int gprs_sndcp_snme_handle_llc_ll_xid_cnf(struct gprs_sndcp_mgmt_entity *snme, uint32_t sapi, uint8_t *l3params, unsigned int l3params_len); int gprs_sndcp_sne_handle_sn_unitdata_req(struct gprs_sndcp_entity *sne, uint8_t *npdu, unsigned int npdu_len); int gprs_sndcp_sne_handle_sn_xid_req(struct gprs_sndcp_entity *sne, const struct osmo_gprs_sndcp_prim *sndcp_prim); +int gprs_sndcp_sne_handle_sn_xid_rsp(struct gprs_sndcp_entity *sne, const struct osmo_gprs_sndcp_prim *sndcp_prim); #define LOGSNME(snme, level, fmt, args...) \ LOGSNDCP(level, "SNME(%08x) " fmt, \ diff --git a/src/sndcp/sndcp.c b/src/sndcp/sndcp.c index 4ae1aac..252ba06 100644 --- a/src/sndcp/sndcp.c +++ b/src/sndcp/sndcp.c @@ -721,24 +721,30 @@ } /* 5.1.1.7 SN-XID.response */ -/* FIXME: This is currently called directly from gprs_sndcp_snme_handle_llc_ll_xid_ind(). It should go async over SNDCP user instead */ -static int gprs_sndcp_sne_handle_sn_xid_rsp(struct gprs_sndcp_mgmt_entity *snme, uint8_t sapi, const struct llist_head *comp_fields) +/* FIXME: This is currently uses comp_fields stored from gprs_sndcp_snme_handle_llc_ll_xid_ind(). +* It should use info provided by upper layers in the prim instead */ +int gprs_sndcp_sne_handle_sn_xid_rsp(struct gprs_sndcp_entity *sne, const struct osmo_gprs_sndcp_prim *sndcp_prim) { struct osmo_gprs_llc_prim *llc_prim_tx; struct msgb *msg; int rc; - LOGSNME(snme, LOGL_DEBUG, "SN-XID.rsp comp_fields:\n"); - gprs_sndcp_dump_comp_fields(comp_fields, LOGL_DEBUG); + if (!sne->l3_xid_comp_fields_req_from_peer) { + LOGSNE(sne, LOGL_DEBUG, "SN-XID.rsp origianted comp_fields not found!\n"); + return -EINVAL; + } - llc_prim_tx = osmo_gprs_llc_prim_alloc_ll_xid_resp(snme->tlli, sapi, NULL, 256); + LOGSNE(sne, LOGL_DEBUG, "SN-XID.rsp comp_fields:\n"); + gprs_sndcp_dump_comp_fields(sne->l3_xid_comp_fields_req_from_peer, LOGL_DEBUG); + + llc_prim_tx = osmo_gprs_llc_prim_alloc_ll_xid_resp(sne->snme->tlli, sne->llc_sapi, NULL, 256); OSMO_ASSERT(llc_prim_tx); msg = llc_prim_tx->oph.msg; llc_prim_tx->ll.l3_pdu = msg->tail; /* Compile modified SNDCP-XID bytes */ rc = gprs_sndcp_compile_xid(msg->tail, msgb_tailroom(msg), - comp_fields, 0); + sne->l3_xid_comp_fields_req_from_peer, 0); if (rc < 0) { msgb_free(msg); return -EINVAL; @@ -913,6 +919,24 @@ int version; struct llist_head *comp_fields; struct gprs_sndcp_comp_field *comp_field; + struct gprs_sndcp_entity *sne = NULL; + struct osmo_gprs_sndcp_prim *sndcp_prim_tx; + unsigned int i; + + for (i = 0; i < ARRAY_SIZE(snme->sne); i++) { + struct gprs_sndcp_entity *sne_i = snme->sne[i]; + if (!sne_i) + continue; + if (sne_i->llc_sapi != sapi) + continue; + LOGSNE(sne_i, LOGL_DEBUG, "LL-XID.ind: Found SNE SAPI=%u\n", sapi); + sne = sne_i; + break; + } + if (!sne) { + LOGSNME(snme, LOGL_ERROR, "LL-XID.ind: No SNDCP entity found having sent a LL-XID.ind (SAPI=%u)\n", sapi); + return -EINVAL; + } /* Some phones send zero byte length SNDCP frames * and do require a confirmation response. */ @@ -923,7 +947,7 @@ /* Parse SNDCP-CID XID-Field */ - comp_fields = gprs_sndcp_parse_xid(&version, g_ctx, + comp_fields = gprs_sndcp_parse_xid(&version, sne, l3params, l3params_len, NULL); @@ -954,9 +978,12 @@ } } - /* FIXME: push SN-XID.ind up to SGSN/MS here, and below should be part of handling SN-XID.rsp from SGSN/MS. */ - rc = gprs_sndcp_sne_handle_sn_xid_rsp(snme, sapi, comp_fields); - talloc_free(comp_fields); + TALLOC_FREE(sne->l3_xid_comp_fields_req_from_peer); + sne->l3_xid_comp_fields_req_from_peer = comp_fields; + + /* Trigger SN-XID.ind to upper layers: */ + sndcp_prim_tx = gprs_sndcp_prim_alloc_sn_xid_ind(sne->snme->tlli, sne->llc_sapi, sne->nsapi); + rc = gprs_sndcp_prim_call_up_cb(sndcp_prim_tx); return rc; } @@ -965,7 +992,7 @@ */ int gprs_sndcp_snme_handle_llc_ll_xid_cnf(struct gprs_sndcp_mgmt_entity *snme, uint32_t sapi, uint8_t *l3params, unsigned int l3params_len) { - /* Note: This function handles an incoming SNDCP-XID confirmiation. + /* Note: This function handles an incoming SNDCP-XID confirmation. * Since the confirmation fields may lack important parameters we * will reconstruct these missing fields using the original request * we have sent. After that we will create (or delete) the diff --git a/src/sndcp/sndcp_prim.c b/src/sndcp/sndcp_prim.c index 09c37b7..63591d7 100644 --- a/src/sndcp/sndcp_prim.c +++ b/src/sndcp/sndcp_prim.c @@ -206,6 +206,17 @@ return sndcp_prim; } +/* 5.1.1.5 SN-XID.indication */ +struct osmo_gprs_sndcp_prim *gprs_sndcp_prim_alloc_sn_xid_ind(uint32_t tlli, uint8_t sapi, uint8_t nsapi) +{ + struct osmo_gprs_sndcp_prim *sndcp_prim; + sndcp_prim = sndcp_prim_sn_alloc(OSMO_GPRS_SNDCP_SN_XID, PRIM_OP_INDICATION, 0); + sndcp_prim->sn.tlli = tlli; + sndcp_prim->sn.sapi = sapi; + sndcp_prim->sn.xid_ind.nsapi = nsapi; + return sndcp_prim; +} + /* 5.1.1.7 SN-XID.response */ struct osmo_gprs_sndcp_prim *osmo_gprs_sndcp_prim_alloc_sn_xid_rsp(uint32_t tlli, uint8_t sapi, uint8_t nsapi) { @@ -358,6 +369,28 @@ return rc; } +/* 5.1.1.7 SN-XID.response:*/ +static int gprs_sndcp_prim_handle_sndcp_sn_xid_rsp(struct osmo_gprs_sndcp_prim *sndcp_prim) +{ + int rc; + struct gprs_sndcp_entity *sne; + + sne = gprs_sndcp_sne_by_dlci_nsapi(sndcp_prim->sn.tlli, sndcp_prim->sn.sapi, + sndcp_prim->sn.xid_rsp.nsapi); + if (!sne) { + LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " + "(TLLI=%08x, SAPI=%u, NSAPI=%u)\n", + sndcp_prim->sn.tlli, sndcp_prim->sn.sapi, + sndcp_prim->sn.xid_rsp.nsapi); + rc = -EIO; + goto ret_free; + } + rc = gprs_sndcp_sne_handle_sn_xid_rsp(sne, sndcp_prim); +ret_free: + msgb_free(sndcp_prim->oph.msg); + return rc; +} + /* SNDCP higher layers push SNDCP primitive down to SNDCP layer: */ int osmo_gprs_sndcp_prim_upper_down(struct osmo_gprs_sndcp_prim *sndcp_prim) { @@ -379,6 +412,9 @@ case OSMO_PRIM(OSMO_GPRS_SNDCP_SN_XID, PRIM_OP_REQUEST): rc = gprs_sndcp_prim_handle_sndcp_sn_xid_req(sndcp_prim); break; + case OSMO_PRIM(OSMO_GPRS_SNDCP_SN_XID, PRIM_OP_RESPONSE): + rc = gprs_sndcp_prim_handle_sndcp_sn_xid_rsp(sndcp_prim); + break; default: rc = gprs_sndcp_prim_handle_unsupported(sndcp_prim); } diff --git a/tests/sndcp/sndcp_prim_test.c b/tests/sndcp/sndcp_prim_test.c index c2e1231..e8c4a7e 100644 --- a/tests/sndcp/sndcp_prim_test.c +++ b/tests/sndcp/sndcp_prim_test.c @@ -137,7 +137,7 @@ rc = osmo_gprs_sndcp_prim_dispatch_snsm(sndcp_prim); OSMO_ASSERT(rc == 0); - /* SN-XID.Req: */ + /* Submit SN-XID.Req, triggers rx of LL-XID.Req: */ sndcp_prim = osmo_gprs_sndcp_prim_alloc_sn_xid_req(tlli, ll_sapi, nsapi); OSMO_ASSERT(sndcp_prim); sndcp_prim->sn.xid_req.pcomp_rfc1144.active = true; @@ -145,18 +145,24 @@ rc = osmo_gprs_sndcp_prim_upper_down(sndcp_prim); OSMO_ASSERT(rc == 0); - /* SN-XID.Cnf: */ + /* Submit LL-XID.Cnf, triggers rx of LL-XID.cnf */ llc_prim = gprs_llc_prim_alloc_ll_xid_cnf(tlli, ll_sapi, (uint8_t *)sndcp_xid, sizeof(sndcp_xid)); OSMO_ASSERT(llc_prim); rc = osmo_gprs_sndcp_prim_lower_up(llc_prim); OSMO_ASSERT(rc == 0); - /* SN-XID.Ind: */ + /* Submit LL-XID.Ind, triggers rx of SN-XID.Ind: */ llc_prim = gprs_llc_prim_alloc_ll_xid_ind(tlli, ll_sapi, (uint8_t *)sndcp_xid, sizeof(sndcp_xid)); OSMO_ASSERT(llc_prim); rc = osmo_gprs_sndcp_prim_lower_up(llc_prim); OSMO_ASSERT(rc == 0); + /* Submit SN-XID.Rsp, triggers rx of LL-XID.Rsp */ + sndcp_prim = osmo_gprs_sndcp_prim_alloc_sn_xid_rsp(tlli, ll_sapi, nsapi); + OSMO_ASSERT(sndcp_prim); + rc = osmo_gprs_sndcp_prim_upper_down(sndcp_prim); + OSMO_ASSERT(rc == 0); + OSMO_ASSERT(osmo_hexparse(sndcp_data_hex, sndcp_data, sizeof(sndcp_data)) > 0); llc_prim = gprs_llc_prim_alloc_ll_unitdata_ind(tlli, ll_sapi, (uint8_t *)sndcp_data, sizeof(sndcp_data)); OSMO_ASSERT(llc_prim); diff --git a/tests/sndcp/sndcp_prim_test.err b/tests/sndcp/sndcp_prim_test.err index 5d12fad..f27486d 100644 --- a/tests/sndcp/sndcp_prim_test.err +++ b/tests/sndcp/sndcp_prim_test.err @@ -75,6 +75,7 @@ DLGLOBAL DEBUG SNME(e1c5d364) Rejecting RFC1144 header compression... DLGLOBAL DEBUG SNME(e1c5d364) Rejecting ROHC header compression... DLGLOBAL INFO Rx from lower layers: LL-XID.indication +DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) LL-XID.ind: Found SNE SAPI=3 DLGLOBAL DEBUG SNME(e1c5d364) LL-XID.cnf requested comp_fields: DLGLOBAL DEBUG SNDCP-XID: DLGLOBAL DEBUG struct gprs_sndcp_comp_field { @@ -132,7 +133,8 @@ DLGLOBAL DEBUG } DLGLOBAL DEBUG SNME(e1c5d364) Rejecting RFC1144 header compression... DLGLOBAL DEBUG SNME(e1c5d364) Rejecting ROHC header compression... -DLGLOBAL DEBUG SNME(e1c5d364) SN-XID.rsp comp_fields: +DLGLOBAL INFO Rx from upper layers: SN-XID.response +DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) SN-XID.rsp comp_fields: DLGLOBAL DEBUG SNDCP-XID: DLGLOBAL DEBUG struct gprs_sndcp_comp_field { DLGLOBAL DEBUG entity=0; diff --git a/tests/sndcp/sndcp_prim_test.ok b/tests/sndcp/sndcp_prim_test.ok index 1789413..4a635fc 100644 --- a/tests/sndcp/sndcp_prim_test.ok +++ b/tests/sndcp/sndcp_prim_test.ok @@ -1,5 +1,6 @@ ==== test_sndcp_prim() [start] ==== test_sndcp_prim_down_cb(): Rx LL-XID.request +test_sndcp_prim_up_cb(): Rx SN-XID.indication test_sndcp_prim_down_cb(): Rx LL-XID.response test_sndcp_prim_up_cb(): Rx SN-UNITDATA.indication TLLI=0xe1c5d364 SAPI=SNDCP3 NSAPI=5 NPDU=[75 22 fa 7c ff d9 56 ba 86 c7 2a f3 d2 1d ce bc 88 3a 8e b6 24 7d de 26 6a 58 de 29 be 96 d2 40 94 7f 9f 4d f5 9c 61 d4 19 e9 9a 58 75 21 21 a9 fd 1f d7 96 90 a7 3f fe 5b 59 f0 e7 c1 52 2c aa a1 39 b6 c5 fd 68 2e fc f4 c0 10 9b 7a 64 9d ae 3a ff a3 0f b0 56 7d 4b 52 33 74 13 67 44 6a ce 62 45 ea cb 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ] test_sndcp_prim_down_cb(): Rx LL-UNITDATA.request TLLI=0xe1c5d364 SAPI=SNDCP3 L3=[65 00 00 00 73 6f 6d 65 2d 6e 70 64 75 2d 64 61 74 61 2d 6c 69 6b 65 2d 61 6e 2d 69 70 2d 70 6b 74 00 ] -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0a5069fd3dc0d6c3dd28aeae09b51c49dd8be92d Gerrit-Change-Number: 30907 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 ) Change subject: sndcp: Initial support for async SN-XID.ind and SN-XID.rsp ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I0a5069fd3dc0d6c3dd28aeae09b51c49dd8be92d Gerrit-Change-Number: 30907 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:11:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: fix memleak of proxy_subscr_listentry

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30981 ) Change subject: fix memleak of proxy_subscr_listentry ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ic1ec4911fa5ae91cc75aa865c8201edd83af41ed Gerrit-Change-Number: 30981 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:10:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Add missing header dependencies to several files

by pespin

Attention is currently required from: neels, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30959 ) Change subject: layer23: Add missing header dependencies to several files ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Agreeing with Neels. I explained it already to Max above. Since in a follow up patch I'm basically splitting osmocom_data.h and the struct having the most fields and hence header dependencies is moved to ms.h, which means new files have to include that file now. The current situation of includes in osmocom-bb is really poor right now. This is just a step forward towards being able to split stuff into manageable chunks and be able to further cleanup include dependencies in the future. This patch is mostly adding #include to C files. I see no problem in it also adding it to some .h files since it really is not making stuff worse. Let Rome be build in more than one day. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9819b12d1c24f6ee197daa887452b09418d689e8 Gerrit-Change-Number: 30959 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:01:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Let each app allocate its ms obj and start layer2 when needed

by pespin

Attention is currently required from: neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30979 ) Change subject: layer23: Let each app allocate its ms obj and start layer2 when needed ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > (now that the callbacks don't communicate any external state, and three of them are called so close […] I initially created a separate main but fixeria wanted to have a shared main and actually changed the "modem" app to have a shared main. I only want to have an app I can run, so let just it be whatever way. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I32f99df76a5513eff9df5489d28d60aedf96dec3 Gerrit-Change-Number: 30979 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 08:56:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023