January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: Initialize osmocom_ms further in common code

by pespin

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30971 to look at the new patch set (#2). Change subject: layer23: Initialize osmocom_ms further in common code ...................................................................... layer23: Initialize osmocom_ms further in common code Change-Id: Ic629cf229167ddd4c533a2abf1b82ad78d1144a9 --- M src/host/layer23/include/osmocom/bb/common/ms.h M src/host/layer23/src/common/main.c M src/host/layer23/src/common/ms.c M src/host/layer23/src/mobile/app_mobile.c 4 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/71/30971/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic629cf229167ddd4c533a2abf1b82ad78d1144a9 Gerrit-Change-Number: 30971 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-coverity: add missing tag coverity

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30916 ) Change subject: ansible: install-coverity: add missing tag coverity ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I86be4c72ad3bce070ddf7f8270492b6cf8ea826e Gerrit-Change-Number: 30916 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:35:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-poky-sdk: add tag poky to the apt install task

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30915 ) Change subject: ansible: install-poky-sdk: add tag poky to the apt install task ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id8e433a789aff8df241687f1f109a161e725a29a Gerrit-Change-Number: 30915 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:35:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: mobile: fix -Wlogical-not-parentheses in gsm48_cc_init()

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30963 ) Change subject: mobile: fix -Wlogical-not-parentheses in gsm48_cc_init() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/gsm48_cc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30963/comment/fe4ca38b_e93e41c0 PS1, Line 54: if (cc->mncc_upqueue.next != NULL) > Using llist_empty() means doing this: […] Feel free to merge this patch if you want, but I think we really fix the code to properly initialize the cc->mncc_upqueue with INIT_LLIST or whatever, instead of doing adhoc assumptions checking against NULL, etc. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic7ffd3aa25339e24a31bae1b7428f1f93e261858 Gerrit-Change-Number: 30963 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: .gitignore: make poky regex more specific

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30914 ) Change subject: ansible: .gitignore: make poky regex more specific ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3ac9a6129323f27ba387b44d8293d7b134716af8 Gerrit-Change-Number: 30914 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:35:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: replace deprecated include by import_tasks

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30912 ) Change subject: ansible: replace deprecated include by import_tasks ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I29766c65b9e1601a20aa8f20a438e8368c65f6a8 Gerrit-Change-Number: 30912 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:34:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: mobile: Several fixes and improvements in show_ms_cmd

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30969 ) Change subject: layer23: mobile: Several fixes and improvements in show_ms_cmd ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30969/comment/a951eb2b_afe3b57c PS1, Line 246: "Display specific MS with given name") > (is there a common MS_STR that can be used instead? that would be the usual approach) The strings below refer to this one so it's fine keeping it the way it was. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4a55328e71ec16355974c20275c0e525077252e1 Gerrit-Change-Number: 30969 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:28:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: Move osmocom_ms to a separate file

by pespin

Attention is currently required from: neels, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30960 ) Change subject: Move osmocom_ms to a separate file ...................................................................... Patch Set 5: (3 comments) File src/host/layer23/include/osmocom/bb/common/osmocom_data.h: https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/f7ec82d1_192e00de PS5, Line 3: #include <stdint.h> > the above are unrelated changes sneaking into this patch why do you say so? when the structs holding most of the include dependencies are moved from here, one still needs to keep the required includes here. That's what I'm doing. In any case the change in this file is so big that it can be considered I'm rewriting the general structure of the file and hence it's file simply changing to use the pragma once here. I see no point in having to do an extra commit for that here. File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/936a1400_85081bb1 PS5, Line 271: ms = osmocom_ms_alloc(l23_ctx); > (ack, IMO would suffice to OSMO_ASSERT(ms) either here or in osmocom_ms_alloc()) Ack https://gerrit.osmocom.org/c/osmocom-bb/+/30960/comment/0d4cc51b_59a742bb PS5, Line 272: llist_add_tail(&ms->entity, &ms_list); > i see now you are moving it in a later patch. […] I prefer keeping it in smaller chunks, iterative changes. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icb4891cc1e4a0ecb5f09cb8a84b0ebe1b91a46b8 Gerrit-Change-Number: 30960 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:27:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: cosmetic layer23/mobile/gsm322: Fix trailing whistepace

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30955 ) Change subject: cosmetic layer23/mobile/gsm322: Fix trailing whistepace ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/30955/comment/cd21ce20_d68b20ec PS4, Line 7: whistepace > (typo) Ack -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I32d28ac219d2a573a77a0041a774ca7427388fb0 Gerrit-Change-Number: 30955 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Add initial VTY support for l23_apps

by pespin

Attention is currently required from: neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30950 ) Change subject: layer23: Add initial VTY support for l23_apps ...................................................................... Patch Set 5: (1 comment) File src/host/layer23/src/common/main.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30950/comment/bb9f9583_1296eec8 PS1, Line 271: handle_options > NB, this is about "l23_app_init()", not "_info()". […] That's why we have now a l23_app_start() step which is caller *after* we passed all cmdline and vty cfg. Apps still need to initialize structures before going through VTY cfg read and hence is why we have the init() in that position. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ife3a3373e5a9c0c8e5959ac714e140e72d6c363a Gerrit-Change-Number: 30950 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 09:18:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023