September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Test assignment of non-AMR codec with Osmux enabled

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29419 ) Change subject: bsc: Test assignment of non-AMR codec with Osmux enabled ...................................................................... bsc: Test assignment of non-AMR codec with Osmux enabled Change-Id: I31ea10963bdf61b2e070ed6ac3257b872245f724 --- M bsc/BSC_Tests.ttcn 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/19/29419/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 6d4bd82..a150310 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -5319,6 +5319,30 @@ f_shutdown_helper(); } +/* Test non-AMR codecs still work fine as RTP when Osmux is enabled BTS<->BSC<->MSC */ +testcase TC_assignment_codec_hr_osmux_on() runs on test_CT { + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + var MSC_ConnHdlr vc_conn; + + g_osmux_enabled_cn := true; + g_osmux_enabled_bts := true; + f_init(1, true); + f_sleep(1.0); + f_ctrs_bsc_and_bts_assignment_init(1); + + pars.ass_codec_list := valueof(ts_BSSMAP_IE_CodecList({ts_CodecHR})); + vc_conn := f_start_handler(refers(f_TC_assignment_codec), pars); + vc_conn.done; + + f_ctrs_bsc_and_bts_add(0, "assignment:attempted", 1); + f_ctrs_bts_add(0, "assignment:attempted_speech", 1); + f_ctrs_bsc_and_bts_add(0, "assignment:completed", 1); + f_ctrs_bts_add(0, "assignment:completed_speech", 1); + f_ctrs_bts_verify(); + + f_shutdown_helper(); +} + /* Test Osmux setup BTS<->BSC<->MSC */ testcase TC_assignment_osmux() runs on test_CT { var TestHdlrParams pars := f_gen_test_hdlr_pars(); @@ -11920,6 +11944,7 @@ execute( TC_assignment_sdcch_exhausted_req_signalling_tch_forbidden() ); execute( TC_assignment_sdcch_exhausted_req_voice_tch_forbidden() ); + execute( TC_assignment_codec_hr_osmux_on() ); execute( TC_assignment_osmux() ); execute( TC_assignment_osmux_cn() ); execute( TC_assignment_osmux_bts() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I31ea10963bdf61b2e070ed6ac3257b872245f724 Gerrit-Change-Number: 29419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: mgcp: Set up Osmux only when AMR codec is selected

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29418 ) Change subject: mgcp: Set up Osmux only when AMR codec is selected ...................................................................... mgcp: Set up Osmux only when AMR codec is selected Until now Osmux was selected unconditionally in bss-side CRCX, without checking if the codec was AMR or not. If Osmux use policy is "on", we only want to request Osmux use if AMR codec is selected. Change-Id: I3f53555dd9608f1337365e4f82b492bdf1da05bb --- M include/osmocom/bsc/lchan_rtp_fsm.h M src/osmo-bsc/lchan_rtp_fsm.c 2 files changed, 27 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/29418/1 diff --git a/include/osmocom/bsc/lchan_rtp_fsm.h b/include/osmocom/bsc/lchan_rtp_fsm.h index 5dbdb0a..397b5e1 100644 --- a/include/osmocom/bsc/lchan_rtp_fsm.h +++ b/include/osmocom/bsc/lchan_rtp_fsm.h @@ -13,6 +13,7 @@ struct gsm_lchan; struct mgcp_conn_peer; +enum mgcp_codecs; enum lchan_rtp_fsm_state { LCHAN_RTP_ST_WAIT_MGW_ENDPOINT_AVAILABLE, @@ -48,3 +49,4 @@ void lchan_forget_mgw_endpoint(struct gsm_lchan *lchan); void mgcp_pick_codec(struct mgcp_conn_peer *verb_info, const struct gsm_lchan *lchan, bool bss_side); +bool mgcp_codec_is_picked(const struct mgcp_conn_peer *verb_info, enum mgcp_codecs codec); diff --git a/src/osmo-bsc/lchan_rtp_fsm.c b/src/osmo-bsc/lchan_rtp_fsm.c index 87c235f..916823a 100644 --- a/src/osmo-bsc/lchan_rtp_fsm.c +++ b/src/osmo-bsc/lchan_rtp_fsm.c @@ -166,8 +166,7 @@ crcx_info = (struct mgcp_conn_peer){ .ptime = 20, - .x_osmo_osmux_use = bts->use_osmux != OSMUX_USAGE_OFF, - .x_osmo_osmux_cid = -1, /* -1 is wildcard */ + .x_osmo_osmux_cid = -1, /* -1 is wildcard, .x_osmo_osmux_use set below */ }; if (lchan->conn) { crcx_info.call_id = lchan->conn->sccp.conn_id; @@ -175,9 +174,25 @@ crcx_info.x_osmo_ign = lchan->conn->sccp.msc->x_osmo_ign; } mgcp_pick_codec(&crcx_info, lchan, true); - /* TODO: lchan_rtp_fail() here if crcx_info->codecs[] contains non-AMR and bts->use_osmux=ONLY. - If bts->use_osmux=ON, only set .x_osmo_osmux_use if there's an AMR in crcx_info->codecs[]. - IF osmux=no, always set x_osmo_osmux_use=false*/ + + /* Set up Osmux use in MGW according to configured policy */ + bool amr_picked = mgcp_codec_is_picked(&crcx_info, CODEC_AMR_8000_1); + switch (bts->use_osmux) { + case OSMUX_USAGE_OFF: + crcx_info.x_osmo_osmux_use = false; + break; + case OSMUX_USAGE_ON: + crcx_info.x_osmo_osmux_use = amr_picked; + break; + case OSMUX_USAGE_ONLY: + if (!amr_picked) { + lchan_rtp_fail("Only AMR codec can be used when configured with policy 'osmux only'." + " Check your configuration."); + return; + } + crcx_info.x_osmo_osmux_use = true; + break; + } osmo_mgcpc_ep_ci_request(lchan->mgw_endpoint_ci_bts, MGCP_VERB_CRCX, &crcx_info, fi, LCHAN_RTP_EV_MGW_ENDPOINT_AVAILABLE, LCHAN_RTP_EV_MGW_ENDPOINT_ERROR, @@ -908,3 +923,8 @@ verb_info->param.amr_octet_aligned = lchan->conn->sccp.msc->amr_octet_aligned; } } + +bool mgcp_codec_is_picked(const struct mgcp_conn_peer *verb_info, enum mgcp_codecs codec) +{ + return verb_info->codecs[0] == codec; +} -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3f53555dd9608f1337365e4f82b492bdf1da05bb Gerrit-Change-Number: 29418 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess_close(): No need to lookup already available struct e1i_ts

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29370 ) Change subject: ipaccess_close(): No need to lookup already available struct e1i_ts ...................................................................... ipaccess_close(): No need to lookup already available struct e1i_ts Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 1b8d8d0..94d2baf 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -452,15 +452,11 @@ struct e1inp_ts *e1i_ts = sign_link->ts; struct osmo_fd *bfd = &e1i_ts->driver.ipaccess.fd; struct e1inp_line *line = e1i_ts->line; + struct osmo_fsm_inst *ka_fsm = e1i_ts->driver.ipaccess.ka_fsm; - /* line might not exist if != bsc||bts */ - if (line) { - /* depending on caller the fsm might be dead */ - struct osmo_fsm_inst* ka_fsm = ipaccess_line_ts(bfd, line)->driver.ipaccess.ka_fsm; - if (ka_fsm) - ipa_keepalive_fsm_stop(ka_fsm); - - } + /* depending on caller the fsm might be dead */ + if (ka_fsm) + ipa_keepalive_fsm_stop(ka_fsm); e1inp_int_snd_event(e1i_ts, sign_link, S_L_INP_TEI_DN); /* the first e1inp_sign_link_destroy call closes the socket. */ 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 Gerrit-Change-Number: 29370 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess: Call line->ops->sign_link_down() only if set

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29371 ) Change subject: ipaccess: Call line->ops->sign_link_down() only if set ...................................................................... ipaccess: Call line->ops->sign_link_down() only if set This op must not necessarily be set by the user, so check if it is set before calling it. Change-Id: I666c5bbf157fe604e336df44f7eac098572d42ba --- M src/input/ipaccess.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved neels: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 94d2baf..42dd942 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -123,7 +123,8 @@ e1i_ts->pending_msg = NULL; /* e1inp_sign_link_destroy releases the socket descriptors for us. */ - line->ops->sign_link_down(line); + if (line->ops->sign_link_down) + line->ops->sign_link_down(line); e1inp_line_put2(line, __func__); return ret; 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I666c5bbf157fe604e336df44f7eac098572d42ba Gerrit-Change-Number: 29371 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipa: Allow users closing lower layer tcp/ipa connections

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29365 ) Change subject: ipa: Allow users closing lower layer tcp/ipa connections ...................................................................... ipa: Allow users closing lower layer tcp/ipa connections This is useful for users to abort connections which are in "connecting" state, since the higher layer struct e1inp_sign_link is not provided to the user until the TCP+IPA handshake in the socket becomes fully established (sign_link_up() callback). This is intended for osmo-bts: when something fails and may enter into SHUTDOWN state, it is desirable to close new RSL links (sockets) which are in progress to connect, while it waits for a while to complete shutdown (power ramping down, etc.). Change-Id: Ia6418321f3b6f1f7274efd414625a4b10a09a362 --- M include/osmocom/abis/e1_input.h M src/input/ipaccess.c 2 files changed, 30 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index 9c3fe56..0daf792 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -336,7 +336,8 @@ int e1inp_ipa_bts_rsl_connect_n(struct e1inp_line *line, const char *rem_addr, uint16_t rem_port, - uint8_t trx_id); + uint8_t trx_nr); +int e1inp_ipa_bts_rsl_close_n(struct e1inp_line *line, uint8_t trx_nr); void e1inp_sign_link_destroy(struct e1inp_sign_link *link); int e1inp_line_update(struct e1inp_line *line); diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 2c1ae93..1b8d8d0 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1163,6 +1163,7 @@ struct ipa_client_conn *rsl_link; struct e1inp_ts *e1i_ts = e1inp_line_ipa_rsl_ts(line, trx_nr); struct ipaccess_line *il; + int rc; if (E1INP_SIGN_RSL+trx_nr-1 >= NUM_E1_TS) { LOGP(DLINP, LOGL_ERROR, "cannot create RSL BTS link: " @@ -1170,17 +1171,14 @@ return -EINVAL; } + /* Drop previous line */ + if ((rc = e1inp_ipa_bts_rsl_close_n(line, trx_nr)) < 0) + return rc; + if (!line->driver_data) line->driver_data = talloc_zero(line, struct ipaccess_line); il = line->driver_data; - /* Drop previous line */ - if (il->ipa_cli[1 + trx_nr]) { - ipa_client_conn_close(il->ipa_cli[1 + trx_nr]); - ipa_client_conn_destroy(il->ipa_cli[1 + trx_nr]); - il->ipa_cli[1 + trx_nr] = NULL; - } - rsl_link = ipa_client_conn_create2(tall_ipa_ctx, e1inp_line_ipa_rsl_ts(line, trx_nr), E1INP_SIGN_RSL+trx_nr, @@ -1209,6 +1207,29 @@ return 0; } +/* Close the underlying IPA TCP socket of an RSL link */ +int e1inp_ipa_bts_rsl_close_n(struct e1inp_line *line, uint8_t trx_nr) +{ + struct ipaccess_line *il; + + if (E1INP_SIGN_RSL+trx_nr-1 >= NUM_E1_TS) { + LOGP(DLINP, LOGL_ERROR, + "cannot close RSL BTS link: trx_nr (%d) out of range\n", trx_nr); + return -EINVAL; + } + + il = line->driver_data; + if (!il) + return 0; /* Nothing to do, no lines created */ + + if (il->ipa_cli[1 + trx_nr]) { + ipa_client_conn_close(il->ipa_cli[1 + trx_nr]); + ipa_client_conn_destroy(il->ipa_cli[1 + trx_nr]); + il->ipa_cli[1 + trx_nr] = NULL; + } + return 0; +} + void e1inp_ipaccess_init(void) { tall_ipa_ctx = talloc_named_const(libosmo_abis_ctx, 1, "ipa"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29365 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia6418321f3b6f1f7274efd414625a4b10a09a362 Gerrit-Change-Number: 29365 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29369 ) Change subject: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds ...................................................................... e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds Change-Id: Ic382ab509e4541124f36df153e4b247d9cba35c5 --- M include/osmocom/abis/e1_input.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index 0daf792..91a71e1 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -229,7 +229,7 @@ int pcap_fd; }; #define e1inp_line_ipa_oml_ts(line) (&line->ts[0]) -#define e1inp_line_ipa_rsl_ts(line, trx_id) (&line->ts[1 + (trx_id)]) +#define e1inp_line_ipa_rsl_ts(line, trx_id) (((1 + (trx_id)) < NUM_E1_TS) ? (&line->ts[1 + (trx_id)]) : NULL) /* SS_L_INPUT signals */ enum e1inp_signal_input { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic382ab509e4541124f36df153e4b247d9cba35c5 Gerrit-Change-Number: 29369 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: cosmetic: Remove unneeded empty line

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29417 ) Change subject: cosmetic: Remove unneeded empty line ...................................................................... cosmetic: Remove unneeded empty line Change-Id: If72058144d0ea4031ec0f4aea7f2b4f20859c014 --- M src/input/ipaccess.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 07fd814..2c1ae93 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -1149,7 +1149,6 @@ return ret; } - /* backwards compatibility */ int e1inp_ipa_bts_rsl_connect(struct e1inp_line *line, const char *rem_addr, uint16_t rem_port) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If72058144d0ea4031ec0f4aea7f2b4f20859c014 Gerrit-Change-Number: 29417 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess: Call line->ops->sign_link_down() only if set

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29371 ) Change subject: ipaccess: Call line->ops->sign_link_down() only if set ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29371 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I666c5bbf157fe604e336df44f7eac098572d42ba Gerrit-Change-Number: 29371 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 15:46:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: ipaccess_close(): No need to lookup already available struct e1i_ts

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29370 ) Change subject: ipaccess_close(): No need to lookup already available struct e1i_ts ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I54a69cad5adc3df3f95dd51e00ea68bb04ba9963 Gerrit-Change-Number: 29370 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 15:46:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmo-abis[master]: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29369 ) Change subject: e1inp_line_ipa_rsl_ts(): Return null instead of reading out of bounds ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29369 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic382ab509e4541124f36df153e4b247d9cba35c5 Gerrit-Change-Number: 29369 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 15:46:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022