September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: osmo_git_clone_url: git.osmocom.org -> gitea

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29485 ) Change subject: osmo_git_clone_url: git.osmocom.org -> gitea ...................................................................... osmo_git_clone_url: git.osmocom.org -> gitea Update the function to not use legacy URLs anymore and allow adding future gitea URLs more easily. Update the description of the function to reflect the new motivation for using this. Change-Id: Ibf53ca2c444fae82af73e417410faa5b16f5de59 --- M scripts/common.sh 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/85/29485/1 diff --git a/scripts/common.sh b/scripts/common.sh index 23a3380..6d93cc8 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -1,7 +1,7 @@ #!/bin/sh # Various functions and variables used in multiple osmo-ci shell scripts OSMO_CI_DIR="$(realpath "$(dirname "$0")/..")" -OSMO_GIT_URL="https://git.osmocom.org" +OSMO_GIT_URL_GITEA="https://gitea.osmocom.org" OSMO_GIT_URL_GERRIT="https://gerrit.osmocom.org" # Osmocom repositories of which we want to build release tarballs automatically, and list the current versions at @@ -120,13 +120,18 @@ fi } -# Print git clone URL for an Osmocom git repository. Prefer the gerrit clone URL, because cloning from the regular URL -# sometimes results in the "garbage at end of loose object" error (OS#4083). +# Echo git clone URL for an Osmocom git repository. For projects developed on +# gerrit, use the gerrit URL to avoid the mirror sync delay, for other +# repositories use the gitea URL. +# https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure # $1: Osmocom project (e.g. "osmo-hlr") osmo_git_clone_url() { case "$1" in - rtl-sdr|osmo-fl2k|libosmo-dsp|libgtpnl|libasn1c|libusrp|libsmpp34) - echo "$OSMO_GIT_URL"/"$1" + libgtpnl|libasn1c|libsmpp34) + echo "$OSMO_GIT_URL_GITEA"/cellular-infrastructure/"$1" + ;; + rtl-sdr|osmo-fl2k|libosmo-dsp|libusrp) + echo "$OSMO_GIT_URL_GITEA"/sdr/"$1" ;; *) echo "$OSMO_GIT_URL_GERRIT"/"$1" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ibf53ca2c444fae82af73e417410faa5b16f5de59 Gerrit-Change-Number: 29485 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: coverity/prepare_source_Osmocom: remove test -d

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29486 ) Change subject: coverity/prepare_source_Osmocom: remove test -d ...................................................................... coverity/prepare_source_Osmocom: remove test -d This was redundant, mkdir -p doesn't error if the directory structure exists. Change-Id: Ic6253ecb9bfd5f8b2d744988b8825ef90e2e6d5e --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/29486/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 122fc1c..258dbb0 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -45,7 +45,7 @@ asn1c " -[ -d $BASEDIR ] || mkdir -p $BASEDIR +mkdir -p $BASEDIR cd $BASEDIR for proj in $PROJECTS $PROJECTS_DONT_BUILD_TEST; do -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic6253ecb9bfd5f8b2d744988b8825ef90e2e6d5e Gerrit-Change-Number: 29486 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: add some guard space to message buffer

by neels

Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29362 ) Change subject: pcu_sock: add some guard space to message buffer ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/29362/comment/6123cad5_fe38863f PS1, Line 17: Change-Id: I99f5204b0563f72f9da427bb7aa5451552d8c5b5 > gerrit registered on this second one, so we remove the first one above Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I99f5204b0563f72f9da427bb7aa5451552d8c5b5 Gerrit-Change-Number: 29362 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Sep 2022 12:25:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: check size of primitive

by neels

Attention is currently required from: pespin, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29361 ) Change subject: pcu_sock: check size of primitive ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I247c6f4b5a7a22d17a060a558c4ceb9221ca7351 Gerrit-Change-Number: 29361 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Sep 2022 12:23:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add ttcn3-upf-test

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29445 ) Change subject: add ttcn3-upf-test ...................................................................... add ttcn3-upf-test Related: I43cd55c9395f2c706369afe1a9a7f475be47339f (osmo-ci) Related: I5964979b3db86268f6011df0afbee7131557f405 (osmo-ci) Change-Id: I7a651bb85861de4b2677a731b9f17fa0d790c621 --- A ttcn3-upf-test/Dockerfile A ttcn3-upf-test/Makefile A ttcn3-upf-test/UPF_Tests.cfg A ttcn3-upf-test/jenkins.sh A ttcn3-upf-test/osmo-upf.cfg 5 files changed, 104 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ttcn3-upf-test/Dockerfile b/ttcn3-upf-test/Dockerfile new file mode 100644 index 0000000..addc43f --- /dev/null +++ b/ttcn3-upf-test/Dockerfile @@ -0,0 +1,13 @@ +ARG REGISTRY +ARG USER +FROM $REGISTRY/$USER/debian-bullseye-titan +ARG OSMO_TTCN3_BRANCH="master" + +ADD http://git.osmocom.org/osmo-ttcn3-hacks/patch?h=$OSMO_TTCN3_BRANCH /tmp/commit +RUN ttcn3-docker-prepare "$OSMO_TTCN3_BRANCH" upf + +VOLUME /data + +COPY UPF_Tests.cfg /data/UPF_Tests.cfg + +CMD ttcn3-docker-run upf UPF_Tests diff --git a/ttcn3-upf-test/Makefile b/ttcn3-upf-test/Makefile new file mode 100644 index 0000000..207d0f1 --- /dev/null +++ b/ttcn3-upf-test/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=-it --sysctl net.ipv6.conf.all.disable_ipv6=0 --network sigtran --ip 172.18.34.202 + +include ../make/Makefile diff --git a/ttcn3-upf-test/UPF_Tests.cfg b/ttcn3-upf-test/UPF_Tests.cfg new file mode 100644 index 0000000..0b794e7 --- /dev/null +++ b/ttcn3-upf-test/UPF_Tests.cfg @@ -0,0 +1,25 @@ +[ORDERED_INCLUDE] +"/osmo-ttcn3-hacks/Common.cfg" +"/osmo-ttcn3-hacks/upf/UPF_Tests.default" + +[LOGGING] +*.JUnitLogger.testsuite_name := "UPF_Tests" + +# Local configuration below + +[LOGGING] + +[TESTPORT_PARAMETERS] +*.UPFVTY.CTRL_HOSTNAME := "172.18.34.20"; +*.STATSVTY.CTRL_HOSTNAME := "172.18.34.20"; + +[MODULE_PARAMETERS] +UPF_Tests.mp_pfcp_ip_upf := "172.18.34.20"; +UPF_Tests.mp_pfcp_ip_local := "172.18.34.203"; + +UPF_Tests.mp_verify_gtp_actions := false; + +[MAIN_CONTROLLER] + +[EXECUTE] +UPF_Tests.control diff --git a/ttcn3-upf-test/jenkins.sh b/ttcn3-upf-test/jenkins.sh new file mode 100755 index 0000000..2fb6d43 --- /dev/null +++ b/ttcn3-upf-test/jenkins.sh @@ -0,0 +1,39 @@ +#!/bin/sh + +. ../jenkins-common.sh +IMAGE_SUFFIX="${IMAGE_SUFFIX:-master}" +docker_images_require \ + "osmo-upf-$IMAGE_SUFFIX" \ + "ttcn3-upf-test" + +set_clean_up_trap +set -e + +mkdir $VOL_BASE_DIR/upf-tester +cp UPF_Tests.cfg $VOL_BASE_DIR/upf-tester/ +write_mp_osmo_repo "$VOL_BASE_DIR/upf-tester/UPF_Tests.cfg" + +mkdir $VOL_BASE_DIR/upf +cp osmo-upf.cfg $VOL_BASE_DIR/upf/ + +SUBNET=34 +network_create $SUBNET + +echo Starting container with UPF +docker run --rm \ + $(docker_network_params $SUBNET 20) \ + --ulimit core=-1 \ + -v $VOL_BASE_DIR/upf:/data \ + --name ${BUILD_TAG}-upf -d \ + $DOCKER_ARGS \ + $REPO_USER/osmo-upf-$IMAGE_SUFFIX + +echo Starting container with UPF testsuite +docker run --rm \ + $(docker_network_params $SUBNET 203) \ + --ulimit core=-1 \ + -e "TTCN3_PCAP_PATH=/data" \ + -v $VOL_BASE_DIR/upf-tester:/data \ + --name ${BUILD_TAG}-ttcn3-upf-test \ + $DOCKER_ARGS \ + $REPO_USER/ttcn3-upf-test diff --git a/ttcn3-upf-test/osmo-upf.cfg b/ttcn3-upf-test/osmo-upf.cfg new file mode 100644 index 0000000..39aaeb7 --- /dev/null +++ b/ttcn3-upf-test/osmo-upf.cfg @@ -0,0 +1,24 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category-hex 0 + logging print category 1 + logging print thread-id 0 + logging print extended-timestamp 1 + logging print level 1 + logging print file basename last + logging level set-all debug +log gsmtap 172.18.34.203 + logging level set-all debug + logging filter all 1 +line vty + no login + bind 0.0.0.0 +ctrl + bind 0.0.0.0 +pfcp + local-addr 172.18.34.20 +gtp + mockup +nft + mockup -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29445 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I7a651bb85861de4b2677a731b9f17fa0d790c621 Gerrit-Change-Number: 29445 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: add osmo-upf-master

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29444 ) Change subject: add osmo-upf-master ...................................................................... add osmo-upf-master Will be used by ttcn3-upf-test in subsequent patch I7a651bb85861de4b2677a731b9f17fa0d790c621. Change-Id: Iceec912eef05bf4903ccc1fc30b0c7362145a1f1 --- A osmo-upf-master/Dockerfile A osmo-upf-master/Makefile A osmo-upf-master/osmo-upf.cfg 3 files changed, 61 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/osmo-upf-master/Dockerfile b/osmo-upf-master/Dockerfile new file mode 100644 index 0000000..7c5c1e6 --- /dev/null +++ b/osmo-upf-master/Dockerfile @@ -0,0 +1,50 @@ +ARG USER +ARG DISTRO +FROM $USER/$DISTRO-build +# Arguments used after FROM must be specified again +ARG DISTRO + +RUN case "$DISTRO" in \ + debian*) \ + apt-get update && \ + apt-get install -y --no-install-recommends \ + libosmocore-dev \ + libgtpnl-dev \ + libnftables-dev \ + libosmo-pfcp-dev \ + && apt-get clean \ + ;; \ + centos*) \ + dnf install -y \ + "pkgconfig(libgtpnl)" \ + "pkgconfig(libnftables)" \ + "pkgconfig(libosmocore)" \ + "pkgconfig(libosmoctrl)" \ + "pkgconfig(libosmovty)" \ + "pkgconfig(libosmo-pfcp)" \ + ;; \ + esac + +WORKDIR /tmp + +ARG OSMO_UPF_BRANCH="master" + +RUN git clone git://git.osmocom.org/osmo-upf.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-upf/+/refs/heads/$OSMO_UPF_… /tmp/commit-osmo-upf + +RUN cd osmo-upf && \ + git fetch && git checkout $OSMO_UPF_BRANCH && \ + (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_UPF_BRANCH || exit 1); \ + git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ + autoreconf -fi && \ + ./configure && \ + make "-j$(nproc)" install + +VOLUME /data + +COPY osmo-upf.cfg /data/osmo-upf.cfg + +WORKDIR /data +CMD ["/bin/sh", "-c", "/usr/local/bin/osmo-upf -c /data/osmo-upf.cfg >/data/osmo-upf.log 2>&1"] + +#EXPOSE diff --git a/osmo-upf-master/Makefile b/osmo-upf-master/Makefile new file mode 100644 index 0000000..3667084 --- /dev/null +++ b/osmo-upf-master/Makefile @@ -0,0 +1,3 @@ +RUN_ARGS?=--rm --network sigtran --ip 172.18.0.23 -v upf-vol:/data + +include ../make/Makefile diff --git a/osmo-upf-master/osmo-upf.cfg b/osmo-upf-master/osmo-upf.cfg new file mode 100644 index 0000000..5ece4b8 --- /dev/null +++ b/osmo-upf-master/osmo-upf.cfg @@ -0,0 +1,8 @@ +log stderr + logging filter all 1 + logging color 1 + logging print category 0 + logging timestamp 0 + logging level set-all notice +gtp + dev create apn23 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iceec912eef05bf4903ccc1fc30b0c7362145a1f1 Gerrit-Change-Number: 29444 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: .gitignore vim swp files

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29443 ) Change subject: .gitignore vim swp files ...................................................................... .gitignore vim swp files Change-Id: I5e67c42271aca9f81711e166324f70663e34cfcf --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index fe1b979..58a1b04 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,5 @@ /release-tarball-build-dist/_release_tarballs /release-tarball-build-dist/_temp + +.*.sw? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29443 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5e67c42271aca9f81711e166324f70663e34cfcf Gerrit-Change-Number: 29443 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-bts[master]: pcu_sock: fix sourcecode formatting

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29484 ) Change subject: pcu_sock: fix sourcecode formatting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib88173363fc11ad44a5bdbcd85ea8ca075db7997 Gerrit-Change-Number: 29484 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Sep 2022 11:48:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: add some guard space to message buffer

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29362 to look at the new patch set (#2). Change subject: pcu_sock: add some guard space to message buffer ...................................................................... pcu_sock: add some guard space to message buffer in osmo-pcu, the message buffer in pcu_sock_read is allocated with 1000 bytes in addition to the true size of the pcu_prim struct. Presumably this is to avoid compatibility problems in case the primitives slightly grow due to appending new struct members. Lets do the same in osmo-bts. Change-Id: I99f5204b0563f72f9da427bb7aa5451552d8c5b5 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/29362/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I99f5204b0563f72f9da427bb7aa5451552d8c5b5 Gerrit-Change-Number: 29362 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-bts[master]: pcu_sock: fix sourcecode formatting

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29484 ) Change subject: pcu_sock: fix sourcecode formatting ...................................................................... pcu_sock: fix sourcecode formatting Change-Id: Ib88173363fc11ad44a5bdbcd85ea8ca075db7997 --- M include/osmo-bts/pcu_if.h M src/common/pcu_sock.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/29484/1 diff --git a/include/osmo-bts/pcu_if.h b/include/osmo-bts/pcu_if.h index bc30f34..6cdc682 100644 --- a/include/osmo-bts/pcu_if.h +++ b/include/osmo-bts/pcu_if.h @@ -5,7 +5,7 @@ extern int pcu_direct; -#define PCUIF_HDR_SIZE ( sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u) ) +#define PCUIF_HDR_SIZE (sizeof(struct gsm_pcu_if) - sizeof(((struct gsm_pcu_if *)0)->u)) int pcu_tx_info_ind(void); int pcu_tx_si(const struct gsm_bts *bts, enum osmo_sysinfo_type si_type, bool enable); diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 980ed13..b7ec048 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -899,7 +899,7 @@ "size is %zu, discarding\n", prim_len, #prim_msg, _len); \ return -EINVAL; \ } \ - } while(0); + } while (0) static int pcu_rx(struct gsm_network *net, uint8_t msg_type, struct gsm_pcu_if *pcu_prim, size_t prim_len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib88173363fc11ad44a5bdbcd85ea8ca075db7997 Gerrit-Change-Number: 29484 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022