lists.osmocom.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
List overview
Download
gerrit-log
September 2022
----- 2025 -----
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
gerrit-log@lists.osmocom.org
2 participants
1860 discussions
Start a n
N
ew thread
Change in osmo-ttcn3-hacks[master]: hnbgw: Add missing results to expected-results.xml
by laforge
Attention is currently required from: pespin. laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29494
) Change subject: hnbgw: Add missing results to expected-results.xml ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29494
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26ccbaa2b071af981bf707b41bc26fb86de62d77 Gerrit-Change-Number: 29494 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 14:17:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
2 years, 9 months
1
0
0
0
Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_hnb_register_duplicate_reuse_sctp_assoc
by laforge
Attention is currently required from: osmith, neels, pespin, fixeria. laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29493
) Change subject: hnbgw: Introduce test TC_hnb_register_duplicate_reuse_sctp_assoc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29493
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09ce08917b590ecd6fdf93f8b564a0d53900c871 Gerrit-Change-Number: 29493 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 14:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
2 years, 9 months
1
0
0
0
Change in osmo-hnbgw[master]: hnbap: Improve logging around HNBAP HNB Register Request
by laforge
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29496
) Change subject: hnbap: Improve logging around HNBAP HNB Register Request ...................................................................... hnbap: Improve logging around HNBAP HNB Register Request Change-Id: I279ef563b38fb0dd3e6a72162db91d8503f91af8 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 841fba8..1c51b63 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -399,11 +399,15 @@ HNBAP_HNBRegisterRequestIEs_t ies; int rc; struct osmo_plmn_id plmn; + struct osmo_fd *ofd = osmo_stream_srv_get_ofd(ctx->conn); + char name[OSMO_SOCK_NAME_MAXLEN]; + + osmo_sock_get_name_buf(name, sizeof(name), ofd->fd); rc = hnbap_decode_hnbregisterrequesties(&ies, in); if (rc < 0) { - LOGHNB(ctx, DHNBAP, LOGL_ERROR, "Failure to decode HNB-REGISTER-REQ from %s: rc=%d\n", - ctx->identity_info, rc); + LOGHNB(ctx, DHNBAP, LOGL_ERROR, "Failure to decode HNB-REGISTER-REQ %s from %s: rc=%d\n", + ctx->identity_info, name, rc); return rc; } @@ -420,19 +424,17 @@ llist_for_each_entry(hnb, &ctx->gw->hnb_list, list) { if (hnb->hnb_registered && ctx != hnb && memcmp(&ctx->id, &hnb->id, sizeof(ctx->id)) == 0) { - struct osmo_fd *ofd = osmo_stream_srv_get_ofd(ctx->conn); - char *name = osmo_sock_get_name(ctx, ofd->fd); LOGHNB(ctx, DHNBAP, LOGL_ERROR, "rejecting HNB-REGISTER-REQ with duplicate cell identity " "MCC=%u,MNC=%u,LAC=%u,RAC=%u,SAC=%u,CID=%u from %s\n", ctx->id.mcc, ctx->id.mnc, ctx->id.lac, ctx->id.rac, ctx->id.sac, ctx->id.cid, name); - talloc_free(name); hnbap_free_hnbregisterrequesties(&ies); return hnbgw_tx_hnb_register_rej(ctx); } } - LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ from %s%s\n", ctx->identity_info, - ctx->hnb_registered ? " (duplicated)" : ""); + LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ %s MCC=%u,MNC=%u,LAC=%u,RAC=%u,SAC=%u,CID=%u from %s%s\n", + ctx->identity_info, ctx->id.mcc, ctx->id.mnc, ctx->id.lac, ctx->id.rac, ctx->id.sac, ctx->id.cid, + name, ctx->hnb_registered ? " (duplicated)" : ""); ctx->hnb_registered = true; -- To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29496
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I279ef563b38fb0dd3e6a72162db91d8503f91af8 Gerrit-Change-Number: 29496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged
2 years, 9 months
1
0
0
0
Change in osmo-hnbgw[master]: hnbap: Accept duplicated HNB Register Request on same conn
by laforge
laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29495
) Change subject: hnbap: Accept duplicated HNB Register Request on same conn ...................................................................... hnbap: Accept duplicated HNB Register Request on same conn As per what's indicated in 3GPP TS 25.469 8.2.4 Abnormal Conditions: """ If the HNB-GW receives a duplicate HNB REGISTER REQUEST (i.e. for an already registered HNB identified by the unique HNB identity), then the new HNB REGISTER REQUEST shall override the existing registration and the handling of the new HNB REGISTER REQUEST is according to section 8.2. """ Related: SYS#6113 Change-Id: I0250350a14a87498a2c68cd0c726ee2f1e72419d --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index c10864a..841fba8 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -431,9 +431,10 @@ } } - ctx->hnb_registered = true; + LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ from %s%s\n", ctx->identity_info, + ctx->hnb_registered ? " (duplicated)" : ""); - LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ from %s\n", ctx->identity_info); + ctx->hnb_registered = true; /* Send HNBRegisterAccept */ rc = hnbgw_tx_hnb_register_acc(ctx); @@ -550,9 +551,8 @@ } } else { switch (imsg->procedureCode) { - case HNBAP_ProcedureCode_id_HNBRegister: /* 8.2 */ - LOGHNB(hnb, DHNBAP, LOGL_NOTICE, - "HNBAP Procedure HNB-Register not permitted for registered HNB\n"); + case HNBAP_ProcedureCode_id_HNBRegister: /* 8.2.4: Abnormal Condition, Accept. */ + rc = hnbgw_rx_hnb_register_req(hnb, &imsg->value); break; case HNBAP_ProcedureCode_id_HNBDe_Register: /* 8.3 */ rc = hnbgw_rx_hnb_deregister(hnb, &imsg->value); -- To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29495
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0250350a14a87498a2c68cd0c726ee2f1e72419d Gerrit-Change-Number: 29495 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged
2 years, 9 months
1
0
0
0
Change in osmo-hnbgw[master]: hnbap: Improve logging around HNBAP HNB Register Request
by laforge
Attention is currently required from: osmith, neels, pespin, fixeria. laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29496
) Change subject: hnbap: Improve logging around HNBAP HNB Register Request ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29496
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I279ef563b38fb0dd3e6a72162db91d8503f91af8 Gerrit-Change-Number: 29496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 14:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
2 years, 9 months
1
0
0
0
Change in osmo-hnbgw[master]: hnbap: Accept duplicated HNB Register Request on same conn
by laforge
Attention is currently required from: osmith, neels, pespin, fixeria. laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29495
) Change subject: hnbap: Accept duplicated HNB Register Request on same conn ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29495
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0250350a14a87498a2c68cd0c726ee2f1e72419d Gerrit-Change-Number: 29495 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 14:16:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
2 years, 9 months
1
0
0
0
Change in osmo-bsc-nat[master]: [do not merge] test rpm/deb CI
by osmith
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492
) Change subject: [do not merge] test rpm/deb CI ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: testing for
https://osmocom.org/issues/2385
-- To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6842b5c641e6b6a0cfb428c7538e0a041751143e Gerrit-Change-Number: 29492 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 14:04:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
2 years, 9 months
1
0
0
0
Change in osmo-hnbgw[master]: hnbap: Accept duplicated HNB Register Request on same conn
by pespin
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29495
) Change subject: hnbap: Accept duplicated HNB Register Request on same conn ...................................................................... hnbap: Accept duplicated HNB Register Request on same conn As per what's indicated in 3GPP TS 25.469 8.2.4 Abnormal Conditions: """ If the HNB-GW receives a duplicate HNB REGISTER REQUEST (i.e. for an already registered HNB identified by the unique HNB identity), then the new HNB REGISTER REQUEST shall override the existing registration and the handling of the new HNB REGISTER REQUEST is according to section 8.2. """ Related: SYS#6113 Change-Id: I0250350a14a87498a2c68cd0c726ee2f1e72419d --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/95/29495/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index c10864a..841fba8 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -431,9 +431,10 @@ } } - ctx->hnb_registered = true; + LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ from %s%s\n", ctx->identity_info, + ctx->hnb_registered ? " (duplicated)" : ""); - LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ from %s\n", ctx->identity_info); + ctx->hnb_registered = true; /* Send HNBRegisterAccept */ rc = hnbgw_tx_hnb_register_acc(ctx); @@ -550,9 +551,8 @@ } } else { switch (imsg->procedureCode) { - case HNBAP_ProcedureCode_id_HNBRegister: /* 8.2 */ - LOGHNB(hnb, DHNBAP, LOGL_NOTICE, - "HNBAP Procedure HNB-Register not permitted for registered HNB\n"); + case HNBAP_ProcedureCode_id_HNBRegister: /* 8.2.4: Abnormal Condition, Accept. */ + rc = hnbgw_rx_hnb_register_req(hnb, &imsg->value); break; case HNBAP_ProcedureCode_id_HNBDe_Register: /* 8.3 */ rc = hnbgw_rx_hnb_deregister(hnb, &imsg->value); -- To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29495
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0250350a14a87498a2c68cd0c726ee2f1e72419d Gerrit-Change-Number: 29495 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
2 years, 9 months
1
0
0
0
Change in osmo-hnbgw[master]: hnbap: Improve logging around HNBAP HNB Register Request
by pespin
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29496
) Change subject: hnbap: Improve logging around HNBAP HNB Register Request ...................................................................... hnbap: Improve logging around HNBAP HNB Register Request Change-Id: I279ef563b38fb0dd3e6a72162db91d8503f91af8 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 9 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/96/29496/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 841fba8..1c51b63 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -399,11 +399,15 @@ HNBAP_HNBRegisterRequestIEs_t ies; int rc; struct osmo_plmn_id plmn; + struct osmo_fd *ofd = osmo_stream_srv_get_ofd(ctx->conn); + char name[OSMO_SOCK_NAME_MAXLEN]; + + osmo_sock_get_name_buf(name, sizeof(name), ofd->fd); rc = hnbap_decode_hnbregisterrequesties(&ies, in); if (rc < 0) { - LOGHNB(ctx, DHNBAP, LOGL_ERROR, "Failure to decode HNB-REGISTER-REQ from %s: rc=%d\n", - ctx->identity_info, rc); + LOGHNB(ctx, DHNBAP, LOGL_ERROR, "Failure to decode HNB-REGISTER-REQ %s from %s: rc=%d\n", + ctx->identity_info, name, rc); return rc; } @@ -420,19 +424,17 @@ llist_for_each_entry(hnb, &ctx->gw->hnb_list, list) { if (hnb->hnb_registered && ctx != hnb && memcmp(&ctx->id, &hnb->id, sizeof(ctx->id)) == 0) { - struct osmo_fd *ofd = osmo_stream_srv_get_ofd(ctx->conn); - char *name = osmo_sock_get_name(ctx, ofd->fd); LOGHNB(ctx, DHNBAP, LOGL_ERROR, "rejecting HNB-REGISTER-REQ with duplicate cell identity " "MCC=%u,MNC=%u,LAC=%u,RAC=%u,SAC=%u,CID=%u from %s\n", ctx->id.mcc, ctx->id.mnc, ctx->id.lac, ctx->id.rac, ctx->id.sac, ctx->id.cid, name); - talloc_free(name); hnbap_free_hnbregisterrequesties(&ies); return hnbgw_tx_hnb_register_rej(ctx); } } - LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ from %s%s\n", ctx->identity_info, - ctx->hnb_registered ? " (duplicated)" : ""); + LOGHNB(ctx, DHNBAP, LOGL_DEBUG, "HNB-REGISTER-REQ %s MCC=%u,MNC=%u,LAC=%u,RAC=%u,SAC=%u,CID=%u from %s%s\n", + ctx->identity_info, ctx->id.mcc, ctx->id.mnc, ctx->id.lac, ctx->id.rac, ctx->id.sac, ctx->id.cid, + name, ctx->hnb_registered ? " (duplicated)" : ""); ctx->hnb_registered = true; -- To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/29496
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I279ef563b38fb0dd3e6a72162db91d8503f91af8 Gerrit-Change-Number: 29496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
2 years, 9 months
1
0
0
0
Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_hnb_register_duplicate_reuse_sctp_assoc
by pespin
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29493
) Change subject: hnbgw: Introduce test TC_hnb_register_duplicate_reuse_sctp_assoc ...................................................................... hnbgw: Introduce test TC_hnb_register_duplicate_reuse_sctp_assoc Change-Id: I09ce08917b590ecd6fdf93f8b564a0d53900c871 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/29493/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index b1868c2..d77a18f 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -681,6 +681,8 @@ f_shutdown_helper(); } +/* Try to register the same HNB from 2 different concurrent connections. Second + * one should be rejected. */ testcase TC_hnb_register_duplicate() runs on test_CT { g_num_hnbs := 2; f_init(); @@ -690,6 +692,18 @@ f_shutdown_helper(); } +/* Try to register the same HNB in the same connection already established, aka + * duplicate HNB Register Request. It should be accepted and new configuration + * applied. TS 25.469 8.2.4 */ +testcase TC_hnb_register_duplicate_reuse_sctp_assoc() runs on test_CT { + g_num_hnbs := 1; + f_init(); + f_hnbap_register(0); + f_hnbap_register(0); + f_verify_talloc_count(HNBGWVTY, {"struct hnb_context"}, expect_count := 1); + f_shutdown_helper(); +} + /* Drop HNBAP conn (HNBAP DEREG) and reconnect it (HNBAP REG) using same SCTP association. * Related: OS#5676, SYS#6113 */ testcase TC_hnb_reregister_reuse_sctp_assoc() runs on test_CT { @@ -1431,6 +1445,7 @@ control { execute(TC_hnb_register()); execute(TC_hnb_register_duplicate()); + execute(TC_hnb_register_duplicate_reuse_sctp_assoc()); execute(TC_ranap_cs_initial_ue()); execute(TC_ranap_ps_initial_ue()); execute(TC_ranap_cs_initial_ue_empty_cr()); -- To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29493
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09ce08917b590ecd6fdf93f8b564a0d53900c871 Gerrit-Change-Number: 29493 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
2 years, 9 months
1
0
0
0
← Newer
1
...
28
29
30
31
32
33
34
...
186
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
Results per page:
10
25
50
100
200