September 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: cosmetic: osmux: Properly separate expressions with whitespace

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29515 ) Change subject: cosmetic: osmux: Properly separate expressions with whitespace ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I524899148da767516c7c1e4bc47b9d3a7b726356 Gerrit-Change-Number: 29515 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:30:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Fix AMR F,Q,CMR fields not properly encoded in osmux header

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29514 ) Change subject: osmux: Fix AMR F,Q,CMR fields not properly encoded in osmux header ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I06f3d07a05181d938c22bbd0da7172b5dad6659a Gerrit-Change-Number: 29514 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:30:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: tests/osmux: Add new osmux_input_test to validate AMR FT changes

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29513 ) Change subject: tests/osmux: Add new osmux_input_test to validate AMR FT changes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I105466fc8a4d92341f34886ee81ef0ca04014514 Gerrit-Change-Number: 29513 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:29:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: tests/osmux: Add new osmux_input_test to validate AMR FT changes

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29513 ) Change subject: tests/osmux: Add new osmux_input_test to validate AMR FT changes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I105466fc8a4d92341f34886ee81ef0ca04014514 Gerrit-Change-Number: 29513 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:29:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Proper encoding of osmux frames when when AMR FT changes

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29512 ) Change subject: osmux: Proper encoding of osmux frames when when AMR FT changes ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/osmux.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/41e78fbd_ecd777c2 PS1, Line 470: !state.rtph Why are you changing this? I guess because below in your code you're doing !foo. The existing code is doing "foo == NULL", so I would rather stay consistent. Not really critical, but still catches an eye. https://gerrit.osmocom.org/c/libosmo-netif/+/29512/comment/05b819ea_b3da177d PS1, Line 535: struct amr_hdr *amrh const? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I25eb6ee54c898f575cc71ccfd6d190fe51d56dbe Gerrit-Change-Number: 29512 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-hnodeb[master]: configure: don't turn some warnings into errors

by msuraev

Attention is currently required from: osmith. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 ) Change subject: configure: don't turn some warnings into errors ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > yes: the previous patch in this series adds --enable-werror, and that fails on some generated code. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: I783035fcded73f9c3938c4110ccb84eddc36a274 Gerrit-Change-Number: 26213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:14:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: amr: Add data[0] field to amr_hdr

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29511 ) Change subject: amr: Add data[0] field to amr_hdr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I72c0a001bf7ce9a63ac03beef352af177084e644 Gerrit-Change-Number: 29511 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:11:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-gbproxy[master]: implement LL DISCARD with second BVCI

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/29508 ) Change subject: implement LL DISCARD with second BVCI ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/29508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: Iaa488ee8ac3d85b86c0f360d9d6440f7cda82230 Gerrit-Change-Number: 29508 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 29 Sep 2022 08:10:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmocore[master]: Update multiaddr helper

by fixeria

Attention is currently required from: neels, pespin, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 ) Change subject: Update multiaddr helper ...................................................................... Patch Set 9: (6 comments) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/d53f555c_f92e43e0 PS9, Line 206: buf_len There is no 'buf_len' anymore. And it looks like this comment was initially incorrect: it should be host_count/addrs_count I guess? https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/929275f4_7dc7d54a PS9, Line 211: const char **hosts, size_t host_count, cosmetic: alignment needs to be fixed here https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/e19adda9_0983c84b PS9, Line 220: I think it makes sense to assert() here that either **hosts or **addrs is passed, not both at the same time. https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/1504e0df_a1cc8835 PS9, Line 236: if (hosts[i]) Before your patch this function would print "0.0.0.0" if hosts[i] is NULL. You're changing it to not print anything. What's your motivation? https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/eb09c2cb_42c8e947 PS9, Line 241: LOGL_DEBUG LOGL_ERROR? Not sure if we need to log anything here though. https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/eeab4d3a_6d3e68f1 PS9, Line 749: 512 Better do sizeof(strbuf). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 07:56:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-smlc[master]: configure.ac: set -std=gnu11

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29522 ) Change subject: configure.ac: set -std=gnu11 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-smlc/+/29522/comment/85c86810_fb28aab3 PS1, Line 14: https://lists.osmocom.org/pipermail/openbsc/2021-January/013360.html Minor: I think it makes sense to link to hyperkitty instead of the legacy archive (https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/message…) -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29522 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I76ed877d160f98e3627293b0539bec5fac1e8469 Gerrit-Change-Number: 29522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 29 Sep 2022 07:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022