August 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: README.md: fix module name: s/serial/pyserial/

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29229 ) Change subject: README.md: fix module name: s/serial/pyserial/ ...................................................................... README.md: fix module name: s/serial/pyserial/ Change-Id: I5fd308fb161cd5bd5f702845691296877e523248 --- M README.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/29229/1 diff --git a/README.md b/README.md index 75885fd..66bc0ce 100644 --- a/README.md +++ b/README.md @@ -35,7 +35,7 @@ Please install the following dependencies: - pyscard - - serial + - pyserial - pytlv - cmd2 >= 1.3.0 but < 2.0.0 - jsonpath-ng -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5fd308fb161cd5bd5f702845691296877e523248 Gerrit-Change-Number: 29229 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: Bump minimum required construct version to v2.9.51

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29227 ) Change subject: Bump minimum required construct version to v2.9.51 ...................................................................... Bump minimum required construct version to v2.9.51 With this version I can get all unittests passing: python -m unittest discover tests/ We're passing argument 'path' to stream_read_entire(), which was added in [1] and become available since v2.9.51. Change-Id: I4223c83570d333ad8d79bc2aa2d8bcc580156cff Related: [1] bfe71315b027e18e62f00ec4de75043992fd2316 construct.git Related: OS#5666 --- M setup.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/29227/1 diff --git a/setup.py b/setup.py index ec1a76a..b9ad1bf 100644 --- a/setup.py +++ b/setup.py @@ -14,7 +14,7 @@ "pytlv", "cmd2 >= 1.3.0, < 2.0.0", "jsonpath-ng", - "construct >= 2.9", + "construct >= 2.9.51", "bidict", "gsm0338", "termcolor", -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4223c83570d333ad8d79bc2aa2d8bcc580156cff Gerrit-Change-Number: 29227 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: README.md,requirements.txt: add missing construct version info

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29228 ) Change subject: README.md,requirements.txt: add missing construct version info ...................................................................... README.md,requirements.txt: add missing construct version info Change-Id: I90da0df431f0d7dbfa4aa428366fbf0e35db388f Related: OS#5666 --- M README.md M requirements.txt 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/28/29228/1 diff --git a/README.md b/README.md index e10820f..75885fd 100644 --- a/README.md +++ b/README.md @@ -39,7 +39,7 @@ - pytlv - cmd2 >= 1.3.0 but < 2.0.0 - jsonpath-ng - - construct + - construct >= 2.9.51 - bidict - gsm0338 diff --git a/requirements.txt b/requirements.txt index 320cc7a..4f037da 100644 --- a/requirements.txt +++ b/requirements.txt @@ -3,7 +3,7 @@ pytlv cmd2==1.5 jsonpath-ng -construct +construct>=2.9.51 bidict gsm0338 pyyaml>=5.1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I90da0df431f0d7dbfa4aa428366fbf0e35db388f Gerrit-Change-Number: 29228 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: construct: use Python's API for int<->bytes conversion

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29226 ) Change subject: construct: use Python's API for int<->bytes conversion ...................................................................... construct: use Python's API for int<->bytes conversion Argument 'signed' was added in [1] and become available since v2.10.63. Therefore using bytes2integer() and integer2bytes() from construct.core bumps the minimum required version of construct to v2.10.63. For instance, debian:bullseye currently ships v2.10.58. There is no strict requirement to use construct's API, so let's use Python's API instead. This allows using older construct versions from the v2.9.xx family. Change-Id: I613dbfebe993f9c19003635371941710fc1b1236 Related: [1] 660ddbe2d9a351731ad7976351adbf413809a715 construct.git Related: OS#5666 --- M pySim/construct.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/26/29226/1 diff --git a/pySim/construct.py b/pySim/construct.py index 4910a7f..97af235 100644 --- a/pySim/construct.py +++ b/pySim/construct.py @@ -2,7 +2,7 @@ from construct.core import EnumIntegerString import typing from construct import * -from construct.core import evaluate, bytes2integer, integer2bytes, BitwisableString +from construct.core import evaluate, BitwisableString from construct.lib import integertypes from pySim.utils import b2h, h2b, swap_nibbles import gsm0338 @@ -219,7 +219,7 @@ if evaluate(self.swapped, context): data = swapbytes(data) try: - return bytes2integer(data, self.signed) + return int.from_bytes(data, byteorder='big', signed=self.signed) except ValueError as e: raise IntegerError(str(e), path=path) @@ -248,7 +248,7 @@ raise IntegerError(f"value {obj} is not an integer", path=path) length = self.__bytes_required(obj, self.minlen) try: - data = integer2bytes(obj, length, self.signed) + data = obj.to_bytes(length, byteorder='big', signed=self.signed) except ValueError as e: raise IntegerError(str(e), path=path) if evaluate(self.swapped, context): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I613dbfebe993f9c19003635371941710fc1b1236 Gerrit-Change-Number: 29226 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-ggsn[master]: Ignore .deb build byproducts

by fixeria

Attention is currently required from: msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 ) Change subject: Ignore .deb build byproducts ...................................................................... Patch Set 2: (1 comment) File .gitignore: https://gerrit.osmocom.org/c/osmo-ggsn/+/29224/comment/46016d64_0dea5044 PS2, Line 27: # debian I suggest to move your new entries here, so that we have all debian stuff in one place. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iec63ef5ea0acfc5e6621054926be15ae4754d65d Gerrit-Change-Number: 29224 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 12:53:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-hlr[master]: Set working directory in systemd service file

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29225 ) Change subject: Set working directory in systemd service file ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I40b5d50470cb55ca94af5e17f21658181a02d4c2 Gerrit-Change-Number: 29225 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Aug 2022 12:48:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ggsn[master]: Set working directory in systemd service file

by msuraev

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 to look at the new patch set (#2). Change subject: Set working directory in systemd service file ...................................................................... Set working directory in systemd service file By default systemd will execute service with root directory (or home directory for user instance) which might result in attempts to create files in unexpected place. Let's set it to 'osmocom' subdir of state directory (/var/lib for system instance) instead. Related: OS#4821 Change-Id: Idffc115c21cac77f6f43356333de538ba549fc6a --- M contrib/systemd/osmo-ggsn.service 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/23/29223/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idffc115c21cac77f6f43356333de538ba549fc6a Gerrit-Change-Number: 29223 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 8 months

1
0
0 0

Change in osmo-ggsn[master]: Set working directory in systemd service file

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 ) Change subject: Set working directory in systemd service file ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idffc115c21cac77f6f43356333de538ba549fc6a Gerrit-Change-Number: 29223 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Aug 2022 12:01:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ggsn[master]: Ignore .deb build byproducts

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 ) Change subject: Ignore .deb build byproducts ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iec63ef5ea0acfc5e6621054926be15ae4754d65d Gerrit-Change-Number: 29224 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Aug 2022 12:00:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels, laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: > I've added comment to the line which raised questions - hopefully this would clarify things. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 10:26:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels, laforge, fixeria. Hello Jenkins Builder, neels, laforge, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 to look at the new patch set (#15). Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD The length limit of optional Data parameter is 130 bytes according to ITU-T Rec Q.713 §4.2..§4.5. If we receive CR, CC or RLSD message with bigger data - cache it if necessary and send via separate DT1 message after connection becomes active. While at it, clarify the order of comments in the encoding routine to match the spec. Fixes: OS#5579 Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a --- M src/sccp_scoc.c 1 file changed, 132 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/29084/15 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 15 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 8 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels, laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 14: (4 comments) This change is ready for review. Patchset: PS14: I've added comment to the line which raised questions - hopefully this would clarify things. File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/6ce89fd4_8d05fbff PS8, Line 659: break > drop the "break;" Done File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/48dbaa89_d31e82c7 PS14, Line 603: if (conn->opt_data_cache->cb[0] != exp_type) > cosmetic: we use curly braces around multi-line blocks, even if it's only a single statement within […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/a86dafd8_0ce12659 PS14, Line 1110: xua_opt_data_send_cache(conn, SUA_CO_CORE, xua->hdr.msg_class); > or maybe this? […] I think I'm missing a point in here. Could you elaborate - what exactly you think should be changed in here and why? That's both the intention behind this code and how the result looks like in wireshark: A B ------> Conn Req (cache Optional Data) <------ Conn Conf ------> DT1 with cached data When the lib receieve CR with way too much data (but not big enough to not fit into DT1) we cache it, send CR without optional data and send DT1 after receiving CC. To make sure we do not interfere with regular user traffic the DT1 (with outstanding optional data from CR) is sent here from conn_pend_out state before we notify lib user that CC was received. You can reproduce this yourself by following readme for examples/ code which is already merged to master. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 10:25:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: update expected-results.xml

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216 ) Change subject: bts: update expected-results.xml ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcd8601d1aadce78a1b0a0ed814ae9e77e8497aa Gerrit-Change-Number: 29216 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 09:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control

by osmith

Attention is currently required from: Hoernchen, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 ) Change subject: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 Gerrit-Change-Number: 29215 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 09:07:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 ) Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Gerrit-Change-Number: 29217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 09:05:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:59:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: also execute maintainer-clean target

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29218 ) Change subject: contrib/jenkins.sh: also execute maintainer-clean target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c Gerrit-Change-Number: 29218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:59:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29220 ) Change subject: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:58:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-smlc[master]: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL...

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29221 ) Change subject: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:58:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:57:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic

by osmith

Attention is currently required from: neels, laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 ) Change subject: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 Gerrit-Change-Number: 29202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 08:56:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... contrib/jenkins.sh: do not override parallel make for libsmpp34 Parallel build has been fixed [1] and re-enabled [2] back in 2018. Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12 libsmpp34.git Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70 libsmpp34.git --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/29222/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fb858d7..e1bbad4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -35,7 +35,7 @@ osmo-build-dep.sh libosmo-abis osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp -PARALLEL_MAKE="" osmo-build-dep.sh libsmpp34 +osmo-build-dep.sh libsmpp34 osmo-build-dep.sh osmo-mgw osmo-build-dep.sh osmo-hlr -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-smlc[master]: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL...

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29221 ) Change subject: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/21/29221/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 939a514..62e6516 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -58,12 +58,12 @@ || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" \ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi -$MAKE maintainer-clean +$MAKE $PARALLEL_MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29220 ) Change subject: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/20/29220/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 0848bea..f3331af 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -51,7 +51,7 @@ ./configure --enable-sanitize --enable-werror --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh $MAKE $PARALLEL_MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: actually build with $PARALLEL_MAKE Executing $MAKE without $PARALLEL_MAKE builds the project with -j1. Executing $MAKE with $PARALLEL_MAKE after that makes no sense, because everything is already compiled and there is nothing to do. Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 --- M contrib/jenkins.sh 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/19/29219/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 3b4e639..7a75e25 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -7,7 +7,6 @@ autoreconf --install --force ./configure --enable-sanitize --enable-werror -$MAKE $MAKE $PARALLEL_MAKE $MAKE distcheck || cat-testlogs.sh $MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: also execute maintainer-clean target

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29218 ) Change subject: contrib/jenkins.sh: also execute maintainer-clean target ...................................................................... contrib/jenkins.sh: also execute maintainer-clean target Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/18/29218/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 104ba2a..0848bea 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -53,6 +53,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE $PARALLEL_MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c Gerrit-Change-Number: 29218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: debian,RPM: package with PFCP support

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 ) Change subject: debian,RPM: package with PFCP support ...................................................................... debian,RPM: package with PFCP support - depend on libosmo-pfcp - configure --enable-pfcp Related: SYS#5895 Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0 --- M contrib/osmo-hnbgw.spec.in M debian/control M debian/rules 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index a4379fa..75b1e51 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -45,6 +45,7 @@ BuildRequires: pkgconfig(libosmo-hnbap) >= 1.3.0 BuildRequires: pkgconfig(libosmo-ranap) >= 1.3.0 BuildRequires: pkgconfig(libosmo-rua) >= 1.3.0 +BuildRequires: pkgconfig(libosmo-pfcp) >= 0.1.0 BuildRequires: pkgconfig(talloc) BuildRequires: pkgconfig(libasn1c) >= 0.9.30 %{?systemd_requires} @@ -60,7 +61,8 @@ autoreconf -fi %configure \ --docdir=%{_docdir}/%{name} \ - --with-systemdsystemunitdir=%{_unitdir} + --with-systemdsystemunitdir=%{_unitdir} \ + --enable-pfcp make %{?_smp_mflags} %install diff --git a/debian/control b/debian/control index 3fe8035..0aed0f4 100644 --- a/debian/control +++ b/debian/control @@ -21,6 +21,7 @@ libosmo-hnbap-dev (>= 1.3.0), libosmo-ranap-dev (>= 1.3.0), libosmo-rua-dev (>= 1.3.0), + libosmo-pfcp-dev (>= 0.1.0), osmo-gsm-manuals-dev (>= 1.3.0) Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/osmo-hnbgw diff --git a/debian/rules b/debian/rules index bce8ed6..f341a84 100755 --- a/debian/rules +++ b/debian/rules @@ -46,6 +46,7 @@ # debmake generated override targets CONFIGURE_FLAGS += --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals +CONFIGURE_FLAGS += --enable-pfcp override_dh_auto_configure: dh_auto_configure -- $(CONFIGURE_FLAGS) # -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0 Gerrit-Change-Number: 29002 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: debian,RPM: package with PFCP support

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 ) Change subject: debian,RPM: package with PFCP support ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: libosmo-pfcp shows as succeeded in obs for nightly and latest; it is disabled on CentOS7, but so is osmo-hnbgw. my "home" build on obs worked, so this should succeed now... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0 Gerrit-Change-Number: 29002 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 27 Aug 2022 16:02:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 ) Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY ...................................................................... osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY The PRIM_INFO_MODIFY is sent on receipt of the RSL MODE MODIFY message, which may optionally contain new ciphering parameters. Before this patch, osmo-bts-trx would ignore the new parameters and continue using the old ciphering key/algorithm. * Modify l1if_set_ciphering() to allow updating ciphering params. * Call l1if_set_ciphering() when handling PRIM_INFO_MODIFY. This problem was uncovered by BTS_Tests.TC_rsl_modify_encr, which has been failing ever since it was introduced [1]. This patch makes it pass. Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Related: [1] I4cbea499bb6a331d314e6573548a4540945208b5 osmo-ttcn3-hacks.git Related: OS#3750 --- M src/osmo-bts-trx/l1_if.c 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/29217/1 diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 92180b5..8c364c3 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -326,8 +326,8 @@ /* enable ciphering */ static int l1if_set_ciphering(struct gsm_lchan *lchan, uint8_t chan_nr, int downlink) { - /* ciphering already enabled in both directions */ - if (lchan->ciph_state == LCHAN_CIPH_RXTX_CONF) + /* ignore the request when the channel is not active */ + if (lchan->state != LCHAN_S_ACTIVE) return -EINVAL; if (!downlink) { @@ -463,6 +463,13 @@ lchan->tch.amr_mr.mode[3].mode, amr_get_initial_mode(lchan), 0); + /* update ciphering params */ + l1if_set_ciphering(lchan, chan_nr, 0); + l1if_set_ciphering(lchan, chan_nr, 1); + if (lchan->encr.alg_id) + lchan->ciph_state = LCHAN_CIPH_RXTX_CONF; + else + lchan->ciph_state = LCHAN_CIPH_NONE; break; } /* here, type == PRIM_INFO_DEACTIVATE */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Gerrit-Change-Number: 29217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 ) Change subject: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control ...................................................................... BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control Both testcases were introduced in 2021 [1], however they're not executed on Jenkins because they're not present in control section. Fixes: [1] I38e8a1cf15eb41a621b457b39024283a767c94be Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/29215/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b2d6383..f9361a0 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8726,9 +8726,11 @@ execute( TC_chan_act_a51() ); execute( TC_chan_act_a52() ); execute( TC_chan_act_a53() ); + execute( TC_chan_act_a54() ); execute( TC_encr_cmd_a51() ); execute( TC_encr_cmd_a52() ); execute( TC_encr_cmd_a53() ); + execute( TC_encr_cmd_a54() ); execute( TC_err_rep_wrong_mdisc() ); execute( TC_err_rep_wrong_msg_type() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 Gerrit-Change-Number: 29215 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: update expected-results.xml

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216 ) Change subject: bts: update expected-results.xml ...................................................................... bts: update expected-results.xml Change-Id: Ifcd8601d1aadce78a1b0a0ed814ae9e77e8497aa --- M bts/expected-results.xml 1 file changed, 69 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/29216/1 diff --git a/bts/expected-results.xml b/bts/expected-results.xml index e3804a4..38b283f 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -1,5 +1,6 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='156' failures='18' errors='1' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='220' failures='12' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='BTS_Tests' name='TC_est_dchan' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_chan_act_stress' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_chan_act_react' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_chan_deact_not_active' time='MASKED'/> @@ -13,11 +14,12 @@ <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_async' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_sacch_chan_act_ho_sync' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_content' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_rach_content_emerg' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_count' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_max_ta' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_ho_rach' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_ho_physical_info' time='MASKED'> - <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : Rx unexpected Downlink DCCH (before handover RACH): MASKED" + <failure type='fail-verdict'>Rx unexpected Downlink DCCH (before handover RACH): MASKED BTS_Tests.ttcn:MASKED BTS_Tests control part BTS_Tests.ttcn:MASKED TC_ho_physical_info testcase </failure> @@ -25,11 +27,21 @@ <testcase classname='BTS_Tests' name='TC_rach_load_idle_thresh0' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_load_idle_below_thresh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rach_load_count' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_meas_res_speech_tchf' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_meas_res_speech_tchf_facch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_meas_res_speech_tchh' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_meas_res_speech_tchh_facch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_meas_res_speech_tchh_toa256' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_meas_res_sign_tchf' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_meas_res_sign_tchh' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_meas_res_sign_sdcch4' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_meas_res_sign_sdcch8' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_meas_res_sign_tchh_toa256' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_meas_res_speech_tchf_sapi3' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_meas_res_speech_tchh_sapi3' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_tx_power_start_ramp_up_bcch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_tx_power_start_ramp_down_bcch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_tx_power_ramp_adm_state_change' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rsl_bs_pwr_static_ass' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rsl_bs_pwr_static_power_control' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rsl_ms_pwr_ctrl' time='MASKED'/> @@ -41,10 +53,11 @@ <testcase classname='BTS_Tests' name='TC_rsl_ms_pwr_dyn_max' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rsl_chan_initial_ms_pwr' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rsl_chan_initial_ta' time='MASKED'/> - <testcase classname='BTS_Tests' name='TC_rsl_modify_encr' time='MASKED'> - <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : BTS shouldn't be able to decrypt after key change" + <testcase classname='BTS_Tests' name='TC_rsl_modify_encr' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_rsl_rf_resource_ind' time='MASKED'> + <failure type='fail-verdict'>RF RESource INDication mismatch: MASKED BTS_Tests.ttcn:MASKED BTS_Tests control part - BTS_Tests.ttcn:MASKED TC_rsl_modify_encr testcase + BTS_Tests.ttcn:MASKED TC_rsl_rf_resource_ind testcase </failure> </testcase> <testcase classname='BTS_Tests' name='TC_conn_fail_crit' time='MASKED'/> @@ -68,12 +81,21 @@ <testcase classname='BTS_Tests' name='TC_ipa_crcx_mdcx_dlcx_not_active' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_ipa_crcx_mdcx_mdcx_dlcx_not_active' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_ipa_crcx_sdcch_not_active' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_ipa_crcx_ack_addr' time='MASKED'> + <failure type='fail-verdict'>CRCX ACK indicates nonsense addr "0.0.0.0" + BTS_Tests.ttcn:MASKED BTS_Tests control part + BTS_Tests.ttcn:MASKED TC_ipa_crcx_ack_addr testcase + </failure> + </testcase> + <testcase classname='BTS_Tests' name='TC_paging_imsi_200percent_with_ps' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_act_req' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_act_req_wrong_ts' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_act_req_wrong_bts' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_act_req_wrong_trx' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_deact_req' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_deact_req_wrong_ts' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_ver_si1' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_ver_si3' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_ver_si13' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_ptcch' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_pcu_data_req_agch' time='MASKED'/> @@ -105,9 +127,20 @@ <testcase classname='BTS_Tests' name='TC_dyn_osmo_pdch_double_act' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_dyn_ipa_pdch_act_deact' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_dyn_ipa_pdch_act_tchf_act_nack' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_info_ind_fh_params' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_socket_nsvc_ipv4' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_socket_nsvc_ipv6' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_pcu_socket_two_nsvc' time='MASKED'> + <failure type='fail-verdict'>NSVCI { 1234, 0 } does not match { 1234, 5678 } + BTS_Tests.ttcn:MASKED BTS_Tests control part + BTS_Tests.ttcn:MASKED TC_pcu_socket_two_nsvc testcase + </failure> + </testcase> + <testcase classname='BTS_Tests' name='TC_pcu_interf_ind' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_dyn_osmo_pdch_unsol_deact' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_dyn_osmo_pdch_tchf_act' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_dyn_osmo_pdch_tchh_act' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_dyn_osmo_pdch_sdcch8_act' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_dyn_ipa_pdch_tchf_act' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_dyn_ipa_pdch_tchf_act_pdch_act_nack' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_rll_est_ind' time='MASKED'/> @@ -136,13 +169,27 @@ <testcase classname='BTS_Tests' name='TC_lapdm_selftest' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_tch_sign_l2_fill_frame' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_tch_sign_l2_fill_frame_dtxd' time='MASKED'> - <failure type='fail-verdict'>"BTS_Tests.ttcn:MASKED : Not enough fill frames received" + <failure type='fail-verdict'>Received DTX TCH fill frame with bad frame number: MASKED BTS_Tests.ttcn:MASKED BTS_Tests control part BTS_Tests.ttcn:MASKED TC_tch_sign_l2_fill_frame_dtxd testcase </failure> </testcase> <testcase classname='BTS_Tests' name='TC_chopped_ipa_ping' time='MASKED'/> <testcase classname='BTS_Tests' name='TC_chopped_ipa_payload' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_ms_pwr_ctrl_constant' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_ms_pwr_ctrl_pf_ewma' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_speech_no_rtp_tchf' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_speech_no_rtp_tchh' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_speech_rtp_tchf' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_speech_rtp_tchh' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_early_immediate_assignment' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_acch_overpower_rxqual_thresh' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_acch_overpower_rxqual_thresh_dtx' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_acch_overpower_always_on_facch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_acch_overpower_always_on_sacch' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_acch_overpower_limit' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_dyn_osmo_pdch_tchh_race_act' time='MASKED'/> + <testcase classname='BTS_Tests' name='TC_dyn_osmo_pdch_sdcch8_race_act' time='MASKED'/> <testcase classname='BTS_Tests_SMSCB' name='TC_cbch_load_idle_no_cbch' time='MASKED'/> <testcase classname='BTS_Tests_SMSCB' name='TC_sms_cb_cmd_sdcch4_1block' time='MASKED'/> <testcase classname='BTS_Tests_SMSCB' name='TC_sms_cb_cmd_sdcch4_2block' time='MASKED'/> @@ -214,4 +261,20 @@ <testcase classname='BTS_Tests_LAPDm' name='TC_rr_response_frame_loss' time='MASKED'/> <testcase classname='BTS_Tests_LAPDm' name='TC_incorrect_cr' time='MASKED'/> <testcase classname='BTS_Tests_LAPDm' name='TC_sabm_incorrect_c' time='MASKED'/> + <testcase classname='BTS_Tests_LAPDm' name='TC_normal_reestablishment' time='MASKED'/> + <testcase classname='BTS_Tests_LAPDm' name='TC_normal_reestablishment_state_unacked' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_act_vff' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_act_vhh' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_act_hvhh' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_act_dyn_ipa_vff' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_act_dyn_osmo_vff' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_act_dyn_osmo_vhh' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_act_dyn_osmo_hvhh' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_mode_modify_vff' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_mode_modify_vhh' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_mode_modify_hvhh' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_mode_modify_dyn_ipa_vff' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_mode_modify_dyn_osmo_vff' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_mode_modify_dyn_osmo_vhh' time='MASKED'/> + <testcase classname='BTS_Tests_VAMOS' name='TC_vamos_chan_mode_modify_dyn_osmo_hvhh' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcd8601d1aadce78a1b0a0ed814ae9e77e8497aa Gerrit-Change-Number: 29216 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: packate the new osmo-hnbgw-pfcp.cfg example config file

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164 ) Change subject: packate the new osmo-hnbgw-pfcp.cfg example config file ...................................................................... packate the new osmo-hnbgw-pfcp.cfg example config file In I62c4935bcc7f684bfe850f88f1b80e8970e0e098 we added a new example config file, but didn't actually package it in dpkg or rpm packages yet. This also lead to package build failures like: [ 39s] RPM build errors: [ 39s] Installed (but unpackaged) file(s) found: [ 39s] /usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg Change-Id: I7c5c346f67f003b2cc5d74e812441c3704b133ef --- M debian/osmo-hnbgw.install 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/osmo-hnbgw.install b/debian/osmo-hnbgw.install index ac1f931..daf1f1a 100644 --- a/debian/osmo-hnbgw.install +++ b/debian/osmo-hnbgw.install @@ -2,3 +2,4 @@ lib/systemd/system/osmo-hnbgw.service usr/bin/osmo-hnbgw usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw.cfg usr/share/doc/osmo-hnbgw/examples +usr/share/doc/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg usr/share/doc/osmo-hnbgw/examples -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7c5c346f67f003b2cc5d74e812441c3704b133ef Gerrit-Change-Number: 29164 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: packate the new osmo-hnbgw-pfcp.cfg example config file

by neels

Attention is currently required from: laforge. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164 ) Change subject: packate the new osmo-hnbgw-pfcp.cfg example config file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29164 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7c5c346f67f003b2cc5d74e812441c3704b133ef Gerrit-Change-Number: 29164 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 26 Aug 2022 11:53:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-upf[master]: drop charts/, duplicated from libosmo-pfcp.git

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29211 ) Change subject: drop charts/, duplicated from libosmo-pfcp.git ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I95f11e1525b3bc6b782e5f8aecddea672a104c99 Gerrit-Change-Number: 29211 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 11:47:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: fix nftables errors on centos8

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29214 ) Change subject: repo-install-test: fix nftables errors on centos8 ...................................................................... repo-install-test: fix nftables errors on centos8 Don't attempt to install nftables-devel or python3-nftables in centos8 in the repo-install-test. What happens is, that dnf tries to install the versions from the centos repositories, which conflict with the ones from the OBS repositories. This fixes the failing Osmocom-repo-install-centos8 jenkins job. Change-Id: I57670069cc09a5493667971997f0245e1d6a7259 --- M scripts/repo-install-test/blacklist_centos8.txt 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/scripts/repo-install-test/blacklist_centos8.txt b/scripts/repo-install-test/blacklist_centos8.txt index 83d2cbd..3e5381d 100644 --- a/scripts/repo-install-test/blacklist_centos8.txt +++ b/scripts/repo-install-test/blacklist_centos8.txt @@ -9,3 +9,7 @@ # the dependency problem means that we can't simply install the package in # centos. In OBS we work around this in the project config. ulfius-devel + +# Also linked to opensuse versions +nftables-devel +python3-nftables -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I57670069cc09a5493667971997f0245e1d6a7259 Gerrit-Change-Number: 29214 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-upf[master]: osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29213 ) Change subject: osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error ...................................................................... osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error Fix for building on opensuse 15.4 with GCC 7.5.0+r278197: osmo_pfcp_tool_main.c:219:15: error: initializer element is not constant .copyright = osmo_pfcp_tool_copyright, The variable is only used once, so move its contents directly into the struct vty_app_info, like it is done in osmo_upf_main.c. Fixes: OS#5655 Change-Id: Iff273283a082bb6d07c4c98d421b17b54457abe1 --- M src/osmo-pfcp-tool/osmo_pfcp_tool_main.c 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, approved diff --git a/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c b/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c index 43c3b45..e950f7f 100644 --- a/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c +++ b/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c @@ -206,17 +206,16 @@ } } -static const char * const osmo_pfcp_tool_copyright = - "OsmoPFCPTool - Osmocom Packet Forwarding Control Protocol tool for testing\r\n" - "Copyright (C) 2021-2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>\r\n" - "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" - "This is free software: you are free to change and redistribute it.\r\n" - "There is NO WARRANTY, to the extent permitted by law.\r\n"; static struct vty_app_info pfcp_tool_vty_app_info = { .name = "osmo-pfcp-tool", .version = PACKAGE_VERSION, - .copyright = osmo_pfcp_tool_copyright, + .copyright = + "OsmoPFCPTool - Osmocom Packet Forwarding Control Protocol tool for testing\r\n" + "Copyright (C) 2021-2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>\r\n" + "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" + "This is free software: you are free to change and redistribute it.\r\n" + "There is NO WARRANTY, to the extent permitted by law.\r\n", }; static const struct log_info_cat pfcp_tool_default_categories[] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iff273283a082bb6d07c4c98d421b17b54457abe1 Gerrit-Change-Number: 29213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-upf[master]: osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29213 ) Change subject: osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iff273283a082bb6d07c4c98d421b17b54457abe1 Gerrit-Change-Number: 29213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 11:40:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: fix nftables errors on centos8

by neels

Attention is currently required from: osmith, fixeria, daniel. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29214 ) Change subject: repo-install-test: fix nftables errors on centos8 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I57670069cc09a5493667971997f0245e1d6a7259 Gerrit-Change-Number: 29214 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 11:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: fix nftables errors on centos8

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29214 ) Change subject: repo-install-test: fix nftables errors on centos8 ...................................................................... repo-install-test: fix nftables errors on centos8 Don't attempt to install nftables-devel or python3-nftables in centos8 in the repo-install-test. What happens is, that dnf tries to install the versions from the centos repositories, which conflict with the ones from the OBS repositories. This fixes the failing Osmocom-repo-install-centos8 jenkins job. Change-Id: I57670069cc09a5493667971997f0245e1d6a7259 --- M scripts/repo-install-test/blacklist_centos8.txt 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/14/29214/1 diff --git a/scripts/repo-install-test/blacklist_centos8.txt b/scripts/repo-install-test/blacklist_centos8.txt index 83d2cbd..3e5381d 100644 --- a/scripts/repo-install-test/blacklist_centos8.txt +++ b/scripts/repo-install-test/blacklist_centos8.txt @@ -9,3 +9,7 @@ # the dependency problem means that we can't simply install the package in # centos. In OBS we work around this in the project config. ulfius-devel + +# Also linked to opensuse versions +nftables-devel +python3-nftables -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I57670069cc09a5493667971997f0245e1d6a7259 Gerrit-Change-Number: 29214 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in libosmocore[master]: Use osmo_sockaddr_strs_to_str() for multiaddr helper

by laforge

Attention is currently required from: msuraev. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 ) Change subject: Use osmo_sockaddr_strs_to_str() for multiaddr helper ...................................................................... Removed Code-Review+1 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icef53fe4b6e51563d97a1bc48001d67679b3b6e9 Gerrit-Change-Number: 28993 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 year, 8 months

1
0
0 0

Change in libosmocore[master]: Make osmo_sockaddr_str_from_sockaddr() less picky

by laforge

Attention is currently required from: pespin, msuraev, dexter. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28995 ) Change subject: Make osmo_sockaddr_str_from_sockaddr() less picky ...................................................................... Removed Code-Review+1 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf Gerrit-Change-Number: 28995 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 year, 8 months

1
0
0 0

Change in libosmo-netif[master]: Properly handle send() return code

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29178 ) Change subject: Properly handle send() return code ...................................................................... Properly handle send() return code Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9 --- M src/stream.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/stream.c b/src/stream.c index dc44a1c..a7053e9 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1330,8 +1330,8 @@ default: ret = -ENOTSUP; } - if (ret < 0) { - LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", strerror(-ret)); + if (ret < 0) { /* send(): On error , -1 is returned, and errno is set appropriately */ + LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", (ret == -1) ? strerror(errno) : strerror(-ret)); } msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9 Gerrit-Change-Number: 29178 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in libosmo-netif[master]: Properly handle send() return code

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29178 ) Change subject: Properly handle send() return code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: If9b80e855b740254d5414ea50b4ce594855da8e9 Gerrit-Change-Number: 29178 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 09:29:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by laforge

Attention is currently required from: fixeria, msuraev. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Removed Code-Review+1 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 year, 8 months

1
0
0 0

Change in osmo-upf[master]: osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/29213 ) Change subject: osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error ...................................................................... osmo_pfcp_tool: fix osmo_pfcp_tool_copyright error Fix for building on opensuse 15.4 with GCC 7.5.0+r278197: osmo_pfcp_tool_main.c:219:15: error: initializer element is not constant .copyright = osmo_pfcp_tool_copyright, The variable is only used once, so move its contents directly into the struct vty_app_info, like it is done in osmo_upf_main.c. Fixes: OS#5655 Change-Id: Iff273283a082bb6d07c4c98d421b17b54457abe1 --- M src/osmo-pfcp-tool/osmo_pfcp_tool_main.c 1 file changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/13/29213/1 diff --git a/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c b/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c index 43c3b45..e950f7f 100644 --- a/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c +++ b/src/osmo-pfcp-tool/osmo_pfcp_tool_main.c @@ -206,17 +206,16 @@ } } -static const char * const osmo_pfcp_tool_copyright = - "OsmoPFCPTool - Osmocom Packet Forwarding Control Protocol tool for testing\r\n" - "Copyright (C) 2021-2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>\r\n" - "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" - "This is free software: you are free to change and redistribute it.\r\n" - "There is NO WARRANTY, to the extent permitted by law.\r\n"; static struct vty_app_info pfcp_tool_vty_app_info = { .name = "osmo-pfcp-tool", .version = PACKAGE_VERSION, - .copyright = osmo_pfcp_tool_copyright, + .copyright = + "OsmoPFCPTool - Osmocom Packet Forwarding Control Protocol tool for testing\r\n" + "Copyright (C) 2021-2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>\r\n" + "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" + "This is free software: you are free to change and redistribute it.\r\n" + "There is NO WARRANTY, to the extent permitted by law.\r\n", }; static const struct log_info_cat pfcp_tool_default_categories[] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iff273283a082bb6d07c4c98d421b17b54457abe1 Gerrit-Change-Number: 29213 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: debian,RPM: package with PFCP support

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 ) Change subject: debian,RPM: package with PFCP support ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I54dfe600d45541fecbb4c05bf75f147934c230f0 Gerrit-Change-Number: 29002 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 05:39:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-upf[master]: Allow running without a GTP dev

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29210 ) Change subject: Allow running without a GTP dev ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ibb79b3ce1906136f77a895ff6f691d72a92c9fb9 Gerrit-Change-Number: 29210 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 05:38:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-upf[master]: drop charts/, duplicated from libosmo-pfcp.git

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29211 ) Change subject: drop charts/, duplicated from libosmo-pfcp.git ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I95f11e1525b3bc6b782e5f8aecddea672a104c99 Gerrit-Change-Number: 29211 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 05:38:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-sgsn[master]: gprs_llc: fix misleading spacing in gprs_llc_rcvmsg()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29212 ) Change subject: gprs_llc: fix misleading spacing in gprs_llc_rcvmsg() ...................................................................... gprs_llc: fix misleading spacing in gprs_llc_rcvmsg() Change-Id: I7ec97a7d9b37f0541887bc13e31f547613f8945e --- M src/sgsn/gprs_llc.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sgsn/gprs_llc.c b/src/sgsn/gprs_llc.c index 453ded5..f16f200 100644 --- a/src/sgsn/gprs_llc.c +++ b/src/sgsn/gprs_llc.c @@ -965,9 +965,9 @@ llhp.data); if (rc < 0) return rc; - llhp.fcs = *(llhp.data + llhp.data_len); - llhp.fcs |= *(llhp.data + llhp.data_len + 1) << 8; - llhp.fcs |= *(llhp.data + llhp.data_len + 2) << 16; + llhp.fcs = *(llhp.data + llhp.data_len); + llhp.fcs |= *(llhp.data + llhp.data_len + 1) << 8; + llhp.fcs |= *(llhp.data + llhp.data_len + 2) << 16; } else { LOGP(DLLC, LOGL_NOTICE, "encrypted frame for LLC that " "has no KC/Algo! Dropping.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7ec97a7d9b37f0541887bc13e31f547613f8945e Gerrit-Change-Number: 29212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-sgsn[master]: gprs_llc: fix misleading spacing in gprs_llc_rcvmsg()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29212 ) Change subject: gprs_llc: fix misleading spacing in gprs_llc_rcvmsg() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7ec97a7d9b37f0541887bc13e31f547613f8945e Gerrit-Change-Number: 29212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Aug 2022 05:37:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

2024

2023

2022

gerrit-log August 2022