August 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29239 ) Change subject: contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5 ...................................................................... contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5 pylint v2.15 is crashing, let's fall-back to a known to work v2.14.5. Change-Id: Ie29be6ec6631ff2b3d8cd6b2dd9ac0ed8f505e4f Related: https://github.com/PyCQA/pylint/issues/7375 Related: OS#5668 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/39/29239/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index ac5fba8..bdf1311 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -36,7 +36,7 @@ # Ignore E0401: import-error # pySim/utils.py:276: E0401: Unable to import 'Crypto.Cipher' (import-error) # pySim/utils.py:277: E0401: Unable to import 'Crypto.Util.strxor' (import-error) -pip install pylint +pip install pylint==2.14.5 # FIXME: 2.15 is crashing, see OS#5668 python -m pylint --errors-only \ --disable E1102 \ --disable E0401 \ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29239 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie29be6ec6631ff2b3d8cd6b2dd9ac0ed8f505e4f Gerrit-Change-Number: 29239 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: speed up pylint by running multiple processes

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29240 ) Change subject: contrib/jenkins.sh: speed up pylint by running multiple processes ...................................................................... contrib/jenkins.sh: speed up pylint by running multiple processes Use multiple processes to speed up pylint. Specifying -j0 will auto-detect the number of processors available to use. On AMD Ryzen 7 3700X this significantly reduces the exec time: $ time python -m pylint -j1 ... pySim *.py real 0m12.409s user 0m12.149s sys 0m0.136s $ time python -m pylint -j0 ... pySim *.py real 0m5.541s user 0m58.496s sys 0m1.213s Change-Id: I76d1696c27ddcab358526f807c4a0a7f0d4c85d4 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/40/29240/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index bdf1311..f5cf8a2 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -37,7 +37,7 @@ # pySim/utils.py:276: E0401: Unable to import 'Crypto.Cipher' (import-error) # pySim/utils.py:277: E0401: Unable to import 'Crypto.Util.strxor' (import-error) pip install pylint==2.14.5 # FIXME: 2.15 is crashing, see OS#5668 -python -m pylint --errors-only \ +python -m pylint -j0 --errors-only \ --disable E1102 \ --disable E0401 \ --enable W0301 \ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I76d1696c27ddcab358526f807c4a0a7f0d4c85d4 Gerrit-Change-Number: 29240 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-msc[master]: Make esme struct shared

by pespin

Attention is currently required from: neels, msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 10:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-msc[master]: Make esme struct shared

by pespin

Attention is currently required from: neels, msuraev, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 19: (1 comment) File include/osmocom/smpp/smpp_smsc.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b0d5c58f_47d2fa14 PS19, Line 32: struct esme *esme; > just 'struct esme esme;' (non-pointer) to avoid extra talloc, […] Hi Neels, it's fine the way the patch is now, I actually pointed towards the current directon, since the idea is to decouple the structs and hide the implementation details, so allocating and freeing the struct is the usual way. It's not like this struct is allocated tons of times per seconds in any case... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 10:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: actually build with $PARALLEL_MAKE Parallel build has been fixed [1] and re-enabled [2] back in 2018. Executing $MAKE without $PARALLEL_MAKE builds the project with -j1. Executing $MAKE with $PARALLEL_MAKE after that makes no sense, because everything is already compiled and there is nothing to do. Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12 Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70 --- M contrib/jenkins.sh 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 3b4e639..7a75e25 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -7,7 +7,6 @@ autoreconf --install --force ./configure --enable-sanitize --enable-werror -$MAKE $MAKE $PARALLEL_MAKE $MAKE distcheck || cat-testlogs.sh $MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Aug 2022 07:17:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2html5 to provide /usr/bin/rst2html5 (rst2html5) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2latex to provide /usr/bin/rst2latex (rst2latex) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2man to provide /usr/bin/rst2man (rst2man) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2odt to provide /usr/bin/rst2odt (rst2odt) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2odt_prepstyles to provide /usr/bin/rst2odt_prepstyles (rst2odt_prepstyles) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2pseudoxml to provide /usr/bin/rst2pseudoxml (rst2pseudoxml) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2s5 to provide /usr/bin/rst2s5 (rst2s5) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2xetex to provide /usr/bin/rst2xetex (rst2xetex) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rst2xml to provide /usr/bin/rst2xml (rst2xml) in auto mode [ 302s] update-alternatives: using /usr/share/docutils/scripts/python3/rstpep2html to provide /usr/bin/rstpep2html (rstpep2html) in auto mode [ 304s] [459/492] installing python3-reportlab-3.5.59-2 [ 308s] [460/492] installing g++-4:10.2.1-1+rpi1 [ 308s] update-alternatives: using /usr/bin/g++ to provide /usr/bin/c++ (c++) in auto mode [ 308s] [461/492] installing libosmo-netif-dev-1.2.0.9.a69b.202208300052 [ 309s] [462/492] installing mount-2.36.1-8+deb11u1 [ 313s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/mount.deb' (size=177188) member 'data.tar': lzma error: compressed data is corrupt [ 313s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 313s] dpkg: error processing archive .init_b_cache/mount.deb (--install): [ 313s] cannot copy extracted data for './bin/mount' to '/bin/mount.dpkg-new': unexpected end of file or stream [ 313s] Errors were encountered while processing: [ 313s] .init_b_cache/mount.deb [ 313s] exit ... [ 313s] ### VM INTERACTION START ### [ 314s] [ 283.479303] sysrq: SysRq : Power Off [ 314s] [ 283.481537] reboot: Power down [ 314s] ### VM INTERACTION END ### [ 314s] [ 314s] armbuild01 failed "build osmo-sgsn_1.9.0.2.fb6cf.202208300052.dsc" at Tue Aug 30 03:52:45 UTC 2022. [ 314s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: fix 'publish' target

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29233 ) Change subject: contrib/jenkins.sh: fix 'publish' target ...................................................................... contrib/jenkins.sh: fix 'publish' target Executing 'maintainer-clean' before 'publish' makes the later fail: + make -C /build/doc/manuals publish make: Entering directory '/build/doc/manuals' make: Leaving directory '/build/doc/manuals' make: *** No rule to make target 'publish'. Stop. Execute 'maintainer-clean' after 'publish', like other projects do. Change-Id: I16cc855ee05726938e1542f481488364c5e47a95 Fixes: I2fe0de9bcb372333da1e5c81712a511cda34858c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f3331af..561d3d9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -53,10 +53,10 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh -$MAKE $PARALLEL_MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi +$MAKE $PARALLEL_MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I16cc855ee05726938e1542f481488364c5e47a95 Gerrit-Change-Number: 29233 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: fix 'publish' target

by fixeria

Attention is currently required from: osmith, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29233 ) Change subject: contrib/jenkins.sh: fix 'publish' target ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Urgent fix, merging. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I16cc855ee05726938e1542f481488364c5e47a95 Gerrit-Change-Number: 29233 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Aug 2022 19:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: run pylint on all *.py files

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/29238 ) Change subject: contrib/jenkins.sh: run pylint on all *.py files ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifb1e752cc79fc87211799b355c07ed7fe7052ab5 Gerrit-Change-Number: 29238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon

1 year, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: run pylint on all *.py files

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29238 ) Change subject: contrib/jenkins.sh: run pylint on all *.py files ...................................................................... contrib/jenkins.sh: run pylint on all *.py files Change-Id: Ifb1e752cc79fc87211799b355c07ed7fe7052ab5 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/29238/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7e29d1d..a1d112f 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -33,7 +33,7 @@ --disable E1102 \ --disable E0401 \ --enable W0301 \ - pySim *.py + $(find . -name "*.py") # attempt to build documentation pip install sphinx -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29238 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifb1e752cc79fc87211799b355c07ed7fe7052ab5 Gerrit-Change-Number: 29238 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: execute this script with -x and -e

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29236 ) Change subject: contrib/jenkins.sh: execute this script with -x and -e ...................................................................... contrib/jenkins.sh: execute this script with -x and -e -x Print commands and their arguments as they are executed -e Exit immediately if a command exits with a non-zero status Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/29236/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index ac5fba8..36bc4ae 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/sh -xe # jenkins build helper script for pysim. This is how we build on jenkins.osmocom.org # # environment variables: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I13af70ef770936bec00b050b6c4f988e53ee2833 Gerrit-Change-Number: 29236 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: install dependencies from requirements.txt

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29237 ) Change subject: contrib/jenkins.sh: install dependencies from requirements.txt ...................................................................... contrib/jenkins.sh: install dependencies from requirements.txt Change-Id: I99af496e9a3758ea624ca484f4fbc51b262ffaf4 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/29237/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 36bc4ae..7e29d1d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -17,15 +17,7 @@ virtualenv -p python3 venv --system-site-packages . venv/bin/activate -pip install pytlv -pip install 'pyyaml>=5.1' -pip install cmd2==1.5 -pip install jsonpath-ng -pip install construct -pip install bidict -pip install gsm0338 -pip install termcolor -pip install colorlog +pip install -r requirements.txt # Execute automatically discovered unit tests first python -m unittest discover -v -s tests/ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29237 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I99af496e9a3758ea624ca484f4fbc51b262ffaf4 Gerrit-Change-Number: 29237 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: README.md: update git URLs (git -> https; gitea)

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29234 ) Change subject: README.md: update git URLs (git -> https; gitea) ...................................................................... README.md: update git URLs (git -> https; gitea) Change-Id: Ia86979f656557e442b0f432b0646aa7661c293e9 --- M README.md 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/29234/1 diff --git a/README.md b/README.md index 9eab71c..e268d23 100644 --- a/README.md +++ b/README.md @@ -23,10 +23,10 @@ You can clone from the official Osmocom git repository using ``` -git clone git://git.osmocom.org/pysim.git +git clone https://gitea.osmocom.org/sim-card/pysim.git ``` -There is a cgit interface at <https://git.osmocom.org/pysim> +There is a web interface at <https://gitea.osmocom.org/sim-card/pysim>. Installation -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29234 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia86979f656557e442b0f432b0646aa7661c293e9 Gerrit-Change-Number: 29234 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in pysim[master]: README.md: update installation instructions for Debian

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29235 ) Change subject: README.md: update installation instructions for Debian ...................................................................... README.md: update installation instructions for Debian Change-Id: Icefa33570a34960a4fff145f3c1b6585d867605c --- M README.md 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/29235/1 diff --git a/README.md b/README.md index e268d23..a698653 100644 --- a/README.md +++ b/README.md @@ -47,9 +47,14 @@ - colorlog Example for Debian: -``` -apt-get install python3-pyscard python3-serial python3-pip python3-yaml python3-termcolor python3-colorlog -pip3 install -r requirements.txt +```sh +sudo apt-get install --no-install-recommends \ + pcscd libpcsclite-dev \ + python3 \ + python3-setuptools \ + python3-pyscard \ + python3-pip +pip3 install --user -r requirements.txt ``` After installing all dependencies, the pySim applications ``pySim-read.py``, ``pySim-prog.py`` and ``pySim-shell.py`` may be started directly from the cloned repository. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29235 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icefa33570a34960a4fff145f3c1b6585d867605c Gerrit-Change-Number: 29235 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: fix 'publish' target

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29233 ) Change subject: contrib/jenkins.sh: fix 'publish' target ...................................................................... contrib/jenkins.sh: fix 'publish' target Executing 'maintainer-clean' before 'publish' makes the later fail: + make -C /build/doc/manuals publish make: Entering directory '/build/doc/manuals' make: Leaving directory '/build/doc/manuals' make: *** No rule to make target 'publish'. Stop. Execute 'maintainer-clean' after 'publish', like other projects do. Change-Id: I16cc855ee05726938e1542f481488364c5e47a95 Fixes: I2fe0de9bcb372333da1e5c81712a511cda34858c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/33/29233/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f3331af..561d3d9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -53,10 +53,10 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh -$MAKE $PARALLEL_MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi +$MAKE $PARALLEL_MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29233 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I16cc855ee05726938e1542f481488364c5e47a95 Gerrit-Change-Number: 29233 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 ) Change subject: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic ...................................................................... BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic In cases a), b), c), d), and e) we're sending one or more Measurement Reports via the A-bis/RSL, and then immediately triggering a traffic channel assignment by calling f_TC_chan_alloc_algo(), which sends an Assignment Request via the A interface. The above-mentioned messages are sent immediately all together, so it may happen that the BSC handles the Assignment Request earlier than the Measurement Report(s). In this case there will be no RxLev samples, so the BSC would fall-back to ascending allocation order. Recently we saw this race condition actually happening on Jenkins: https://jenkins.osmocom.org/jenkins/view/TTCN3/job/ttcn3-bsc-test-sccplite/… Let's introduce an artificial delay before sending the Assignment Request, so that the BSC has enough time to process received MRs. Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 --- M bsc/BSC_Tests.ttcn 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 7f4ce46..09cd717 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11666,6 +11666,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 0, ts_RSL_IE_UplinkMeas(30, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); @@ -11677,6 +11678,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(48, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); @@ -11688,6 +11690,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(58, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX3); f_perform_clear_test_ct(dt); @@ -11703,6 +11706,7 @@ f_ipa_tx(ts_RSL_MEAS_RES_EMPTY(dt.rsl_chan_nr, 1, ts_RSL_IE_UplinkMeas(58, 0), ts_RSL_IE_BS_Power(0)), TRX0); + f_sleep(0.3); /* give the IUT some time to process sent MRs */ f_TC_chan_alloc_algo(dt, TRX0); f_perform_clear_test_ct(dt); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 Gerrit-Change-Number: 29202 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > I think this was intentional, i.e. libsmpp34 as we inherited had shown parallel_make problems. I updated the commit message. The parallel build has been fixed back in 2018. -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 29 Aug 2022 15:38:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... contrib/jenkins.sh: do not override parallel make for libsmpp34 Parallel build has been fixed [1] and re-enabled [2] back in 2018. Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12 libsmpp34.git Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70 libsmpp34.git --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fb858d7..e1bbad4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -35,7 +35,7 @@ osmo-build-dep.sh libosmo-abis osmo-build-dep.sh libosmo-netif osmo-build-dep.sh libosmo-sccp -PARALLEL_MAKE="" osmo-build-dep.sh libsmpp34 +osmo-build-dep.sh libsmpp34 osmo-build-dep.sh osmo-mgw osmo-build-dep.sh osmo-hlr -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by fixeria

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 to look at the new patch set (#2). Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: actually build with $PARALLEL_MAKE Parallel build has been fixed [1] and re-enabled [2] back in 2018. Executing $MAKE without $PARALLEL_MAKE builds the project with -j1. Executing $MAKE with $PARALLEL_MAKE after that makes no sense, because everything is already compiled and there is nothing to do. Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Related: [1] I5a9d7dbd7b992d322ed0d852ebf8ca2252b51a12 Related: [2] Id41fbcb5a96093eb6c3dc00bcacbd379111ada70 --- M contrib/jenkins.sh 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/19/29219/2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 8 months

1
0
0 0

Change in osmo-smlc[master]: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL...

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29221 ) Change subject: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 939a514..62e6516 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -58,12 +58,12 @@ || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" \ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi -$MAKE maintainer-clean +$MAKE $PARALLEL_MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29220 ) Change subject: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE ...................................................................... contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 0848bea..f3331af 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -51,7 +51,7 @@ ./configure --enable-sanitize --enable-werror --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ - $MAKE distcheck \ + $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh $MAKE $PARALLEL_MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: also execute maintainer-clean target

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29218 ) Change subject: contrib/jenkins.sh: also execute maintainer-clean target ...................................................................... contrib/jenkins.sh: also execute maintainer-clean target Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 104ba2a..0848bea 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -53,6 +53,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE $PARALLEL_MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c Gerrit-Change-Number: 29218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 ) Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY ...................................................................... osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY The PRIM_INFO_MODIFY is sent on receipt of the RSL MODE MODIFY message, which may optionally contain new ciphering parameters. Before this patch, osmo-bts-trx would ignore the new parameters and continue using the old ciphering key/algorithm. * Modify l1if_set_ciphering() to allow updating ciphering params. * Call l1if_set_ciphering() when handling PRIM_INFO_MODIFY. This problem was uncovered by BTS_Tests.TC_rsl_modify_encr, which has been failing ever since it was introduced [1]. This patch makes it pass. Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Related: [1] I4cbea499bb6a331d314e6573548a4540945208b5 osmo-ttcn3-hacks.git Related: OS#3750 --- M src/osmo-bts-trx/l1_if.c 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 92180b5..8c364c3 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -326,8 +326,8 @@ /* enable ciphering */ static int l1if_set_ciphering(struct gsm_lchan *lchan, uint8_t chan_nr, int downlink) { - /* ciphering already enabled in both directions */ - if (lchan->ciph_state == LCHAN_CIPH_RXTX_CONF) + /* ignore the request when the channel is not active */ + if (lchan->state != LCHAN_S_ACTIVE) return -EINVAL; if (!downlink) { @@ -463,6 +463,13 @@ lchan->tch.amr_mr.mode[3].mode, amr_get_initial_mode(lchan), 0); + /* update ciphering params */ + l1if_set_ciphering(lchan, chan_nr, 0); + l1if_set_ciphering(lchan, chan_nr, 1); + if (lchan->encr.alg_id) + lchan->ciph_state = LCHAN_CIPH_RXTX_CONF; + else + lchan->ciph_state = LCHAN_CIPH_NONE; break; } /* here, type == PRIM_INFO_DEACTIVATE */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Gerrit-Change-Number: 29217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 ) Change subject: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control ...................................................................... BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control Both testcases were introduced in 2021 [1], however they're not executed on Jenkins because they're not present in control section. Fixes: [1] I38e8a1cf15eb41a621b457b39024283a767c94be Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index b2d6383..f9361a0 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -8726,9 +8726,11 @@ execute( TC_chan_act_a51() ); execute( TC_chan_act_a52() ); execute( TC_chan_act_a53() ); + execute( TC_chan_act_a54() ); execute( TC_encr_cmd_a51() ); execute( TC_encr_cmd_a52() ); execute( TC_encr_cmd_a53() ); + execute( TC_encr_cmd_a54() ); execute( TC_err_rep_wrong_mdisc() ); execute( TC_err_rep_wrong_msg_type() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 Gerrit-Change-Number: 29215 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by laforge

Attention is currently required from: neels, fixeria, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 15: (2 comments) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/aebf41e5_35d43381 PS15, Line 600: if ( in whihc situation would we have a zero-length opt_data_cache? https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/59cd70d2_3640867b PS15, Line 639: msgb_alloc(SCCP_MAX_DATA, "SCCP optional data cache for CR/CC/RLSD"); If we ever should run into memory leaks, it would be better to use msgb_alloc_c(conn) to attach this msgb to the 'conn'. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 15 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 15:03:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 15:01:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... fix regression: in RUA, do PFCP only when enabled Tested in ttcn3, by test cases not ready for submission (would require enabling/disabling PFCP while osmo-hnbgw is running). ttcn3 tests in I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Related: SYS#6093 Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 7d5492f..f4e24d7 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -291,7 +291,8 @@ talloc_free(message); #if ENABLE_PFCP - } else { + } else if (hnb_gw_is_gtp_mapping_enabled(hnb->gw)) { + /* map->is_ps == true and PFCP is enabled in osmo-hnbgw.cfg */ message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: fast tracking this regression fix -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:58:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 to look at the new patch set (#2). Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... fix regression: in RUA, do PFCP only when enabled Tested in ttcn3, by test cases not ready for submission (would require enabling/disabling PFCP while osmo-hnbgw is running). ttcn3 tests in I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Related: SYS#6093 Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/32/29232/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: fix regression: in RUA, do PFCP only when enabled

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 ) Change subject: fix regression: in RUA, do PFCP only when enabled ...................................................................... fix regression: in RUA, do PFCP only when enabled Tested in ttcn3, by test cases not ready for submission (would require enabling/disabling PFCP while osmo-hnbgw is running). ttcn3 tests in I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd --- M src/osmo-hnbgw/hnbgw_rua.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/32/29232/1 diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index 7d5492f..f4e24d7 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -291,7 +291,8 @@ talloc_free(message); #if ENABLE_PFCP - } else { + } else if (hnb_gw_is_gtp_mapping_enabled(hnb->gw)) { + /* map->is_ps == true and PFCP is enabled in osmo-hnbgw.cfg */ message = talloc_zero(map, ranap_message); rc = ranap_cn_rx_co_decode(map, message, msgb_l2(prim->oph.msg), msgb_l2len(prim->oph.msg)); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29232 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I39b9632f8524a9f3455c1a2d7611bfe8ba07c2fd Gerrit-Change-Number: 29232 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnbgw: test both with and without PFCP [WIP]

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29231 ) Change subject: hnbgw: test both with and without PFCP [WIP] ...................................................................... hnbgw: test both with and without PFCP [WIP] The "without_pfcp" test still depends on restarting osmo-hnbgw with a modified .cfg. Change-Id: I511e758807e0512c18f3f9e0a8c4699b9a3f5992 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 67 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/29231/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index b440292..7ac6559 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1240,7 +1240,7 @@ } } -friend function f_tc_ps_rab_assignment(charstring id, TestHdlrParams pars) runs on ConnHdlr { +friend function f_tc_ps_rab_assignment_with_pfcp(charstring id, TestHdlrParams pars) runs on ConnHdlr { var RANAP_PDU tx; var RANAP_PDU rx; timer T := 5.0; @@ -1329,13 +1329,75 @@ f_sleep(2.0); } -testcase TC_ps_rab_assignment() runs on test_CT { +testcase TC_ps_rab_assignment_with_pfcp() runs on test_CT { var ConnHdlr vc_conn; f_init(); f_start_hnbs(); f_sleep(1.0); - vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment), t_pars(7, ps_domain := true)); + vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_with_pfcp), t_pars(7, ps_domain := true)); + vc_conn.done; +} + +altstep as_disallow_pfcp() runs on ConnHdlr { + [] PFCP.receive(PDU_PFCP:?) { + setverdict(fail, "Received PFCP message, but no PFCP communication expected"); + mtc.stop; + } +} + +friend function f_tc_ps_rab_assignment_without_pfcp(charstring id, TestHdlrParams pars) runs on ConnHdlr { + var RANAP_PDU tx; + var RANAP_PDU rx; + timer T := 5.0; + + f_init_handler(pars); + + f_pfcp_register(); + activate(as_disallow_pfcp()); + + tx := f_build_initial_ue(g_pars); + f_iuh2iu_connect(tx); + + var GtpParameters gtp_pars := valueof(t_GtpParameters); + var template RAB_SetupOrModifyList rab_sml; + + /* Send RAB Assignment Request */ + rab_sml := ts_RAB_SML_ps(t_RAB_id(23), f_ts_RAB_TLA(gtp_pars.core.remote.addr), gtp_pars.core.remote.teid); + tx := valueof(ts_RANAP_RabAssReq(rab_sml)); + BSSAP.send(tx); + + /* Expect on Iuh: unmodified RAB Assignment Request */ + rx := valueof(ts_RANAP_RabAssReq(rab_sml)); + RUA.receive(rx); + + /* Send back RAB Assignment Response via Iuh */ + var template RAB_SetupOrModifiedList rab_smdl; + rab_smdl := ts_RAB_SMdL_ps(t_RAB_id(23), f_ts_RAB_TLA(gtp_pars.access.remote.addr), + gtp_pars.access.remote.teid); + tx := valueof(ts_RANAP_RabAssResp(rab_smdl)); + RUA.send(tx); + + /* Expect on IuPS: unmodified RAB Assignment Response */ + BSSAP.receive(tr_RANAP_RabAssResp(rab_smdl)); + + f_sleep(2.0); + tx := valueof(ts_RANAP_IuReleaseCommand(ts_RanapCause_om_intervention)); + f_iu2iuh(tx); + + tx := valueof(ts_RANAP_IuReleaseComplete()); + f_iuh2iu(tx); + + f_sleep(2.0); +} + +testcase TC_ps_rab_assignment_without_pfcp() runs on test_CT { + var ConnHdlr vc_conn; + f_init(); + f_start_hnbs(); + f_sleep(1.0); + + vc_conn := f_start_handler_with_pars(refers(f_tc_ps_rab_assignment_without_pfcp), t_pars(7, ps_domain := true)); vc_conn.done; } @@ -1354,7 +1416,8 @@ execute(TC_rab_assign_mgcp_to()); execute(TC_ranap_cs_mo_disconnect()); execute(TC_ranap_ps_mo_disconnect()); - execute(TC_ps_rab_assignment()); + execute(TC_ps_rab_assignment_with_pfcp()); + execute(TC_ps_rab_assignment_without_pfcp()); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29231 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I511e758807e0512c18f3f9e0a8c4699b9a3f5992 Gerrit-Change-Number: 29231 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic

by laforge

Attention is currently required from: neels, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 ) Change subject: BSC_Tests: fix race conditions in TC_chan_alloc_algo_ass_dynamic ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2fd6508488e935d208a7aba8e2f215b1cc14ad32 Gerrit-Change-Number: 29202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:40:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-msc[master]: contrib/jenkins.sh: do not override parallel make for libsmpp34

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29222 ) Change subject: contrib/jenkins.sh: do not override parallel make for libsmpp34 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29222 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I13d2d6f3b5ffae390cf429e41bf9035b8c551f66 Gerrit-Change-Number: 29222 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:39:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-smlc[master]: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL...

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29221 ) Change subject: contrib/jenkins.sh: execute distcheck/maintainer-clean with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I14b0e0343dc70b72cc9e14641bccaa6da2059e46 Gerrit-Change-Number: 29221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in libsmpp34[master]: contrib/jenkins.sh: actually build with $PARALLEL_MAKE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29219 ) Change subject: contrib/jenkins.sh: actually build with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think this was intentional, i.e. libsmpp34 as we inherited had shown parallel_make problems. -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29219 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Iff7e7acfac0b827ce3b1086cea376a438b5af334 Gerrit-Change-Number: 29219 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:38:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29220 ) Change subject: contrib/jenkins.sh: execute 'distcheck' with $PARALLEL_MAKE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29220 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I895c0dbfd56613a5f2f77a338e64e1cde3017d11 Gerrit-Change-Number: 29220 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:38:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-cbc[master]: contrib/jenkins.sh: also execute maintainer-clean target

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/29218 ) Change subject: contrib/jenkins.sh: also execute maintainer-clean target ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/29218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2fe0de9bcb372333da1e5c81712a511cda34858c Gerrit-Change-Number: 29218 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29217 ) Change subject: osmo-bts-trx: fix handling of ciphering params in PRIM_INFO_MODIFY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2278703b487374c0de4cfc42b22e70aaf6548589 Gerrit-Change-Number: 29217 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:37:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: update expected-results.xml

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216 ) Change subject: bts: update expected-results.xml ...................................................................... Patch Set 1: (2 comments) File bts/expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216/comment/be30019d_4a18… PS1, Line 57: do we really expect this test case to fail? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216/comment/55eff426_1e33… PS1, Line 84: likewise here? is this not a real bug or possibly even a regression? I'm very careful with patches updating the "Expected results" which introduce new tests that we _expect_ to fail -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29216 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifcd8601d1aadce78a1b0a0ed814ae9e77e8497aa Gerrit-Change-Number: 29216 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:35:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control

by laforge

Attention is currently required from: Hoernchen, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 ) Change subject: BTS_Tests: add TC_{chan_act,encr_cmd}_a54 to control ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebf6d14321b54e7ef261443aece03296540ebe92 Gerrit-Change-Number: 29215 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:34:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-hlr[master]: Set working directory in systemd service file

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/29225 ) Change subject: Set working directory in systemd service file ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/29225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I40b5d50470cb55ca94af5e17f21658181a02d4c2 Gerrit-Change-Number: 29225 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:33:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ggsn[master]: Set working directory in systemd service file

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 ) Change subject: Set working directory in systemd service file ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idffc115c21cac77f6f43356333de538ba549fc6a Gerrit-Change-Number: 29223 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:32:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in osmo-ggsn[master]: Ignore .deb build byproducts

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 ) Change subject: Ignore .deb build byproducts ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/29224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iec63ef5ea0acfc5e6621054926be15ae4754d65d Gerrit-Change-Number: 29224 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:32:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in pysim[master]: README.md: list recent dependencies from requirements.txt

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29230 ) Change subject: README.md: list recent dependencies from requirements.txt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia486dbc7f630c1404e51728b5353cf5a0d643415 Gerrit-Change-Number: 29230 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:31:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in pysim[master]: README.md: fix module name: s/serial/pyserial/

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29229 ) Change subject: README.md: fix module name: s/serial/pyserial/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29229 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5fd308fb161cd5bd5f702845691296877e523248 Gerrit-Change-Number: 29229 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:31:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in pysim[master]: README.md,requirements.txt: add missing construct version info

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29228 ) Change subject: README.md,requirements.txt: add missing construct version info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I90da0df431f0d7dbfa4aa428366fbf0e35db388f Gerrit-Change-Number: 29228 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:31:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in pysim[master]: Bump minimum required construct version to v2.9.51

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29227 ) Change subject: Bump minimum required construct version to v2.9.51 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4223c83570d333ad8d79bc2aa2d8bcc580156cff Gerrit-Change-Number: 29227 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:31:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in pysim[master]: construct: use Python's API for int<->bytes conversion

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29226 ) Change subject: construct: use Python's API for int<->bytes conversion ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I613dbfebe993f9c19003635371941710fc1b1236 Gerrit-Change-Number: 29226 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Aug 2022 14:30:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 8 months

1
0
0 0

Change in pysim[master]: README.md: list recent dependencies from requirements.txt

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29230 ) Change subject: README.md: list recent dependencies from requirements.txt ...................................................................... README.md: list recent dependencies from requirements.txt Change-Id: Ia486dbc7f630c1404e51728b5353cf5a0d643415 --- M README.md 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/30/29230/1 diff --git a/README.md b/README.md index 66bc0ce..9eab71c 100644 --- a/README.md +++ b/README.md @@ -42,6 +42,9 @@ - construct >= 2.9.51 - bidict - gsm0338 + - pyyaml >= 5.1 + - termcolor + - colorlog Example for Debian: ``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia486dbc7f630c1404e51728b5353cf5a0d643415 Gerrit-Change-Number: 29230 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 8 months

1
0
0 0

2024

2023

2022

gerrit-log August 2022