August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_bsc

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28943 ) Change subject: cbc: Introduce test TC_create_nack_bsc ...................................................................... cbc: Introduce test TC_create_nack_bsc Related: OS#4945 Change-Id: Iabeb3e9d86eaf59b76504edf3976a947ae29b911 --- M cbc/BSC_ConnectionHandler.ttcn M cbc/CBC_Tests.ttcn 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/cbc/BSC_ConnectionHandler.ttcn b/cbc/BSC_ConnectionHandler.ttcn index 804d246..1878f3e 100644 --- a/cbc/BSC_ConnectionHandler.ttcn +++ b/cbc/BSC_ConnectionHandler.ttcn @@ -44,7 +44,8 @@ boolean tcp_is_client, void_fn start_fn, CBS_Message exp_cbs_msg optional, - BSSMAP_FIELD_CellIdentificationList cell_list_success optional + BSSMAP_FIELD_CellIdentificationList cell_list_success optional, + CBSP_FailureListItems tx_fail_list optional }; function f_BSC_ConnHdlr_main(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { @@ -126,11 +127,12 @@ function f_cbsp_tx_write_fail(CBS_Message msg, integer idx := 0, template (omit) BSSMAP_FIELD_CellIdentificationList tx_cell_list := omit, + template (omit) CBSP_IE_NumBcastComplList tx_compl_list := omit, template (omit) CBSP_FailureListItems tx_fail_list := omit) runs on BSC_ConnHdlr { var template (value) CBSP_PDU tx; tx := ts_CBSP_WRITE_CBS_FAIL(msg.msg_id, msg.ser_nr, valueof(tx_fail_list), - omit, tx_cell_list, msg.channel_ind); + tx_compl_list, tx_cell_list, msg.channel_ind); CBSP[idx].send(ts_CBSP_Send(g_cbsp_conn_id[idx], tx)); } @@ -162,7 +164,7 @@ if (istemplatekind(tx_fail_list, "omit")) { f_cbsp_tx_write_compl(msg, idx, tx_cell_list, tx_compl_list); } else { - f_cbsp_tx_write_fail(msg, idx, tx_cell_list, tx_fail_list); + f_cbsp_tx_write_fail(msg, idx, tx_cell_list, tx_compl_list, tx_fail_list); } } [] as_cbsp_keepalive_ack(idx) { repeat; } diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 437ba0b..8daa3bf 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -118,7 +118,8 @@ tcp_is_client := tcp_is_client, start_fn := refers(f_BSC_ConnHdlr_start_fn_void), exp_cbs_msg := omit, - cell_list_success := omit + cell_list_success := omit, + tx_fail_list := omit }; return pars; } @@ -681,6 +682,41 @@ f_shutdown_helper(); } +/* Test BSC answering WRITE-REPLACE REQUEST with WRITE-REPLACE FAILURE */ +private function f_bsc_TC_create_nack_bsc() runs on BSC_ConnHdlr { + f_cbsp_handle_write(g_pars.exp_cbs_msg, 0, g_pars.cell_list_success, g_pars.tx_fail_list); +} +testcase TC_create_nack_bsc() runs on test_CT { + var template (value) BSSMAP_FIELD_CellIdentificationList cell_list_success; + var template (value) CBSP_FailureListItems tx_fail_list; + var CBS_Message msg; + var EcbeCbcMessage ecbe; + + msg := valueof(t_CBSmsg(49, 16752)); + + f_init(num_bsc := 1, num_mme := 0); + + cell_list_success := ts_BSSMAP_CIL_CGI({ + ts_BSSMAP_CI_CGI('901'H, '70'H, 23, 42), + ts_BSSMAP_CI_CGI('901'H, '70'H, 24, 42) + }); + tx_fail_list := { + CBSP_FailureListItem_CGI(ts_BSSMAP_CI_CGI('901'H, '70'H, 24, 48), CBSP_CAUSE_CELL_ID_NOT_VALID), + CBSP_FailureListItem_LAC_CI(ts_BSSMAP_CI_LAC_CI(10001, 50001), CBSP_CAUSE_LAI_OR_LAC_NPT_VALID) + }; + g_pars_BSC[0].start_fn := refers(f_bsc_TC_create_nack_bsc); + g_pars_BSC[0].exp_cbs_msg := msg; + g_pars_BSC[0].cell_list_success := valueof(cell_list_success); + g_pars_BSC[0].tx_fail_list := valueof(tx_fail_list); + f_start(); + + ecbe := f_cbs2ecbe(msg, "TTCN-3"); + f_ecbe_tx_post_cbs(ecbe); + f_ecbe_rx_resp(201); + + f_shutdown_helper(); +} + control { execute( TC_rx_keepalive() ); execute( TC_rx_keepalive_timeout() ); @@ -698,6 +734,8 @@ execute( TC_ecbe_create_delete_etws_bsc() ); execute( TC_ecbe_create_delete_etws_mme() ); + + execute( TC_create_nack_bsc() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iabeb3e9d86eaf59b76504edf3976a947ae29b911 Gerrit-Change-Number: 28943 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: BCS_ConnHdlr: avoid handling received RESTART messages

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28946 ) Change subject: cbc: BCS_ConnHdlr: avoid handling received RESTART messages ...................................................................... cbc: BCS_ConnHdlr: avoid handling received RESTART messages CBSP RESTART messages are only sen BSC->CBS direction, so it makes no sense to activate the receival of RESTART messages in the BSC emulation. Change-Id: I40e78ff4d980050a6142226a7eb9589f2d15e5bd --- M cbc/BSC_ConnectionHandler.ttcn 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/cbc/BSC_ConnectionHandler.ttcn b/cbc/BSC_ConnectionHandler.ttcn index 1878f3e..5f4fa59 100644 --- a/cbc/BSC_ConnectionHandler.ttcn +++ b/cbc/BSC_ConnectionHandler.ttcn @@ -62,7 +62,6 @@ cIl_allInBSS := ''O }; activate(as_cbsp_keepalive_ack(0)); - activate(as_cbsp_restart(0)); f_cbsp_send(ts_CBSP_RESTART(cell_list, CBSP_BC_MSGT_CBS, CBSP_RI_DATA_LOST)); f_cbsp_send(ts_CBSP_RESTART(cell_list, CBSP_BC_MSGT_EMERG, CBSP_RI_DATA_LOST)); as_cbsp_reset(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40e78ff4d980050a6142226a7eb9589f2d15e5bd Gerrit-Change-Number: 28946 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Add expected-results.xml

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28950 ) Change subject: cbc: Add expected-results.xml ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9bf2c513a30c943bf87b47154a10147dc49c3d02 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:04:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_cell_failure_restart_active_{cbc,mme}

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28949 ) Change subject: cbc: Introduce test TC_cell_failure_restart_active_{cbc,mme} ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b1c5275eff56888268601b481e8f8c1dd1bb1b0 Gerrit-Change-Number: 28949 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:04:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_cell_failure_restart_idle_mme

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28948 ) Change subject: cbc: Introduce test TC_cell_failure_restart_idle_mme ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0ab3d4fbe1d9a824b1f69ceacbf7dfd4f0d9728 Gerrit-Change-Number: 28948 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:04:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_cell_failure_restart_idle_bsc

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28947 ) Change subject: cbc: Introduce test TC_cell_failure_restart_idle_bsc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia868bf739c29d5b4548bbd1417c352ee6400f501 Gerrit-Change-Number: 28947 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:03:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: BCS_ConnHdlr: avoid handling received RESTART messages

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28946 ) Change subject: cbc: BCS_ConnHdlr: avoid handling received RESTART messages ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40e78ff4d980050a6142226a7eb9589f2d15e5bd Gerrit-Change-Number: 28946 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:03:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_mme

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 ) Change subject: cbc: Introduce test TC_create_nack_mme ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 Gerrit-Change-Number: 28945 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_bsc

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28943 ) Change subject: cbc: Introduce test TC_create_nack_bsc ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iabeb3e9d86eaf59b76504edf3976a947ae29b911 Gerrit-Change-Number: 28943 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:03:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-pcu[master]: tests/rlcmac: use ARRAY_SIZE macro

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28955 ) Change subject: tests/rlcmac: use ARRAY_SIZE macro ...................................................................... tests/rlcmac: use ARRAY_SIZE macro Change-Id: I6e9d95ef007e984d25403eb64f8aeab02e3fa8e7 --- M tests/rlcmac/RLCMACTest.cpp 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index f2b0447..9ba7831 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -55,10 +55,8 @@ "40883c1493120000000012002b2b2b2b2b2b2b2b2b2b2b", // Pkt Paging Request (OS#4838) }; - int testDataSize = sizeof(testData)/sizeof(testData[0]); - cout << " DOWNLINK " << endl; - for (int i = 0; i < testDataSize; i++) + for (unsigned int i = 0; i < ARRAY_SIZE(testData); i++) { cout << "vector1 = " << testData[i] << endl; bitvec *vector = bitvec_alloc(23, test_ctx); @@ -109,11 +107,8 @@ "4017e5b2cd5a2eca68655e44aec84880139300412b2b2b", }; - int testDataSize = sizeof(testData)/sizeof(testData[0]); - - cout << " UPLINK " << endl; - for (int i = 0; i < testDataSize; i++) + for (unsigned int i = 0; i < ARRAY_SIZE(testData); i++) { cout << "vector1 = " << testData[i] << endl; bitvec *vector = bitvec_alloc(23, test_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28955 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6e9d95ef007e984d25403eb64f8aeab02e3fa8e7 Gerrit-Change-Number: 28955 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022