August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: abis_om2000: constify mo in mo2obj

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28937 ) Change subject: abis_om2000: constify mo in mo2obj ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia09d0c96c8938e287fdbad343b9605cbfd6ff6a1 Gerrit-Change-Number: 28937 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:06:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-bsc[master]: abis_om2000: move switch-case to function

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28914 ) Change subject: abis_om2000: move switch-case to function ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I41f0d9d0d498f6f698c2c959baac50424f5ac317 Gerrit-Change-Number: 28914 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:06:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: Added basic AFC as implemented by SQ5BPF into float_to_bits.c

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28894 ) Change subject: Added basic AFC as implemented by SQ5BPF into float_to_bits.c ...................................................................... Added basic AFC as implemented by SQ5BPF into float_to_bits.c The AFC implementation by SQ5BPF as used in his fork of osmo-tetra significantly increases reception quality. A simple test yields 14545 valid CRCs as opposed to 11934 when AFC is not used. I added the AFC to float_to_bits, the functionality can be activated with the -a flag. Change-Id: I1c9343b83739108a1e423c4880e1dc7964656529 --- M src/float_to_bits.c 1 file changed, 35 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/float_to_bits.c b/src/float_to_bits.c index 9ececa0..89d0421 100644 --- a/src/float_to_bits.c +++ b/src/float_to_bits.c @@ -73,25 +73,47 @@ // size of IO buffers (number of elements) #define BUF_SIZE 1024 +#define MAXVAL 5.0 + int main(int argc, char **argv) { int fd, fd_out, opt; - int opt_verbose = 0; + int opt_afc = 0; - while ((opt = getopt(argc, argv, "v")) != -1) { + float filter = 0; + float filter_val = 0.0001; + float filter_goal = 0; + int sym; + + + while ((opt = getopt(argc, argv, "vaf:F:")) != -1) { switch (opt) { case 'v': opt_verbose = 1; break; + case 'a': + opt_afc = 1; + break; + case 'f': + filter_val = atof(optarg); + break; + case 'F': + filter_goal = atof(optarg); + break; + default: exit(2); } } if (argc <= optind+1) { - fprintf(stderr, "Usage: %s [-v] <infile> <outfile>\n", argv[0]); + fprintf(stderr, "Usage: %s [-v] [-a] [-f filter_val] [-F filter_goal] <infile> <outfile>\n", argv[0]); + fprintf(stderr, "-v verbose, print bits to stdout\n"); + fprintf(stderr, "-a turn on pseudo-afc (automatic frequency correction)\n"); + fprintf(stderr, "-f pseudo-afc averaging filter constant (default 0.0001)\n"); + fprintf(stderr, "-F pseudo-afc filter goal (default: 0)\n"); exit(2); } @@ -119,7 +141,16 @@ rc /= sizeof(*fl); int i; for (i = 0; i < rc; ++i) { - int sym = process_sym_fl(fl[i]); + + if ((fl[i] > -MAXVAL) && (fl[i] < MAXVAL)) { + filter = filter * (1.0 - filter_val) + (fl[i] - filter_goal) * filter_val; + } + if (opt_afc) { + sym = process_sym_fl(fl[i]-filter); + } else { + sym = process_sym_fl(fl[i]); + } + sym_int2bits(sym, bits + i*2); //printf("%2d %1u %1u %f\n", rc, bits[0], bits[1], fl); if (opt_verbose) { -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c9343b83739108a1e423c4880e1dc7964656529 Gerrit-Change-Number: 28894 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: when traffic dump directory is specified, now prints error message an...

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28926 ) Change subject: when traffic dump directory is specified, now prints error message and exits instead of crashing when traffic file cannot be written ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88 Gerrit-Change-Number: 28926 Gerrit-PatchSet: 3 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:05:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-tetra[master]: Added basic AFC as implemented by SQ5BPF into float_to_bits.c

by laforge

Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28894 ) Change subject: Added basic AFC as implemented by SQ5BPF into float_to_bits.c ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c9343b83739108a1e423c4880e1dc7964656529 Gerrit-Change-Number: 28894 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sat, 06 Aug 2022 17:04:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_cell_failure_restart_active_{cbc,mme}

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28949 ) Change subject: cbc: Introduce test TC_cell_failure_restart_active_{cbc,mme} ...................................................................... cbc: Introduce test TC_cell_failure_restart_active_{cbc,mme} These tests are currently failing since osmo-cbc doesn't support reloading cells yet. Related: OS#5641 Change-Id: I7b1c5275eff56888268601b481e8f8c1dd1bb1b0 --- M cbc/CBC_Tests.ttcn 1 file changed, 122 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index aff5359..2f1ad7f 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -787,6 +787,125 @@ f_shutdown_helper(); } +/* Test cell actively broadcasting a message in BSC going unavailable for + broadcasting and going available again. The CBC should reload the announced + cell with the active messages. See 3GPP TS 48.049 7.8 */ +private function f_bsc_TC_cell_failure_restart_active_bsc() runs on BSC_ConnHdlr { + var template (value) CBSP_FailureListItems fail_list := { + CBSP_FailureListItem_CGI(g_pars.cell_list_success.cIl_CGI[0], CBSP_CAUSE_CB_NOT_OPERATIONAL) + }; + var template (value) BSSMAP_FIELD_CellIdentificationList cell_list := ts_BSSMAP_CIL_CGI({ + g_pars.cell_list_success.cIl_CGI[0] + }); + + /* Guide cell into active broadcast msg state: */ + f_cbsp_handle_write(g_pars.exp_cbs_msg, 0, g_pars.cell_list_success); + + /* BSC reports the cell is down */ + f_cbsp_send(ts_CBSP_FAILURE(fail_list, CBSP_BC_MSGT_CBS)); + f_cbsp_send(ts_CBSP_FAILURE(fail_list, CBSP_BC_MSGT_EMERG)); + f_sleep(1.0); + + /* BSC reports the cell is up again */ + f_cbsp_send(ts_CBSP_RESTART(cell_list, CBSP_BC_MSGT_CBS, CBSP_RI_DATA_LOST)); + f_cbsp_send(ts_CBSP_RESTART(cell_list, CBSP_BC_MSGT_EMERG, CBSP_RI_DATA_LOST)); + +/* TODO: OS#5641 + * The BSC informs the CBC by sending the RESTART message (see figure 7.8.2.1) + * containing the Cell List IE identifying the cell(s) being in CBS message + * operational state or in emergency message operational state and the Recovery + * Indication IE, indicating whether the broadcast information data is lost or + * not in the BSC. + * The RESTART message is sent once per broadcast message type + * as indicated by the Broadcast Message Type IE. + */ + f_bsc_create_and_delete(); +} +testcase TC_cell_failure_restart_active_bsc() runs on test_CT { + f_init(num_bsc := 1); + var template (value) BSSMAP_FIELD_CellIdentificationList cell_list_success; + var template (value) CBS_Message msg := t_CBSmsg(43, 16752); + + cell_list_success := ts_BSSMAP_CIL_CGI({ + ts_BSSMAP_CI_CGI('901'H, '70'H, 23, 42) + }); + g_pars_BSC[0].start_fn := refers(f_bsc_TC_cell_failure_restart_active_bsc); + g_pars_BSC[0].exp_cbs_msg := valueof(msg); + g_pars_BSC[0].cell_list_success := valueof(cell_list_success); + f_start(); + + var EcbeCbcMessage ecbe := f_cbs2ecbe(valueof(msg), "TTCN-3"); + f_ecbe_tx_post_cbs(ecbe); + f_ecbe_rx_resp(201); + + f_shutdown_helper(); +} + +/* Test cell actively broadcasting a message in MME going unavailable for + broadcasting and going available again. The CBC should reload the announced + cell with the active messages. See 3GPP TS 29.168 4.3.3E.2 */ +private function f_mme_TC_cell_failure_restart_active_mme() runs on MME_ConnHdlr { + var template (value) Global_ENB_ID enb_id := ts_Global_ENB_ID_MACRO(f_enc_mcc_mnc('901'H, '70'H), 90); + var template (value) Failed_Cell_List fail_list := { + g_pars.bcast_cell_id_list[0].eCGI + } + var template (value) Restarted_Cell_List cell_list := { + g_pars.bcast_cell_id_list[0].eCGI + }; + /* Guide cell into active broadcast msg state: */ + f_sbcap_handle_write_replace_warn_req(g_pars.exp_cbs_msg, 0); + if (ispresent(g_pars.write_replace_warning_ind_cause) and + ispresent(g_pars.bcast_cell_id_list)) { + f_sbcap_tx_write_replace_warn_ind(0, g_pars.exp_cbs_msg, + g_pars.write_replace_warning_ind_cause, + g_pars.bcast_cell_id_list) + } + + /* MME reports the cell is down */ + f_SBC_AP_send(ts_SBCAP_PWS_FAILURE(fail_list, enb_id)); + + f_sleep(1.0); + + /* MME reports the cell is up again */ + f_SBC_AP_send(ts_SBCAP_PWS_RESTART(cell_list, enb_id)); + +/* TODO: OS#5641 + * The CBC shall reload the warning message data (with the same Message + * Identifier and Serial Number) to the (H)eNB by initiating Write Replace + * Warning procedure(s) as specified in clause 4.3.3.2 with the following + * additions: + * - the CBC should set the Warning Area List IE in the Write-Replace + * Warning Request message to the identities of the cell(s) received in the + * Restarted-Cell-List which are relevant to the warning message data being + * reloaded; + * - the CBC shall copy the Global eNB ID into the Write-Replace + * Warning Request message; and + * - the CBC may update the Number of Broadcast Requested, if necessary. + */ + f_mme_create_and_delete(); +} +testcase TC_cell_failure_restart_active_mme() runs on test_CT { + var template (value) CellId_Broadcast_List bcast_cell_id_li; + var template (value) CBS_Message msg := t_CBSmsg(48, 16752); + + f_init(num_bsc := 0, num_mme := 1); + + bcast_cell_id_li := { + ts_SBCAP_CellId_Broadcast_List_Item(ts_SBCAP_ECGI(f_enc_mcc_mnc('901'H, '70'H), 1234)) + }; + g_pars_MME[0].start_fn := refers(f_mme_TC_cell_failure_restart_active_mme); + g_pars_MME[0].exp_cbs_msg := valueof(msg); + g_pars_MME[0].write_replace_warning_ind_cause := SBC_AP_Cause_message_accepted; + g_pars_MME[0].bcast_cell_id_list := valueof(bcast_cell_id_li); + f_start(); + + var EcbeCbcMessage ecbe := f_cbs2ecbe(valueof(msg), "TTCN-3"); + f_ecbe_tx_post_cbs(ecbe); + f_ecbe_rx_resp(201); + + f_shutdown_helper(); +} + control { execute( TC_rx_keepalive() ); execute( TC_rx_keepalive_timeout() ); @@ -810,6 +929,9 @@ execute( TC_cell_failure_restart_idle_bsc() ); execute( TC_cell_failure_restart_idle_mme() ); + + execute( TC_cell_failure_restart_active_bsc() ); + execute( TC_cell_failure_restart_active_mme() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28949 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7b1c5275eff56888268601b481e8f8c1dd1bb1b0 Gerrit-Change-Number: 28949 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Add expected-results.xml

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28950 ) Change subject: cbc: Add expected-results.xml ...................................................................... cbc: Add expected-results.xml Change-Id: I9bf2c513a30c943bf87b47154a10147dc49c3d02 --- A cbc/expected-results.xml 1 file changed, 32 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/cbc/expected-results.xml b/cbc/expected-results.xml new file mode 100644 index 0000000..72acd7c --- /dev/null +++ b/cbc/expected-results.xml @@ -0,0 +1,32 @@ +<?xml version="1.0"?> +<testsuite name='CBC_Tests' tests='0' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='CBC_Tests' name='TC_rx_keepalive' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_rx_keepalive_timeout' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_cgi' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_lac_ci' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_lac' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_ci' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_lai' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_mme_indication' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_mme_unknown_tai' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_bsc_and_mme' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_bsc_server' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_mme_server' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_concurrent_cbs_msg_mme' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_etws_bsc' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_ecbe_create_delete_etws_mme' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_create_nack_bsc' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_create_nack_mme' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_cell_failure_restart_idle_bsc' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_cell_failure_restart_idle_mme' time='MASKED'/> + <testcase classname='CBC_Tests' name='TC_cell_failure_restart_active_bsc' time='MASKED'> + <failure type='fail-verdict'>Tguard timeout + CBC_Tests.ttcn:MASKED TC_cell_failure_restart_active_bsc testcase + </failure> + </testcase> + <testcase classname='CBC_Tests' name='TC_cell_failure_restart_active_mme' time='MASKED'> + <failure type='fail-verdict'>Tguard timeout + CBC_Tests.ttcn:MASKED TC_cell_failure_restart_active_mme testcase + </failure> + </testcase> +</testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9bf2c513a30c943bf87b47154a10147dc49c3d02 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_cell_failure_restart_idle_bsc

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28947 ) Change subject: cbc: Introduce test TC_cell_failure_restart_idle_bsc ...................................................................... cbc: Introduce test TC_cell_failure_restart_idle_bsc Change-Id: Ia868bf739c29d5b4548bbd1417c352ee6400f501 --- M cbc/CBC_Tests.ttcn 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 3394bed..f8d04fe 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -735,6 +735,33 @@ f_shutdown_helper(); } + +/* Test cell in BSC going unavailable for broadcasting and going available again */ +private function f_bsc_TC_cell_failure_restart_idle_bsc() runs on BSC_ConnHdlr { + var template (value) CBSP_FailureListItems fail_list := { + CBSP_FailureListItem_CGI(ts_BSSMAP_CI_CGI('901'H, '70'H, 23, 42), CBSP_CAUSE_CB_NOT_OPERATIONAL), + CBSP_FailureListItem_CGI(ts_BSSMAP_CI_CGI('901'H, '70'H, 24, 42), CBSP_CAUSE_CB_NOT_OPERATIONAL) + }; + f_cbsp_send(ts_CBSP_FAILURE(fail_list, CBSP_BC_MSGT_CBS)); + f_cbsp_send(ts_CBSP_FAILURE(fail_list, CBSP_BC_MSGT_EMERG)); + + f_sleep(1.0); + + var template (value) BSSMAP_FIELD_CellIdentificationList cell_list; + cell_list := ts_BSSMAP_CIL_CGI({ + ts_BSSMAP_CI_CGI('901'H, '70'H, 23, 42), + ts_BSSMAP_CI_CGI('901'H, '70'H, 24, 42) + }); + f_cbsp_send(ts_CBSP_RESTART(cell_list, CBSP_BC_MSGT_CBS, CBSP_RI_DATA_LOST)); + f_cbsp_send(ts_CBSP_RESTART(cell_list, CBSP_BC_MSGT_EMERG, CBSP_RI_DATA_LOST)); +} +testcase TC_cell_failure_restart_idle_bsc() runs on test_CT { + f_init(num_bsc := 1, num_mme := 0); + g_pars_BSC[0].start_fn := refers(f_bsc_TC_cell_failure_restart_idle_bsc); + f_start(); + f_shutdown_helper(); +} + control { execute( TC_rx_keepalive() ); execute( TC_rx_keepalive_timeout() ); @@ -755,6 +782,8 @@ execute( TC_create_nack_bsc() ); execute( TC_create_nack_mme() ); + + execute( TC_cell_failure_restart_idle_bsc() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia868bf739c29d5b4548bbd1417c352ee6400f501 Gerrit-Change-Number: 28947 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_cell_failure_restart_idle_mme

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28948 ) Change subject: cbc: Introduce test TC_cell_failure_restart_idle_mme ...................................................................... cbc: Introduce test TC_cell_failure_restart_idle_mme Related: OS#4945 Change-Id: Ie0ab3d4fbe1d9a824b1f69ceacbf7dfd4f0d9728 --- M cbc/CBC_Tests.ttcn M library/sbcap/SBC_AP_Templates.ttcn 2 files changed, 37 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index f8d04fe..aff5359 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -762,6 +762,31 @@ f_shutdown_helper(); } +/* Test cell in MME going unavailable for broadcasting and going available again */ +private function f_mme_TC_cell_failure_restart_idle_mme() runs on MME_ConnHdlr { + var template (value) Global_ENB_ID enb_id := ts_Global_ENB_ID_MACRO(f_enc_mcc_mnc('901'H, '70'H), 90); + var template (value) Failed_Cell_List fail_list := { + ts_SBCAP_ECGI(f_enc_mcc_mnc('901'H, '70'H), 1234), + ts_SBCAP_ECGI(f_enc_mcc_mnc('901'H, '70'H), 5678) + }; + f_SBC_AP_send(ts_SBCAP_PWS_FAILURE(fail_list, enb_id)); + + f_sleep(1.0); + + var template (value) Restarted_Cell_List cell_list; + cell_list := { + ts_SBCAP_ECGI(f_enc_mcc_mnc('901'H, '70'H), 1234), + ts_SBCAP_ECGI(f_enc_mcc_mnc('901'H, '70'H), 5678) + }; + f_SBC_AP_send(ts_SBCAP_PWS_RESTART(cell_list, enb_id)); +} +testcase TC_cell_failure_restart_idle_mme() runs on test_CT { + f_init(num_bsc := 0, num_mme := 1); + g_pars_MME[0].start_fn := refers(f_mme_TC_cell_failure_restart_idle_mme); + f_start(); + f_shutdown_helper(); +} + control { execute( TC_rx_keepalive() ); execute( TC_rx_keepalive_timeout() ); @@ -784,6 +809,7 @@ execute( TC_create_nack_mme() ); execute( TC_cell_failure_restart_idle_bsc() ); + execute( TC_cell_failure_restart_idle_mme() ); } } diff --git a/library/sbcap/SBC_AP_Templates.ttcn b/library/sbcap/SBC_AP_Templates.ttcn index 68afb58..b002286 100644 --- a/library/sbcap/SBC_AP_Templates.ttcn +++ b/library/sbcap/SBC_AP_Templates.ttcn @@ -40,6 +40,17 @@ iE_Extensions := omit } +template (value) Global_ENB_ID ts_Global_ENB_ID_MACRO(PLMNidentity plmn_id, + integer macro_enb_id) + +:= { + pLMNidentity := plmn_id, + eNB_ID := { + macroENB_ID := int2bit(macro_enb_id, 20) + }, + iE_Extensions := omit +} + template (value) SBC_AP_PDU ts_SBCAP_PWS_RESTART( template (value) Restarted_Cell_List restart_cl, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie0ab3d4fbe1d9a824b1f69ceacbf7dfd4f0d9728 Gerrit-Change-Number: 28948 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_mme

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 ) Change subject: cbc: Introduce test TC_create_nack_mme ...................................................................... cbc: Introduce test TC_create_nack_mme Related: OS#4945 Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 --- M cbc/CBC_Tests.ttcn M cbc/MME_ConnectionHandler.ttcn 2 files changed, 23 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 8daa3bf..3394bed 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -160,6 +160,7 @@ sctp_is_client := sctp_is_client, start_fn := refers(f_MME_ConnHdlr_start_fn_void), exp_cbs_msg := omit, + write_replace_warning_req_cause := SBC_AP_Cause_message_accepted, write_replace_warning_ind_cause := omit, write_repl_unknown_TAIs := omit, bcast_cell_id_list := omit @@ -717,6 +718,23 @@ f_shutdown_helper(); } +/* Test MME answering Write-Replace Warning Request with Write-Replace Warning Response cause != accepted */ +private function f_mme_TC_create_nack_mme() runs on MME_ConnHdlr { + f_sbcap_handle_write_replace_warn_req(g_pars.exp_cbs_msg, 0); +} +testcase TC_create_nack_mme() runs on test_CT { + var template (value) CBS_Message msg := t_CBSmsg(48, 16752); + + f_init(num_bsc := 0, num_mme := 1); + + g_pars_MME[0].start_fn := refers(f_mme_TC_create_nack_mme); + g_pars_MME[0].exp_cbs_msg := valueof(msg); + g_pars_MME[0].write_replace_warning_req_cause := SBcAP_Cause_unspecifed_error; + f_start(); + f_create_and_delete(valueof(msg)); + f_shutdown_helper(); +} + control { execute( TC_rx_keepalive() ); execute( TC_rx_keepalive_timeout() ); @@ -736,6 +754,7 @@ execute( TC_ecbe_create_delete_etws_mme() ); execute( TC_create_nack_bsc() ); + execute( TC_create_nack_mme() ); } } diff --git a/cbc/MME_ConnectionHandler.ttcn b/cbc/MME_ConnectionHandler.ttcn index c49461a..4ab30c6 100644 --- a/cbc/MME_ConnectionHandler.ttcn +++ b/cbc/MME_ConnectionHandler.ttcn @@ -44,6 +44,7 @@ boolean sctp_is_client, void_fn start_fn, CBS_Message exp_cbs_msg optional, + SBC_AP_Cause write_replace_warning_req_cause, SBC_AP_Cause write_replace_warning_ind_cause optional, List_of_TAIs write_repl_unknown_TAIs optional, CellId_Broadcast_List bcast_cell_id_list optional @@ -69,11 +70,12 @@ tx := ts_SBCAP_WRITE_WARNING_RESP_UNKNOWN_TAI( int2bit(msg.msg_id, 16), int2bit(msg.ser_nr, 16), - SBC_AP_Cause_message_accepted, + g_pars.write_replace_warning_req_cause, g_pars.write_repl_unknown_TAIs); } else { tx := ts_SBCAP_WRITE_WARNING_RESP(int2bit(msg.msg_id, 16), - int2bit(msg.ser_nr, 16)); + int2bit(msg.ser_nr, 16), + g_pars.write_replace_warning_req_cause); } f_SBC_AP_send(tx, idx); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 Gerrit-Change-Number: 28945 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022