Attention is currently required from: pespin, msuraev.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-msc/+/28841
to look at the new patch set (#2).
Change subject: ESME: use osmo_sock_get_name() for logging
......................................................................
ESME: use osmo_sock_get_name() for logging
This allows us to drop single-use parameters from osmo_esme to facilitate further code changes.
Related: OS#5568
Change-Id: I34bd4c145b0f6287a323e2350808feb59f1d3187
---
M src/libmsc/smpp_smsc.c
M src/libmsc/smpp_smsc.h
M src/libmsc/smpp_vty.c
3 files changed, 2 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/28841/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I34bd4c145b0f6287a323e2350808feb59f1d3187
Gerrit-Change-Number: 28841
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837 )
Change subject: tests/ranap_rab_ass: fix potential NULL pointer dereferences
......................................................................
Patch Set 3:
(1 comment)
File tests/ranap_rab_ass/ranap_rab_ass_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/16dd9be1_29579720
PS2, Line 67: if (encoded != NULL) {
> maybe use OSMO_ASSERT here as well. There should be an encoded result, otherwise the test is failed.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I16fea7b2a8cb1d693e01c91d7633550e2e599ceb
Gerrit-Change-Number: 28837
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 22:49:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment