Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28826 )
Change subject: Split event list for smscb_message_fsm and smscb_peer_fsm
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> I'd say it's again one of those decisions where I don't really see a clear advantage of either-or. […]
The previous situation simply makes less sense when more peers types are added. This is kind of a preparation for next commit too.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28826
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I909474d1ff4ec7ed20aff0981da47074397df6cb
Gerrit-Change-Number: 28826
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: osmith, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28809 )
Change subject: trxcon: rework trxcon_fsm, move into a separate file
......................................................................
Patch Set 3:
(5 comments)
File src/host/trxcon/src/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/d75ae639_2df99d3a
PS3, Line 467: /* FIXME: we cannot know for sure if the given mode was actually applied.
> can this be fixed? the comment sounds like it can't but there's a FIXME infront
No, it cannot be fixed. This is a limitation of the osmo_fsm API: you cannot indicate a negative outcome from the .action callback. I we were in C++ land, I would simply raise an exception, but this is C. Adding this FIXME to not forget about this problem. Maybe I'll find a solution later.
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/d0bc3771_81e23712
PS3, Line 52: /* TODO: osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); */
> kept on purpose?
Yes. This is going to be fixed in a follow up patch, not here.
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/9442e46b_2fe16d08
PS3, Line 127: /* TODO: timeout */
> kept on purpose?
Yes, this is a potential improvement, so that's why TODO.
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/b0d88f35_c989d4b6
PS3, Line 210: ");
> missing \n
Nice catch! Thanks!
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/2ebc644c_b5dfa87b
PS3, Line 280: /* TODO: set proper .snr */
> kept on purpose? same below
This TODO existed before this commit, so I'll keep it.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28809
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifaf63ead9dd180181358e771367b2a686ba159ca
Gerrit-Change-Number: 28809
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:53:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: wbokslag.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-tetra/+/28596
to look at the new patch set (#2).
Change subject: fixed out of bounds write to pdu_sync buffer
......................................................................
fixed out of bounds write to pdu_sync buffer
Change-Id: I414bf2d61dc1cb37d30dc84b401a75b918116bbb
---
M src/conv_enc_test.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/96/28596/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28596
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I414bf2d61dc1cb37d30dc84b401a75b918116bbb
Gerrit-Change-Number: 28596
Gerrit-PatchSet: 2
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28824 )
Change subject: sbcap: Improve handling of WriteReplaceWarnResponse
......................................................................
Patch Set 3:
(2 comments)
File src/sbcap_link_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/c893150f_dc8e3e05
PS3, Line 256: /* static const long asn_VAL_19_SBcAP_id_Cause = 1; */
> this appears to be meant to explain the '1' in the line below. […]
Yes, it's generated as static. As I wrote in the other patch, I may work on adding our own enum in sbcap_common.h but it's not really urgent.
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/aff1e326_73993a70
PS3, Line 264: SBcAP_Cause_missing_mandatory_element, pdu);
> Looks like error with missing mandatory element is sent back even if cause is not accepted. […]
Sorry I'm not following you here.
how can you access "cause" before "ie" in your example if "cause" is found inside "ie"?
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28824
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0a4d5bdbb6c4fd3870a4f4ebf226668b70fea06a
Gerrit-Change-Number: 28824
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:38:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837 )
Change subject: tests/ranap_rab_ass: fix NULL pointer dereference
......................................................................
Patch Set 1:
(2 comments)
File tests/ranap_rab_ass/ranap_rab_ass_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/7e5e73df_54091c49
PS1, Line 64: encoded ? "ok" : "ERROR"
This makes Coverity think that encoded can be NULL. And yes, in src/osmo-hnbgw/ranap_rab_ass.c I see that it can actually return NULL.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/01cb5e4a_e7e88095
PS1, Line 67: if (encoded != NULL) {
> I'm a bit lost here. […]
See my comment above. I don't like the idea of adding OSMO_ASSERT() because it makes harder to add new tests showing some bug. Fine with adding "potential".
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I16fea7b2a8cb1d693e01c91d7633550e2e599ceb
Gerrit-Change-Number: 28837
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28822 )
Change subject: sbcap: Request and handle Write Replace Warning Indication
......................................................................
Patch Set 3:
(1 comment)
File src/sbcap_msg.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/8e20f213_a61f126e
PS3, Line 231: ie = sbcap_alloc_Write_Replace_Warning_Request_IE(24, SBcAP_Criticality_ignore,
> the comment above should make it clear. […]
Because asn1c is not exporting those values in a header file, as you can see in the commit they are declared static.
I may add our own enum with the IDs later on, and change all of them, not urgent though.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28822
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I563e7d1c999f14b8197bb41e85b7bcf6262fe2a0
Gerrit-Change-Number: 28822
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:35:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28794 )
Change subject: trxcon: trx_if_close(): power the transceiver off if needed
......................................................................
trxcon: trx_if_close(): power the transceiver off if needed
Currently it may happen that the transceiver (e.g. fake_trx.py) remains
powered on when we loose a L1CTL client connection. This is going to
be fixed in change [1] re-implementing the trxcon_fsm. For now let's
ensure that the transceiver is properly powered off by sending
"CMD POWEROFF" from trx_if_close().
Change-Id: I9c5178907304b36ec3de0ee31b7f7a9ed2e31c16
Related: [1] Ifaf63ead9dd180181358e771367b2a686ba159ca
---
M src/host/trxcon/src/trx_if.c
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/host/trxcon/src/trx_if.c b/src/host/trxcon/src/trx_if.c
index a9a6c96..92b9d12 100644
--- a/src/host/trxcon/src/trx_if.c
+++ b/src/host/trxcon/src/trx_if.c
@@ -768,6 +768,8 @@
void trx_if_close(struct trx_instance *trx)
{
+ static const char cmd_poweroff[] = "CMD POWEROFF";
+
/* May be unallocated due to init error */
if (!trx)
return;
@@ -780,6 +782,10 @@
/* Flush CTRL message list */
trx_if_flush_ctrl(trx);
+ /* Power off if the transceiver is up */
+ if (trx->powered_up && trx->trx_ofd_ctrl.fd >= 0)
+ send(trx->trx_ofd_ctrl.fd, &cmd_poweroff[0], sizeof(cmd_poweroff), 0);
+
/* Close sockets */
trx_udp_close(&trx->trx_ofd_ctrl);
trx_udp_close(&trx->trx_ofd_data);
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28794
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9c5178907304b36ec3de0ee31b7f7a9ed2e31c16
Gerrit-Change-Number: 28794
Gerrit-PatchSet: 7
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837 )
Change subject: tests/ranap_rab_ass: fix NULL pointer dereference
......................................................................
Patch Set 1:
(1 comment)
File tests/ranap_rab_ass/ranap_rab_ass_test.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837/comment/e8084232_882b8db9
PS1, Line 67: if (encoded != NULL) {
I'm a bit lost here. Is this really returning encoded=NULL at all? the commit message seems to be indicating so, but I doubt it.
If at all, it should be "Fix potential null pointer dereference".
In any case, I think adding an OSMO_ASSERT(encoded) would be preferable here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28837
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I16fea7b2a8cb1d693e01c91d7633550e2e599ceb
Gerrit-Change-Number: 28837
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 12:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816 )
Change subject: add ps_rab_ass FSM to map GTP via UPF
......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/hnbgw/hnbgw.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816/comment/68ef4966_d3888780
PS2, Line 193: /* Return true when the user configured GTP mapping to be enabled, by configuring a PFCP link to a UPF.
> "Firstly to allow users to keep their current installations working": you mean non-working right? As […]
If a current setup without GTP-U proxy in SGSN (or HNBGW) is broken, then I think there is an unrelated bug that should be fixed. see https://projects.sysmocom.de/issues/5435#note-16
I really don't think we should *enforce* the use of a GTP-U proxy / upf. The only real reason to use it is in situations where thre is no transparent routing of IP packets between RAN and CN - which is basically the case in probably almost every larger-scale commercial network out there. Just in lab / private networks this is an option.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28816
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic9bc30f322c4c6c6e82462d1da50cb15b336c63a
Gerrit-Change-Number: 28816
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:48:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28828 )
Change subject: Split smscb_peer_fsm into CBSP and SBcAP specific FSMs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/cbsp_smscb_peer_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28828/comment/f07ac078_46817312
PS1, Line 3: mme
if this is CBSP then there's no MME
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28828
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0fd00b60cdc6bc6a088be1336d849548ca89c847
Gerrit-Change-Number: 28828
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28826 )
Change subject: Split event list for smscb_message_fsm and smscb_peer_fsm
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I'd say it's again one of those decisions where I don't really see a clear advantage of either-or. I find it much more reasonable with shared event names, hence that's what I originally implemented it. But well, since you're doing all the related development work now.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28826
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I909474d1ff4ec7ed20aff0981da47074397df6cb
Gerrit-Change-Number: 28826
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28824 )
Change subject: sbcap: Improve handling of WriteReplaceWarnResponse
......................................................................
Patch Set 3:
(1 comment)
File src/sbcap_link_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/329b4988_3e851289
PS3, Line 256: /* static const long asn_VAL_19_SBcAP_id_Cause = 1; */
> did you leave this on purpose?
this appears to be meant to explain the '1' in the line below. I don't know why we cannot use that asn_VAL_19_SBcAP_id_Cause. Because it's generated by asn1c as static?
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28824
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0a4d5bdbb6c4fd3870a4f4ebf226668b70fea06a
Gerrit-Change-Number: 28824
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28834 )
Change subject: trxcon: move L1 params from struct trx_instance to trxcon_inst
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/trxcon/src/sched_prim.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28834/comment/0ffa3722_8d2f4a3c
PS1, Line 192: trx
change to trxcon? or is this commented out code still useful?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28834
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd9bb17d63ab1d8712d0c8022a62117a48c6384
Gerrit-Change-Number: 28834
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:15:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28822 )
Change subject: sbcap: Request and handle Write Replace Warning Indication
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File include/osmocom/cbc/smscb_message_fsm.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/266e9610_0b5177de
PS3, Line 35: SMSCB_E_SBCAP_WRITE_IND,
> are you sure the name shouldn't reflect more than "WRITE" if it is called Write Replace Warning?
the difference (at least in cbsp / sabp) is that WRITE would *not* replace. Not sure how it is in SBcAP...
File src/sbcap_msg.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28822/comment/1840b15f_aefa3a19
PS3, Line 231: ie = sbcap_alloc_Write_Replace_Warning_Request_IE(24, SBcAP_Criticality_ignore,
> is 24 a magic nr or a placeholder token? […]
the comment above should make it clear. I'm just wondering why we are not using that asn_VAL_14_SBcAP_id_Send_Write_Replace_Warning_Indication ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28822
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I563e7d1c999f14b8197bb41e85b7bcf6262fe2a0
Gerrit-Change-Number: 28822
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:14:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28809 )
Change subject: trxcon: rework trxcon_fsm, move into a separate file
......................................................................
Patch Set 3: Code-Review+1
(5 comments)
File src/host/trxcon/src/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/d9ef0347_805e253e
PS3, Line 467: /* FIXME: we cannot know for sure if the given mode was actually applied.
can this be fixed? the comment sounds like it can't but there's a FIXME infront
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/3a57afc8_4c83ec71
PS3, Line 52: /* TODO: osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); */
kept on purpose?
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/e29a713a_dc6b26ba
PS3, Line 127: /* TODO: timeout */
kept on purpose?
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/77cbe446_8d40f950
PS3, Line 210: ");
missing \n
https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/bcb7166b_09fd7094
PS3, Line 280: /* TODO: set proper .snr */
kept on purpose? same below
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28809
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ifaf63ead9dd180181358e771367b2a686ba159ca
Gerrit-Change-Number: 28809
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:12:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28820 )
Change subject: Move cbc_cell_id2str() and make it public
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28820
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I74ccbbc810a2fa76fb2999a7588b3f67d4d21e03
Gerrit-Change-Number: 28820
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:11:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 )
Change subject: sbcap: Log info about messages received and trasmitted
......................................................................
Patch Set 2:
(1 comment)
File src/sbcap/sbcap_common.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/a8311b89_24c5da27
PS2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));
> as discussed in chat, this is undefined behavior and it would be better to not rely on it. […]
I agree. Only in recent years (decades?) glibc-on-linux prints that (null) and we don't know if this always will hold true on all platforms (musl, uClibc, etc.)
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28819
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04
Gerrit-Change-Number: 28819
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 11:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28826 )
Change subject: Split event list for smscb_message_fsm and smscb_peer_fsm
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28826
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I909474d1ff4ec7ed20aff0981da47074397df6cb
Gerrit-Change-Number: 28826
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 10:16:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28824 )
Change subject: sbcap: Improve handling of WriteReplaceWarnResponse
......................................................................
Patch Set 3:
(2 comments)
File src/sbcap_link_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/3d610fee_8aee9bc8
PS3, Line 256: /* static const long asn_VAL_19_SBcAP_id_Cause = 1; */
did you leave this on purpose?
https://gerrit.osmocom.org/c/osmo-cbc/+/28824/comment/0f5a1dde_c1a94aa9
PS3, Line 264: SBcAP_Cause_missing_mandatory_element, pdu);
Looks like error with missing mandatory element is sent back even if cause is not accepted. Is this how it should be? After reading the commit message, I would have assumed:
if (cause == accepted) {
if (!ie) {
// tx error_ind_pdu: missing mandatory element
}
} else {
// ...
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28824
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I0a4d5bdbb6c4fd3870a4f4ebf226668b70fea06a
Gerrit-Change-Number: 28824
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 10:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830 )
Change subject: cbc: Handle each CBSP and SBc-AP on a separate component
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
Gerrit-Change-Number: 28830
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 09:57:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels, laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 )
Change subject: sbcap: Log info about messages received and trasmitted
......................................................................
Patch Set 2:
(1 comment)
File src/sbcap/sbcap_common.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/e4e604b0_5c585749
PS2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));
> If that ever happened, "(null)" would be printed which is not a big issue.
as discussed in chat, this is undefined behavior and it would be better to not rely on it.
see also: https://www.geeksforgeeks.org/g-fact-44-passing-null-to-printf-in-c/
otherwise the patch looks good to me!
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28819
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04
Gerrit-Change-Number: 28819
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 09:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830
to look at the new patch set (#3).
Change subject: cbc: Handle each CBSP and SBc-AP on a separate component
......................................................................
cbc: Handle each CBSP and SBc-AP on a separate component
* Each BSC_ConnectionHandler emulates a BSC and handles one TCP/CBSP
conn.
* Each MME_ConectionHandler emulates an MME and handles one SCTP/SBc-AP
conn.
* ECBE related functionalities are moved to its own file
ECBE_Components.ttcn.
* CBS_Message is moved to its own file since it is used by all modules.
Related: OS#4945
Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
---
A cbc/BSC_ConnectionHandler.ttcn
M cbc/CBC_Tests.ttcn
A cbc/CBS_Message.ttcn
A cbc/ECBE_Components.ttcn
A cbc/MME_ConnectionHandler.ttcn
5 files changed, 608 insertions(+), 325 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/28830/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
Gerrit-Change-Number: 28830
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830 )
Change subject: cbc: Handle each CBSP and SBc-AP on a separate component
......................................................................
Patch Set 2:
(1 comment)
File cbc/CBC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830/comment/43a4fcb5_b337…
PS2, Line 205: 100
> do we really need to sleep that much?
No idea, I didn't write this. In any case, it's not run in control(), I think it's just for debugging, hecne the big number.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia0300a2ae69bdf604373dbc484537958413c79a2
Gerrit-Change-Number: 28830
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28794 )
Change subject: trxcon: trx_if_close(): power the transceiver off if needed
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28794
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9c5178907304b36ec3de0ee31b7f7a9ed2e31c16
Gerrit-Change-Number: 28794
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:26:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28833 )
Change subject: BTS_Tests: tune back to CCCH/BCCH in TC_sacch_chan_act_ho_[a]sync
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I65fb243a62fc7670b43f467d6b79268cdfb98f36
Gerrit-Change-Number: 28833
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:08:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28823 )
Change subject: sbcap: Store reported failed TAIs from WriteReplaceResponse in cbc_message_peer
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
> ok, i see now; but with a comment here i wouldn't have had to look
It's not the first time I have to override this so I didn't consider necessary to write about this every time I do it.
File src/smscb_peer_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28823/comment/5357b5cb_bc494f0e
PS3, Line 328: struct cbc_cell_id *cci = NULL; // FIXME: lookup
> explain merging this FIXME?
It's the same as currently done for CBSP. This needs to be improved for both at some point later in time.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28823
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I37b08aa374c1097d2871bf69a7bb7893f32bccd3
Gerrit-Change-Number: 28823
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 )
Change subject: sbcap: Log info about messages received and trasmitted
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/1d2905c0_d15986a2
PS2, Line 8:
> (same for all patches in this relation chain)
I see no need for writing an issue if it's a generic patch simply refactoring/improving some code. It would be more distracting than anything else since there's nothing of interest in the issue regarding this patch.
File src/sbcap/sbcap_common.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/ea30c48b_6bc59b3d
PS2, Line 162: static char pdu_name[256] = "<unknown>";
> may i suggest the pattern […]
I rather have a static buf in the app than using OTC_SELECT.
No need to use it more than once per printf, we are not handling several messages in parallel.
https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/5db8feb2_5a3833fc
PS2, Line 166: OSMO_STRBUF_PRINTF(sb, "%s", sbcap_procedure_code_str(pc));
> are you sure about: sbcap_procedure_code_str() might return NULL
If that ever happened, "(null)" would be printed which is not a big issue.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28819
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04
Gerrit-Change-Number: 28819
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 29 Jul 2022 08:03:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment