July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: doc: Document SBc-AP support and config

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28640 ) Change subject: doc: Document SBc-AP support and config ...................................................................... Patch Set 3: (2 comments) File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/c/osmo-cbc/+/28640/comment/5b81ec69_e27749b3 PS3, Line 77: BSC did you mean MME here? https://gerrit.osmocom.org/c/osmo-cbc/+/28640/comment/69cf1f66_11fa2954 PS3, Line 138: configured unrelated fix -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic14ec2766fce251a6fe52a77d7bc0bbcd8d3afbf Gerrit-Change-Number: 28640 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 13:15:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Add initial SBc-AP support to osmo-cbc

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 ) Change subject: Add initial SBc-AP support to osmo-cbc ...................................................................... Patch Set 10: (4 comments) File include/osmocom/cbc/cbc_data.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/56c05280_a0b510eb PS10, Line 23: CBC_PEER_PROTO_SBcAP cosmetic: missing comma File include/osmocom/cbc/internal.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/a6eff4be_d01902c2 PS10, Line 30: enum sbcap_server_event { So we have the same set of events as in enum cbsp_server_event. Can both FSMs simply use a single unified set of events? File src/cbc_data.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/9947dc6a_f858f547 PS10, Line 104: ws, 'unsigned int i' could be added here (scoped variable) File src/smscb_peer_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/520e6770_6221b929 PS10, Line 483: cosmetic: there should be no space here -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 Gerrit-Change-Number: 28602 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 13:10:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Update asn1c skeleton files

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28639 ) Change subject: sbcap: Update asn1c skeleton files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I581fc53b124a443e150508811df4cca4593038c4 Gerrit-Change-Number: 28639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 12:48:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: doc: Document SBc-AP support and config

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28640 ) Change subject: doc: Document SBc-AP support and config ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/c/osmo-cbc/+/28640/comment/40f74477_24f2cc4a PS3, Line 117: Port port https://gerrit.osmocom.org/c/osmo-cbc/+/28640/comment/74b87448_5e0cfb87 PS3, Line 119: configure configured -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic14ec2766fce251a6fe52a77d7bc0bbcd8d3afbf Gerrit-Change-Number: 28640 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 12:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Update asn1c skeleton files

by osmith

Attention is currently required from: laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28639 ) Change subject: sbcap: Update asn1c skeleton files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I581fc53b124a443e150508811df4cca4593038c4 Gerrit-Change-Number: 28639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 12:34:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: contrib/osmo-cbc.spec: add libosmo-sbcap0/-dev

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28641 to look at the new patch set (#2). Change subject: contrib/osmo-cbc.spec: add libosmo-sbcap0/-dev ...................................................................... contrib/osmo-cbc.spec: add libosmo-sbcap0/-dev Fix for: error: Installed (but unpackaged) file(s) found: ... Related: OS#4945 Change-Id: I789b32c9a9e1fd3f11db8593da3c3ac9a20aeb3d --- M contrib/osmo-cbc.spec.in 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/41/28641/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I789b32c9a9e1fd3f11db8593da3c3ac9a20aeb3d Gerrit-Change-Number: 28641 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: libosmo-sbcap.pc.in: new file

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28643 ) Change subject: libosmo-sbcap.pc.in: new file ...................................................................... libosmo-sbcap.pc.in: new file Related: OS#4945 Change-Id: I9a7cf40e68cc246cab81f8c93485b83f75dcf778 --- M .gitignore M Makefile.am M configure.ac M contrib/osmo-cbc.spec.in M debian/libosmo-sbcap-dev.install A libosmo-sbcap.pc.in 6 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/43/28643/1 diff --git a/.gitignore b/.gitignore index 893b3d2..1872058 100644 --- a/.gitignore +++ b/.gitignore @@ -61,3 +61,4 @@ doc/manuals/vty/cbc_vty_reference.xml contrib/osmo-cbc.spec +libosmo-sbcap.pc diff --git a/Makefile.am b/Makefile.am index 77b1180..f291c8a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3,6 +3,11 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include SUBDIRS = include src doc contrib tests +pkgconfigdir = $(libdir)/pkgconfig +pkgconfig_DATA = \ + libosmo-sbcap.pc \ + $(NULL) + EXTRA_DIST = .version \ README.md \ git-version-gen \ diff --git a/configure.ac b/configure.ac index c104f2c..2c910e7 100644 --- a/configure.ac +++ b/configure.ac @@ -191,4 +191,5 @@ doc/examples/Makefile doc/manuals/Makefile contrib/systemd/Makefile + libosmo-sbcap.pc Makefile) diff --git a/contrib/osmo-cbc.spec.in b/contrib/osmo-cbc.spec.in index 4dbf94d..2b5cac8 100644 --- a/contrib/osmo-cbc.spec.in +++ b/contrib/osmo-cbc.spec.in @@ -121,6 +121,7 @@ %files -n libosmo-sbcap-devel %{_libdir}/libosmo-sbcap.so +%{_libdir}/pkgconfig/libosmo-sbcap.pc %dir %{_includedir}/osmocom %dir %{_includedir}/osmocom/sbcap %{_includedir}/osmocom/sbcap/*.h diff --git a/debian/libosmo-sbcap-dev.install b/debian/libosmo-sbcap-dev.install index a33f2c3..904bdbb 100644 --- a/debian/libosmo-sbcap-dev.install +++ b/debian/libosmo-sbcap-dev.install @@ -1,3 +1,4 @@ usr/include/osmocom/sbcap usr/lib/*/libosmo-sbcap.so usr/lib/*/libosmo-sbcap.a +usr/lib/*/pkgconfig/libosmo-sbcap.pc diff --git a/libosmo-sbcap.pc.in b/libosmo-sbcap.pc.in new file mode 100644 index 0000000..e5ac893 --- /dev/null +++ b/libosmo-sbcap.pc.in @@ -0,0 +1,10 @@ +prefix=@prefix@ +exec_prefix=@exec_prefix@ +libdir=@libdir@ +includedir=@includedir@ + +Name: Osmocom SBc-AP encoding/decoding library +Description: C Utility Library +Version: @VERSION@ +Libs: -L${libdir} -losmo-sbcap +Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9a7cf40e68cc246cab81f8c93485b83f75dcf778 Gerrit-Change-Number: 28643 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: contrib/osmo-cbc.spec: add libosmo-sbcap0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28641 ) Change subject: contrib/osmo-cbc.spec: add libosmo-sbcap0 ...................................................................... contrib/osmo-cbc.spec: add libosmo-sbcap0 Fix for: error: Installed (but unpackaged) file(s) found: ... Related: OS#4945 Change-Id: I789b32c9a9e1fd3f11db8593da3c3ac9a20aeb3d --- M contrib/osmo-cbc.spec.in 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/41/28641/1 diff --git a/contrib/osmo-cbc.spec.in b/contrib/osmo-cbc.spec.in index 814f298..4dbf94d 100644 --- a/contrib/osmo-cbc.spec.in +++ b/contrib/osmo-cbc.spec.in @@ -49,6 +49,24 @@ %description utils CLI utility to interface with the osmo-cbc REST interface (ECBE). +%package -n libosmo-sbcap0 +Summary: Osmocom's library to encode/decode SBc-AP messages +Group: System/Libraries + +%description -n libosmo-sbcap0 +Osmocom's library to encode/decode SBc-AP messages. + +%package -n libosmo-sbcap-devel +Summary: Development files for libosmo-sbcap +Group: Development/Libraries/C and C++ +Requires: libosmo-sbcap0 = %{version} + +%description -n libosmo-sbcap-devel +Osmocom's library to encode/decode SBc-AP messages. + +This subpackage contains libraries and header files for developing +applications that want to make use of libosmo-sbcap. + %prep %setup -q @@ -63,6 +81,7 @@ %install %make_install install -m 755 contrib/cbc-apitool.py %{buildroot}/usr/bin/cbc-apitool.py +find %{buildroot} $ -name '*.la' -o -name '*.a' $ -delete -print %if 0%{?suse_version} %preun @@ -92,7 +111,18 @@ %config(noreplace) %{_sysconfdir}/osmocom/osmo-cbc.cfg %{_unitdir}/%{name}.service +%dir %{_includedir}/osmocom/sbcap/ + %files utils %{_bindir}/cbc-apitool.py +%files -n libosmo-sbcap0 +%{_libdir}/libosmo-sbcap.so.0* + +%files -n libosmo-sbcap-devel +%{_libdir}/libosmo-sbcap.so +%dir %{_includedir}/osmocom +%dir %{_includedir}/osmocom/sbcap +%{_includedir}/osmocom/sbcap/*.h + %changelog -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I789b32c9a9e1fd3f11db8593da3c3ac9a20aeb3d Gerrit-Change-Number: 28641 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: debian: add subpackages libosmo-sbcap0/-dev

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28642 ) Change subject: debian: add subpackages libosmo-sbcap0/-dev ...................................................................... debian: add subpackages libosmo-sbcap0/-dev Related: OS#4945 Change-Id: Ic0e80000b377f80c3914e607e94e998e9862ceac --- M debian/control A debian/libosmo-sbcap-dev.install A debian/libosmo-sbcap0.install 3 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/42/28642/1 diff --git a/debian/control b/debian/control index f971922..7dbaa10 100644 --- a/debian/control +++ b/debian/control @@ -48,3 +48,18 @@ Description: ${misc:Package} PDF documentation Various manuals: user manual, VTY reference manual and/or protocol/interface manuals. + +Package: libosmo-sbcap0 +Section: libs +Architecture: any +Multi-Arch: same +Pre-Depends: ${misc:Pre-Depends} +Depends: ${misc:Depends}, ${shlibs:Depends} +Description: libosmo-sbcap: Osmocom's library to encode/decode SBc-AP messages + +Package: libosmo-sbcap-dev +Section: libdevel +Architecture: any +Multi-Arch: same +Depends: libosmo-sbcap0 (= ${binary:Version}), ${misc:Depends} +Description: libosmo-sbcap: Osmocom's library to encode/decode SBc-AP messages diff --git a/debian/libosmo-sbcap-dev.install b/debian/libosmo-sbcap-dev.install new file mode 100644 index 0000000..a33f2c3 --- /dev/null +++ b/debian/libosmo-sbcap-dev.install @@ -0,0 +1,3 @@ +usr/include/osmocom/sbcap +usr/lib/*/libosmo-sbcap.so +usr/lib/*/libosmo-sbcap.a diff --git a/debian/libosmo-sbcap0.install b/debian/libosmo-sbcap0.install new file mode 100644 index 0000000..0619cfb --- /dev/null +++ b/debian/libosmo-sbcap0.install @@ -0,0 +1 @@ +usr/lib/*/libosmo-sbcap.so.* -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic0e80000b377f80c3914e607e94e998e9862ceac Gerrit-Change-Number: 28642 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add TC_chan_alloc_algo_{a,de}scending

by fixeria

Attention is currently required from: neels, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28214 ) Change subject: BSC_Tests: add TC_chan_alloc_algo_{a,de}scending ...................................................................... Patch Set 5: (2 comments) Patchset: PS4: > I understand why a NACK makes things quicker, but it is surely better to model […] Hi Neels. Thanks for your feedback! BSC_Tests.TC_ratectr_all_available_allocated is not a good example because is not doing TCH assignment. It's simply filling up all SDCCH channels, what makes osmo-bsc allocate TCH channels for signalling. Regarding the VTY scripts, it would have been a better option indeed. But unfortunately I ran out of time budget, so I cannot spend more time on this task. Patchset: PS5: > unfortunately even v4 still going through the NACK case, something both neels and I have been expres […] The main problem preventing me from implementing proper assignment scenarios is the complexity of MGCP_Emulation component. It was designed to be executed on MSC_ConnHdlr component, and there is no easy way to make it run on the test_CT. And I cannot spawn MSC_ConnHdlr components here because multi-trx support is currently only implemented for the test_CT. I ran out of time budget, so I cannot spend more hours on this task. Reworking the MGCP_Emulation to support running on test_CT would be a lot of work (I tried to do so, but quickly gave up). Implementing multi-trx support for the test_CT also seems like a lot of work. I am fine with not merging this patchset or even abandoning it. These testcases were useful for me during development of SYS#5460, so I didn't have to play ping-pong with the customer saying that "it should work find" and getting "it does not" in a loop. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic74a9cd264320a9a17648f9331b67fb2c2404122 Gerrit-Change-Number: 28214 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 11:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022