June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: add osmo-upf

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28308 ) Change subject: add osmo-upf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28308 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I745bcbde6859004c41ddbfd2558036bf9a2d1de2 Gerrit-Change-Number: 28308 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:14:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add libgtpnl dependency

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28307 ) Change subject: add libgtpnl dependency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9928be6f62f5a89d98bdac63428f7a046c95c855 Gerrit-Change-Number: 28307 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:14:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add pfcp_endpoint

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 ) Change subject: add pfcp_endpoint ...................................................................... Patch Set 4: (1 comment) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/d8acc337_fb25e285 PS3, Line 77: osmo_pfcp_endpoint_cb set_msg_ctx; > there are various function pointers in osmocom code that are not named *_cb, […] General comment: Pointing to historical mistakes is never a good reason not to improve new code. _ops is a container for multiple callback functions (operations), so it doesn't apply. e1inp_driver and call_leg are rather ancient examples, where of course we cannot fix it now without API breakage, which we clearly don't want. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:14:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: add pfcp_endpoint

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28244 ) Change subject: add pfcp_endpoint ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File include/osmocom/pfcp/pfcp_endpoint.h: https://gerrit.osmocom.org/c/osmo-upf/+/28244/comment/2e3eb482_139e229b PS3, Line 104: > every time i have written API with opaque structs, i have regretted it from the extensive work requi […] We used a lot of public structs in the beginning, and my experience is that this _usually_ haunts us if there are changes happening again and again. Breaking the ABI should be avoided if possible. "Simple recompilation" is the perspective of a developer, not of a user, who may want to run old binaries with new libraries and vice-versa for testing. Also, think of people wanting to use significantly different versions of osmo-* programs with one system-wide install of libosmo-foo. Basically it comes down to: Do we as developers want to shift burden/cosntraints to distributions or users, or do we invest more effort on our end to make their life easier. I always hold projects with full getter/setter API in the highsest regard, as it shows the developers went the extra mile. One can see this "more evolved" development culture e.g. in code that Pablo wrote (libosmo-netif, libgtpnl, ...). Having said all of the above, we don't have a clear policy on it in osmocom. I just wanted to share my thoughts on the matter. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28244 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic8d42e201b63064a71b40ca45a5a40e29941e8ac Gerrit-Change-Number: 28244 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:12:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: move libosmo-gtlv to libosmo-pfcp.git

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28287 ) Change subject: move libosmo-gtlv to libosmo-pfcp.git ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28287 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Id72cdf94da60d4b6d09d0044c74e672c4412c15d Gerrit-Change-Number: 28287 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:05:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-upf[master]: move libosmo-pfcp to libosmo-pfcp.git

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28306 ) Change subject: move libosmo-pfcp to libosmo-pfcp.git ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28306 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I1464cdd846b00707b0abba9126aa5bb784b7caf1 Gerrit-Change-Number: 28306 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:04:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: Refactor smsq_take_next_sms()

by laforge

Attention is currently required from: pespin, keith, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28338 ) Change subject: Refactor smsq_take_next_sms() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm somewhat skeptical it makes sense to merge this to master. It creates a merge nightmare for all of my work on a SQL-less SMS storage backend. So if we merege this, I expect it will cost days of additional work at my end :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I06c418d4919dd8d28c643b7e0a735bc74d66212c Gerrit-Change-Number: 28338 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 18 Jun 2022 09:03:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/osmo-gbproxy in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-gbproxy failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-gbproxy Last lines of build log: [ 285s] [428/469] installing texlive-extra-utils-2020.20210202-3 [ 297s] [429/469] installing texlive-science-2020.20210202-3 [ 299s] [430/469] installing dbus-1.12.20-2 [ 300s] invoke-rc.d: could not determine current runlevel [ 300s] invoke-rc.d: policy-rc.d denied execution of start. [ 300s] [431/469] installing g++-10-10.2.1-6+rpi1 [ 302s] [432/469] installing python3-pil-8.1.2+dfsg-0.3+deb11u1 [ 303s] [433/469] installing graphviz-2.42.2-5 [ 304s] [434/469] installing util-linux-2.36.1-8+deb11u1 [ 306s] [435/469] installing asciidoc-9.0.0~rc2-1 [ 307s] [436/469] installing base-files-11.1+rpi1+deb11u3 [ 308s] [437/469] installing python3-docutils-0.16+dfsg-4 [ 311s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/python3-docutils.deb' (size=384108) member 'control.tar': lzma error: compressed data is corrupt [ 311s] tar: Unexpected EOF in archive [ 311s] tar: Unexpected EOF in archive [ 311s] tar: Error is not recoverable: exiting now [ 311s] dpkg-deb: error: tar subprocess returned error exit status 2 [ 311s] dpkg: error processing archive .init_b_cache/python3-docutils.deb (--install): [ 311s] dpkg-deb --control subprocess returned error exit status 2 [ 311s] Errors were encountered while processing: [ 311s] .init_b_cache/python3-docutils.deb [ 311s] exit ... [ 311s] ### VM INTERACTION START ### [ 312s] [ 257.473181] sysrq: SysRq : Power Off [ 312s] [ 257.505999] reboot: Power down [ 313s] ### VM INTERACTION END ### [ 313s] [ 313s] armbuild01 failed "build osmo-gbproxy_0.2.0.11.3ca57.202206180026.dsc" at Sat Jun 18 03:31:42 UTC 2022. [ 313s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: Add VTY command for SMS queue trigger holdoff

by keith

Attention is currently required from: keith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28345 to look at the new patch set (#2). Change subject: Add VTY command for SMS queue trigger holdoff ...................................................................... Add VTY command for SMS queue trigger holdoff There are various places in the code that retrigger the SMS -> In Memory pending queue mechanism. The default was to trigger the queue in one second, which could result in running the queue every second. This parameter can ease the queue run interval in case one second is causing too much load. Sms _SHOULD_ be delivered anyway without these queue runs, due to for example, MS becoming available or due to being notified by the call back of a new SMS. Change-Id: I43d88342436d654afd6d955e304e7f85fbc4840f --- M include/osmocom/msc/sms_queue.h M src/libmsc/sms_queue.c M src/libmsc/smsc_vty.c M tests/test_nodes.vty 4 files changed, 25 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/28345/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28345 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I43d88342436d654afd6d955e304e7f85fbc4840f Gerrit-Change-Number: 28345 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: Refactor smsq_take_next_sms()

by keith

Attention is currently required from: pespin, lynxis lazus. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28338 ) Change subject: Refactor smsq_take_next_sms() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm aware that there is a patch in progress that will remove the DB from osmo-msc altogether. However, for the time being maybe it makes sense to have this is master. (I'll clean up the commit messages that are two wide if it gets positive review) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I06c418d4919dd8d28c643b7e0a735bc74d66212c Gerrit-Change-Number: 28338 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 18 Jun 2022 02:33:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022