June 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: osmo_pcap_lapd_write: Fix write of uninitialized byte(s)

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28413 ) Change subject: osmo_pcap_lapd_write: Fix write of uninitialized byte(s) ...................................................................... osmo_pcap_lapd_write: Fix write of uninitialized byte(s) The problem is that we don't zero-initialize the struct pcap_rechdr + pcap_lapdhdr before memcpy'ing them to buf, before we call write: ==20097== Syscall param write(buf) points to uninitialised byte(s) ==20097== at 0x4E48471: write (write.c:26) ==20097== by 0x4DA8DE9: osmo_pcap_lapd_write (lapd_pcap.c:168) ==20097== by 0x4DA8433: send_ph_data_req (lapd.c:628) ==20097== by 0x4C94F5C: lapd_send_rej (lapd_core.c:536) ==20097== by 0x4C9A08A: lapd_rx_i (lapd_core.c:1574) ==20097== by 0x4C9AA8F: lapd_ph_data_ind (lapd_core.c:1708) ==20097== by 0x4DA7C55: lapd_receive (lapd.c:496) ==20097== by 0x4D96B2C: e1inp_rx_ts_lapd (e1_input.c:778) ==20097== by 0x4D9C97C: handle_ts_sign_read (e1d.c:78) ==20097== by 0x4D9D908: e1d_fd_cb (e1d.c:281) ==20097== by 0x4D1281B: poll_disp_fds (select.c:361) ==20097== by 0x4D12928: _osmo_select_main (select.c:399) ==20097== Address 0x1ffefffed7 is on thread 1's stack ==20097== in frame #1, created by osmo_pcap_lapd_write (lapd_pcap.c:129) The whole idea of first filling the two structs on the stack, and then copying them to another buffer on the stack is somehow weird. Let's just create a combined struct on the stack and then fill that one directly. Change-Id: I358c71354cc6ddad1964cc4a988ad29b7ba617f1 Closes: OS#5592 --- M src/input/lapd_pcap.c 1 file changed, 22 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/13/28413/1 diff --git a/src/input/lapd_pcap.c b/src/input/lapd_pcap.c index 77d4971..6e1faf5 100644 --- a/src/input/lapd_pcap.c +++ b/src/input/lapd_pcap.c @@ -127,50 +127,45 @@ /* This currently only works for the D-Channel */ int osmo_pcap_lapd_write(int fd, int direction, struct msgb *msg) { - int numbytes = 0; struct timeval tv; - struct pcap_rechdr pcap_rechdr; - struct pcap_lapdhdr header; - char buf[sizeof(struct pcap_rechdr) + - sizeof(struct pcap_lapdhdr) + msg->len]; + struct { + struct pcap_rechdr pcap_rechdr; + struct pcap_lapdhdr header; + char buf[msg->len]; + } __attribute__((packed)) s; /* PCAP file has not been opened, skip. */ if (fd < 0) return 0; - pcap_rechdr.ts_sec = 0; - pcap_rechdr.ts_usec = 0; - pcap_rechdr.incl_len = msg->len + sizeof(struct pcap_lapdhdr); - pcap_rechdr.orig_len = msg->len + sizeof(struct pcap_lapdhdr); + memset(&s, 0, sizeof(s)); + + s.pcap_rechdr.ts_sec = 0; + s.pcap_rechdr.ts_usec = 0; + s.pcap_rechdr.incl_len = msg->len + sizeof(struct pcap_lapdhdr); + s.pcap_rechdr.orig_len = msg->len + sizeof(struct pcap_lapdhdr); if (direction == OSMO_LAPD_PCAP_OUTPUT) - header.pkttype = htons(LINUX_SLL_OUTGOING); + s.header.pkttype = htons(LINUX_SLL_OUTGOING); else - header.pkttype = htons(LINUX_SLL_HOST); - header.hatype = 0; - header.halen = 0; - header.addr[0] = 0x01; /* we are the network side */ - header.protocol = ntohs(48); + s.header.pkttype = htons(LINUX_SLL_HOST); + s.header.hatype = 0; + s.header.halen = 0; + s.header.addr[0] = 0x01; /* we are the network side */ + s.header.protocol = ntohs(48); gettimeofday(&tv, NULL); - pcap_rechdr.ts_sec = tv.tv_sec; - pcap_rechdr.ts_usec = tv.tv_usec; + s.pcap_rechdr.ts_sec = tv.tv_sec; + s.pcap_rechdr.ts_usec = tv.tv_usec; - memcpy(buf + numbytes, &pcap_rechdr, sizeof(pcap_rechdr)); - numbytes += sizeof(pcap_rechdr); + memcpy(s.buf, msg->data, msg->len); - memcpy(buf + numbytes, &header, sizeof(header)); - numbytes += sizeof(header); - - memcpy(buf + numbytes, msg->data, msg->len); - numbytes += msg->len; - - if (write(fd, buf, numbytes) != numbytes) { + if (write(fd, &s, sizeof(s)) != sizeof(s)) { LOGP(DLLAPD, LOGL_ERROR, "cannot write packet to PCAP: %s\n", strerror(errno)); return -1; } - return numbytes; + return sizeof(s); } int osmo_pcap_lapd_close(int fd) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I358c71354cc6ddad1964cc4a988ad29b7ba617f1 Gerrit-Change-Number: 28413 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/osmo-bts in Raspbian_10/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 154s] Initializing machine ID from random generator. [ 154s] [446/473] installing texlive-fonts-recommended-2018.20190227-2 [ 157s] [447/473] installing librsvg2-common-2.44.10-2.1+rpi1 [ 157s] [448/473] installing texlive-plain-generic-2018.20190227-2 [ 163s] [449/473] installing texlive-latex-base-2018.20190227-2 [ 164s] [450/473] installing python3-nwdiag-1.0.4+dfsg-1 [ 164s] [451/473] installing texlive-lang-greek-2018.20190227-2 [ 175s] [452/473] installing initscripts-2.93-8 [ 177s] invoke-rc.d: could not determine current runlevel [ 177s] invoke-rc.d: policy-rc.d denied execution of start. [ 177s] [453/473] installing python-apt-1.8.4.3 [ 178s] [454/473] installing graphviz-2.40.1-6+deb10u1 [ 178s] [455/473] installing adwaita-icon-theme-3.30.1-1 [ 183s] update-alternatives: using /usr/share/icons/Adwaita/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in auto mode [ 183s] [456/473] installing texlive-bibtex-extra-2018.20190227-2 [ 194s] dpkg-deb (subprocess): decompressing archive member: lzma error: compressed data is corrupt [ 194s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 194s] dpkg: error processing archive .init_b_cache/texlive-bibtex-extra.deb (--install): [ 194s] cannot copy extracted data for './usr/share/doc/texlive-doc/latex/biblatex-philosophy/biblatex-philosophy.pdf' to '/usr/share/doc/texlive-doc/latex/biblatex-philosophy/biblatex-philosophy.pdf.dpkg-new': unexpected end of file or stream [ 194s] Errors were encountered while processing: [ 194s] .init_b_cache/texlive-bibtex-extra.deb [ 194s] exit ... [ 194s] ### VM INTERACTION START ### [ 194s] [ 176.052965] sysrq: SysRq : Power Off [ 194s] [ 176.054382] reboot: Power down [ 195s] ### VM INTERACTION END ### [ 195s] [ 195s] armbuild01 failed "build osmo-bts_1.4.0.103.b8ae.202206270026.dsc" at Mon Jun 27 00:42:41 UTC 2022. [ 195s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/osmo-bsc in Raspbian_10/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-bsc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 201s] Initializing machine ID from random generator. [ 202s] [451/478] installing texlive-fonts-recommended-2018.20190227-2 [ 206s] [452/478] installing librsvg2-common-2.44.10-2.1+rpi1 [ 206s] [453/478] installing texlive-plain-generic-2018.20190227-2 [ 215s] [454/478] installing texlive-latex-base-2018.20190227-2 [ 216s] [455/478] installing python3-nwdiag-1.0.4+dfsg-1 [ 217s] [456/478] installing texlive-lang-greek-2018.20190227-2 [ 230s] [457/478] installing initscripts-2.93-8 [ 232s] invoke-rc.d: could not determine current runlevel [ 232s] invoke-rc.d: policy-rc.d denied execution of start. [ 232s] [458/478] installing python-apt-1.8.4.3 [ 233s] [459/478] installing graphviz-2.40.1-6+deb10u1 [ 233s] [460/478] installing adwaita-icon-theme-3.30.1-1 [ 239s] update-alternatives: using /usr/share/icons/Adwaita/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in auto mode [ 239s] [461/478] installing texlive-bibtex-extra-2018.20190227-2 [ 243s] dpkg-deb (subprocess): decompressing archive member: lzma error: compressed data is corrupt [ 243s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 243s] dpkg: error processing archive .init_b_cache/texlive-bibtex-extra.deb (--install): [ 243s] cannot copy extracted data for './usr/share/doc/texlive-doc/latex/biblatex-archaeology/example/ufg-muenster-verbose-example.pdf' to '/usr/share/doc/texlive-doc/latex/biblatex-archaeology/example/ufg-muenster-verbose-example.pdf.dpkg-new': unexpected end of file or stream [ 243s] Errors were encountered while processing: [ 243s] .init_b_cache/texlive-bibtex-extra.deb [ 243s] exit ... [ 243s] ### VM INTERACTION START ### [ 244s] [ 222.147316] sysrq: SysRq : Power Off [ 244s] [ 222.149271] reboot: Power down [ 244s] ### VM INTERACTION END ### [ 244s] [ 244s] armbuild01 failed "build osmo-bsc_1.8.0.223.b06f.202206260026.dsc" at Sun Jun 26 01:01:47 UTC 2022. [ 244s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/osmo-trx in Raspbian_10/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-trx failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 498s] [577/612] installing python3-nwdiag-1.0.4+dfsg-1 [ 500s] [578/612] installing texlive-lang-greek-2018.20190227-2 [ 519s] [579/612] installing initscripts-2.93-8 [ 522s] invoke-rc.d: could not determine current runlevel [ 522s] invoke-rc.d: policy-rc.d denied execution of start. [ 522s] [580/612] installing libboost-graph-parallel1.67.0-1.67.0-13+deb10u1 [ 523s] [581/612] installing python-apt-1.8.4.3 [ 524s] [582/612] installing graphviz-2.40.1-6+deb10u1 [ 525s] [583/612] installing mpi-default-dev-1.13 [ 525s] [584/612] installing adwaita-icon-theme-3.30.1-1 [ 534s] update-alternatives: using /usr/share/icons/Adwaita/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in auto mode [ 534s] [585/612] installing libboost-graph-parallel1.67-dev-1.67.0-13+deb10u1 [ 535s] [586/612] installing libboost-python1.67-dev-1.67.0-13+deb10u1 [ 536s] [587/612] installing texlive-bibtex-extra-2018.20190227-2 [ 553s] [588/612] installing texlive-latex-recommended-2018.20190227-2 [ 553s] dpkg-deb (subprocess): decompressing archive member: lzma error: compressed data is corrupt [ 553s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 553s] dpkg: error processing archive .init_b_cache/texlive-latex-recommended.deb (--install): [ 553s] cannot copy extracted data for './usr/share/doc/texlive-doc/latex/koma-script/scrguide.pdf' to '/usr/share/doc/texlive-doc/latex/koma-script/scrguide.pdf.dpkg-new': unexpected end of file or stream [ 553s] Errors were encountered while processing: [ 553s] .init_b_cache/texlive-latex-recommended.deb [ 553s] exit ... [ 553s] ### VM INTERACTION START ### [ 554s] [ 501.691525] sysrq: SysRq : Power Off [ 554s] [ 501.712075] reboot: Power down [ 555s] ### VM INTERACTION END ### [ 555s] [ 555s] armbuild01 failed "build osmo-trx_1.4.0.3.9a3e.202206260026.dsc" at Sun Jun 26 00:51:20 UTC 2022. [ 555s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/libosmo-sccp in Raspbian_11/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l… Package network:osmocom:nightly/libosmo-sccp failed to build in Raspbian_11/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 270s] [470/488] installing texlive-formats-extra-2020.20210202-3 [ 272s] [471/488] installing docbook-utils-0.6.14-3.4 [ 272s] Processing triggers for sgml-base (1.30) ... [ 272s] [472/488] installing libpam-systemd-247.3-7+rpi1 [ 273s] [473/488] installing asciidoc-dblatex-9.0.0~rc2-1 [ 273s] [474/488] installing dbus-user-session-1.12.20-2 [ 274s] [475/488] installing dconf-service-0.38.0-2 [ 274s] [476/488] installing dconf-gsettings-backend-0.38.0-2 [ 274s] [477/488] installing gsettings-desktop-schemas-3.38.0-2 [ 275s] [478/488] installing libgtk-3-common-3.24.24-4+deb11u2 [ 278s] dpkg-deb (subprocess): decompressing archive '.init_b_cache/libgtk-3-common.deb' (size=3759308) member 'control.tar': lzma error: compressed data is corrupt [ 278s] tar: Unexpected EOF in archive [ 278s] tar: Unexpected EOF in archive [ 278s] tar: Error is not recoverable: exiting now [ 278s] dpkg-deb: error: tar subprocess returned error exit status 2 [ 278s] dpkg: error processing archive .init_b_cache/libgtk-3-common.deb (--install): [ 278s] dpkg-deb --control subprocess returned error exit status 2 [ 278s] Errors were encountered while processing: [ 278s] .init_b_cache/libgtk-3-common.deb [ 278s] exit ... [ 278s] ### VM INTERACTION START ### [ 278s] mount: /: mount point is busy. [ 278s] Warning: 'remount -o ro /' failed. Triple Syncing.. [ 279s] Powering off. [ 279s] [ 222.362524] reboot: Power down [ 279s] ### VM INTERACTION END ### [ 279s] [ 279s] armbuild02 failed "build libosmo-sccp_1.5.0.20.e9cc.202206240026.dsc" at Fri Jun 24 01:46:32 UTC 2022. [ 279s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: Use unix timestamps in the SMS db

by keith

keith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28339 ) Change subject: Use unix timestamps in the SMS db ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I599a57666da22adf806b01ff095c8672d523a737 Gerrit-Change-Number: 28339 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: Refactor smsq_take_next_sms()

by keith

keith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28338 ) Change subject: Refactor smsq_take_next_sms() ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I06c418d4919dd8d28c643b7e0a735bc74d66212c Gerrit-Change-Number: 28338 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: lchan_select: implement dynamic selection mode for assignment

by fixeria

Attention is currently required from: laforge, fixeria, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 to look at the new patch set (#5). Change subject: lchan_select: implement dynamic selection mode for assignment ...................................................................... lchan_select: implement dynamic selection mode for assignment This change implements an additional channel allocation mode, which can be employed during a TCH channel allocation for assignment. Selection between ascending and descending order is performed depending on pre-configured parameters: * Uplink RxLev threshold and number of samples for averaging, * C0 (BCCH carrier) channel load threshold. This is useful in setups where Tx power of the RF carriers cannot be adjusted +dynamically at run-time and thus BS Power Control cannot be performed. In such setups the BCCH carrier is transmitting at relatively higher power than the other RF carriers. The key idea is to allocate channels in a smarter way, so that UEs with poor signal would get channels on carriers with high Tx power, while UEs with good signal could use carriers with lower Tx power. Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Related: osmo-ttcn3-hacks.git Ia522f37c1c001b3a36f5145b8875fbb88311c2e5 Related: SYS#5460 --- M doc/manuals/chapters/chan_alloc.adoc M include/osmocom/bsc/bts.h M include/osmocom/bsc/lchan_select.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/handover_decision_2.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/lchan_select.c M tests/handover/handover_test.c M tests/osmo-bsc.vty 13 files changed, 329 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/28328/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Gerrit-Change-Number: 28328 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: lchan_select: implement dynamic selection mode for assignment

by fixeria

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 to look at the new patch set (#4). Change subject: lchan_select: implement dynamic selection mode for assignment ...................................................................... lchan_select: implement dynamic selection mode for assignment This change implements an additional channel allocation mode, which can be employed during a TCH channel allocation for assignment. Selection between ascending and descending order is performed depending on pre-configured parameters: * Uplink RxLev threshold and number of samples for averaging, * C0 (BCCH carrier) channel load threshold. This is useful in setups where Tx power of the RF carriers cannot be adjusted +dynamically at run-time and thus BS Power Control cannot be performed. In such setups the BCCH carrier is transmitting at relatively higher power than the other RF carriers. The key idea is to allocate channels in a smarter way, so that UEs with poor signal would get channels on carriers with high Tx power, while UEs with good signal could use carriers with lower Tx power. Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Related: osmo-ttcn3-hacks.git Ia522f37c1c001b3a36f5145b8875fbb88311c2e5 Related: SYS#5460 --- M doc/manuals/chapters/chan_alloc.adoc M include/osmocom/bsc/bts.h M include/osmocom/bsc/lchan_select.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/handover_decision_2.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/lchan_select.c M tests/handover/handover_test.c M tests/osmo-bsc.vty 13 files changed, 331 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/28328/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28328 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b7a0d706976b73cc5c30a8714b830811addfe8d Gerrit-Change-Number: 28328 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: doc/manuals: document channel allocation parameters

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28412 ) Change subject: doc/manuals: document channel allocation parameters ...................................................................... doc/manuals: document channel allocation parameters Change-Id: Ib77eb3d4ad896f1e37b52e549ca3c24f4980240b Related: SYS#5460 --- A doc/manuals/chapters/chan_alloc.adoc M doc/manuals/chapters/interf_meas.adoc M doc/manuals/osmobsc-usermanual.adoc 3 files changed, 82 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/doc/manuals/chapters/chan_alloc.adoc b/doc/manuals/chapters/chan_alloc.adoc new file mode 100644 index 0000000..3a6d41a --- /dev/null +++ b/doc/manuals/chapters/chan_alloc.adoc @@ -0,0 +1,79 @@ +== Channel allocation + +Radio resource management is one of the main tasks of the Base Station Controller. +This involves selection, activation, and deactivation of logical channels, which +are maintained by connected Base Stations. The number of usable logical channels +is limited by total number of radio carriers and may vary depending on the physical +channel combinations assigned to their timeslots. Thus a major goal of the this +task is to manage all the available resources in an efficient way, shifting the +balance between service quality and the overall capacity. + +=== Channel allocation parameters + +OsmoBSC's channel allocator can be configured via the VTY interface. All +relevant parameters are limited by the scope of a BTS node they belong to. +There is currently no way to define global configuration for all BTS. + +All parameters with their respective default values are listed below: + +---- +network + bts 0 + channel allocator ascending + channel allocator avoid-interference 0 + channel allocator tch-signalling-policy always +---- + +==== Channel allocation modes + +Currently only the following two simple channel allocation modes are supported: + +- ascending (default): allocates channels in ascending order, +starting from timeslot 0 of the first TRX (also called C0, the BCCH carrier); +- descending: allocates channels in descending order, +starting from timeslot 7 of the last TRX. + +NOTE: Regardless of the chosen mode, logical channels (sub-slots) are always +selected in ascending order. For example, if a timeslot is configured as SDCCH/8 +and all 8 sub-slots are not in use, then the first SDCCH(0) sub-slot will be +selected in both ascending and descending modes. + +The allocation mode to be used can be configured using the following VTY command: + +---- +OsmoBSC(config-net-bts)# channel allocator ? + ascending Allocate Timeslots and Transceivers in ascending order + descending Allocate Timeslots and Transceivers in descending order +---- + +==== Interference aware channel allocation + +The channel allocator can be configured to prefer logical channels with least +interference, based on interference measurements periodically sent by the BTSs +(see <<interf_rep>>). This is an optional feature, which is disabled by default. + +---- +OsmoBSC(config-net-bts)# channel allocator avoid-interference ? + 0 Ignore interference levels (default). Always assign lchans + in a deterministic order. + 1 In channel allocation, prefer lchans with less interference. +---- + +NOTE: Interference levels are compared within the scope of a single TRX, which +is selected with respect to the configured allocation mode. This means that +the selection logic would ignore channels on the other TRXes, even if they +are better according to the interference reports from the BTS. + +==== TCH sigalling policy + +By default, in a situation when all SDCCHs are exhausted, OsmoBSC will be using TCH +channels for signalling (e.g for Location Updating or call establishment). This +behavior can be restricted to certain kinds of signalling or disabled completely. + +---- +OsmoBSC(config-net-bts)# channel allocator tch-signalling-policy ? + never Never allow TCH for signalling purposes + emergency Only allow TCH for signalling purposes when establishing an emergency call + voice Allow TCH for signalling purposes when establishing any voice call + always Always allow TCH for signalling purposes (default) +---- diff --git a/doc/manuals/chapters/interf_meas.adoc b/doc/manuals/chapters/interf_meas.adoc index c82ff49..518a6e5 100644 --- a/doc/manuals/chapters/interf_meas.adoc +++ b/doc/manuals/chapters/interf_meas.adoc @@ -1,3 +1,4 @@ +[[interf_rep]] == Interference reporting According to 3GPP 48.058, section 6.1, the BTS shall periodically report the diff --git a/doc/manuals/osmobsc-usermanual.adoc b/doc/manuals/osmobsc-usermanual.adoc index 0afa015..f835525 100644 --- a/doc/manuals/osmobsc-usermanual.adoc +++ b/doc/manuals/osmobsc-usermanual.adoc @@ -24,6 +24,8 @@ include::{srcdir}/chapters/bsc.adoc[] +include::{srcdir}/chapters/chan_alloc.adoc[] + include::{srcdir}/chapters/power_control.adoc[] include::{srcdir}/chapters/interf_meas.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib77eb3d4ad896f1e37b52e549ca3c24f4980240b Gerrit-Change-Number: 28412 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022