June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: ansible: get OBS pub key from proper URL

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28266 ) Change subject: ansible: get OBS pub key from proper URL ...................................................................... ansible: get OBS pub key from proper URL Same reasoning as in previous patch Idd0fb6e07cba959a36269244b0c7b5c62aaffeee. Change-Id: I630654ade0edddd23f9fe7c578d1f329f5f49603 --- M ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/66/28266/1 diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml index fc4fcc3..457d01e 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml @@ -16,7 +16,7 @@ - name: add apt.key apt_key: - url: https://download.opensuse.org/repositories/network:/osmocom:/latest/{{ obs_distro }}/Release.key + url: https://build.opensuse.org/projects/network:osmocom/public_key - name: add apt repository apt_repository: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I630654ade0edddd23f9fe7c578d1f329f5f49603 Gerrit-Change-Number: 28266 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: get OBS pub key from proper URL

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28265 ) Change subject: repo-install-test: get OBS pub key from proper URL ...................................................................... repo-install-test: get OBS pub key from proper URL The public OBS key expired on 2022-05-22 and was replaced with a key that was only shortly valid until 2022-06-08. Shortly after it was replaced with a key that is valid longer, until 2024-08-02. On 2022-06-09, one of the osmocom-repo-install tests started failing. For some reason, the key in the latest/Debian_10 directory was not updated to the latest one: https://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_… Since the key is the same for all of network:osmocom, adjust the function to download it from a place that the OBS web UI links to when attempting to download the public GPG key. I guess the latest/Debian_10/Release.key will get updated once making a new release and updating the packages in the repository. But sinc there's a lot of other tasks to do, just use this practical solution for now. Change-Id: Idd0fb6e07cba959a36269244b0c7b5c62aaffeee --- M scripts/repo-install-test/run-inside-docker.sh 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/28265/1 diff --git a/scripts/repo-install-test/run-inside-docker.sh b/scripts/repo-install-test/run-inside-docker.sh index e44c609..933adef 100755 --- a/scripts/repo-install-test/run-inside-docker.sh +++ b/scripts/repo-install-test/run-inside-docker.sh @@ -100,7 +100,6 @@ configure_osmocom_repo_debian() { local proj="$1" local obs_repo="download.opensuse.org/repositories/$(proj_with_slashes "$proj")/$DISTRO_OBSDIR/" - local release_key="/var/cache/apt/${proj}_Release.key" echo "Configuring Osmocom repository" @@ -108,9 +107,9 @@ if ! [ -e "$release_key" ]; then apt-get update apt install -y wget - wget -O "$release_key" "https://$obs_repo/Release.key" + wget -O /tmp/Release.key "https://build.opensuse.org/projects/network:osmocom/public_key" fi - apt-key add "$release_key" + apt-key add /tmp/Release.key echo "deb http://$obs_repo ./" > "/etc/apt/sources.list.d/$proj.list" apt-get update -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idd0fb6e07cba959a36269244b0c7b5c62aaffeee Gerrit-Change-Number: 28265 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-iuh[master]: move new_transp_layer_addr to public API

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28264 ) Change subject: move new_transp_layer_addr to public API ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: No Ic9bc30f322c4c6c6e82462d1da50cb15b336c63a in gerrit? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Icc61620b4d11c4ba6823b40abc7c300f0533c058 Gerrit-Change-Number: 28264 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 12:35:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-iuh[master]: move new_transp_layer_addr to public API

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/28264 ) Change subject: move new_transp_layer_addr to public API ...................................................................... move new_transp_layer_addr to public API osmo-hnbgw will use this function in Ic9bc30f322c4c6c6e82462d1da50cb15b336c63a. Related: SYS#5859 Change-Id: Icc61620b4d11c4ba6823b40abc7c300f0533c058 --- M include/osmocom/ranap/iu_helpers.h M src/iu_helpers.c 2 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/64/28264/1 diff --git a/include/osmocom/ranap/iu_helpers.h b/include/osmocom/ranap/iu_helpers.h index bf2a580..3a06c4b 100644 --- a/include/osmocom/ranap/iu_helpers.h +++ b/include/osmocom/ranap/iu_helpers.h @@ -20,3 +20,4 @@ RANAP_TransportLayerInformation_t *ranap_new_transp_info_rtp(struct osmo_sockaddr *addr, bool use_x213_nsap); RANAP_TransportLayerInformation_t *ranap_new_transp_info_gtp(struct osmo_sockaddr *addr, uint32_t tei, bool use_x213_nsap); +int ranap_new_transp_layer_addr(BIT_STRING_t *out, struct osmo_sockaddr *addr, bool use_x213_nsap); diff --git a/src/iu_helpers.c b/src/iu_helpers.c index 1591f7d..6e2c203 100644 --- a/src/iu_helpers.c +++ b/src/iu_helpers.c @@ -143,7 +143,7 @@ if (len == 20 && buf[0] == 0x35) { /* For an X.213 NSAP encoded address we expect a buffer of exactly 20 bytes (3 bytes IDP + 17 bytes * DSP). we also expect AFI = 0x35, which means that two byte IDI and an IP address follows. (see also - * comments in function new_transp_layer_addr below) */ + * comments in function ranap_new_transp_layer_addr below) */ x213_nsap = true; icp = osmo_load16be(&buf[1]); switch (icp) { @@ -176,7 +176,7 @@ return 0; } -static int new_transp_layer_addr(BIT_STRING_t *out, struct osmo_sockaddr *addr, bool use_x213_nsap) +int ranap_new_transp_layer_addr(BIT_STRING_t *out, struct osmo_sockaddr *addr, bool use_x213_nsap) { uint8_t *buf; unsigned int len; @@ -242,7 +242,7 @@ } tli = CALLOC(1, sizeof(*tli)); - rc = new_transp_layer_addr(&tli->transportLayerAddress, addr, use_x213_nsap); + rc = ranap_new_transp_layer_addr(&tli->transportLayerAddress, addr, use_x213_nsap); if (rc < 0) { ASN_STRUCT_FREE(asn_DEF_RANAP_TransportLayerInformation, tli); return NULL; @@ -262,7 +262,7 @@ uint32_t binding_buf = htonl(tei); int rc; - rc = new_transp_layer_addr(&tli->transportLayerAddress, addr, use_x213_nsap); + rc = ranap_new_transp_layer_addr(&tli->transportLayerAddress, addr, use_x213_nsap); if (rc < 0) { ASN_STRUCT_FREE(asn_DEF_RANAP_TransportLayerInformation, tli); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/28264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Icc61620b4d11c4ba6823b40abc7c300f0533c058 Gerrit-Change-Number: 28264 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in libosmocore[master]: APDU parsing support for GlobalPlatform

by k_o_

Attention is currently required from: laforge. k_o_ has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28248 ) Change subject: APDU parsing support for GlobalPlatform ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > quite interesting. […] I think it is related the the Android carrier privileges using the GlobalPlatform access rules which is reusing commands, here STORE DATA from the GlobalPlatform card specification. In general all MNOs are free to install whatever applet is necessary for their business purposes, e.g. QoS applets, Multi IMSI applets, crypto applets, payment applets. These applets can use an arbitrary APDU command set, i.e. to be in general useful all APDUs have to be supported by the simtrace board. Would it be possible to generalize the APDU case code to support any ISO command or is this not possible because the whole command is not available? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28248 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib734fc852e7b63b9efdc414adccbd796a572eb55 Gerrit-Change-Number: 28248 Gerrit-PatchSet: 1 Gerrit-Owner: k_o_ <wider.stand(a)gmx.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 Jun 2022 12:11:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in libosmocore[master]: cbsp: Add enum and value string for Cause

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28258 ) Change subject: cbsp: Add enum and value string for Cause ...................................................................... cbsp: Add enum and value string for Cause Change-Id: I35592bb4fff2e7b442d0e0cd537b66687862baf2 --- M TODO-RELEASE M include/osmocom/gsm/cbsp.h M src/gsm/cbsp.c 3 files changed, 47 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 9f9f9d9..5f9d6e8 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -12,3 +12,4 @@ libosmogb ABI BREAKAGE Add reset_ack_notification function pointer to struct bssgp_bvc_fsm_ops libosmogsm add API Add rach_tx_integer_raw2val() in gsm_utils.h libosmogsm add API iuup.h +libosmogsm add API cbsp.h enum osmo_cbsp_cause, osmo_cbsp_cause_name(s) diff --git a/include/osmocom/gsm/cbsp.h b/include/osmocom/gsm/cbsp.h index 30a0ec9..1e705e5 100644 --- a/include/osmocom/gsm/cbsp.h +++ b/include/osmocom/gsm/cbsp.h @@ -71,7 +71,7 @@ struct llist_head list; /* entry in a fail_list below */ enum CELL_IDENT id_discr; union gsm0808_cell_id_u cell_id; - uint8_t cause; + uint8_t cause; /* enum osmo_cbsp_cause */ }; @@ -241,6 +241,30 @@ enum cbsp_channel_ind *channel_ind; }; +/* 8.2.13 Cause */ +enum osmo_cbsp_cause { + OSMO_CBSP_CAUSE_PARAM_NOT_RECOGNISED = 0, + OSMO_CBSP_CAUSE_PARAM_VALUE_INVALID, + OSMO_CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED, + OSMO_CBSP_CAUSE_CELL_ID_NOT_VALID, + OSMO_CBSP_CAUSE_UNRECOGNISED_MESSAGE, + OSMO_CBSP_CAUSE_MISSING_MANDATORY_ELEMENT, + OSMO_CBSP_CAUSE_BSC_CAPACITY_EXCEEDED, + OSMO_CBSP_CAUSE_CELL_MEMORY_EXCEEDED, + OSMO_CBSP_CAUSE_BSC_MEMORY_EXCEEDED, + OSMO_CBSP_CAUSE_CELL_BROADCAST_NOT_SUPPORTED, + OSMO_CBSP_CAUSE_CELL_BROADCAST_NOT_OPERATIONAL, + OSMO_CBSP_CAUSE_INCOMPATIBLE_DRX_PARAM, + OSMO_CBSP_CAUSE_EXT_CHAN_NOT_SUPPORTED, + OSMO_CBSP_CAUSE_MSG_REF_ALREADY_USED, + OSMO_CBSP_CAUSE_UNSPECIFIED_ERROR, + OSMO_CBSP_CAUSE_LAI_OR_LAC_NOT_VALID, +}; +extern const struct value_string osmo_cbsp_cause_names[]; +static inline const char *osmo_cbsp_cause_name(enum osmo_cbsp_cause cause) +{ + return get_value_string(osmo_cbsp_cause_names, cause); +} /* decoded CBSP message */ struct osmo_cbsp_decoded { diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index e340ebe..2095003 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -1477,4 +1477,25 @@ return rc; } +/*! value_string[] for enum osmo_cbsp_cause. */ +const struct value_string osmo_cbsp_cause_names[] = { + { OSMO_CBSP_CAUSE_PARAM_NOT_RECOGNISED, "Parameter-not-recognised" }, + { OSMO_CBSP_CAUSE_PARAM_VALUE_INVALID, "Parameter-value-invalid" }, + { OSMO_CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED, "Message-reference-not-identified" }, + { OSMO_CBSP_CAUSE_CELL_ID_NOT_VALID, "Cell-identity-not-valid" }, + { OSMO_CBSP_CAUSE_UNRECOGNISED_MESSAGE, "Unrecognised-message" }, + { OSMO_CBSP_CAUSE_MISSING_MANDATORY_ELEMENT, "Missing-mandatory-element" }, + { OSMO_CBSP_CAUSE_BSC_CAPACITY_EXCEEDED, "BSC-capacity-exceeded" }, + { OSMO_CBSP_CAUSE_CELL_MEMORY_EXCEEDED, "Cell-memory-exceeded" }, + { OSMO_CBSP_CAUSE_BSC_MEMORY_EXCEEDED, "BSC-memory-exceeded" }, + { OSMO_CBSP_CAUSE_CELL_BROADCAST_NOT_SUPPORTED, "Cell-broadcast-not-supported" }, + { OSMO_CBSP_CAUSE_CELL_BROADCAST_NOT_OPERATIONAL, "Cell-broadcast-not-operational" }, + { OSMO_CBSP_CAUSE_INCOMPATIBLE_DRX_PARAM, "Incompatible-DRX-parameter:"}, + { OSMO_CBSP_CAUSE_EXT_CHAN_NOT_SUPPORTED, "Extended-channel-not-supported"}, + { OSMO_CBSP_CAUSE_MSG_REF_ALREADY_USED, "Message-reference-already-used"}, + { OSMO_CBSP_CAUSE_UNSPECIFIED_ERROR, "Unspecified-error"}, + { OSMO_CBSP_CAUSE_LAI_OR_LAC_NOT_VALID, "LAI-or-LAC-not-valid"}, + { 0, NULL } +}; + #endif /* HAVE_SYS_SOCKET_H */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35592bb4fff2e7b442d0e0cd537b66687862baf2 Gerrit-Change-Number: 28258 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in libosmocore[master]: cbsp: Add enum and value string for Cause

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28258 ) Change subject: cbsp: Add enum and value string for Cause ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I35592bb4fff2e7b442d0e0cd537b66687862baf2 Gerrit-Change-Number: 28258 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Jun 2022 11:54:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Allow setting hnbllif sapi versions

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28252 ) Change subject: hnodeb: Allow setting hnbllif sapi versions ...................................................................... hnodeb: Allow setting hnbllif sapi versions Version 1 of audio SAPI will be used in follow-up patch. Related: SYS#5516 Change-Id: I24d757d3dfa4148537db49d70c525e1a81836426 --- M hnodeb/HNBGW_ConnectionHandler.ttcn M hnodeb/HNB_Tests.ttcn 2 files changed, 19 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/hnodeb/HNBGW_ConnectionHandler.ttcn b/hnodeb/HNBGW_ConnectionHandler.ttcn index 6b06437..a92ac9e 100644 --- a/hnodeb/HNBGW_ConnectionHandler.ttcn +++ b/hnodeb/HNBGW_ConnectionHandler.ttcn @@ -106,19 +106,20 @@ f_HNBGW_ConnHdlr_init_vty(); /* Connect to HNB on LLSK and do HELLO ping-pong */ - f_start_hnbllif(LLSK, id & "-LLSK", g_pars.hnbllif_sk_path, g_llsk_conn_id); + f_start_hnbllif(LLSK, id & "-LLSK", g_pars, g_llsk_conn_id); } -function f_start_hnbllif(HNBLLIF_CODEC_PT pt, charstring id, charstring hnbllif_sk_path, out integer hnbllif_conn_id) { +function f_start_hnbllif(HNBLLIF_CODEC_PT pt, charstring id, TestHdlrParams pars, + out integer hnbllif_conn_id) { timer T := 2.0; var HNBLLIF_send_data sd; var HNBLLIF_Message last_hello_cnf; - if (hnbllif_sk_path == "") { + if (pars.hnbllif_sk_path == "") { hnbllif_conn_id := -1; return; } - hnbllif_conn_id := f_hnbllif_connect(pt, hnbllif_sk_path); + hnbllif_conn_id := f_hnbllif_connect(pt, pars.hnbllif_sk_path); T.start; pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_CTL, HNBLLIF_Types.mp_hnbllif_version))); @@ -128,23 +129,23 @@ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=CTL"); } } - pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_IUH, 0))); + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_IUH, pars.hnbllif_sapi_iuh_version))); alt { - [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_IUH, 0); + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_IUH, pars.hnbllif_sapi_iuh_version); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=IUH"); } } - pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_AUDIO, 0))); + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_AUDIO, pars.hnbllif_sapi_audio_version))); alt { - [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_AUDIO, 0); + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_AUDIO, pars.hnbllif_sapi_audio_version); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=AUDIO"); } } - pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_GTP, 0))); + pt.send(t_SD_HNBLLIF(hnbllif_conn_id, ts_HNBLLIF_CTL_HELLO_REQ(HNBLL_IF_SAPI_GTP, pars.hnbllif_sapi_gtp_version))); alt { - [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_GTP, 0); + [] as_hnbllif_hello_cnf(pt, hnbllif_conn_id, last_hello_cnf, HNBLL_IF_SAPI_GTP, pars.hnbllif_sapi_gtp_version); [] T.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for HNBLLIF HELLO.REQ SAPI=GTP"); } @@ -153,6 +154,9 @@ type record TestHdlrParams { charstring hnbllif_sk_path, /* "" means don't connect */ + uint16_t hnbllif_sapi_iuh_version, + uint16_t hnbllif_sapi_gtp_version, + uint16_t hnbllif_sapi_audio_version, charstring hnbgw_addr, charstring hnodeb_addr, integer hnbgw_port, @@ -171,6 +175,9 @@ * f_gen_test_hdlr_pars() instead in order to get a configuration. */ template (value) TestHdlrParams t_def_TestHdlrPars := { hnbllif_sk_path := HNBLL_SOCK_DEFAULT, + hnbllif_sapi_iuh_version := 0, + hnbllif_sapi_gtp_version := 0, + hnbllif_sapi_audio_version := 0, hnbgw_addr := "127.0.0.1", hnodeb_addr := "127.0.0.1", hnbgw_port := 29169, diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn index 24feab8..1a02a6f 100644 --- a/hnodeb/HNB_Tests.ttcn +++ b/hnodeb/HNB_Tests.ttcn @@ -113,9 +113,9 @@ f_vty_transceive(HNBVTY, "enable"); } -private function f_init_hnbllif() runs on test_CT { +private function f_init_hnbllif(TestHdlrParams pars) runs on test_CT { map(self:LLSK, system:LLSK); - f_start_hnbllif(LLSK, testcasename(), mp_hnbllif_sk_path, g_llsk_conn_id); + f_start_hnbllif(LLSK, testcasename(), pars, g_llsk_conn_id); } /* global initialization function */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28252 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I24d757d3dfa4148537db49d70c525e1a81836426 Gerrit-Change-Number: 28252 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: hnodeb: Update primitives to audio SAPI version 1

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28253 ) Change subject: hnodeb: Update primitives to audio SAPI version 1 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Readding +1 from laforge since I fixed the indent issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9af56f5e6a70b350f2fffa2e04be384d101b52ed Gerrit-Change-Number: 28253 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 Jun 2022 11:54:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-hnbgw[master]: fix segfault in error handling for mgw_fi == NULL

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28263 ) Change subject: fix segfault in error handling for mgw_fi == NULL ...................................................................... fix segfault in error handling for mgw_fi == NULL In mgw_fsm_handle_rab_ass_resp(), a NULL mgw_fi is handled as error, but the error handling fails to return. The function continues to dereference mgw_fi. Add missing return. Related: SYS#5995 Change-Id: I3e98dc3a00145ec1f71c678bbf45debfd4276237 --- M src/osmo-hnbgw/mgw_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-hnbgw/mgw_fsm.c b/src/osmo-hnbgw/mgw_fsm.c index d90571b..b84d87e 100644 --- a/src/osmo-hnbgw/mgw_fsm.c +++ b/src/osmo-hnbgw/mgw_fsm.c @@ -767,6 +767,7 @@ /* Send a release request, to make sure that the MSC is aware of the problem. */ tx_release_req(map); + return -1; } mgw_fsm_priv = map->mgw_fi->priv; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3e98dc3a00145ec1f71c678bbf45debfd4276237 Gerrit-Change-Number: 28263 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022