April 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: vty: Add a 'skip-zero' version of 'show stats' and 'show rate-counters'

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27822 ) Change subject: vty: Add a 'skip-zero' version of 'show stats' and 'show rate-counters' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie4df1c139e3c82deca1dd3cdab5d3909e0513684 Gerrit-Change-Number: 27822 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Apr 2022 15:50:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in pysim[master]: ts_102_222: Set number of records when creating linear files

by fixeria

Attention is currently required from: Christian Amsüss. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27825 ) Change subject: ts_102_222: Set number of records when creating linear files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8aeb869c601ee5d1c8b02da6d72eb3c50e347982 Gerrit-Change-Number: 27825 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Comment-Date: Tue, 19 Apr 2022 15:43:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: e1d: stat_items for the GPS-DO related bits

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27830 ) Change subject: e1d: stat_items for the GPS-DO related bits ...................................................................... e1d: stat_items for the GPS-DO related bits It is interesting from a monitoring point of view to be able to correlate the GPSDO state with other performance counters we export. While each GPS-DO only exists once per icE1usb, we still export the state per line, to make it easy for external monitoring to have one set of counters per line. Change-Id: I1f98610b7c725146a3f016a8737440be5baae858 --- M src/e1d.h M src/intf_line.c M src/usb.c 3 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/30/27830/1 diff --git a/src/e1d.h b/src/e1d.h index 00d2149..42be1b4 100644 --- a/src/e1d.h +++ b/src/e1d.h @@ -28,6 +28,7 @@ #include <osmocom/core/isdnhdlc.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/rate_ctr.h> +#include <osmocom/core/stat_item.h> #include <osmocom/core/timer.h> #include <osmocom/vty/command.h> @@ -45,6 +46,8 @@ }; #define line_ctr_add(line, idx, add) rate_ctr_add(rate_ctr_group_get_ctr((line)->ctrs, idx), add) +#define line_stat_set(line, idx, add) \ + osmo_stat_item_set(osmo_stat_item_group_get_item((line)->stats, idx), add) enum e1d_line_ctr { LINE_CTR_LOS, @@ -58,6 +61,14 @@ LINE_CTR_FRAMES_DEMUXED_E1O, }; +enum e1d_line_stat_item { + LINE_GPSDO_STATE, + LINE_GPSDO_ANTENNA, + LINE_GPSDO_TUNE_COARSE, + LINE_GPSDO_TUNE_FINE, + LINE_GPSDO_FREQ_EST, +}; + enum e1_ts_mode { E1_TS_MODE_OFF = 0, E1_TS_MODE_RAW, @@ -118,6 +129,7 @@ void *drv_data; struct rate_ctr_group *ctrs; + struct osmo_stat_item_group *stats; /* timeslots for channelized mode */ struct e1_ts ts[32]; diff --git a/src/intf_line.c b/src/intf_line.c index 234f0c0..d12c0df 100644 --- a/src/intf_line.c +++ b/src/intf_line.c @@ -35,6 +35,7 @@ #include <osmocom/core/utils.h> #include <osmocom/core/stats.h> #include <osmocom/core/rate_ctr.h> +#include <osmocom/core/stat_item.h> #include <osmocom/core/timer.h> #include <osmocom/e1d/proto.h> @@ -68,6 +69,23 @@ .ctr_desc = line_ctr_description, }; +static const struct osmo_stat_item_desc line_stat_description[] = { + [LINE_GPSDO_STATE] = { "gpsdo:state", "GPSDO State" }, + [LINE_GPSDO_ANTENNA] = { "gpsdo:antenna", "GSPDO Antenna State" }, + [LINE_GPSDO_TUNE_COARSE]= { "gpsdo:tune:coarse", "GSPDO Coarse Tuning" }, + [LINE_GPSDO_TUNE_FINE] = { "gpsdo:tune:fine", "GSPDO Fine Tuning" }, + [LINE_GPSDO_FREQ_EST] = { "gpsdo:freq_est", "GSPDO Frequency Estimate" }, +}; + +static const struct osmo_stat_item_group_desc line_stats_desc = { + .group_name_prefix = "e1d_line", + .group_description = "Stat items for E1 line", + .class_id = OSMO_STATS_CLASS_GLOBAL, + .num_items = ARRAY_SIZE(line_stat_description), + .item_desc = line_stat_description, +}; + + /* watchdog timer, called once per second to check if we still receive data on the line */ static void line_watchdog_cb(void *data) { @@ -253,8 +271,13 @@ line->ctrs = rate_ctr_group_alloc(line, &line_ctrg_desc, intf->id << 8 | line->id); OSMO_ASSERT(line->ctrs); + + line->stats = osmo_stat_item_group_alloc(line, &line_stats_desc, intf->id << 8 | line->id); + OSMO_ASSERT(line->stats); + snprintf(name, sizeof(name), "I%u:L%u", intf->id, line->id); rate_ctr_group_set_name(line->ctrs, name); + osmo_stat_item_group_set_name(line->stats, name); llist_add_tail(&line->list, &intf->lines); diff --git a/src/usb.c b/src/usb.c index 1949485..fa6ddee 100644 --- a/src/usb.c +++ b/src/usb.c @@ -707,6 +707,7 @@ struct e1_usb_intf_data *id = intf->drv_data; struct e1usb_gpsdo_status *last_st = &id->gpsdo.last_status; const struct e1usb_gpsdo_status *st; + struct e1_line *line; if (len < sizeof(*st)) { LOGPIF(intf, DE1D, LOGL_ERROR, "GPSDO status %zu < %zu!\n", len, sizeof(*st)); @@ -742,6 +743,15 @@ LOGPIF(intf, DE1D, LOGL_ERROR, "GPS Fix LOST\n"); } + /* update stat_items for statsd / monitoring */ + llist_for_each_entry(line, &intf->lines, list) { + line_stat_set(line, LINE_GPSDO_STATE, st->state); + line_stat_set(line, LINE_GPSDO_ANTENNA, st->antenna_state); + line_stat_set(line, LINE_GPSDO_TUNE_COARSE, libusb_le16_to_cpu(st->tune.coarse)); + line_stat_set(line, LINE_GPSDO_TUNE_FINE, libusb_le16_to_cpu(st->tune.fine)); + line_stat_set(line, LINE_GPSDO_FREQ_EST, osmo_load32le(&st->freq_est)); + } + /* update our state */ memcpy(last_st, st, sizeof(*last_st)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1f98610b7c725146a3f016a8737440be5baae858 Gerrit-Change-Number: 27830 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: octoi: Add new rate-counter for out-of-order packets

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27829 ) Change subject: octoi: Add new rate-counter for out-of-order packets ...................................................................... octoi: Add new rate-counter for out-of-order packets Change-Id: Ie97c1efecf8b673620ddc097e0184f8a9c92c3f0 --- M src/octoi/e1oip.c M src/octoi/e1oip.h 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/29/27829/1 diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c index 27eb201..e14d719 100644 --- a/src/octoi/e1oip.c +++ b/src/octoi/e1oip.c @@ -22,6 +22,7 @@ #include <errno.h> #include <unistd.h> #include <stdint.h> +#include <inttypes.h> #include <string.h> #include <sys/types.h> #include <sys/socket.h> @@ -45,6 +46,7 @@ static const struct rate_ctr_desc iline_ctr_description[] = { [LINE_CTR_E1oIP_UNDERRUN] = { "e1oip:underrun", "Frames missing/substituted in IP->E1 direction"}, [LINE_CTR_E1oIP_OVERFLOW] = { "e1oip:overflow", "Frames overflowed in IP->E1 direction"}, + [LINE_CTR_E1oIP_RX_OUT_OF_ORDER] = { "e1oip:rx:pkt_out_of_order", "Packets out-of-order in IP->E1 direction"}, }; static const struct rate_ctr_group_desc iline_ctrg_desc = { @@ -204,6 +206,7 @@ re_ordering = false; } + iline_ctr_add(iline, LINE_CTR_E1oIP_RX_OUT_OF_ORDER, 1); LOGPEER(peer, LOGL_NOTICE, "RxIP: frame_nr=%u, but expected %u: delta=%d - assuming %s\n", frame_nr, exp_next_seq, delta, re_ordering ? "re-ordering" : "packet loss"); diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h index 54fbadd..1a71f6c 100644 --- a/src/octoi/e1oip.h +++ b/src/octoi/e1oip.h @@ -16,6 +16,7 @@ enum e1oip_line_ctr { LINE_CTR_E1oIP_UNDERRUN, LINE_CTR_E1oIP_OVERFLOW, + LINE_CTR_E1oIP_RX_OUT_OF_ORDER, }; enum e1oip_line_stat { -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie97c1efecf8b673620ddc097e0184f8a9c92c3f0 Gerrit-Change-Number: 27829 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: Add rate counters for number of frames muxed/demuxed (E1 side)

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27828 ) Change subject: Add rate counters for number of frames muxed/demuxed (E1 side) ...................................................................... Add rate counters for number of frames muxed/demuxed (E1 side) Nominally this is of course 8000/s, but this patch should allow us to verify this in monitoring. Note that the rate_ctr base of course is "wrong" as it uses the normal system clock, which is much less precise than the E1 clock of an icE1usb with GPS-DO. So it really only helps us to compare Rx against Tx or against other values/counters derived from the TDM clock. Change-Id: I40e9fb38561410fbf0902b8a390673690a36ea5e --- M src/e1d.h M src/intf_line.c M src/mux_demux.c 3 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/28/27828/1 diff --git a/src/e1d.h b/src/e1d.h index 726696e..00d2149 100644 --- a/src/e1d.h +++ b/src/e1d.h @@ -54,6 +54,8 @@ LINE_CTR_TX_UNFL, LINE_CTR_RX_REMOTE_E, LINE_CTR_RX_REMOTE_A, + LINE_CTR_FRAMES_MUXED_E1T, + LINE_CTR_FRAMES_DEMUXED_E1O, }; enum e1_ts_mode { diff --git a/src/intf_line.c b/src/intf_line.c index 63fd098..234f0c0 100644 --- a/src/intf_line.c +++ b/src/intf_line.c @@ -56,6 +56,8 @@ [LINE_CTR_TX_UNFL] = { "tx:underflow", "E1 Tx Underflow" }, [LINE_CTR_RX_REMOTE_E] ={ "rx:remote_crc_errors", "Rx Frames Reporting Remote CRC Error"}, [LINE_CTR_RX_REMOTE_A] ={ "rx:remote_alarm", "Rx Frames Reporting Remote Alarm"}, + [LINE_CTR_FRAMES_MUXED_E1T] = { "tx:frames_muxed", "E1 Tx Frames multiplexed" }, + [LINE_CTR_FRAMES_DEMUXED_E1O] = { "rx:frames_demuxed", "E1 Rx Frames demultiplexed" }, }; static const struct rate_ctr_group_desc line_ctrg_desc = { diff --git a/src/mux_demux.c b/src/mux_demux.c index 671d6d1..cd5c286 100644 --- a/src/mux_demux.c +++ b/src/mux_demux.c @@ -218,6 +218,8 @@ OSMO_ASSERT(0); } + line_ctr_add(line, LINE_CTR_FRAMES_MUXED_E1T, fts); + return tsz; } @@ -421,6 +423,8 @@ if (frame_base >= 0) _e1_line_demux_in_ts0(line, buf, ftr, frame_base); + line_ctr_add(line, LINE_CTR_FRAMES_DEMUXED_E1O, ftr); + switch (line->mode) { case E1_LINE_MODE_CHANNELIZED: return _e1_line_demux_in_channelized(line, buf, ftr); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I40e9fb38561410fbf0902b8a390673690a36ea5e Gerrit-Change-Number: 27828 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: octoi: Update RIFO depth also on dequeue

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27827 ) Change subject: octoi: Update RIFO depth also on dequeue ...................................................................... octoi: Update RIFO depth also on dequeue We updated the RIFO depth on every enqueue, let's also do so on dequeue. Otherwise the figure might be wrong in case of no further received input frames. Change-Id: I175f0503e7435c362f35bd8083b785197d9d7338 --- M src/octoi/octoi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/27/27827/1 diff --git a/src/octoi/octoi.c b/src/octoi/octoi.c index 3137b75..d2960ac 100644 --- a/src/octoi/octoi.c +++ b/src/octoi/octoi.c @@ -127,5 +127,5 @@ memcpy(cur, iline->e1t.last_frame, BYTES_PER_FRAME); } } - //iline_stat_set(iline, LINE_STAT_E1oIP_E1T_FIFO, frame_fifo_frames(&iline->e1t.fifo)); + iline_stat_set(iline, LINE_STAT_E1oIP_E1T_FIFO, frame_rifo_depth(&iline->e1t.rifo)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I175f0503e7435c362f35bd8083b785197d9d7338 Gerrit-Change-Number: 27827 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: OCTOI: Fix the extension of 16b FN from packet to full 32b FN

by tnt

tnt has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27826 ) Change subject: OCTOI: Fix the extension of 16b FN from packet to full 32b FN ...................................................................... OCTOI: Fix the extension of 16b FN from packet to full 32b FN Only frames withing a certain window are even accepted for processing the rest is dropped since it could corrupt our state. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I25b2e150d924aa8c714b766cb92e9e23e67cfa4c --- M src/octoi/e1oip.c 1 file changed, 19 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/26/27826/1 diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c index 27eb201..482b89c 100644 --- a/src/octoi/e1oip.c +++ b/src/octoi/e1oip.c @@ -165,10 +165,12 @@ /* An E1OIP_MSGT_TDM_DATA message was received from a remote IP peer */ int e1oip_rcvmsg_tdm_data(struct e1oip_line *iline, struct msgb *msg) { + const int WIN = 8000; struct octoi_peer *peer = iline->peer; const struct e1oip_tdm_hdr *e1th; uint16_t frame_nr; uint32_t fn32; + bool update_next; uint32_t ts_mask; uint8_t idx2ts[BYTES_PER_FRAME]; unsigned int n_frames; @@ -194,32 +196,25 @@ ts_mask = ntohl(e1th->ts_mask); if (frame_nr != exp_next_seq) { - int delta = frame_nr - exp_next_seq; - bool re_ordering; - if (delta > 0 && delta < 5 * iline->cfg.batching_factor) { - /* assume re-ordering */ - re_ordering = true; - } else { - /* assume packet loss */ - re_ordering = false; + uint16_t frame_nr_ofs; + + LOGPEER(peer, LOGL_NOTICE, "RxIP: frame_nr=%u, but expected %u\n", + frame_nr, exp_next_seq); + + frame_nr_ofs = frame_nr - (exp_next_seq - WIN); + if (frame_nr_ofs > (2 * WIN)) { + /* Outside window, throw packet away */ + LOGPEER(peer, LOGL_NOTICE, "RxIP: frame_nr=%u at exp_next_fn32=%u; " + "received frame outside +/- 1s window of expected frame\n", + frame_nr, iline->e1t.next_fn32); + return -EINVAL; } - LOGPEER(peer, LOGL_NOTICE, "RxIP: frame_nr=%u, but expected %u: delta=%d - assuming %s\n", - frame_nr, exp_next_seq, delta, re_ordering ? "re-ordering" : "packet loss"); - - fn32 = (iline->e1t.next_fn32 & 0xffff0000) + frame_nr; - if (fn32 > iline->e1t.next_fn32 + 8000) { - /* more than 1s in the future: was this a wrap-around? */ - fn32 = ((iline->e1t.next_fn32 & 0xffff0000) - 0x10000) + frame_nr; - if (fn32 < iline->e1t.next_fn32 - 8000) { - /* also no match: give up */ - LOGPEER(peer, LOGL_NOTICE, "RxIP: frame_nr=%u at exp_next_fn32=%u; " - "received frame outside +/- 1s window of expected frame\n", - frame_nr, iline->e1t.next_fn32); - } - } + fn32 = iline->e1t.next_fn32 + frame_nr_ofs - WIN; + update_next = frame_nr_ofs >= WIN; } else { fn32 = iline->e1t.next_fn32; + update_next = true; } /* compute E1oIP idx to timeslot table */ @@ -252,9 +247,8 @@ } /* update local state */ memcpy(iline->e1t.last_frame, frame_buf, BYTES_PER_FRAME); - /* FIXME: only in some cases */ - //if (fn32 >= iline->e1t.next_fn32I - iline->e1t.next_fn32 = fn32 + n_frames; + if (update_next) + iline->e1t.next_fn32 = fn32 + n_frames; iline_stat_set(iline, LINE_STAT_E1oIP_E1T_FIFO, frame_rifo_depth(&iline->e1t.rifo)); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I25b2e150d924aa8c714b766cb92e9e23e67cfa4c Gerrit-Change-Number: 27826 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc[2022q1]: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27792 ) Change subject: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE ...................................................................... smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE When responding to a CBSP KILL with a CBSP KILL COMPLETE, make sure we include the optional "Number of Broadcasts Completed List" IE in order to inform the CBC about how many times the just-killed message had been broadcast before it was killed. It seems some CBCs expect this IE to be present, while 3GPP TS 48.049 lists it as optional. Since we alrady have code to encode it, let's just always add it - it certainly won't hurt. Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Closes: SYS#5906 (cherry picked from commit 592c8ec29dd39806ea812be5d55ced3db13122bf) --- M src/osmo-bsc/smscb.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 232c0d7..5fe6345 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -651,6 +651,8 @@ if (!smscb) return -CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED; + append_bcast_compl(r_state, chan_state->bts, smscb); + /* Remove it */ bts_smscb_del(smscb, chan_state, "KILL"); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q1 Gerrit-Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Gerrit-Change-Number: 27792 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[2022q1]: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27792 ) Change subject: smscb: Populate "Number of Broadcasts Completed" to KILL COMPLETE ...................................................................... Patch Set 2: Code-Review+2 This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: 2022q1 Gerrit-Change-Id: I47aebd613dfc6dd9261ea9019a51aff0cd6470d8 Gerrit-Change-Number: 27792 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Apr 2022 10:03:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: amr_loop: do not miss C/I samples

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27778 ) Change subject: osmo-bts-trx: amr_loop: do not miss C/I samples ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ieb5473ead7200f652b5d0e339e4e252d6567482d Gerrit-Change-Number: 27778 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Apr 2022 09:10:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022