Attention is currently required from: laforge, lynxis lazus.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 )
Change subject: RFC: lint: annotate lines in gerrit
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/4984745d_651384f5
PS1, Line 13: The jenkins nodes needs to access the gerrit via ssh
> We could execute this script from the review job, save the json in the workspace and execute the upl […]
I don't think the complexity of the extra job is worth it (and to do it right, if we do allow untrusted input for the review json, it would be a good idea to do a sanity check on the json file too before passing it to the gerrit review command...).
Therefore I suggest to continue as follows:
* gerrit-lint.yml: replace " - shell: '{obj:cmd}'" with " - shell: '~/osmo-ci/lint/lint_diff.sh HEAD~1'", then remove the "cmd" variable in that file so it cannot be overridden
* create a gerrit user that has permission only to provide review
* configure jenkins to have permissions to that gerrit/ssh user
File lint/checkpatch/checkpatch_json.py:
https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/3cf12757_b0228386
PS1, Line 3: # from coreboot rev 9cae17d028d4bd3b278fc89ada8e06287917e213
I'd note the exact commit in the commit message, but not in the file. Otherwise we might update/change the file later on and forget to update the revision string here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49
Gerrit-Change-Number: 26393
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 25 Mar 2022 10:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-gbproxy failed to build in openSUSE_Leap_15.1_ARM/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-gbproxy
Last lines of build log:
[ 432s] checking whether to build static libraries... yes
[ 432s] checking for pkg-config... /usr/bin/pkg-config
[ 432s] checking for armv7hl-suse-linux-gnueabi-pkg-config... /usr/bin/armv7hl-suse-linux-gnueabi-pkg-config
[ 432s] checking pkg-config is at least version 0.20... yes
[ 434s] checking for library containing dlopen... -ldl
[ 436s] checking for library containing dlsym... -ldl
[ 436s] checking for libosmocore >= 1.6.0... no
[ 436s] configure: error: Package requirements (libosmocore >= 1.6.0) were not met:
[ 436s]
[ 436s] Package 'libsctp', required by 'libosmocore', not found
[ 436s]
[ 436s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 436s] installed software in a non-standard prefix.
[ 436s]
[ 436s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 436s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 436s] See the pkg-config man page for more details.
[ 437s] error: Bad exit status from /var/tmp/rpm-tmp.u7SgEL (%build)
[ 437s]
[ 437s]
[ 437s] RPM build errors:
[ 437s] Bad exit status from /var/tmp/rpm-tmp.u7SgEL (%build)
[ 437s] ### VM INTERACTION START ###
[ 437s] [ 381.681645] sysrq: SysRq : Power Off
[ 437s] [ 381.693336] reboot: Power down
[ 438s] ### VM INTERACTION END ###
[ 438s]
[ 438s] armbuild21 failed "build osmo-gbproxy.spec" at Fri Mar 25 10:53:42 UTC 2022.
[ 438s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/s…
Package network:osmocom:nightly/simtrace2 failed to build in openSUSE_Leap_15.1_ARM/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly simtrace2
Last lines of build log:
[ 41s] checking whether to build shared libraries... yes
[ 41s] checking whether to build static libraries... no
[ 41s] checking for pkg-config... /usr/bin/pkg-config
[ 41s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config
[ 41s] checking pkg-config is at least version 0.20... yes
[ 41s] checking if gcc supports -fvisibility=hidden... yes
[ 41s] checking for libosmocore >= 1.4.0... no
[ 41s] configure: error: Package requirements (libosmocore >= 1.4.0) were not met:
[ 41s]
[ 41s] Package 'libsctp', required by 'libosmocore', not found
[ 41s]
[ 41s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 41s] installed software in a non-standard prefix.
[ 41s]
[ 41s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 41s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 41s] See the pkg-config man page for more details.
[ 41s] error: Bad exit status from /var/tmp/rpm-tmp.25pbj5 (%build)
[ 41s]
[ 41s]
[ 41s] RPM build errors:
[ 41s] Bad exit status from /var/tmp/rpm-tmp.25pbj5 (%build)
[ 41s] ### VM INTERACTION START ###
[ 41s] [ 30.204999] sysrq: SysRq : Power Off
[ 41s] [ 30.206090] reboot: Power down
[ 41s] ### VM INTERACTION END ###
[ 41s]
[ 41s] obs-arm-11 failed "build simtrace2.spec" at Fri Mar 25 10:52:12 UTC 2022.
[ 41s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-pcap failed to build in openSUSE_Leap_15.1_ARM/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-pcap
Last lines of build log:
[ 61s] checking how to run the C preprocessor... gcc -E
[ 61s] checking for grep that handles long lines and -e... /usr/bin/grep
[ 61s] checking for egrep... /usr/bin/grep -E
[ 61s] checking for ANSI C header files... yes
[ 61s] checking whether to enable VTY tests... no
[ 61s] checking for pcap-config... /usr/bin/pcap-config
[ 61s] checking for libosmocore >= 1.6.0... no
[ 61s] configure: error: Package requirements (libosmocore >= 1.6.0) were not met:
[ 61s]
[ 61s] Package 'libsctp', required by 'libosmocore', not found
[ 61s]
[ 61s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 61s] installed software in a non-standard prefix.
[ 61s]
[ 61s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 61s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 61s] See the pkg-config man page for more details.
[ 61s] error: Bad exit status from /var/tmp/rpm-tmp.UmzcEH (%build)
[ 61s]
[ 61s]
[ 61s] RPM build errors:
[ 61s] Bad exit status from /var/tmp/rpm-tmp.UmzcEH (%build)
[ 61s] ### VM INTERACTION START ###
[ 61s] [ 51.307241] sysrq: SysRq : Power Off
[ 61s] [ 51.309291] reboot: Power down
[ 61s] ### VM INTERACTION END ###
[ 61s]
[ 62s] obs-arm-9 failed "build osmo-pcap.spec" at Fri Mar 25 10:46:46 UTC 2022.
[ 62s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l…
Package network:osmocom:nightly/libosmo-netif failed to build in openSUSE_Leap_15.1_ARM/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly libosmo-netif
Last lines of build log:
[ 108s] checking syslog.h presence... yes
[ 108s] checking for syslog.h... yes
[ 109s] checking ctype.h usability... yes
[ 109s] checking ctype.h presence... yes
[ 109s] checking for ctype.h... yes
[ 109s] checking if gcc supports -fvisibility=hidden... yes
[ 109s] checking for libosmocore >= 1.5.0... no
[ 109s] configure: error: Package requirements (libosmocore >= 1.5.0) were not met:
[ 109s]
[ 109s] Package 'libsctp', required by 'libosmocore', not found
[ 109s]
[ 109s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 109s] installed software in a non-standard prefix.
[ 109s]
[ 109s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 109s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 109s] See the pkg-config man page for more details.
[ 109s] error: Bad exit status from /var/tmp/rpm-tmp.GbAR7X (%build)
[ 109s]
[ 109s]
[ 109s] RPM build errors:
[ 109s] Bad exit status from /var/tmp/rpm-tmp.GbAR7X (%build)
[ 109s] ### VM INTERACTION START ###
[ 109s] [ 91.351206] sysrq: SysRq : Power Off
[ 109s] [ 91.385446] reboot: Power down
[ 109s] ### VM INTERACTION END ###
[ 109s]
[ 110s] obs-arm-5 failed "build libosmo-netif.spec" at Fri Mar 25 10:43:53 UTC 2022.
[ 110s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-gbproxy failed to build in openSUSE_Leap_15.1_ARM/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-gbproxy
Last lines of build log:
[ 132s] checking whether to build static libraries... yes
[ 132s] checking for pkg-config... /usr/bin/pkg-config
[ 132s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config
[ 132s] checking pkg-config is at least version 0.20... yes
[ 133s] checking for library containing dlopen... -ldl
[ 133s] checking for library containing dlsym... -ldl
[ 133s] checking for libosmocore >= 1.6.0... no
[ 133s] configure: error: Package requirements (libosmocore >= 1.6.0) were not met:
[ 133s]
[ 133s] Package 'libsctp', required by 'libosmocore', not found
[ 133s]
[ 133s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 133s] installed software in a non-standard prefix.
[ 133s]
[ 133s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 133s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 133s] See the pkg-config man page for more details.
[ 133s] error: Bad exit status from /var/tmp/rpm-tmp.Gj3zHH (%build)
[ 133s]
[ 133s]
[ 133s] RPM build errors:
[ 133s] Bad exit status from /var/tmp/rpm-tmp.Gj3zHH (%build)
[ 133s] ### VM INTERACTION START ###
[ 134s] [ 111.479663] sysrq: SysRq : Power Off
[ 134s] [ 111.494606] reboot: Power down
[ 134s] ### VM INTERACTION END ###
[ 134s]
[ 134s] obs-arm-3 failed "build osmo-gbproxy.spec" at Fri Mar 25 10:43:43 UTC 2022.
[ 134s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o…
Package network:osmocom:nightly/osmo-pcu failed to build in openSUSE_Leap_15.1_ARM/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-pcu
Last lines of build log:
[ 76s] checking dynamic linker characteristics... (cached) GNU/Linux ld.so
[ 76s] checking how to hardcode library paths into programs... immediate
[ 76s] checking for pkg-config... /usr/bin/pkg-config
[ 76s] checking for aarch64-suse-linux-gnu-pkg-config... /usr/bin/aarch64-suse-linux-gnu-pkg-config
[ 76s] checking pkg-config is at least version 0.20... yes
[ 76s] checking for ANSI C header files... (cached) yes
[ 76s] checking for libosmocore >= 1.6.0... no
[ 76s] configure: error: Package requirements (libosmocore >= 1.6.0) were not met:
[ 76s]
[ 76s] Package 'libsctp', required by 'libosmocore', not found
[ 76s]
[ 76s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 76s] installed software in a non-standard prefix.
[ 76s]
[ 76s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 76s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 76s] See the pkg-config man page for more details.
[ 76s] error: Bad exit status from /var/tmp/rpm-tmp.AjMEx1 (%build)
[ 76s]
[ 76s]
[ 76s] RPM build errors:
[ 76s] Bad exit status from /var/tmp/rpm-tmp.AjMEx1 (%build)
[ 77s] ### VM INTERACTION START ###
[ 77s] [ 67.963389] sysrq: SysRq : Power Off
[ 77s] [ 67.965321] reboot: Power down
[ 77s] ### VM INTERACTION END ###
[ 77s]
[ 77s] obs-arm-9 failed "build osmo-pcu.spec" at Fri Mar 25 10:35:05 UTC 2022.
[ 77s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/l…
Package network:osmocom:nightly/libosmo-netif failed to build in openSUSE_Leap_15.1_ARM/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmo-netif
Last lines of build log:
[ 139s] checking syslog.h presence... yes
[ 139s] checking for syslog.h... yes
[ 140s] checking ctype.h usability... yes
[ 140s] checking ctype.h presence... yes
[ 140s] checking for ctype.h... yes
[ 140s] checking if gcc supports -fvisibility=hidden... yes
[ 140s] checking for libosmocore >= 1.5.0... no
[ 140s] configure: error: Package requirements (libosmocore >= 1.5.0) were not met:
[ 140s]
[ 140s] Package 'libsctp', required by 'libosmocore', not found
[ 140s]
[ 140s] Consider adjusting the PKG_CONFIG_PATH environment variable if you
[ 140s] installed software in a non-standard prefix.
[ 140s]
[ 140s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS
[ 140s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config.
[ 140s] See the pkg-config man page for more details.
[ 140s] error: Bad exit status from /var/tmp/rpm-tmp.y7kZ61 (%build)
[ 140s]
[ 140s]
[ 140s] RPM build errors:
[ 140s] Bad exit status from /var/tmp/rpm-tmp.y7kZ61 (%build)
[ 140s] ### VM INTERACTION START ###
[ 140s] [ 117.215131] sysrq: SysRq : Power Off
[ 140s] [ 117.220279] reboot: Power down
[ 141s] ### VM INTERACTION END ###
[ 141s]
[ 141s] obs-arm-3 failed "build libosmo-netif.spec" at Fri Mar 25 10:32:22 UTC 2022.
[ 141s]
--
Configure notifications at https://build.opensuse.org/my/subscriptions
openSUSE Build Service (https://build.opensuse.org/)
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569 )
Change subject: hlr: add imsi unknown cause test case
......................................................................
Patch Set 1:
(1 comment)
File hlr/HLR_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/0f5af3f4_6618…
PS1, Line 987: TC_gsup_ul_unknown_imsi_roaming_not_allowed
Please add it to the 'control' section below and update the expected-results.xml. Thanks!
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a
Gerrit-Change-Number: 27569
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 25 Mar 2022 10:31:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27572 )
Change subject: libosmocore.spec: Make libosmocore-devel require libsctp
......................................................................
libosmocore.spec: Make libosmocore-devel require libsctp
Now that the libosmo*.pc files 'Require' the libsctp pkg-config
file to be installed, we need an explicit package dependency
from libosmocore-devel to lksctp-tools-devel, the package providing
the related libsctp.pc file.
Change-Id: I967369f6726e88946872881d298ab90440ca2c0e
---
M contrib/libosmocore.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/27572/1
diff --git a/contrib/libosmocore.spec.in b/contrib/libosmocore.spec.in
index c2fe738..d699b58 100644
--- a/contrib/libosmocore.spec.in
+++ b/contrib/libosmocore.spec.in
@@ -129,6 +129,7 @@
Group: Development/Libraries/C and C++
Requires: libosmocore18 = %version
Requires: libtalloc-devel
+Requires: lksctp-tools-devel
%description -n libosmocore-devel
libosmocore is a library with various utility functions shared
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27572
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I967369f6726e88946872881d298ab90440ca2c0e
Gerrit-Change-Number: 27572
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange