March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs)

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27362 ) Change subject: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c Gerrit-Change-Number: 27362 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:45:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27364 ) Change subject: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1c96305839e6627a36655c2e64da64f0a6704896 Gerrit-Change-Number: 27364 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs)

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27362 ) Change subject: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c Gerrit-Change-Number: 27362 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 16:42:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: ipa oml: Fix encoding of T3105

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 to look at the new patch set (#3). Change subject: ipa oml: Fix encoding of T3105 ...................................................................... ipa oml: Fix encoding of T3105 As the comment above the fix suggest, the encoding is in 10ms units. osmo-bts is also doing the proper: """ uint8_t t3105 = *TLVP_VAL(&tp, NM_ATT_BTS_AIR_TIMER); bts->t3105_ms = t3105 * 10; """ Related: SYS#5838 Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/27363/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 Gerrit-Change-Number: 27363 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27364 ) Change subject: tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper ...................................................................... tests: nanobts_omlattr_test: Use msgb_eq_data_print() helper Change-Id: I1c96305839e6627a36655c2e64da64f0a6704896 --- M tests/nanobts_omlattr/nanobts_omlattr_test.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/64/27364/1 diff --git a/tests/nanobts_omlattr/nanobts_omlattr_test.c b/tests/nanobts_omlattr/nanobts_omlattr_test.c index 1b3cc8e..e15d20e 100644 --- a/tests/nanobts_omlattr/nanobts_omlattr_test.c +++ b/tests/nanobts_omlattr/nanobts_omlattr_test.c @@ -43,7 +43,7 @@ msgb = nanobts_attr_bts_get(bts); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -59,7 +59,7 @@ msgb = nanobts_attr_nse_get(bts->site_mgr); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -75,7 +75,7 @@ msgb = nanobts_attr_cell_get(bts); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -91,7 +91,7 @@ msgb = nanobts_attr_nsvc_get(bts); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); @@ -109,7 +109,7 @@ msgb = nanobts_attr_radio_get(bts, trx); printf("result= %s\n", osmo_hexdump_nospc(msgb->data, msgb->len)); printf("expected=%s\n", osmo_hexdump_nospc(expected, msgb->len)); - OSMO_ASSERT(memcmp(msgb->data, expected, msgb->len) == 0); + OSMO_ASSERT(msgb_eq_data_print(msgb, expected, msgb->len)); msgb_free(msgb); printf("ok.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1c96305839e6627a36655c2e64da64f0a6704896 Gerrit-Change-Number: 27364 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: ipa oml: Fix encoding of T3105

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 to look at the new patch set (#2). Change subject: ipa oml: Fix encoding of T3105 ...................................................................... ipa oml: Fix encoding of T3105 As the comment above the fix suggest, the encoding is in 10ms units. osmo-bts is also doing the proper: """ uint8_t t3105 = *TLVP_VAL(&tp, NM_ATT_BTS_AIR_TIMER); bts->t3105_ms = t3105 * 10; """ Related: SYS#5838 Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M tests/nanobts_omlattr/nanobts_omlattr_test.c M tests/nanobts_omlattr/nanobts_omlattr_test.ok 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/27363/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 Gerrit-Change-Number: 27363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: ipa oml: Fix encoding of T3105

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27363 ) Change subject: ipa oml: Fix encoding of T3105 ...................................................................... ipa oml: Fix encoding of T3105 As the comment above the fix suggest, the encoding is in 10ms units. osmo-bts is also doing the proper: """ uint8_t t3105 = *TLVP_VAL(&tp, NM_ATT_BTS_AIR_TIMER); bts->t3105_ms = t3105 * 10; """ Related: SYS#5838 Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 --- M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/63/27363/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index aac0ddf..d5b4215 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -85,7 +85,7 @@ msgb_tv_fixed_put(msgb, NM_ATT_LDAVG_SLOTS, 2, buf); /* 10 milliseconds */ - msgb_tv_put(msgb, NM_ATT_BTS_AIR_TIMER, osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1)); + msgb_tv_put(msgb, NM_ATT_BTS_AIR_TIMER, osmo_tdef_get(bts->network->T_defs, 3105, OSMO_TDEF_MS, -1)/10); /* 10 retransmissions of physical config */ msgb_tv_put(msgb, NM_ATT_NY1, 10); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie190514ee35d1ca81b70e9180bf7393b973d3504 Gerrit-Change-Number: 27363 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27362 ) Change subject: doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) ...................................................................... doc: bsc.adoc: Update timer info from code (gsm_network_T_defs) Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c --- M doc/manuals/chapters/bsc.adoc 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/27362/1 diff --git a/doc/manuals/chapters/bsc.adoc b/doc/manuals/chapters/bsc.adoc index 38f267c..bdc3d2b 100644 --- a/doc/manuals/chapters/bsc.adoc +++ b/doc/manuals/chapters/bsc.adoc @@ -63,18 +63,18 @@ .Configurable Timers |=== |node|timer|default|description -|network|t3101|10|Timeout for 'Immediate Assignment' (sec) -|network|t3103|?|Timeout for Handover (sec) -|network|t3105|40|Repetition of 'Physical Information' (sec) -|network|t3107|?|? -|network|t3109|?|RSL SACCH deactivation timeout (sec) -|network|t3111|?|RSL timeout to wait before releasing the RF channel (sec) -|network|t3113|60|Time to try paging for a subscriber (sec) -|network|t3115|?|? -|network|t3117|?|? -|network|t3119|?|? +|network|t3101|3|Timeout for 'Immediate Assignment' (sec) +|network|t3103|5|Timeout for Handover (sec) +|network|t3105|100|Repetition of 'Physical Information' (millisec) +|network|t3107|5|? +|network|t3109|5|RSL SACCH deactivation timeout (sec) +|network|t3111|2|RSL timeout to wait before releasing the RF channel (sec) +|network|t3113|7|Time to try paging for a subscriber (sec) +|network|t3115|10|? +|network|t3117|10|? +|network|t3119|10|? |network|t3122|10|Waiting time after 'Immediate Assignment Reject' -|network|t3141|?|? +|network|t3141|10|? |=== //TODO: split between BSC and MSC timers -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27362 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1652e6d53f568f606b692b16d4198d5209df2d9c Gerrit-Change-Number: 27362 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... osmo-ggsn: update libgtp-queue_depth_32.patch Adjust to change in osmo-ggsn I6034b0fab2b2e5962314c2fca2f893246ce5cf4f ("libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)"). Set it to 128, as Pau suggested. Fix for: Applying patch libgtp-queue_depth_32.patch patching file gtp/queue.h Hunk #1 FAILED at 19. Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 --- A recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch D recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 3 files changed, 36 insertions(+), 15 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Verified diff --git a/recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch b/recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch new file mode 100644 index 0000000..53ac7ef --- /dev/null +++ b/recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch @@ -0,0 +1,34 @@ +From 2e0112520892b8f6a794c16bf3d025a7d10a89a5 Mon Sep 17 00:00:00 2001 +From: Oliver Smith <osmith(a)sysmocom.de> +Date: Wed, 2 Mar 2022 11:24:31 +0100 +Subject: [PATCH] libgtp: set PDP_MAX to 128 + +Reduce PDP_MAX and therefore QUEUE_SIZE (which is PDP_MAX * 2, see +gtp/queue.h). Harald explained why: + + libgtp statically allocates immensely large queues for packet + re-transmissions by default, way too much to run OsmoSGSN or + OpenGGSN/OsmoGGSN on the small ARM926EJS of sysmoBTS 1002. + +Related: https://gerrit.osmocom.org/c/meta-telephony/+/4092/2#message-8ec2174fac6c0b… +Change-Id: I97d5db8f2def4d628a6c4e67c27f07c7200b94d4 +--- + gtp/pdp.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/gtp/pdp.h b/gtp/pdp.h +index 4dcdde46..9587f31e 100644 +--- a/gtp/pdp.h ++++ b/gtp/pdp.h +@@ -24,7 +24,7 @@ struct gsn_t; + #define LOGPDPX(ss, level, pdp, fmt, args...) \ + LOGP(ss, level, "PDP(%s:%u): " fmt, imsi_gtp2str(&(pdp)->imsi), (pdp)->nsapi, ## args) + +-#define PDP_MAX 1024 /* Max number of PDP contexts */ ++#define PDP_MAX 128 /* Max number of PDP contexts */ + #define PDP_MAXNSAPI 16 /* Max number of NSAPI */ + + #define PDP_EUA_ORG_IETF 0xF1 +-- +2.30.2 + diff --git a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch b/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch deleted file mode 100644 index 52bc37b..0000000 --- a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch +++ /dev/null @@ -1,13 +0,0 @@ -diff --git a/gtp/queue.h b/gtp/queue.h -index 556b6ef..d59a1a3 100644 ---- a/gtp/queue.h -+++ b/gtp/queue.h -@@ -19,7 +19,7 @@ - - #define QUEUE_DEBUG 0 /* Print debug information */ - --#define QUEUE_SIZE 1024 /* Size of retransmission queue */ -+#define QUEUE_SIZE 32 /* Size of retransmission queue */ - #define QUEUE_HASH_SIZE 65536 /* Size of hash table (2^16) */ - - struct qmsg_t { /* Holder for queued packets */ diff --git a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb index 28424e8..e45f7d1 100644 --- a/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb +++ b/recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb @@ -3,7 +3,7 @@ S = "${WORKDIR}/git" SRCREV = "${AUTOREV}" SRC_URI = "git://git.osmocom.org/osmo-ggsn \ - file://libgtp-queue_depth_32.patch \ + file://0001-libgtp-set-PDP_MAX-to-128.patch \ " PV = "1.8.0+gitr${SRCPV}" -PR = "${INC_PR}.0" +PR = "${INC_PR}.1" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 15:43:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 15:09:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: pespin, keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) File recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb: https://gerrit.osmocom.org/c/meta-telephony/+/27358/comment/14bd790e_b70670… PS2, Line 9: PR = "${INC_PR}.0" > I don't see you are touching INC_PR either: […] Ack -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 14:08:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: osmith, keith. Hello pespin, keith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 to look at the new patch set (#3). Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... osmo-ggsn: update libgtp-queue_depth_32.patch Adjust to change in osmo-ggsn I6034b0fab2b2e5962314c2fca2f893246ce5cf4f ("libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)"). Set it to 128, as Pau suggested. Fix for: Applying patch libgtp-queue_depth_32.patch patching file gtp/queue.h Hunk #1 FAILED at 19. Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 --- A recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch D recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 3 files changed, 36 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/58/27358/3 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

Change in osmo-bts[master]: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27360 ) Change subject: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late ...................................................................... bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late If len is < 0, it means osmo_amr_rtp_dec() failed and some of the out variables there are not set. We should check the return code before continuing and using potentially uninitialized values. Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 08a58bb..b100fab 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -441,6 +441,10 @@ len = osmo_amr_rtp_dec(msg_tch->l2h, msgb_l2len(msg_tch), &cmr_codec, &cmi, &ft_codec, &bfi, &sti); + if (len < 0) { + LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send invalid AMR payload\n"); + goto free_bad_msg; + } cmr = -1; ft = -1; for (i = 0; i < chan_state->codecs; i++) { @@ -478,10 +482,6 @@ LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "TCH mode invalid, please fix!\n"); goto free_bad_msg; } - if (len < 0) { - LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send invalid AMR payload\n"); - goto free_bad_msg; - } if (msgb_l2len(msg_tch) != len) { LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send payload with " "invalid length! (expecting %d, received %d)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 Gerrit-Change-Number: 27360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in osmo-bts[master]: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27360 ) Change subject: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 Gerrit-Change-Number: 27360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 13:32:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bts[master]: bts-trx: Fix dropping of DL AMR SID frames

by pespin

Attention is currently required from: neels, laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27361 ) Change subject: bts-trx: Fix dropping of DL AMR SID frames ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This is still not tested, I'll mark it as WIP while I try to write a ttcn3 test for it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icb6f72c091bb7855dba5a2d6bb1eba838bf6ec92 Gerrit-Change-Number: 27361 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 13:17:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bts[master]: bts-trx: Fix dropping of DL AMR SID frames

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27361 ) Change subject: bts-trx: Fix dropping of DL AMR SID frames ...................................................................... bts-trx: Fix dropping of DL AMR SID frames Received DL RTP packets from the MGW containing AMR SID frames (FT=8) were being checked to be in the active AMR codec mode subset, and subsequently failing because the SID frames can always be expected there and are not part of any active mode subset. As a result, they were being dropped: "(bts=0,trx=0,ts=4) TCH/F: Codec (FT = 8) of RTP frame not in list". Related: SYS#5838 Change-Id: Icb6f72c091bb7855dba5a2d6bb1eba838bf6ec92 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 22 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/27361/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index b100fab..6b745f3 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -446,12 +446,11 @@ goto free_bad_msg; } cmr = -1; - ft = -1; for (i = 0; i < chan_state->codecs; i++) { - if (chan_state->codec[i] == cmr_codec) + if (chan_state->codec[i] == cmr_codec) { cmr = i; - if (chan_state->codec[i] == ft_codec) - ft = i; + break; + } } if (cmr >= 0) { /* new request */ chan_state->dl_cmr = cmr; @@ -461,17 +460,26 @@ /* enable AMR loop */ trx_loop_amr_set(chan_state, 1); } - if (ft < 0) { - LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, - "Codec (FT = %d) of RTP frame not in list\n", ft_codec); - goto free_bad_msg; + if (ft_codec < AMR_SID) { + ft = -1; + for (i = 0; i < chan_state->codecs; i++) { + if (chan_state->codec[i] == ft_codec) { + ft = i; + break; + } + } + if (ft < 0) { + LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, + "Codec (FT = %d) of RTP frame not in list\n", ft_codec); + goto free_bad_msg; + } + if (amr_is_cmr && chan_state->dl_ft != ft) { + LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Codec (FT = %d) " + " of RTP cannot be changed now, but in next frame\n", ft_codec); + goto free_bad_msg; + } + chan_state->dl_ft = ft; } - if (amr_is_cmr && chan_state->dl_ft != ft) { - LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Codec (FT = %d) " - " of RTP cannot be changed now, but in next frame\n", ft_codec); - goto free_bad_msg; - } - chan_state->dl_ft = ft; if (bfi == AMR_BAD) { LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Transmitting 'bad AMR frame'\n"); goto free_bad_msg; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icb6f72c091bb7855dba5a2d6bb1eba838bf6ec92 Gerrit-Change-Number: 27361 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) File recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb: https://gerrit.osmocom.org/c/meta-telephony/+/27358/comment/b77bd9d6_3379b3… PS2, Line 9: PR = "${INC_PR}.0" > it will increase automatically by INC_PR I don't see you are touching INC_PR either: recipes-osmocom/osmo-ggsn/osmo-ggsn.inc 8:INC_PR="r2.${META_TELEPHONY_OSMO_INC}" In any case, the increase should be done in here (PR) since the change is in this file. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 13:13:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bts[master]: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late

by osmith

Attention is currently required from: neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27360 ) Change subject: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 Gerrit-Change-Number: 27360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 13:12:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: pespin, keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) File recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb: https://gerrit.osmocom.org/c/meta-telephony/+/27358/comment/60cea4c8_aa925b… PS2, Line 9: PR = "${INC_PR}.0" > I think you need to increase PR here to . […] it will increase automatically by INC_PR -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 13:06:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) File recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb: https://gerrit.osmocom.org/c/meta-telephony/+/27358/comment/ea941fdd_08da42… PS2, Line 9: PR = "${INC_PR}.0" I think you need to increase PR here to .1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 12:58:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bts[master]: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27360 ) Change subject: bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late ...................................................................... bts-trx: amr: Fix return code of osmo_amr_rtp_dec() checked too late If len is < 0, it means osmo_amr_rtp_dec() failed and some of the out variables there are not set. We should check the return code before continuing and using potentially uninitialized values. Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/60/27360/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 08a58bb..b100fab 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -441,6 +441,10 @@ len = osmo_amr_rtp_dec(msg_tch->l2h, msgb_l2len(msg_tch), &cmr_codec, &cmi, &ft_codec, &bfi, &sti); + if (len < 0) { + LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send invalid AMR payload\n"); + goto free_bad_msg; + } cmr = -1; ft = -1; for (i = 0; i < chan_state->codecs; i++) { @@ -478,10 +482,6 @@ LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "TCH mode invalid, please fix!\n"); goto free_bad_msg; } - if (len < 0) { - LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send invalid AMR payload\n"); - goto free_bad_msg; - } if (msgb_l2len(msg_tch) != len) { LOGL1SB(DL1P, LOGL_ERROR, l1ts, br, "Cannot send payload with " "invalid length! (expecting %d, received %d)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I76020c6b5dc8d3e52e8c5be8cdecdf8a0bb52ed9 Gerrit-Change-Number: 27360 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Thanks, I forgot to prepare and submit this patch. However, I'd go for PDP_MAX=128. […] Changed to PDP_MAX=128. I prefer to not spend more time on this, so I'd rather just set one value for all devices now and have the build fixed. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 12:53:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: update libgtp-queue_depth_32.patch

by osmith

Attention is currently required from: osmith. Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 to look at the new patch set (#2). Change subject: osmo-ggsn: update libgtp-queue_depth_32.patch ...................................................................... osmo-ggsn: update libgtp-queue_depth_32.patch Adjust to change in osmo-ggsn I6034b0fab2b2e5962314c2fca2f893246ce5cf4f ("libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)"). Set it to 128, as Pau suggested. Fix for: Applying patch libgtp-queue_depth_32.patch patching file gtp/queue.h Hunk #1 FAILED at 19. Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 --- A recipes-osmocom/osmo-ggsn/files/0001-libgtp-set-PDP_MAX-to-128.patch D recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch M recipes-osmocom/osmo-ggsn/osmo-ggsn_git.bb 3 files changed, 35 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/58/27358/2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch_osmo.sh: exclude .patch files

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27359 ) Change subject: lint: checkpatch_osmo.sh: exclude .patch files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I734452bc78d7e026292883f81bc07c3baf58e309 Gerrit-Change-Number: 27359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:37:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: rebase libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: rebase libgtp-queue_depth_32.patch ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:37:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: rebase libgtp-queue_depth_32.patch

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: rebase libgtp-queue_depth_32.patch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks, I forgot to prepare and submit this patch. However, I'd go for PDP_MAX=128. See my first comment in https://gerrit.osmocom.org/c/osmo-ggsn/+/27352 it explains the calculations/assumptions there. I'm happy to discuss it further if needed. We could even have a separate patch (applied per machine, can be done in OE) which applies PDP_MAX 7*7 for sysmobts (which has 1 TRX, but iirc there was a sysmobts with 2 TRX?) -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:37:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 02 Mar 2022 11:29:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch_osmo.sh: exclude .patch files

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27359 ) Change subject: lint: checkpatch_osmo.sh: exclude .patch files ...................................................................... lint: checkpatch_osmo.sh: exclude .patch files Change-Id: I734452bc78d7e026292883f81bc07c3baf58e309 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/59/27359/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index faf0fca..084a7ea 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -8,6 +8,8 @@ echo '--exclude \.(ok|err)$' # Generated from commit log, which may contain spelling errors (OS#5232) echo '--exclude ^debian/changelog$' + # Patch files + echo '--exclude \.patch$' } exclude_paths_common_asn1c() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27359 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I734452bc78d7e026292883f81bc07c3baf58e309 Gerrit-Change-Number: 27359 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in meta-telephony[laforge/nightly]: osmo-ggsn: rebase libgtp-queue_depth_32.patch

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/meta-telephony/+/27358 ) Change subject: osmo-ggsn: rebase libgtp-queue_depth_32.patch ...................................................................... osmo-ggsn: rebase libgtp-queue_depth_32.patch Adjust to change in osmo-ggsn I6034b0fab2b2e5962314c2fca2f893246ce5cf4f ("libgtp: Define retransmit QUEUE_SIZE relative to PDP_MAX (increase)"). Fix for: Applying patch libgtp-queue_depth_32.patch patching file gtp/queue.h Hunk #1 FAILED at 19. Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 --- M recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch 1 file changed, 32 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/58/27358/1 diff --git a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch b/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch index 52bc37b..99e5dd5 100644 --- a/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch +++ b/recipes-osmocom/osmo-ggsn/files/libgtp-queue_depth_32.patch @@ -1,13 +1,34 @@ -diff --git a/gtp/queue.h b/gtp/queue.h -index 556b6ef..d59a1a3 100644 ---- a/gtp/queue.h -+++ b/gtp/queue.h -@@ -19,7 +19,7 @@ +From 295d85927658a734cf544e03abd28ec33c5bfb2c Mon Sep 17 00:00:00 2001 +From: Oliver Smith <osmith(a)sysmocom.de> +Date: Wed, 2 Mar 2022 11:24:31 +0100 +Subject: [PATCH] libgtp: reduce queue depth to 32 + +Set PDP_MAX to 16 and QUEUE_SIZE to 32 (QUEUE_SIZE is PDP_MAX * 2, see +gtp/queue.h). Harald explained why: + + libgtp statically allocates immensely large queues for packet + re-transmissions by default, way too much to run OsmoSGSN or + OpenGGSN/OsmoGGSN on the small ARM926EJS of sysmoBTS 1002. + +Related: https://gerrit.osmocom.org/c/meta-telephony/+/4092/2#message-8ec2174fac6c0b… +Change-Id: I97d5db8f2def4d628a6c4e67c27f07c7200b94d4 +--- + gtp/pdp.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/gtp/pdp.h b/gtp/pdp.h +index 4dcdde46..5db08af3 100644 +--- a/gtp/pdp.h ++++ b/gtp/pdp.h +@@ -24,7 +24,7 @@ struct gsn_t; + #define LOGPDPX(ss, level, pdp, fmt, args...) \ + LOGP(ss, level, "PDP(%s:%u): " fmt, imsi_gtp2str(&(pdp)->imsi), (pdp)->nsapi, ## args) - #define QUEUE_DEBUG 0 /* Print debug information */ +-#define PDP_MAX 1024 /* Max number of PDP contexts */ ++#define PDP_MAX 16 /* Max number of PDP contexts */ + #define PDP_MAXNSAPI 16 /* Max number of NSAPI */ --#define QUEUE_SIZE 1024 /* Size of retransmission queue */ -+#define QUEUE_SIZE 32 /* Size of retransmission queue */ - #define QUEUE_HASH_SIZE 65536 /* Size of hash table (2^16) */ - - struct qmsg_t { /* Holder for queued packets */ + #define PDP_EUA_ORG_IETF 0xF1 +-- +2.30.2 + -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/27358 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: laforge/nightly Gerrit-Change-Id: Ib8803fba7d1308042d12186009344b2a61abb6e3 Gerrit-Change-Number: 27358 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: New stats for lchan life duration.

by iedemam

Attention is currently required from: laforge. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: New stats for lchan life duration. ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: > I'd be happy to see this patch moving ahead, but with the unit tests failing, that's of course not a […] Thanks for the confidence boost. I have two other things on my plate at the moment but will be back to this as soon as I can. It really would be a huge feature for us. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 12 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 10:15:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > What? It's there. Next line after the 'Change-Id'. my bad, sorry. I would usually have expected it above the Change-Id and hence my brain stopped parsing at that line :( File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/d3a17f61_83061227 PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124) : pgsm = true; > This is also an option, yes. […] I think it's confusing that we have a variable whether or not we are in the PGSM case, but it is true even in a non-PGSM case. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): determine empty set by checking the ARFCN count

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27357 ) Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN count ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > IMHO, this is what holger would have called "sideways development". […] I find it cleaner to relay on the counter ('arfcns' in this case) to check if the set is empty, rather than checking one of the resulting values ('max'). There is no advantage of this method, it just makes the code easier to read. But in general, I don't care. This patch can be abandoned. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Gerrit-Change-Number: 27357 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:27:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: > also, missing Related: SYS#.... What? It's there. Next line after the 'Change-Id'. File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/9c82b989_d970bae6 PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124) : pgsm = true; > isn't this the true bug? PGSM is primary GSM, and not E-GSM 900. […] This is also an option, yes. Currently we assume that all ARFCNs are in P-GSM, and fall-back to other encodings if we find an out-of-range (i.e. E-GSM) value. https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/34f9fd24_f1d4a737 PS1, Line 522: / > how are we attempting to use a different format here? we return an error. I am adding an 'if' statement right after the 'for' loop (see line 532), which checks rc. If it's 0, then we return 0. If not, then we fall-back to other encoding formats. I can change it to do 'goto foo_bar' instead of setting rc to -ERANGE. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: also, missing Related: SYS#.... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:14:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): determine empty set by checking the ARFCN count

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27357 ) Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN count ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: IMHO, this is what holger would have called "sideways development". It changes something without improving it ("moving forward"). If there's a clear advantage of your method, please explain it in the changelog. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Gerrit-Change-Number: 27357 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:14:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: this is the kind of issue where a clear-cut unit test showing the bug should be introduced first, and then the bug should be fixed in a follow-up commit, demonstrating that the unit test now passes. I don't see immediately how his commit fixes anything - all it does is to return error values to the caller and log something, but it's not immediately obvious how an alternative encoding is chosen. File src/osmo-bsc/system_information.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/14e3e6ae_1cdc5154 PS1, Line 508: && bts->c0->arfcn >= 1 && bts->c0->arfcn <= 124) : pgsm = true; isn't this the true bug? PGSM is primary GSM, and not E-GSM 900. So the pgsm flag should never be set in a situation where E-GSM channels are used. Maybe we should not just check for c0->arfcn but iterate over all channels and set pgsm only true if all of them are within the P-GSM range? https://gerrit.osmocom.org/c/osmo-bsc/+/27356/comment/a9653cb1_024d2227 PS1, Line 522: / how are we attempting to use a different format here? we return an error. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Mar 2022 09:13:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): fix handling of E-GSM ARFCNs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27356 ) Change subject: bitvec2freq_list(): fix handling of E-GSM ARFCNs ...................................................................... bitvec2freq_list(): fix handling of E-GSM ARFCNs According to 3GPP TS 44.018, section 10.5.2.1b.2, only ARFCN values in range 1..124 can be encoded using the 'bit map 0' format. Before this patch, ARFCN values belonging to E-GSM band (0, 975..1023) were ignored in bitvec2freq_list(), and thus not present in the resulting Cell Channel Description IE. Let's fix this by falling back to other encoding formats. Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Related: SYS#5854 --- M src/osmo-bsc/system_information.c 1 file changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/56/27356/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 974af3a..885bdd3 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -512,14 +512,25 @@ chan_list[0] = 0; for (i = 0; i < bv->data_len*8; i++) { - if (i >= 1 && i <= 124 - && bitvec_get_bit_pos(bv, i)) { - rc = freq_list_bm0_set_arfcn(chan_list, i); - if (rc < 0) - return rc; + if (!bitvec_get_bit_pos(bv, i)) + continue; + /* According to 3GPP TS 44.018, section 10.5.2.1b.2, only the + * ARFCN values in range 1..124 can be encoded using this format. */ + if (i == 0 || i > 124) { + LOGP(DRR, LOGL_DEBUG, "ARFCN %d exceeds the range 1..124, " + "so we cannot use the 'bit map 0' format\n", i); + /* Attempt to use a different encoding format */ + memset(chan_list, 0, 16); + rc = -ERANGE; + break; } + rc = freq_list_bm0_set_arfcn(chan_list, i); + if (rc < 0) + return rc; } - return 0; + + if (rc == 0) + return 0; } for (i = 0; i < bv->data_len*8; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I17739e6845cd84e2a81bc406dd532541f7c52cb6 Gerrit-Change-Number: 27356 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: bitvec2freq_list(): determine empty set by checking the ARFCN count

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27357 ) Change subject: bitvec2freq_list(): determine empty set by checking the ARFCN count ...................................................................... bitvec2freq_list(): determine empty set by checking the ARFCN count Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Related: SYS#5854 --- M src/osmo-bsc/system_information.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/57/27357/1 diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index 885bdd3..b5198dd 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -564,7 +564,7 @@ max = i; } - if (max == -1) { + if (arfcns == 0) { /* Empty set, use 'bit map 0 format' */ chan_list[0] = 0; return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29ca51461beec053bcb8b8210f0ad24bb8c7765f Gerrit-Change-Number: 27357 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 2 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by daniel

Attention is currently required from: pespin, lynxis lazus. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File common/chapters/gb-ns2-maintenance.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687/comment/94d8052b_dc9d… PS2, Line 80: For FR, IPA: The NSE is ALIVE if there is at least one NSVC in state UNBLOCKED. > Ack Can you push an updated version? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Mar 2022 17:31:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by lynxis lazus

Attention is currently required from: pespin, daniel, lynxis lazus. Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 to look at the new patch set (#6). Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... common: gb-ns2: add chapter Gb/NS maintenance Add chapter to describe common maintenance Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f --- A common/chapters/gb-ns2-maintenance.adoc A common/chapters/gb-ns2-nsvc-states-alive.dot A common/chapters/gb-ns2-nsvc-states-reset-block.dot 3 files changed, 130 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/87/24687/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by lynxis lazus

Attention is currently required from: pespin, daniel, lynxis lazus. Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 to look at the new patch set (#5). Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... common: gb-ns2: add chapter Gb/NS maintenance Add chapter to describe common maintenance Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f --- A common/chapters/gb-ns2-maintenance.adoc A common/chapters/gb-ns2-nsvc-states-alive.dot A common/chapters/gb-ns2-nsvc-states-reset-block.dot 3 files changed, 130 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/87/24687/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

2 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_addr_pool_exhaustion

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 ) Change subject: ggsn: Introduce test TC_addr_pool_exhaustion ...................................................................... ggsn: Introduce test TC_addr_pool_exhaustion Related: OS#5469 Related: https://github.com/open5gs/open5gs/pull/1397 Change-Id: Iee24384b35f9277475b02cb59bf04cd6c9f23b1c --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 103 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 58a12a6..05d335a 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -1975,6 +1975,107 @@ setverdict(pass); } + /* Test callocation of PDP contexts until reaching addr pool exhaustion */ + type record of OCT4 TEIClist; + testcase TC_addr_pool_exhaustion() runs on GT_CT { + var Gtp1cUnitdata udc; + var Gtp1uUnitdata udu; + var PdpContext ctx; + timer T_next := 0.005; + var integer next_req_ctx := 0; + var integer rx_resp_ctx := 0; + var integer num_ctx; + var boolean cont_req := true; + var CreatePDPContextResponse cpr; + var TEIClist teic_list := {}; + var integer teic; + + f_init(); + + T_default.start(120.0); + + T_next.start; + alt { + [DIAMETER_PROC.checkstate("Connected")] as_DIA_CCR(INITIAL_REQUEST) { repeat; } + [] pingpong(); + [] T_next.timeout { + if (cont_req) { + if (next_req_ctx - rx_resp_ctx < 100) { /* if we have too many in progress, wait a bit to continue */ + ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), f_rnd_msisdn('1234'O), c_ApnInternet, valueof(t_EuaIPv4Dyn))); + ctx.nsapi := '0001'B; + ctx.teic := int2oct(next_req_ctx+1, 4); /* +1: skip TEIC=0 */ + ctx.teid := int2oct(next_req_ctx+1, 4); /* +1: skip TEID=0 */ + f_send_gtpc(ts_GTPC_CreatePDP(g_peer_c, g_c_seq_nr, ctx.imsi, g_restart_ctr, + ctx.teid, ctx.teic, ctx.nsapi, + ctx.eua, ctx.apn, g_sgsn_ip_c, g_sgsn_ip_u, + ctx.msisdn, ctx.pco_req, ctx.ratType, + ctx.uli)); + next_req_ctx := next_req_ctx + 1; + } + T_next.start; + } + repeat; + } + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, createPDPContextResponse, ?)) -> value udc { + cpr := udc.gtpc.gtpc_pdu.createPDPContextResponse; + + if (cpr.cause.causevalue == '80'O) { + teic_list := teic_list & {cpr.teidControlPlane.teidControlPlane}; + } else { + if (cont_req == true) { + num_ctx := rx_resp_ctx; + log("Successfully created ", num_ctx, " PDP contexts before exhausting the pool"); + setverdict(pass); + } + cont_req := false; + } + rx_resp_ctx := rx_resp_ctx + 1; + if (not cont_req and next_req_ctx == rx_resp_ctx) { + break; + } else { + repeat; + } + } + [] GTPC.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPC"); } + [] GTPU.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPU"); } + } + + /* Let's close them now: */ + next_req_ctx := 0; + rx_resp_ctx := 0; + T_next.start; + alt { + [DIAMETER_PROC.checkstate("Connected")] as_DIA_CCR(TERMINATION_REQUEST) { repeat; } + [] pingpong(); + [] T_next.timeout { + f_send_gtpc(ts_GTPC_DeletePDP(g_peer_c, g_c_seq_nr, teic_list[next_req_ctx], '0001'B, '1'B)); + next_req_ctx := next_req_ctx + 1; + if (next_req_ctx < num_ctx) { + T_next.start; + } + repeat; + } + [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextResponse, ?)) -> value udc { + teic := oct2int(udc.gtpc.teid); + if (not match(teic, (1 .. num_ctx))) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Rx Unexpected TEIC"); + } + rx_resp_ctx := rx_resp_ctx + 1; + if (rx_resp_ctx < num_ctx) { + repeat; + } + setverdict(pass); + } + [] GTPC.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPC"); } + [] GTPU.receive { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected GTPU"); } + } + T_next.stop; + + T_default.stop; + setverdict(pass); + } + control { execute(TC_pdp4_act_deact()); execute(TC_pdp4_act_deact_ipcp()); @@ -2019,5 +2120,7 @@ execute(TC_pdp_act_restart_ctr_echo()); execute(TC_lots_of_concurrent_pdp_ctx()); + /* Keep at the end, crashes older osmo-ggsn versions (OS#5469): */ + execute(TC_addr_pool_exhaustion()); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee24384b35f9277475b02cb59bf04cd6c9f23b1c Gerrit-Change-Number: 27350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_addr_pool_exhaustion

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 ) Change subject: ggsn: Introduce test TC_addr_pool_exhaustion ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iee24384b35f9277475b02cb59bf04cd6c9f23b1c Gerrit-Change-Number: 27350 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:48:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in pysim[master]: pySim-shell: Add 'decode_hex' command for transparent + linear EF

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27335 ) Change subject: pySim-shell: Add 'decode_hex' command for transparent + linear EF ...................................................................... pySim-shell: Add 'decode_hex' command for transparent + linear EF These commands can be used to decode a user-provided hex-string, instead of decoding the data read from the file. This is useful for quickly manually decoding some values read from other locations, such as e.g. copy+pasted from a eSIM profile in ASN.1 value notation. Change-Id: I81f73bce2c26e3e5dfc7538d223bb2d2483c7fa0 --- M docs/shell.rst M pySim/filesystem.py 2 files changed, 36 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/docs/shell.rst b/docs/shell.rst index f24dc93..2c8da84 100644 --- a/docs/shell.rst +++ b/docs/shell.rst @@ -384,6 +384,13 @@ This allows for easy interactive modification of records. +decode_hex +~~~~~~~~~~ +.. argparse:: + :module: pySim.filesystem + :func: LinFixedEF.ShellCommands.dec_hex_parser + + Transparent EF commands ----------------------- @@ -460,6 +467,13 @@ This allows for easy interactive modification of file contents. +decode_hex +~~~~~~~~~~ +.. argparse:: + :module: pySim.filesystem + :func: TransparentEF.ShellCommands.dec_hex_parser + + BER-TLV EF commands ------------------- diff --git a/pySim/filesystem.py b/pySim/filesystem.py index f8b86c5..5bbd57b 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -526,6 +526,17 @@ def __init__(self): super().__init__() + dec_hex_parser = argparse.ArgumentParser() + dec_hex_parser.add_argument('--oneline', action='store_true', + help='No JSON pretty-printing, dump as a single line') + dec_hex_parser.add_argument('HEXSTR', help='Hex-string of encoded data to decode') + + @cmd2.with_argparser(dec_hex_parser) + def do_decode_hex(self, opts): + """Decode command-line provided hex-string as if it was read from the file.""" + data = self._cmd.rs.selected_file.decode_hex(opts.HEXSTR) + self._cmd.poutput_json(data, opts.oneline) + read_bin_parser = argparse.ArgumentParser() read_bin_parser.add_argument( '--offset', type=int, default=0, help='Byte offset for start of read') @@ -738,6 +749,17 @@ def __init__(self, **kwargs): super().__init__(**kwargs) + dec_hex_parser = argparse.ArgumentParser() + dec_hex_parser.add_argument('--oneline', action='store_true', + help='No JSON pretty-printing, dump as a single line') + dec_hex_parser.add_argument('HEXSTR', help='Hex-string of encoded data to decode') + + @cmd2.with_argparser(dec_hex_parser) + def do_decode_hex(self, opts): + """Decode command-line provided hex-string as if it was read from the file.""" + data = self._cmd.rs.selected_file.decode_record_hex(opts.HEXSTR) + self._cmd.poutput_json(data, opts.oneline) + read_rec_parser = argparse.ArgumentParser() read_rec_parser.add_argument( 'record_nr', type=int, help='Number of record to be read') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I81f73bce2c26e3e5dfc7538d223bb2d2483c7fa0 Gerrit-Change-Number: 27335 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 2 months

1
0
0 0

Change in pysim[master]: pySim-shell: Add 'decode_hex' command for transparent + linear EF

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27335 ) Change subject: pySim-shell: Add 'decode_hex' command for transparent + linear EF ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27335 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I81f73bce2c26e3e5dfc7538d223bb2d2483c7fa0 Gerrit-Change-Number: 27335 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:48:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: New stats for lchan life duration.

by laforge

Attention is currently required from: iedemam. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: New stats for lchan life duration. ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Patchset: PS12: I'd be happy to see this patch moving ahead, but with the unit tests failing, that's of course not an option... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 12 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:36:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: inter-BSC HO in: expect codecs in HO Request ACK

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 ) Change subject: bsc: inter-BSC HO in: expect codecs in HO Request ACK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27311 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b Gerrit-Change-Number: 27311 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:35:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by laforge

Attention is currently required from: pespin, daniel, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:35:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by laforge

Attention is currently required from: pespin, daniel, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: asciidoc: WARNING: gb.adoc: line 28: callout refers to non-existent list item 1234 asciidoc: WARNING: gb.adoc: line 28: callout refers to non-existent list item 1235 ../build/Makefile.asciidoc.inc:90: recipe for target 'test-usermanual.check' failed -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Mar 2022 16:35:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 2 months

1
0
0 0

2024

2023

2022

gerrit-log March 2022