Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/27053 )
Change subject: lua dissector: adjust usage instructions
......................................................................
lua dissector: adjust usage instructions
...as originally described in the first commit that added the file.
Change-Id: I67918f0f62b1619786324ae84276a46d7c64eee5
---
M contrib/simtrace.lua
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/53/27053/1
diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua
index fa477d5..fadc01a 100644
--- a/contrib/simtrace.lua
+++ b/contrib/simtrace.lua
@@ -2,7 +2,10 @@
-- (C) 2021 by sysmocom - s.f.m.c. GmbH, Author: Eric Wild
-- SPDX-License-Identifier: GPL-2.0+
--
--- Usage: Put this into your ~/.wireshark/init.lua [or include it from there]
+-- Usage: Move this file to your "personal lua plugins" folder that
+-- can be found in the Wireshark Help->About Wireshark->Folders tab
+-- Windows: %APPDATA%\Wireshark\plugins.
+-- Unix-like systems: ~/.local/lib/wireshark/plugins.
usb_simtrace_protocol = Proto("USB_simtrace", "USB simtrace protocol")
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/27053
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I67918f0f62b1619786324ae84276a46d7c64eee5
Gerrit-Change-Number: 27053
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27049 )
Change subject: treewide: use almalinux instead of centos8
......................................................................
treewide: use almalinux instead of centos8
CentOS Linux 8 is EOL, attempting to install packages in it results in
an error. CentOS Linux is a rebuild of RHEL (stable versions). The
CentOS projects recommends to use CentOS Stream instead, which is a
build of the "public development branch for RHEL".
After the early EOL was announced on 2020-12-08, alternative projects
AlmaLinux and Rocky Linux have been established as binary compatible
forks of RHEL 8 (stable versions).
Both Alma and Rocky seem to be solid projects, see related Wikipedia
articles and their sources. Pick Alma and adjust the whole tree to use
the almalinux:8 docker image instead of centos:centos8.
Fix for:
Error: Failed to download metadata for repo 'appstream': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried
Related: SYS#5818
Related: https://www.centos.org/cl-vs-cs/
Related: https://www.centos.org/centos-linux-eol/
Related: https://bugs.centos.org/view.php?id=18394
Related: https://en.wikipedia.org/wiki/AlmaLinux
Related: https://en.wikipedia.org/wiki/Rocky_Linux
Change-Id: I30e1a773b901b1d2187214445116c7f2aecc4e36
---
M centos8-build/Dockerfile
M centos8-build/Makefile
M centos8-obs-latest/Dockerfile
M centos8-obs-latest/Makefile
M centos8-repo-install-test/Dockerfile
M jenkins-common.sh
M systemd/Dockerfile
7 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
laforge: Looks good to me, approved; Verified
pespin: Looks good to me, but someone else must approve
diff --git a/centos8-build/Dockerfile b/centos8-build/Dockerfile
index e36e3f0..26ef819 100644
--- a/centos8-build/Dockerfile
+++ b/centos8-build/Dockerfile
@@ -1,5 +1,5 @@
ARG REGISTRY=docker.io
-ARG UPSTREAM_DISTRO=centos:centos8
+ARG UPSTREAM_DISTRO=almalinux:8
FROM ${REGISTRY}/${UPSTREAM_DISTRO}
# Arguments used after FROM must be specified again
ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org"
diff --git a/centos8-build/Makefile b/centos8-build/Makefile
index cba5cee..a18eb5c 100644
--- a/centos8-build/Makefile
+++ b/centos8-build/Makefile
@@ -1,3 +1,3 @@
-UPSTREAM_DISTRO:=centos:centos8
+UPSTREAM_DISTRO:=almalinux:8
DISTRO:=centos8
include ../make/Makefile
diff --git a/centos8-obs-latest/Dockerfile b/centos8-obs-latest/Dockerfile
index 4e180de..69eeb79 100644
--- a/centos8-obs-latest/Dockerfile
+++ b/centos8-obs-latest/Dockerfile
@@ -1,5 +1,5 @@
ARG REGISTRY=docker.io
-ARG UPSTREAM_DISTRO=centos:centos8
+ARG UPSTREAM_DISTRO=almalinux:8
FROM ${REGISTRY}/${UPSTREAM_DISTRO}
# Arguments used after FROM must be specified again
ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org"
diff --git a/centos8-obs-latest/Makefile b/centos8-obs-latest/Makefile
index cba5cee..a18eb5c 100644
--- a/centos8-obs-latest/Makefile
+++ b/centos8-obs-latest/Makefile
@@ -1,3 +1,3 @@
-UPSTREAM_DISTRO:=centos:centos8
+UPSTREAM_DISTRO:=almalinux:8
DISTRO:=centos8
include ../make/Makefile
diff --git a/centos8-repo-install-test/Dockerfile b/centos8-repo-install-test/Dockerfile
index 27d7a59..2f1c345 100644
--- a/centos8-repo-install-test/Dockerfile
+++ b/centos8-repo-install-test/Dockerfile
@@ -1,6 +1,6 @@
ARG USER
ARG REGISTRY=docker.io
-ARG UPSTREAM_DISTRO=centos:centos8
+ARG UPSTREAM_DISTRO=almalinux:8
FROM ${REGISTRY}/${UPSTREAM_DISTRO}
# dnf-utils: for repoquery
diff --git a/jenkins-common.sh b/jenkins-common.sh
index 1e9435a..7130fe2 100644
--- a/jenkins-common.sh
+++ b/jenkins-common.sh
@@ -39,9 +39,9 @@
docker_upstream_distro_from_image_name() {
case "$1" in
osmo-*-centos7) echo "centos:centos7"; ;;
- osmo-*-centos8) echo "centos:centos8"; ;;
+ osmo-*-centos8) echo "almalinux:8"; ;;
centos7-*) echo "centos:centos7" ;;
- centos8-*) echo "centos:centos8" ;;
+ centos8-*) echo "almalinux:8" ;;
debian9-*) echo "debian:stretch" ;;
debian10-*) echo "debian:buster" ;;
debian11-*) echo "debian:bullseye" ;;
@@ -120,7 +120,7 @@
# name (e.g. osmo-mgw-master-centos8), it gets removed from the subdir
# where the Dockerfile is taken from (e.g. osmo-mgw-master/Dockerfile)
# and UPSTREAM_DISTRO and DISTRO are passed accordingly (e.g.
-# UPSTREAM_DISTRO=centos:centos8 DISTRO=centos8). This allows one
+# UPSTREAM_DISTRO=almalinux:8 DISTRO=centos8). This allows one
# Dockerfile for multiple distributions, without duplicating configs for
# each distribution. Dependencies listed in docker_depends() are built
# automatically too.
diff --git a/systemd/Dockerfile b/systemd/Dockerfile
index 8f1763d..63d4c40 100644
--- a/systemd/Dockerfile
+++ b/systemd/Dockerfile
@@ -1,5 +1,5 @@
ARG REGISTRY=docker.io
-ARG UPSTREAM_DISTRO=centos:centos8
+ARG UPSTREAM_DISTRO=almalinux:8
FROM ${REGISTRY}/${UPSTREAM_DISTRO}
# Arguments used after FROM must be specified again
ARG DISTRO
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27049
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I30e1a773b901b1d2187214445116c7f2aecc4e36
Gerrit-Change-Number: 27049
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27049 )
Change subject: treewide: use almalinux instead of centos8
......................................................................
Patch Set 1: Verified+1 Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27049
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I30e1a773b901b1d2187214445116c7f2aecc4e36
Gerrit-Change-Number: 27049
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Feb 2022 10:02:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: osmith, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27047 )
Change subject: core/utils.h: make use of OSMO_LIKELY in OSMO_ASSERT
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
So the linter suggests the following:
include/osmocom/core/utils.h:113: ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
I tried doing this, and got lots of compilation errors like:
logging.c:1430:9: error: expected ‘;’ before ‘tall_log_ctx’
The problem is that some OSMO_ASSERT statements in the code (not only in libosmocore) have no semicolon in the end.
I suggest to ignore this warning, as I see no easy solution to this.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27047
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I29b32a2477ec92762f8f0ce5e5c5a30810f6abbe
Gerrit-Change-Number: 27047
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Feb 2022 08:37:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27045 )
Change subject: osmo-uecups-master: install iputils-ping for ttcn3-pgw-test
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27045
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I73a78949d2e433d7cc4233395e45665056f083c8
Gerrit-Change-Number: 27045
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 02 Feb 2022 08:19:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment