February 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: Better decode of EF.UST, EF.EST and EF.IST

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/27127 to look at the new patch set (#2). Change subject: Better decode of EF.UST, EF.EST and EF.IST ...................................................................... Better decode of EF.UST, EF.EST and EF.IST So far, we only returned an array of service numbers like [ 2, 4, 5, 9 ] which is not very friendly to the human reader. In EF.SST we already had more verbose decoding including a description of each service. Let's add the same principle to EF.UST, EST and IST The same output above now looks like this: { "1": { "description": "Local Phone Book", "activated": false }, "2": { "description": "Fixed Dialling Numbers (FDN)", "activated": true }, "3": { "description": "Extension 2", "activated": false }, "4": { "description": "Service Dialling Numbers (SDN)", "activated": true }, "5": { "description": "Extension3", "activated": true }, "6": { "description": "Barred Dialling Numbers (BDN)", "activated": false }, "7": { "description": "Extension4", "activated": false }, "9": { "description": "Incoming Call Information (ICI and ICT)", "activated": true } } Change-Id: I34f64d1043698dc385619b2fdda23cb541675f76 --- M pySim/ts_31_102.py M pySim/ts_31_103.py 2 files changed, 45 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/27127/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I34f64d1043698dc385619b2fdda23cb541675f76 Gerrit-Change-Number: 27127 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-iuh[master]: ranap_msg_factory: add missing apidoc

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/27128 ) Change subject: ranap_msg_factory: add missing apidoc ...................................................................... ranap_msg_factory: add missing apidoc The functions ranap_new_msg_iu_rel_req and ranap_new_msg_rab_rel_req lack apidoc strings. Change-Id: I7484413980acdf17fde9ed0f97cf7f97e0ef3ae4 --- M src/ranap_msg_factory.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/28/27128/1 diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index 60dc9e0..b871343 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -876,6 +876,7 @@ return msg; } +/*! \brief generate RANAP IU RELEASE REQUEST message */ struct msgb *ranap_new_msg_iu_rel_req(const RANAP_Cause_t *cause) { RANAP_Iu_ReleaseRequestIEs_t ies; @@ -905,6 +906,7 @@ return msg; } +/*! \brief generate RANAP RAB RELEASE REQUEST message */ struct msgb *ranap_new_msg_rab_rel_req(uint8_t rab_id, const RANAP_Cause_t *cause) { RANAP_RAB_ReleaseItemIEs_t item_ies; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/27128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7484413980acdf17fde9ed0f97cf7f97e0ef3ae4 Gerrit-Change-Number: 27128 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in pysim[master]: WIP: pySim-shell: support TS 102 220 administrative commands

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27126 ) Change subject: WIP: pySim-shell: support TS 102 220 administrative commands ...................................................................... WIP: pySim-shell: support TS 102 220 administrative commands Change-Id: I5b1ffb1334afa18d62beb642268066a30deb7ea6 --- M pySim-shell.py M pySim/commands.py M pySim/filesystem.py 3 files changed, 66 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/26/27126/1 diff --git a/pySim-shell.py b/pySim-shell.py index 8e8a1a6..0a2e5b0 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -169,6 +169,7 @@ self._onchange_conserve_write('conserve_write', False, self.conserve_write) self._onchange_apdu_trace('apdu_trace', False, self.apdu_trace) self.register_command_set(Iso7816Commands()) + self.register_command_set(Ts102221Commands()) self.register_command_set(PySimCommands()) self.iccid, sw = self.card.read_iccid() rs.select('MF', self) @@ -624,6 +625,51 @@ else: raise ValueError("error: cannot authenticate, no adm-pin!") +@with_default_category('TS 102 222 Commands') +class Ts102221Commands(CommandSet): + """Administrative commands for telecommunication aplpications.""" + def __init__(self): + super().__init__() + + def do_delete_file(self, opts): + """Delete the specified file. DANGEROUS!""" + path = opts.arg_list[0] + f = self._cmd.rs.get_file_for_selectable(path) + (data, sw) = self._cmd.card._scc.delete_file(f.fid) + + def complete_delete_file(self, text, line, begidx, endidx) -> List[str]: + """Command Line tab completion for DELETE FILE""" + index_dict = { 1: self._cmd.rs.selected_file.get_selectable_names() } + return self._cmd.index_based_complete(text, line, begidx, endidx, index_dict=index_dict) + + def do_terminate_df(self, opts): + """Terminate the specified DF. DANGEROUS!""" + path = opts.arg_list[0] + f = self._cmd.rs.get_file_for_selectable(path) + (data, sw) = self._cmd.card._scc.terminate_df(f.fid) + + def complete_terminate_df(self, text, line, begidx, endidx) -> List[str]: + """Command Line tab completion for TERMINATE DF""" + index_dict = { 1: self._cmd.rs.selected_file.get_selectable_names() } + return self._cmd.index_based_complete(text, line, begidx, endidx, index_dict=index_dict) + + def do_terminate_ef(self, opts): + """Terminate the specified EF. DANGEROUS!""" + path = opts.arg_list[0] + f = self._cmd.rs.get_file_for_selectable(path) + (data, sw) = self._cmd.card._scc.terminate_ef(f.fid) + + def complete_terminate_ef(self, text, line, begidx, endidx) -> List[str]: + """Command Line tab completion for TERMINATE EF""" + index_dict = { 1: self._cmd.rs.selected_file.get_selectable_names() } + return self._cmd.index_based_complete(text, line, begidx, endidx, index_dict=index_dict) + + def do_terminate_card_usage(self, opts): + """Terminate the Card. SUPER DANGEROUS!""" + (data, sw) = self._cmd.card._scc.terminate_card_usage() + + + @with_default_category('ISO7816 Commands') class Iso7816Commands(CommandSet): def __init__(self): diff --git a/pySim/commands.py b/pySim/commands.py index 674e184..9dc273c 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -431,6 +431,22 @@ """ return self._tp.send_apdu_checksw(self.cla_byte + '44000002' + fid) + def delete_file(self, fid): + """Execute DELETE FILE command as per TS 102 222 Section 6.4""" + return self._tp.send_apdu_checksw(self.cla_byte + 'e4000002' + fid) + + def terminate_df(self, fid): + """Execute TERMINATE DF command as per TS 102 222 Section 6.7""" + return self._tp.send_apdu_checksw(self.cla_byte + 'e6000002' + fid) + + def terminate_ef(self, fid): + """Execute TERMINATE EF command as per TS 102 222 Section 6.8""" + return self._tp.send_apdu_checksw(self.cla_byte + 'e8000002' + fid) + + def terminate_card_usage(self): + """Execute TERMINATE CARD USAGE command as per TS 102 222 Section 6.9""" + return self._tp.send_apdu_checksw(self.cla_byte + 'fe000000') + def manage_channel(self, mode='open', lchan_nr=0): """Execute MANAGE CHANNEL command as per TS 102 221 Section 11.1.17. diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 7100b21..d9c7475 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1265,6 +1265,10 @@ (data, sw) = self.card._scc.status() return self.selected_file.decode_select_response(data) + def get_file_for_selectable(self, name:str): + sels = self.selected_file.get_selectables() + return sels[name] + def activate_file(self, name:str): """Request ACTIVATE FILE of specified file.""" sels = self.selected_file.get_selectables() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b1ffb1334afa18d62beb642268066a30deb7ea6 Gerrit-Change-Number: 27126 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in pysim[master]: Better decode of EF.UST, EF.EST and EF.IST

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27127 ) Change subject: Better decode of EF.UST, EF.EST and EF.IST ...................................................................... Better decode of EF.UST, EF.EST and EF.IST So far, we only returned an array of service numbers like [ 2, 4, 5, 9 ] which is not very friendly to the human reader. In EF.SST we already had more verbose decoding including a description of each service. Let's add the same principle to EF.UST, EST and IST The same output above now looks like this: { "1": { "description": "Local Phone Book", "activated": false }, "2": { "description": "Fixed Dialling Numbers (FDN)", "activated": true }, "3": { "description": "Extension 2", "activated": false }, "4": { "description": "Service Dialling Numbers (SDN)", "activated": true }, "5": { "description": "Extension3", "activated": true }, "6": { "description": "Barred Dialling Numbers (BDN)", "activated": false }, "7": { "description": "Extension4", "activated": false }, "9": { "description": "Incoming Call Information (ICI and ICT)", "activated": true } } Change-Id: I34f64d1043698dc385619b2fdda23cb541675f76 --- M pySim/ts_31_102.py M pySim/ts_31_103.py 2 files changed, 44 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/27/27127/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index f6f6c00..da2d7ce 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -165,6 +165,13 @@ 135: 'Support for Trusted non-3GPP access networks by USIM' } +# Mapping between USIM Enbled Service Number and its description +EF_EST_map = { + 1: 'Fixed Dialling Numbers (FDN)', + 2: 'Barred Dialling Numbers (BDN)', + 3: 'APN Control List (ACL)' +} + LOCI_STATUS_map = { 0: 'updated', 1: 'not updated', @@ -519,30 +526,48 @@ self._construct = Int8ub # TS 31.102 Section 4.2.8 -class EF_UST(TransparentEF): - def __init__(self, fid='6f38', sfid=0x04, name='EF.UST', desc='USIM Service Table', size={1,17}): +class EF_UServiceTable(TransparentEF): + def __init__(self, fid, sfid, name, desc, size, table): super().__init__(fid=fid, sfid=sfid, name=name, desc=desc, size=size) + self.table = table # add those commands to the general commands of a TransparentEF self.shell_commands += [self.AddlShellCommands()] + @staticmethod + def _bit_byte_offset_for_service(service:int) -> (int, int): + i = service - 1 + byte_offset = i//8 + bit_offset = (i % 8) + return (byte_offset, bit_offset) def _decode_bin(self, in_bin): - ret = [] + ret = {} for i in range (0, len(in_bin)): byte = in_bin[i] for bitno in range(0,7): - if byte & (1 << bitno): - ret.append(i * 8 + bitno + 1) + service_nr = i * 8 + bitno + 1 + ret[service_nr] = { + 'description' : self.table[service_nr] if service_nr in self.table else None, + 'activated': True if byte & (1 << bitno) else False + } return ret def _encode_bin(self, in_json): - # FIXME: size this to length of file - ret = bytearray(20) - for srv in in_json: - print("srv=%d"%srv) - srv = srv-1 - byte_nr = srv // 8 - # FIXME: detect if service out of range was selected - bit_nr = srv % 8 - ret[byte_nr] |= (1 << bit_nr) - return ret + # compute the required binary size + bin_len = 0 + for srv in in_json.keys(): + service_nr = int(srv) + (byte_offset, bit_offset) = EF_UServiceTable._bit_byte_offset_for_service(service_nr) + if byte_offset >= bin_len: + bin_len = byte_offset+1 + # encode the actual data + out = bytearray(b'\x00' * bin_len) + for srv in in_json.keys(): + service_nr = int(srv) + (byte_offset, bit_offset) = EF_UServiceTable._bit_byte_offset_for_service(service_nr) + if in_json[srv]['activated'] == True: + bit = 1 + else: + bit = 0 + out[byte_offset] |= (bit) << bit_offset + return out @with_default_category('File-Specific Commands') class AddlShellCommands(CommandSet): def __init__(self): @@ -991,7 +1016,7 @@ 'User controlled PLMN Selector with Access Technology'), EF_HPPLMN(), EF_ACMmax(), - EF_UST(), + EF_UServiceTable('6f38', 0x04, 'EF.UST', 'USIM Service Table', size={1,17}, table=EF_UST_map), CyclicEF('6f39', None, 'EF.ACM', 'Accumulated call meter', rec_len={3,3}), TransparentEF('6f3e', None, 'EF.GID1', 'Group Identifier Level 1'), TransparentEF('6f3f', None, 'EF.GID2', 'Group Identifier Level 2'), @@ -1027,7 +1052,7 @@ EF_ADN('6f4d', None, 'EF.BDN', 'Barred Dialling Numbers'), EF_EXT('6f55', None, 'EF.EXT4', 'Extension4 (BDN/SSC)'), EF_CMI(), - EF_UST('6f56', 0x05, 'EF.EST', 'Enabled Services Table', size={1,None}), + EF_UServiceTable('6f56', 0x05, 'EF.EST', 'Enabled Services Table', size={1,None}, table=EF_EST_map), EF_ACL(), EF_DCK(), EF_CNL(), diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py index 9c7843f..6b69990 100644 --- a/pySim/ts_31_103.py +++ b/pySim/ts_31_103.py @@ -26,7 +26,7 @@ from pySim.utils import * from pySim.tlv import * from pySim.ts_51_011 import EF_AD, EF_SMS, EF_SMSS, EF_SMSR, EF_SMSP -from pySim.ts_31_102 import ADF_USIM, EF_FromPreferred +from pySim.ts_31_102 import ADF_USIM, EF_FromPreferred, EF_UServiceTable import pySim.ts_102_221 from pySim.ts_102_221 import EF_ARR @@ -101,26 +101,6 @@ super().__init__(fid=fid, sfid=sfid, name=name, desc=desc) self._tlv = EF_IMPU.impu -# TS 31.103 Section 4.2.7 -class EF_IST(TransparentEF): - def __init__(self, fid='6f07', sfid=0x07, name='EF.IST', desc='ISIM Service Table'): - super().__init__(fid=fid, sfid=sfid, name=name, desc=desc, size={1,4}) - # add those commands to the general commands of a TransparentEF - self.shell_commands += [self.AddlShellCommands()] - - @with_default_category('File-Specific Commands') - class AddlShellCommands(CommandSet): - def __init__(self): - super().__init__() - - def do_ist_service_activate(self, arg): - """Activate a service within EF.IST""" - self._cmd.card.update_ist(int(arg), 1) - - def do_ist_service_deactivate(self, arg): - """Deactivate a service within EF.IST""" - self._cmd.card.update_ist(int(arg), 0) - # TS 31.103 Section 4.2.8 class EF_PCSCF(LinFixedEF): def __init__(self, fid='6f09', sfid=None, name='EF.P-CSCF', desc='P-CSCF Address'): @@ -192,7 +172,7 @@ EF_IMPU(), EF_AD(), EF_ARR('6f06', 0x06), - EF_IST(), + EF_UServiceTable('6f07', 0x07, 'EF.IST', 'ISIM Service Table', {1,None}, EF_IST_map), EF_PCSCF(), EF_GBABP(), EF_GBANL(), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I34f64d1043698dc385619b2fdda23cb541675f76 Gerrit-Change-Number: 27127 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27103 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Abandoned Original patch has been improved to not download files, we don't need my variant: https://gerrit.osmocom.org/c/docker-playground/+/20622 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27103 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If2d1ba8a775dc6c396f50f9853e633df110329a9 Gerrit-Change-Number: 27103 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bts-test: use osmo-config-merge to generate config files

by osmith

Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/20622 ) Change subject: ttcn3-bts-test: use osmo-config-merge to generate config files ...................................................................... Patch Set 9: Code-Review-1 (3 comments) Patchset: PS9: LGTM once the cp commands and FORCE_FETCH is fixed. I highly suggest running it locally, that's how I found that the config files are not copied properly. File ttcn3-bts-test/Makefile: https://gerrit.osmocom.org/c/docker-playground/+/20622/comment/1c68eedb_4c0… PS9, Line 24: FORCE_FETCH: FORCE_FETCH is not needed, cfg above is already a phony target. https://www.gnu.org/software/make/manual/make.html#Phony-Targets > If you write a rule whose recipe will not create the target file, the recipe will be executed every time the target comes up for remaking. Here is an example: File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/20622/comment/ca596a9d_6f3… PS6, Line 139: cp osmo-bsc-generic.gen.cfg $VOL_BASE_DIR/bsc/ > Wait, actually no. […] Ah right, I did not not see that... but still, it needs to be cp osmo-bsc-generic.gen.cfg $VOL_BASE_DIR/bsc/osmo-bsc.gen.cfg then. Otherwise the file is named osmo-bsc-generic.gen.cfg in the target dir. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/20622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If15461240f3037c142c176fc7da745a1701ae3f8 Gerrit-Change-Number: 20622 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Assignee: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Feb 2022 09:28:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in pysim[master]: filesystem: Fix TLV decode/encode

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/27100 to look at the new patch set (#2). Change subject: filesystem: Fix TLV decode/encode ...................................................................... filesystem: Fix TLV decode/encode We cannot call a method of a class without instantiating it Change-Id: I6d7c1bf49a8eaf3d8e50fb12888bf3d5b46b6c55 --- M pySim/filesystem.py 1 file changed, 36 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/00/27100/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27100 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6d7c1bf49a8eaf3d8e50fb12888bf3d5b46b6c55 Gerrit-Change-Number: 27100 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix typo in EF_MMSUP

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27099 ) Change subject: ts_51_011: Fix typo in EF_MMSUP ...................................................................... ts_51_011: Fix typo in EF_MMSUP The TLV decoder class must be in self._tlv, not self.tlv Change-Id: Ide6f6c823d5a16e375c324ba9bfa92e02c3b3c89 --- M pySim/ts_51_011.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index a4e3507..a7f9f97 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -887,7 +887,7 @@ def __init__(self, fid='6fd1', sfid=None, name='EF.MMSUP', rec_len={1,None}, desc='MMS User Preferences'): super().__init__(fid, sfid=sfid, name=name, desc=desc, rec_len=rec_len) - self.tlv = EF_MMSUP.MMS_User_Preferences + self._tlv = EF_MMSUP.MMS_User_Preferences # TS 51.011 Section 10.3.55 class EF_MMSUCP(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ide6f6c823d5a16e375c324ba9bfa92e02c3b3c89 Gerrit-Change-Number: 27099 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in pysim[master]: ts_31_102: EF.PNN encoding is identical to that of DF.GSM

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27098 ) Change subject: ts_31_102: EF.PNN encoding is identical to that of DF.GSM ...................................................................... ts_31_102: EF.PNN encoding is identical to that of DF.GSM so let's use the DF.GSM/EF.PNN decoder Change-Id: If2ce52fccfca3d8bb2c9801b9812912922600377 --- M pySim/ts_31_102.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index c96bf09..f6f6c00 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -292,7 +292,7 @@ from pySim.ts_51_011 import EF_CBMID, EF_CBMIR, EF_ADN, EF_SMS, EF_MSISDN, EF_SMSP, EF_SMSS from pySim.ts_51_011 import EF_SMSR, EF_DCK, EF_EXT, EF_CNL, EF_OPL, EF_MBI, EF_MWIS from pySim.ts_51_011 import EF_MMSN, EF_MMSICP, EF_MMSUP, EF_MMSUCP, EF_VGCS, EF_VGCSS, EF_NIA -from pySim.ts_51_011 import EF_ACMmax, EF_AAeM, EF_eMLPP, EF_CMI +from pySim.ts_51_011 import EF_ACMmax, EF_AAeM, EF_eMLPP, EF_CMI, EF_PNN import pySim.ts_102_221 @@ -1037,7 +1037,7 @@ 'User controlled PLMN Selector with Access Technology'), EF_ARR('6f06', 0x17), TransparentEF('6fc4', None, 'EF.NETPAR', 'Network Parameters'), - LinFixedEF('6fc5', 0x19, 'EF.PNN', 'PLMN Network Name'), + EF_PNN('6fc5', 0x19), EF_OPL(), EF_ADN('6fc7', None, 'EF.MBDN', 'Mailbox Dialling Numbers'), EF_MBI(), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If2ce52fccfca3d8bb2c9801b9812912922600377 Gerrit-Change-Number: 27098 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix typo in EF_MMSUP

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27099 ) Change subject: ts_51_011: Fix typo in EF_MMSUP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ide6f6c823d5a16e375c324ba9bfa92e02c3b3c89 Gerrit-Change-Number: 27099 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 09 Feb 2022 20:23:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022