December 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: preserve A5 params during [P]DCH-to-DCH transition

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30627 ) Change subject: trxcon: preserve A5 params during [P]DCH-to-DCH transition ...................................................................... trxcon: preserve A5 params during [P]DCH-to-DCH transition This is not really needed because layer23 apps do send another another L1CTL_CRYPTO_REQ message for the new DCH. I wrote this patch before I figured this out, but we may want to offload the task of preserving the A5 params to the L1 some day... Change-Id: I822a27a1bacc21dae7a3e31166a7609c7e1faeff --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/trxcon_fsm.c 2 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/27/30627/1 diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h index 9148771..103a047 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h @@ -31,6 +31,11 @@ uint16_t band_arfcn; uint8_t tx_power; int8_t ta; + + /* A5 encryption state */ + uint8_t a5_algo; + uint8_t a5_key_len; + uint8_t a5_key[128 / 8]; /* MAX_A5_KEY_LEN */ } l1p; }; diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index b575fd0..dbab84a 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -64,6 +64,11 @@ trxcon->l1p.tx_power = 0; trxcon->l1p.ta = 0; + /* Reset the A5 state */ + trxcon->l1p.a5_algo = 0; + trxcon->l1p.a5_key_len = 0; + memset(&trxcon->l1p.a5_key[0], 0x00, sizeof(trxcon->l1p.a5_key)); + phycmd.type = TRXCON_PHYIF_CMDT_RESET; trxcon_phyif_handle_cmd(trxcon->phyif, &phycmd); break; @@ -359,6 +364,15 @@ return; } + /* Reapply A5 ciphering parameters (if needed) */ + if (config != GSM_PCHAN_PDCH && trxcon->l1p.a5_algo) { + rc = l1sched_start_ciphering(ts, trxcon->l1p.a5_algo, + &trxcon->l1p.a5_key[0], + trxcon->l1p.a5_key_len); + if (rc != 0) + LOGPFSML(fi, LOGL_ERROR, "Failed to configure ciphering\n"); + } + if (config == GSM_PCHAN_PDCH) osmo_fsm_inst_state_chg(fi, TRXCON_ST_PACKET_DATA, 0, 0); else @@ -492,6 +506,11 @@ LOGPFSML(fi, LOGL_ERROR, "Failed to configure ciphering\n"); return; } + + trxcon->l1p.a5_algo = req->a5_algo; + trxcon->l1p.a5_key_len = req->key_len; + OSMO_ASSERT(req->key_len <= sizeof(trxcon->l1p.a5_key)); + memcpy(&trxcon->l1p.a5_key[0], req->key, req->key_len); break; } case TRXCON_EV_TX_DATA_REQ: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I822a27a1bacc21dae7a3e31166a7609c7e1faeff Gerrit-Change-Number: 30627 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: [WIP] trxcon: implement the missing TRXCON_ST_DCH_TUNING

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30628 ) Change subject: [WIP] trxcon: implement the missing TRXCON_ST_DCH_TUNING ...................................................................... [WIP] trxcon: implement the missing TRXCON_ST_DCH_TUNING This is a transient state called 'TUNING DCH' in 3GPP TS 44.004, Figure 5.1. We may want to have it implemented in the trxcon_fsm for proper handling of the L1CTL_DM_REL_REQ (TRXCON_EV_DCH_REL_REQ) and additionally for handling DCH establishment failures. Change-Id: I817691243d5c45f23bed1d9f8d7d16c002108a38 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h M src/host/trxcon/src/trxcon_fsm.c 2 files changed, 18 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/28/30628/1 diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h index ec0b2c6..75ce6f5 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon_fsm.h @@ -12,6 +12,7 @@ TRXCON_ST_FULL_POWER_SCAN, TRXCON_ST_FBSB_SEARCH, TRXCON_ST_BCCH_CCCH, + TRXCON_ST_DCH_TUNING, TRXCON_ST_DEDICATED, TRXCON_ST_PACKET_DATA, }; diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index dbab84a..d272dc8 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -622,8 +622,7 @@ .name = "BCCH_CCCH", .out_state_mask = S(TRXCON_ST_RESET) | S(TRXCON_ST_FBSB_SEARCH) - | S(TRXCON_ST_DEDICATED) - | S(TRXCON_ST_PACKET_DATA), + | S(TRXCON_ST_DCH_TUNING), .in_event_mask = S(TRXCON_EV_RX_DATA_IND) | S(TRXCON_EV_SET_CCCH_MODE_REQ) | S(TRXCON_EV_TX_ACCESS_BURST_REQ) @@ -631,9 +630,24 @@ | S(TRXCON_EV_DCH_EST_REQ), .action = &trxcon_st_bcch_ccch_action, }, + [TRXCON_ST_DCH_TUNING] = { + .name = "DCH_TUNING", + .out_state_mask = S(TRXCON_ST_RESET) + | S(TRXCON_ST_FBSB_SEARCH) + | S(TRXCON_ST_DEDICATED) + | S(TRXCON_ST_PACKET_DATA), + .in_event_mask = S(TRXCON_EV_DCH_REL_REQ) + | S(TRXCON_EV_SET_TCH_MODE_REQ) + | S(TRXCON_EV_TX_DATA_REQ) + | S(TRXCON_EV_TX_DATA_CNF) + | S(TRXCON_EV_RX_DATA_IND) + | S(TRXCON_EV_CRYPTO_REQ), + .action = &trxcon_st_dch_tuning_action, + }, [TRXCON_ST_DEDICATED] = { .name = "DEDICATED", .out_state_mask = S(TRXCON_ST_RESET) + | S(TRXCON_ST_DCH_TUNING) | S(TRXCON_ST_FBSB_SEARCH) | S(TRXCON_ST_DEDICATED) | S(TRXCON_ST_PACKET_DATA), @@ -651,6 +665,7 @@ [TRXCON_ST_PACKET_DATA] = { .name = "PACKET_DATA", .out_state_mask = S(TRXCON_ST_RESET) + | S(TRXCON_ST_DCH_TUNING) | S(TRXCON_ST_FBSB_SEARCH) | S(TRXCON_ST_DEDICATED) | S(TRXCON_ST_PACKET_DATA), -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30628 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I817691243d5c45f23bed1d9f8d7d16c002108a38 Gerrit-Change-Number: 30628 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: TRXCON_EV_DCH_REL_REQ does not switch to TRXCON_ST_RESET

by fixeria

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30485 to look at the new patch set (#3). Change subject: trxcon: TRXCON_EV_DCH_REL_REQ does not switch to TRXCON_ST_RESET ...................................................................... trxcon: TRXCON_EV_DCH_REL_REQ does not switch to TRXCON_ST_RESET It's not really clear to me how the L1 is supposed to handle the L1CTL_DM_REL_REQ message, which maps to the TRXCON_EV_DCH_REL_REQ in our case. Lookig at the layer23 code I see that it's sent along with the L1CTL_RESET_REQ (maps to the TRXCON_EV_RESET_SCHED_REQ). The layer1 firmware does reset some parameters on receipt of the L1CTL_DM_REL_REQ and some more parameters on the L1CTL_RESET_REQ. It's clear though that we should not switch to the TRXCON_ST_RESET on receipt of the L1CTL_DM_REL_REQ. The layer23 application (e.g. mobile) may send L1CTL_DM_EST_REQ right after that, and we won't be able to transition from the TRXCON_ST_RESET directly to the TRXCON_ST_DEDICATED. Such transition is neither implemented nor permitted by 3GPP TS 44.004, Figure 5.1. Ideally, according to 3GPP TS 44.004, Figure 5.1, we should have an additional transient state 'TUNING DCH' in the trxcon_fsm and switch there on reciept of the L1CTL_DM_REL_REQ. But currently it's not implemented and adding it would require some effort. As a temporary solution, let's do not change the current state and stay in the TRXCON_ST_DEDICATED. This workaround is needed to make mobile terminated calls work in the mobile app. Change-Id: I5bbe6ca4cc6299f9faf343822c992a6872a45081 Related: OS#5599 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/85/30485/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5bbe6ca4cc6299f9faf343822c992a6872a45081 Gerrit-Change-Number: 30485 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: reset the L1 params on TRXCON_EV_RESET_FULL_REQ

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30626 ) Change subject: trxcon: reset the L1 params on TRXCON_EV_RESET_FULL_REQ ...................................................................... trxcon: reset the L1 params on TRXCON_EV_RESET_FULL_REQ Change-Id: Ie94b7977fec857aa5f13f53162816d5fd9f5594c Related: OS#5599 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 47da0bd..eaa4825 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -59,6 +59,11 @@ osmo_fsm_inst_state_chg(fi, TRXCON_ST_RESET, 0, 0); l1sched_reset(trxcon->sched, true); + /* Reset the L1 parameters */ + trxcon->l1p.band_arfcn = 0xffff; + trxcon->l1p.tx_power = 0; + trxcon->l1p.ta = 0; + phycmd.type = TRXCON_PHYIF_CMDT_RESET; trxcon_phyif_handle_cmd(trxcon->phyif, &phycmd); break; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30626 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie94b7977fec857aa5f13f53162816d5fd9f5594c Gerrit-Change-Number: 30626 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: ipa: Guard against calling ipa_client_conn_open* multiple times

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30618 ) Change subject: ipa: Guard against calling ipa_client_conn_open* multiple times ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I574af543429d01c9522e267265e97e4efe55b60c Gerrit-Change-Number: 30618 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 19:59:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: Pass gprc_rlcmac_pdch to tbf_set_polling

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30625 ) Change subject: Pass gprc_rlcmac_pdch to tbf_set_polling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5ecc57c72e7f60e31e64e76e724d7a5a95968c40 Gerrit-Change-Number: 30625 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 19:59:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: Pass gprc_rlcmac_pdch to tbf_check_polling

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30624 ) Change subject: Pass gprc_rlcmac_pdch to tbf_check_polling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1c7140b35b7c93d3df4156841e908d3b44d7336d Gerrit-Change-Number: 30624 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 19:59:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: Pass gprs_rlcmac_pdch to create_dl_acked_block()

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30623 ) Change subject: Pass gprs_rlcmac_pdch to create_dl_acked_block() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I1efccb32c5afa4fe62233bf114ea95b6fbbe1a06 Gerrit-Change-Number: 30623 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 19:59:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: tests/tbf: test_tbf_dl_llc_loss(): Fix wrong param passed and wrong e...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30622 ) Change subject: tests/tbf: test_tbf_dl_llc_loss(): Fix wrong param passed and wrong expectancies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ibe6fc073b7438b8024c4d3ddb0e60c6112752351 Gerrit-Change-Number: 30622 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 19:58:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: Convert tbf->control_ts to be a gprs_rlcmac_pdch*

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30620 ) Change subject: Convert tbf->control_ts to be a gprs_rlcmac_pdch* ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6a97b6528b2f9d78dfbca8fb97ab7c621f777fc7 Gerrit-Change-Number: 30620 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 19:58:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022