December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: ms-trx support

by Hoernchen

Attention is currently required from: pespin, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 11: (6 comments) File .gitignore: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cf4a5e8_a523dac5 PS3, Line 10: Transceiver52M/osmo-trx-ipc2 > This doesn't belong to this commit afaiu. Done File Transceiver52M/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e7b2096_994f5744 PS3, Line 27: AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/ > Is it OK if the submodule isn't there and the patch doesn't exist? I guess it's fine, the compiler j […] just paths used for searching, compiler doesn't care. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97e0f637_37bbbed7 PS3, Line 28: AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/ > What about filling a LIBTRXCON_CFLAGS/LIBS in configure? It would be way more cleaner. see the new changes , i'd rather keep it in one place, since it is ltlibs anyway and splitting it obfuscates it. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a472fdb_6af6b51b PS3, Line 82: $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \ > LIBTRXCON_LIBS in configure. […] Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a2870f13_9e6c4827 PS3, Line 124: $(TRXCON_LDADD) > LIBTRXCON_LIBS in configure. […] Done https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5e6e874_8dbf5124 PS3, Line 187: # bin_PROGRAMS += osmo-trx-ipc2 > This doesn't belong to this patch. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 14:03:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by Hoernchen

Attention is currently required from: manawyrm, pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 4: (1 comment) File Transceiver52M/device/bladerf/bladerf.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5592ec15_a4732f59 PS4, Line 502: RX fucked > Well, that's true, but a different error message might still be favorable 😊 Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 14:03:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: manawyrm <osmocom.account(a)tbspace.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by Hoernchen

Attention is currently required from: Hoernchen, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 to look at the new patch set (#5). Change subject: bladerf xa4 support ...................................................................... bladerf xa4 support This is not really finished, there are multiple reasons to not use this: 1) main clock is not a gsm multiple, so it will continously drift 2) small buffer sizes lead to tx gaps that are hard to detect and break everything. Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac --- M .gitignore M Transceiver52M/Makefile.am M Transceiver52M/device/Makefile.am A Transceiver52M/device/bladerf/Makefile.am A Transceiver52M/device/bladerf/bladerf.cpp A Transceiver52M/device/bladerf/bladerf.h M configure.ac 7 files changed, 920 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/30413/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by Hoernchen

Attention is currently required from: Hoernchen, fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 to look at the new patch set (#11). Change subject: ms-trx support ...................................................................... ms-trx support This is basically a trxcon that includes a transceiver, and can just be used with existing and future apps supporting the trxcon interface, i.e. mobile or ccch_scan. Supports bladerf and uhd, binaries are automatically built if those libs are detected + the osmocom-bb submodule exists. Currently using hardcoded sched/prios aimed at a setup with working, reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3, not 2, not any other version) Additionally builds test tools used for development: osmo-trx-syncthing* Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 --- M .gitignore M Makefile.am M Transceiver52M/Makefile.am A Transceiver52M/ms/bladerf_specific.h A Transceiver52M/ms/itrq.h A Transceiver52M/ms/l1ctl_server.c A Transceiver52M/ms/l1ctl_server_cb.cpp A Transceiver52M/ms/logging.cpp A Transceiver52M/ms/ms.cpp A Transceiver52M/ms/ms.h A Transceiver52M/ms/ms_rx_burst.h A Transceiver52M/ms/ms_rx_burst_test.cpp A Transceiver52M/ms/ms_rx_lower.cpp A Transceiver52M/ms/ms_upper.cpp A Transceiver52M/ms/ms_upper.h A Transceiver52M/ms/sch.c A Transceiver52M/ms/sch.h A Transceiver52M/ms/uhd_specific.h M configure.ac 19 files changed, 3,469 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 11 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: ctrl: add optional port to bind command

by osmith

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 ) Change subject: ctrl: add optional port to bind command ...................................................................... Patch Set 5: (1 comment) File src/ctrl/control_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/ce98088e_21e05183 PS5, Line 34: "bind A.B.C.D [<0-65535>]", It looks like this only works if the application using libosmocore actually uses ctrl_vty_get_bind_port(). So this might be confusing the users, based on the vty parsing it seems it would always work, users might end up setting a port here and then wondering why it does not work. Maybe indicate from the application that this feature is supported, and check for that in cfg_ctrl_bind_addr_cmd when the user attempts to set a port, and fail with error in case the application doesn't support it? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Gerrit-Change-Number: 30444 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 12:21:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs: retire osmocom-gerrit-debian* labels

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30480 ) Change subject: jobs: retire osmocom-gerrit-debian* labels ...................................................................... jobs: retire osmocom-gerrit-debian* labels Let the gerrit-binpkgs and gerrit-pipeline-result jobs use the "osmocom-gerrit" label. Having the -debian10/11 label previously was useful to make sure this doesn't run on an ancient python version that fails on f-strings. But since the debian9 builders were retired, this is not needed anymore. These are the only jobs that used these, so now the labels in the README can be simplified (following patch). Related: OS#5793 Change-Id: Ieee95d25e036dcd4869d89b10c281179024672e7 --- M jobs/gerrit-binpkgs.yml M jobs/gerrit-pipeline-result.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/80/30480/1 diff --git a/jobs/gerrit-binpkgs.yml b/jobs/gerrit-binpkgs.yml index 8408950..247ebad 100644 --- a/jobs/gerrit-binpkgs.yml +++ b/jobs/gerrit-binpkgs.yml @@ -13,7 +13,7 @@ - job-template: name: 'gerrit-binpkgs-{type}' project-type: freestyle - node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 + node: osmocom-gerrit concurrent: true retry-count: 3 # scm checkout properties: diff --git a/jobs/gerrit-pipeline-result.yml b/jobs/gerrit-pipeline-result.yml index 94fc88c..e1a7a74 100644 --- a/jobs/gerrit-pipeline-result.yml +++ b/jobs/gerrit-pipeline-result.yml @@ -9,7 +9,7 @@ - job: name: 'gerrit-pipeline-result' project-type: freestyle - node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 + node: osmocom-gerrit retry-count: 3 # scm checkout properties: - build-discarder: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieee95d25e036dcd4869d89b10c281179024672e7 Gerrit-Change-Number: 30480 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/README: modernize

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30481 ) Change subject: jobs/README: modernize ...................................................................... jobs/README: modernize Remove outdated debian 9 related information, update section on labels. Change-Id: I6616f4bdacc90c295db7996855e9aa2b48172b43 --- M jobs/README.adoc 1 file changed, 15 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/81/30481/1 diff --git a/jobs/README.adoc b/jobs/README.adoc index bea1d9f..2533563 100644 --- a/jobs/README.adoc +++ b/jobs/README.adoc @@ -5,8 +5,6 @@ Install jenkins-job-builder: -For debian 9, see troubleshooting below. Otherwise: - apt-get install jenkins-job-builder Have a jenkins-job-builder.ini file. One of @@ -74,30 +72,21 @@ Also be aware that jobs are only actually updated when anything changed. -- debian 9 - -For jenkins-job-builder to work on debian 9: - -add 'testing' to /etc/apt/sources.list like - - deb http://ftp.de.debian.org/debian/ testing main - -then - - sudo apt-get update - sudo apt-get -t testing install python-jenkins - sudo apt-get install jenkins-job-builder - -and make sure to *not* pick the python3 versions -(or you'll need to add catching of HTTPError to jenkins/__init__.py in -'def maybe_add_crumb') - *Jenkins labels* -The build jobs are using labels to specify on which nodes the job should be run. -Please use the following labels +Most jenkins jobs should run a docker container and install all required +dependencies inside that, so we don't need to install them on the jenkins node. +These jobs don't need to set a label, they can just run on any generic jenkins +node that has docker available. So if you add a new job, you probably don't +need a label at all. -- osmocom-master-debian8: are nodes which can build osmocom-master and is a debian 8 -- osmocom-master-debian9: are nodes which can build osmocom-master and is a debian 9 -- osmocom-gerrit-debian8: are nodes which can build osmocom-gerrit and is a debian 8 -- osmocom-gerrit-debian9: are nodes which can build osmocom-gerrit and is a debian 9 +Existing jobs typically have a label set by the topic they belong to, e.g.: +- osmocom-master +- osmocom-gerrit +- ttcn3 + +Other labels indicate specific software/hardware works here, e.g.: +- coverity +- hdlc +- osmo-gsm-tester +- podman -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6616f4bdacc90c295db7996855e9aa2b48172b43 Gerrit-Change-Number: 30481 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci: remove deb9 nodes

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30479 ) Change subject: jobs/update-osmo-ci: remove deb9 nodes ...................................................................... jobs/update-osmo-ci: remove deb9 nodes Related: OS#5793 Change-Id: Id2bf3c273848c1de12a3dce3bc007dd205bf4af7 --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/79/30479/1 diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index e566431..9174a6f 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -6,11 +6,9 @@ type: slave name: label values: - - build2-deb9build-ansible - build2-deb10build-ansible - build2-deb11build-ansible - build3-deb11build-ansible - - gtp0-deb9build - gtp0-deb10fr - host2-deb11build-ansible - osmo-gsm-tester-prod -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2bf3c273848c1de12a3dce3bc007dd205bf4af7 Gerrit-Change-Number: 30479 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: run inside podman

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/30468 to look at the new patch set (#2). Change subject: repo-install-test: run inside podman ...................................................................... repo-install-test: run inside podman Change repo-install-test to run inside podman instead of systemd. This job needs to run systemd to verify that the systemd services start up properly. Running systemd inside docker was never officially supported, it worked with cgroups1 but does not work anymore with cgroups2. It is officially supported in podman. Related: OS#5365 Change-Id: I2be8359972556ab99fcfb7967fc43bcec1ca05f7 --- M jobs/repo-install-test.yml M scripts/repo-install-test.sh R scripts/repo-install-test/run-inside-podman.sh 3 files changed, 33 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/30468/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30468 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2be8359972556ab99fcfb7967fc43bcec1ca05f7 Gerrit-Change-Number: 30468 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: ansible/podman: configure storage driver vfs

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30475 ) Change subject: ansible/podman: configure storage driver vfs ...................................................................... Abandoned evil twin of https://gerrit.osmocom.org/c/osmo-ci/+/30478 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic6e317b3eb2068c3690d174700d02158efd87b2a Gerrit-Change-Number: 30475 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022