Attention is currently required from: osmith.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 )
Change subject: ctrl: add optional port to bind command
......................................................................
Patch Set 5:
(1 comment)
File src/ctrl/control_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/15a18e80_a276c483
PS5, Line 34: "bind A.B.C.D [<0-65535>]",
> It looks like this only works if the application using libosmocore actually uses ctrl_vty_get_bind_p […]
That's exactly how vty_get_bind_port() works though. I think it's less confusing to keep the same (albeit somewhat ugly) semantics for both ctrl and vty binds.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9
Gerrit-Change-Number: 30444
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 16:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 )
Change subject: rate_ctr: convert to timerfd
......................................................................
Patch Set 9:
(1 comment)
File src/rate_ctr.c:
https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/c9672742_59893d86
PS9, Line 358: do { /* Increment number of ticks before we calculate intervals,
> I see no good reason to use do while here instead of just while, but ok...
Because it better expresses the expectations for the input to this part of the code: we expect and for the vast majority of cases (even on non-realtime kernel) get 1 == expire_count
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
Gerrit-Change-Number: 30302
Gerrit-PatchSet: 9
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 15:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30468 )
Change subject: repo-install-test: run inside podman
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30468
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2be8359972556ab99fcfb7967fc43bcec1ca05f7
Gerrit-Change-Number: 30468
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 15:31:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, daniel.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30468 )
Change subject: repo-install-test: run inside podman
......................................................................
Patch Set 2:
(1 comment)
File scripts/repo-install-test.sh:
https://gerrit.osmocom.org/c/osmo-ci/+/30468/comment/953e156a_27d50b9c
PS2, Line 38: buildah bud \
> is this some typo or some language I never heard of?
lol... no, the tool is really called buildah.
https://buildah.io/
"bud" means "build", no idea why it's written like that. in newer versions, it was renamed to "build" (backwards compatible, "bud" still works). However the buildah versions installed on the jenkins nodes have an older version that requires this spelling.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30468
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2be8359972556ab99fcfb7967fc43bcec1ca05f7
Gerrit-Change-Number: 30468
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 15:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 11:
(8 comments)
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/668bb158_0fd429d4
PS11, Line 88: grgsm_vitac/grgsm_vitac.cpp \
is this only to be used in ms-trx? why not moving it to subdir ms/grgsm_vita/ then?
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8630fe58_37c98796
PS11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
$(top_srcdir)/Transceiver52/device/ipc? not sure if it's a good idea to use relative paths there.
File Transceiver52M/ms/itrq.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c07c1582_ff3c8410
PS11, Line 127: class spsc : public T<block_read, block_write> {
didn't we have an implementation of this somewhere else already?
File Transceiver52M/ms/logging.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8ac01e1_c8a07cda
PS11, Line 83: void trxc_log_init(void *tallctx)
shouldn't this be called "trxcon_log_init"?
File Transceiver52M/ms/ms.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f3dd3ea_e636957f
PS11, Line 312: // in thory fn equal and tn+3 equal is also a problem...
theory
File Transceiver52M/ms/ms_upper.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1f9d86c_bdff35ed
PS11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:
value_string?
File Transceiver52M/ms/sch.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fb6d243a_f13769d2
PS11, Line 7: * (C) 2022 by 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> / Eric Wild <ewild(a)sysmocom.de>
repeated "2022 by"
File Transceiver52M/ms/sch.c:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6e3cc067_359daed9
PS11, Line 97: int gsm_fcch_check_fn(int fn)
don't we have these sort of functionalities already in libosmocore?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 11
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 15:24:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30469 )
Change subject: repo-install-test: run without SYS_NICE
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> the question would perhaps be: why do we want to run with podman if all those features which we need […]
Because we can't run it anymore with docker since the debian 9 lxcs have been retired. If we don't change it to podman, we can't run it at all. It would be nicer if we could test the systemd-files as-is, but testing them with these three features disabled is better than not testing them at all.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30469
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I00d0349c236c8619a3ab9cf22238cba73af1e45c
Gerrit-Change-Number: 30469
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 15:21:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, lynxis lazus.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356
to look at the new patch set (#2).
Change subject: BSC_Tests: add OML tests for bts_setup_ramp
......................................................................
BSC_Tests: add OML tests for bts_setup_ramp
The current BSC_Tests are using osmo-bts-omldummy to keep OML out of the test context.
Add a new test file and component for OML tests.
Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee
---
M bsc/BSC_Tests.cfg
A bsc/BSC_Tests_OML.ttcn
M bsc/gen_links.sh
M bsc/regen_makefile.sh
4 files changed, 377 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/56/30356/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee
Gerrit-Change-Number: 30356
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: newpatchset
