Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30471 )
Change subject: repo-install-test: disable ProtectHome option
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I'm in general quite sceptic. We're replacing docker with podman as supposedly we can run more thngs there without container specific hacks. But it looks like we're adding various new workarounds here, so I'm wondering if this really is the way to go. Maybe we simply want to run those tests in a qemu-kvm virtual machine, after all? we could always start from the same clean disk image, with COW for the changes done by the job. And once it's completed, we delete the COW and the next execution starts from clean rootfs again.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30471
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I394918fc61de36acce65ffb33defcb8fc21801c4
Gerrit-Change-Number: 30471
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 17:45:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 14: Code-Review+1
(2 comments)
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23d9eb91_c878241d
PS11, Line 179: osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
> abosolutely does not matter here, the directory layout has been unchanged for 10 years and this dire […]
The reason I had in mind here is not about changing dir structure, it's more about whether this relative path is properly handled when you have builddir != srcdir, etc.
File Transceiver52M/ms/ms_upper.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd2cf424_96ff42f4
PS11, Line 297: case trxcon::TRXCON_PHYIF_CMDT_RESET:
> Done
By done you mean you disabled it by default?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 14
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 17:40:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, msuraev.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/30301
to look at the new patch set (#22).
Change subject: osmo-stat-dummy: add rate counters and statsd tester
......................................................................
osmo-stat-dummy: add rate counters and statsd tester
It's handy for testing rate counters as well as statsd metrics.
Related: OS#5671
Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7
---
M .gitignore
M configure.ac
M utils/Makefile.am
A utils/osmo-stat-dummy/Makefile.am
A utils/osmo-stat-dummy/osmo-stat-dummy.c
A utils/osmo-stat-dummy/osmo-stat-dummy.cfg
A utils/osmo-stat-dummy/osmo-stat-dummy.html
7 files changed, 446 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/30301/22
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7
Gerrit-Change-Number: 30301
Gerrit-PatchSet: 22
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, msuraev.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/30301
to look at the new patch set (#21).
Change subject: osmo-stat-dummy: add rate counters and statsd tester
......................................................................
osmo-stat-dummy: add rate counters and statsd tester
It's handy for testing rate counters as well as statsd metrics.
Related: OS#5671
Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7
---
M .gitignore
M configure.ac
M utils/Makefile.am
A utils/osmo-stat-dummy/Makefile.am
A utils/osmo-stat-dummy/osmo-stat-dummy.c
A utils/osmo-stat-dummy/osmo-stat-dummy.cfg
A utils/osmo-stat-dummy/osmo-stat-dummy.html
7 files changed, 446 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/30301/21
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7
Gerrit-Change-Number: 30301
Gerrit-PatchSet: 21
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30472 )
Change subject: repo-install-test: update services list
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This is very confusing: osmo-pcu also needs realtime config (at least it's configured in .service) files. Yet, unlike osmo-trx it's not affected - I presume that's because those directives were stripped elsewhere. It's better to add comment clarifying this and reference the stripper.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30472
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia2757863a23b2cae7438d47694cdd01476a91071
Gerrit-Change-Number: 30472
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Dec 2022 17:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment