December 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: mobile: clean up GAPK I/O state on channel release

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30454 ) Change subject: mobile: clean up GAPK I/O state on channel release ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8943ee9bd46afc96e6d7cfd52c95c34fd311ce11 Gerrit-Change-Number: 30454 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 05 Dec 2022 22:39:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: firmware: remove TCH/F specific bit re-ordering

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30484 ) Change subject: firmware: remove TCH/F specific bit re-ordering ...................................................................... firmware: remove TCH/F specific bit re-ordering This is a partial revert of d49a748cbbf7d7b5bb77f3d906179da9b462e6d1. The GAPK based audio I/O implementation of the mobile app is now capable of handling TI's specific TCH frame format, which can be configured via the VTY interface ('io-tch-format ti'). Thus there is no need to have the conversion logic in the firmware anymore. This patch also fixes the layer1 firmware, so it does not hang on receipt of Uplink TCH frames anymore when compiled with recent arm-none-eabi toolchain (v12.2.0 on my machine). Change-Id: I5afd4e4ddd9c06d32768d01bc1e3e18d476706fb Related: OS#3400 --- M src/target/firmware/Makefile M src/target/firmware/layer1/prim_tch.c 2 files changed, 1 insertion(+), 55 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/84/30484/1 diff --git a/src/target/firmware/Makefile b/src/target/firmware/Makefile index 104ddac..d1ab0c6 100644 --- a/src/target/firmware/Makefile +++ b/src/target/firmware/Makefile @@ -126,8 +126,7 @@ comm/libcomm.a \ tiffs/libtiffs.a \ ../../shared/libosmocore/build-target/src/.libs/libosmocore.a \ - ../../shared/libosmocore/build-target/src/gsm/.libs/libosmogsm.a \ - ../../shared/libosmocore/build-target/src/codec/.libs/libosmocodec.a + ../../shared/libosmocore/build-target/src/gsm/.libs/libosmogsm.a # diff --git a/src/target/firmware/layer1/prim_tch.c b/src/target/firmware/layer1/prim_tch.c index 0542e82..56c32fb 100644 --- a/src/target/firmware/layer1/prim_tch.c +++ b/src/target/firmware/layer1/prim_tch.c @@ -28,7 +28,6 @@ #include <byteorder.h> #include <osmocom/gsm/gsm_utils.h> #include <osmocom/gsm/protocol/gsm_04_08.h> -#include <osmocom/codec/codec.h> #include <osmocom/core/msgb.h> #include <calypso/dsp_api.h> #include <calypso/irq.h> @@ -52,45 +51,6 @@ #include <l1ctl_proto.h> -static inline int msb_get_bit(uint8_t *buf, int bn) -{ - int pos_byte = bn >> 3; - int pos_bit = 7 - (bn & 7); - - return (buf[pos_byte] >> pos_bit) & 1; -} - -static inline void msb_set_bit(uint8_t *buf, int bn, int bit) -{ - int pos_byte = bn >> 3; - int pos_bit = 7 - (bn & 7); - - buf[pos_byte] |= (bit << pos_bit); -} - -static void tch_fr_bit_magic(uint8_t *frame, int dl) -{ - uint8_t fr[33]; - int i, di, si; - - memset(fr, 0x00, 33); - - if (dl) - fr[0] = 0xd0; - - for (i = 0; i < 260; i++) { - di = gsm610_bitorder[i]; - si = (i > 181) ? i + 4 : i; - - if (dl) - msb_set_bit(fr, 4 + di, msb_get_bit(frame, si)); - else - msb_set_bit(fr, si, msb_get_bit(frame, 4 + di)); - } - - memcpy(frame, fr, 33); -} - /* This computes various parameters both for the DSP and for * our logic. Not all are used all the time, but it's easier * to build all in one place */ @@ -351,12 +311,6 @@ /* Copy actual data, skipping the information block [0,1,2] */ dsp_memcpy_from_api(payload, &traffic_buf[3], 33, 1); - /** - * Perform some bit conversations - * FIXME: what about other (than FR) codecs? - */ - tch_fr_bit_magic(payload, 1); - /* Give message to up layer */ l1_queue_for_l2(msg); } @@ -483,13 +437,6 @@ /* Pull Traffic data (if any) */ msg = msgb_dequeue(&l1s.tx_queue[L1S_CHAN_TRAFFIC]); - /** - * Perform some bit conversations - * FIXME: what about other (than FR) codecs? - */ - if (msg) - tch_fr_bit_magic(msg->l2h, 0); - /* Copy actual data, skipping the information block [0,1,2] */ if (msg) { data = msg->l2h; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5afd4e4ddd9c06d32768d01bc1e3e18d476706fb Gerrit-Change-Number: 30484 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: do not enforce RTP format for Uplink TCH frames

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30483 ) Change subject: mobile: do not enforce RTP format for Uplink TCH frames ...................................................................... mobile: do not enforce RTP format for Uplink TCH frames This is a partial revert of 8f04fa975819113f2a75a1803cbc3d06877fd36d. The GAPK based audio I/O implementation of the mobile app is now capable of handling TI's specific TCH frame format, which can be configured via the VTY interface ('io-tch-format ti'). TCH frames in this format are different from the ones in RTP format and may have different length and different bit ordering. Remove voice_frame_verify(). Change-Id: I6113ba443e65ddaae091b643af54c873b7da4de8 Related: OS#3400 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 0 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/83/30483/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 4ecbcff..f0b052c 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -67,7 +67,6 @@ #include <osmocom/gsm/rsl.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/core/bitvec.h> -#include <osmocom/codec/codec.h> #include <osmocom/bb/common/osmocom_data.h> #include <osmocom/bb/common/l1l2_interface.h> @@ -5771,47 +5770,10 @@ #endif -#define LOG_FRAME_VERIFY(mode, level, fmt, args...) \ - LOGP(DRR, level, "Voice frame, mode=%s: " fmt, get_value_string(gsm48_chan_mode_names, mode), ## args) - -int voice_frame_verify(enum gsm48_chan_mode mode, uint8_t *frame, size_t frame_len) -{ - switch (mode) { - case GSM48_CMODE_SPEECH_V1: - /* FIXME: this is FR only, check for TCH/F (FR) and TCH/H (HR) */ - /* RFC 3551, section 4.5.8 GSM */ - if (frame_len != GSM_FR_BYTES) { - LOG_FRAME_VERIFY(mode, LOGL_ERROR, "incorrect length (%zu != %u)\n", frame_len, GSM_FR_BYTES); - return -2; - } - if ((frame[0] >> 4) != 0xd) { - LOG_FRAME_VERIFY(mode, LOGL_ERROR, "incorrect magic (%u != 0xd)\n", frame[0] >> 4); - return -3; - } - break; - case GSM48_CMODE_SPEECH_EFR: - /* RFC 3551, section 4.5.9 GSM-EFR */ - if (frame_len != GSM_EFR_BYTES) { - LOG_FRAME_VERIFY(mode, LOGL_ERROR, "incorrect length (%zu != %u)\n", frame_len, GSM_EFR_BYTES); - return -4; - } - if ((frame[0] >> 4) != 0xc) { - LOG_FRAME_VERIFY(mode, LOGL_ERROR, "incorrect magic (%u != 0xc)\n", frame[0] >> 4); - return -5; - } - break; - default: - LOG_FRAME_VERIFY(mode, LOGL_ERROR, "not implemented\n"); - return -1; - } - return 0; -} - int gsm48_rr_tx_voice(struct osmocom_ms *ms, struct msgb *msg) { struct gsm48_rrlayer *rr = &ms->rrlayer; uint8_t ch_type, ch_subch, ch_ts; - struct l1ctl_traffic_req *tr; if (!rr->dm_est) { LOGP(DRR, LOGL_INFO, "Current channel is not active\n"); @@ -5830,10 +5792,6 @@ goto error; } - tr = (struct l1ctl_traffic_req *)msg->l2h; - if (voice_frame_verify(rr->cd_now.mode, tr->data, msgb_l2len(msg)) < 0) - goto error; - return l1ctl_tx_traffic_req(ms, msg, rr->cd_now.chan_nr, 0); error: msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30483 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6113ba443e65ddaae091b643af54c873b7da4de8 Gerrit-Change-Number: 30483 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in gapk[master]: libgsmhr/fetch_sources.py: convert to Python 3

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/30482 ) Change subject: libgsmhr/fetch_sources.py: convert to Python 3 ...................................................................... libgsmhr/fetch_sources.py: convert to Python 3 * Use https://docs.python.org/3/library/logging.html ** Add more logging, use DEBUG by default * Use https://docs.python.org/3/library/urllib.request.html ** Do not send custom HTTP headers (not needed anymore) * Use https://docs.python.org/3/library/io.html Change-Id: I05d25343b4453550ab07b948cfaa1048b0f58067 Related: OS#3400 --- M libgsmhr/fetch_sources.py 1 file changed, 26 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/82/30482/1 diff --git a/libgsmhr/fetch_sources.py b/libgsmhr/fetch_sources.py index 6fb1b8e..178125c 100755 --- a/libgsmhr/fetch_sources.py +++ b/libgsmhr/fetch_sources.py @@ -1,35 +1,30 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 -import urllib2 +import logging as log +import urllib.request +import io import os import sys import zipfile -try: - import cStringIO as StringIO -except: - import StringIO + +URL = "http://www.3gpp.org/ftp/Specs/archive/06_series/06.06/0606-421.zip" -SRC = "http://www.3gpp.org/ftp/Specs/archive/06_series/06.06/0606-421.zip" -HDR = { - "User-Agent": "Mozilla/5.0 (X11; ArchLinux; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0", - "Accept": "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8", -} +def get_zipfile(data: bytes) -> zipfile.ZipFile: + return zipfile.ZipFile(io.BytesIO(data), 'r') -def get_zipfile(data): - return zipfile.ZipFile(StringIO.StringIO(data)) - - -def get_subfile_data(data, filename): +def get_subfile_data(data: bytes, filename: str): + log.debug('Unpacking \'%s\'', filename) z = get_zipfile(data) return z.read(filename) def process_file(z, e): - fh = open(os.path.basename(e.filename.lower()), 'w') - d = z.read(e).replace('\r','') + log.debug('Processing file \'%s\'', e.filename.lower()) + fh = open(os.path.basename(e.filename.lower()), 'wb') + d = z.read(e).replace(b'\r', b'') fh.write(d) fh.close() @@ -38,7 +33,7 @@ # Args if len(args) != 2: - print "Usage: %s target_dir" % args[0] + print("Usage: %s target_dir" % args[0]) return tgt = args[1] @@ -49,9 +44,16 @@ os.chdir(tgt) # Get the original data - req = urllib2.Request(SRC, headers = HDR) - u = urllib2.urlopen(req) - d = u.read() + log.info('Requesting file: %s', URL) + with urllib.request.urlopen(URL) as response: + log.debug('Response code: %d', response.code) + assert response.code == 200 + + for h in ('Last-Modified', 'Content-Type', 'Content-Length'): + log.debug('%s: %s', h, response.getheader(h)) + + log.info('Downloading %d bytes...', response.length) + d = response.read() # Get DISK.zip d = get_subfile_data(d, 'DISK.zip') @@ -67,5 +69,7 @@ process_file(z, e) +log.basicConfig(format='[%(levelname)s] %(filename)s:%(lineno)d %(message)s', level=log.DEBUG) + if __name__ == '__main__': main(*sys.argv) -- To view, visit https://gerrit.osmocom.org/c/gapk/+/30482 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I05d25343b4453550ab07b948cfaa1048b0f58067 Gerrit-Change-Number: 30482 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by msuraev

msuraev has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 ) Change subject: rate_ctr: convert to timerfd ...................................................................... rate_ctr: convert to timerfd Use timerfd to schedule 1-second periodic timer once instead rescheduling every second in timer callback. Related: OS#5671 Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 --- M src/rate_ctr.c 1 file changed, 46 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/rate_ctr.c b/src/rate_ctr.c index ffae1b8..3fc4992 100644 --- a/src/rate_ctr.c +++ b/src/rate_ctr.c @@ -53,14 +53,17 @@ * * \file rate_ctr.c */ +#include <errno.h> #include <stdbool.h> #include <stdint.h> #include <string.h> +#include <unistd.h> +#include <inttypes.h> #include <osmocom/core/utils.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/talloc.h> -#include <osmocom/core/timer.h> +#include <osmocom/core/select.h> #include <osmocom/core/rate_ctr.h> #include <osmocom/core/logging.h> @@ -310,7 +313,7 @@ ctr->intv[intv+1].rate += ctr->intv[intv].rate; } -static struct osmo_timer_list rate_ctr_timer; +static struct osmo_fd rate_ctr_timer = { .fd = -1 }; static uint64_t timer_ticks; /* The one-second interval has expired */ @@ -331,18 +334,35 @@ } } -static void rate_ctr_timer_cb(void *data) +static int rate_ctr_timer_cb(struct osmo_fd *ofd, unsigned int what) { struct rate_ctr_group *ctrg; + uint64_t expire_count; + int rc; - /* Increment number of ticks before we calculate intervals, - * as a counter value of 0 would already wrap all counters */ - timer_ticks++; + /* check that the timer has actually expired */ + if (!(what & OSMO_FD_READ)) + return 0; - llist_for_each_entry(ctrg, &rate_ctr_groups, list) - rate_ctr_group_intv(ctrg); + /* read from timerfd: number of expirations of periodic timer */ + rc = read(ofd->fd, (void *) &expire_count, sizeof(expire_count)); + if (rc < 0 && errno == EAGAIN) + return 0; - osmo_timer_schedule(&rate_ctr_timer, 1, 0); + OSMO_ASSERT(rc == sizeof(expire_count)); + + if (expire_count > 1) + LOGP(DLGLOBAL, LOGL_NOTICE, "Stats timer expire_count=%" PRIu64 ": We missed %" PRIu64 " timers\n", + expire_count, expire_count - 1); + + do { /* Increment number of ticks before we calculate intervals, + * as a counter value of 0 would already wrap all counters */ + timer_ticks++; + llist_for_each_entry(ctrg, &rate_ctr_groups, list) + rate_ctr_group_intv(ctrg); + } while (--expire_count); + + return 0; } /*! Initialize the counter module. Call this once from your application. @@ -350,13 +370,27 @@ * \returns 0 on success; negative on error */ int rate_ctr_init(void *tall_ctx) { + struct timespec ts_interval = { .tv_sec = 1, .tv_nsec = 0 }; + int rc; + /* ignore repeated initialization */ - if (osmo_timer_pending(&rate_ctr_timer)) + if (osmo_fd_is_registered(&rate_ctr_timer)) return 0; tall_rate_ctr_ctx = tall_ctx; - osmo_timer_setup(&rate_ctr_timer, rate_ctr_timer_cb, NULL); - osmo_timer_schedule(&rate_ctr_timer, 1, 0); + + rc = osmo_timerfd_setup(&rate_ctr_timer, rate_ctr_timer_cb, NULL); + if (rc < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, "Failed to setup the timer with error code %d (fd=%d)\n", + rc, rate_ctr_timer.fd); + return rc; + } + + rc = osmo_timerfd_schedule(&rate_ctr_timer, NULL, &ts_interval); + if (rc < 0) { + LOGP(DLGLOBAL, LOGL_ERROR, "Failed to schedule the timer with error code %d (fd=%d)\n", + rc, rate_ctr_timer.fd); + } return 0; } 11 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by msuraev

Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 ) Change subject: rate_ctr: convert to timerfd ...................................................................... Patch Set 12: (1 comment) File src/rate_ctr.c: https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/39b40a5e_bdec2393 PS9, Line 358: do { /* Increment number of ticks before we calculate intervals, > Because it better expresses the expectations for the input to this part of the code: we expect and f […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 19:12:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: osmo-stat-dummy: add rate counters and statsd tester

by msuraev

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30301 to look at the new patch set (#23). Change subject: osmo-stat-dummy: add rate counters and statsd tester ...................................................................... osmo-stat-dummy: add rate counters and statsd tester It's handy for testing rate counters as well as statsd metrics. Related: OS#5671 Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 --- M .gitignore M configure.ac M utils/Makefile.am A utils/osmo-stat-dummy/Makefile.am A utils/osmo-stat-dummy/osmo-stat-dummy.c A utils/osmo-stat-dummy/osmo-stat-dummy.cfg A utils/osmo-stat-dummy/osmo-stat-dummy.html 7 files changed, 446 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/30301/23 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 Gerrit-Change-Number: 30301 Gerrit-PatchSet: 23 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add OML tests for bts_setup_ramp

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 ) Change subject: BSC_Tests: add OML tests for bts_setup_ramp ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee Gerrit-Change-Number: 30356 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 18:50:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: rate_ctr: convert to timerfd

by laforge

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 ) Change subject: rate_ctr: convert to timerfd ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0 Gerrit-Change-Number: 30302 Gerrit-PatchSet: 11 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 18:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: ctrl: add optional port to bind command

by laforge

Attention is currently required from: osmith, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 ) Change subject: ctrl: add optional port to bind command ...................................................................... Patch Set 5: (1 comment) File src/ctrl/control_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/03fece6d_2300c075 PS5, Line 34: "bind A.B.C.D [<0-65535>]", > That's exactly how vty_get_bind_port() works though. […] in the VTY case, IMHO the idea was that the "usual" caller of vty_bind_get_port() is inside libosmovty itself: The function telnet_init_default(). Unfortunately it seems that (almost) all apps still call telnet_init_dynif(). That's a separate bug, will report it: https://osmocom.org/issues/5809 In order to avoid repeating this for thye CTRL interface, you'd also have to create a @ctrl_interface_setup_default()@ function, mark the other ones as deprecated and port all applications over from @ctrl_interface_setup_dynip()@ to that new function. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Gerrit-Change-Number: 30444 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 18:27:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022