Change in libosmocore[master]: ctrl: add optional port to bind command
Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 ) Change subject: ctrl: add optional port to bind command ...................................................................... Patch Set 5: (1 comment) File src/ctrl/control_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/ce98088e_21e05183 PS5, Line 34: "bind A.B.C.D [<0-65535>]", It looks like this only works if the application using libosmocore actually uses ctrl_vty_get_bind_port(). So this might be confusing the users, based on the vty parsing it seems it would always work, users might end up setting a port here and then wondering why it does not work. Maybe indicate from the application that this feature is supported, and check for that in cfg_ctrl_bind_addr_cmd when the user attempts to set a port, and fail with error in case the application doesn't support it? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Gerrit-Change-Number: 30444 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 12:21:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
participants (1)
-
osmith